qense | bingo! | 10:25 |
---|---|---|
qense | I got something to work at last. | 10:25 |
qense | It works! Eureka! | 10:27 |
qense | jcastro: I'll test it a last time and after that I can finally continue to work on Banshee. | 10:28 |
qense | I can't believe it's actually working. :P | 10:29 |
sanderqd | have you considered changing the spacing between the 'old' systray icons, to make it more consistent with the new indicators? | 12:19 |
tgpraveen12 | qense: hey will banshee get the app indicator in lucid now that UI freeze has been passed? | 12:54 |
tgpraveen12 | and FF freeze also | 12:54 |
qense | tgpraveen12: I'll try to get it in Banshee 1.5.5, and eventually Banshee 1.6.0 will be included in Lucid, so it should eventually reach Lucid, but it may need a FFe | 12:56 |
tgpraveen12 | qense: thx for the reply. have u talked to upstream? will it be included upstream/ | 12:58 |
qense | tgpraveen12: at the moment I'm working on getting the patch I provided into an acceptable state for upstream. | 12:58 |
tgpraveen12 | qense: awesome | 12:59 |
qense | I just stumbled upon another bug in the Mono bindings for AppInd, though. The Fallback and Unfallback methods aren't provided in C# and therefore I cannot override them. | 12:59 |
gregknicholson | moni | 13:29 |
gregknicholson | …I beg your pardon — pre-empted gnome-do there | 13:30 |
qense | ok, we've got a problem | 14:07 |
qense | the virtual-member support of the GAPI generator won't land until GTK# 3.0 | 14:07 |
qense | Which means no fallback and unfallback until September | 14:08 |
qense | jcastro: After several hours of working on getting fallback and unfallback to work in Mono I'm removing the use of that from the Banshee patch since GTK# is such a stupid project. | 14:36 |
qense | aargh | 14:36 |
qense | jcastro: I need virtual member support, and GAPI has already got that since a few months ago, before Karmic was released, but it won't be included until GTK#3.0. | 14:37 |
qense | Just when everything else worked... | 14:37 |
qense | sigh | 14:38 |
qense | Everything worked flawlessly! | 14:38 |
qense | All that was needed was GAPI to recognise a certain node type, which it already can in trunk. | 14:38 |
jcastro | qense: ok so you're saying it all works except for the fallback? | 16:23 |
qense | jcastro: We'll have to make do with the default fallback. I'm working on finishing the last bits of the patch, should be able to submit it today. | 16:25 |
jcastro | ok I don't understand | 16:25 |
qense | jcastro: So yes, the rest works. | 16:25 |
jcastro | can you explain how it will be different? | 16:26 |
qense | jcastro: The default fallback uses the AppInd menu and shows it on left mouse button. I wanted to use the GtkStatusIcon provided by Banshee since that provides a bit more functionality. | 16:27 |
qense | It means: no tooltip and no rating-from-the-tray-menu. | 16:28 |
qense | jcastro: Do you think I should add the artist and the album currently being played to the menu, just as Rhythmbox already does? | 16:29 |
jcastro | qense: I was just thinking about that | 16:31 |
jcastro | qense: yeah I think it makes sense to have them both behave the same in there | 16:31 |
jcastro | qense: I am asking upstream how they would feel about a monochrome icon too | 16:31 |
qense | the same as for Rhythmbox? | 16:32 |
jcastro | no | 16:32 |
jcastro | I was thinking the current logo but black and white | 16:32 |
qense | That probably fits better with the themes indeed. | 16:33 |
qense | jcastro: Giving up on showing the currently played song in the menu: due to a bug in GTK+ the label of a MenuItem isn't updated when its action's label is. Due to a bug in GTK# you can't change or read the label of a MenuItem after you've created it. | 21:28 |
qense | sigh... | 21:28 |
qense | Again just when I thought it worked. | 21:28 |
gabaug | qense: we change the Label of MenuItems all the time in Banshee by modifying their Gtk.Action | 21:30 |
qense | gabaug: Really? | 21:30 |
qense | maybe it is a AppInd bug, despite what the comments in the Rhythmbox patch say | 21:31 |
gabaug | qense: are you modifying the Gtk.Action and not the ActionEntry? | 21:31 |
qense | gabaug: yes I am | 21:31 |
qense | gabaug: and changing the Visible property does work | 21:31 |
qense | just not the Label property | 21:32 |
gabaug | yeah, is probably an appind bug, not sending the update over dbus | 21:32 |
gabaug | definitely not an issue with Gtk+ or Gtk# | 21:32 |
qense | I'll take a look at it then | 21:32 |
jpetersen | qense, the problem is that the GtkMenuItem does not send the notify::label signal when the label of the action is changed | 22:10 |
qense | ah | 22:10 |
qense | can't we emit that ourselves? | 22:10 |
jpetersen | qense, not really | 22:11 |
jpetersen | qense, i will fix it on appindicator | 22:12 |
qense | jpetersen: How? | 22:12 |
jpetersen | qense, listen also to the signal of the action related to the menu item | 22:12 |
qense | ah | 22:12 |
jpetersen | qense, I will work on monday on it | 22:12 |
qense | jpetersen: great, thank you | 22:13 |
jpetersen | your welcome | 22:13 |
qense | patch sent upstream | 22:26 |
qense | I'm off now, bye! | 22:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!