| === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| adiroiban | henninge: hi. Can you please land this branch https://code.edge.launchpad.net/~adiroiban/launchpad/bug-509252-take-2/+merge/19484 ? | 09:02 |
|---|---|---|
| henninge | adiroiban: yes, sure. | 09:03 |
| henninge | Hi adiroiban! | 09:03 |
| henninge | ;-) | 09:03 |
| adiroiban | gmb: Hi. Do you have time to land this branch https://code.edge.launchpad.net/~adiroiban/launchpad/bug-512307/+merge/20442 ? | 09:04 |
| gmb | adiroiban: Sure. | 09:05 |
| adiroiban | thanks gmb and henninge ! :) | 09:05 |
| === noodles785 is now known as noodles775 | ||
| === jelmer_ is now known as jelmer | ||
| === wgrant changed the topic of #launchpad-reviews to: on call: henninge || reviewing: - || queue [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === wgrant changed the topic of #launchpad-reviews to: on call: henninge || reviewing: - || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === stub1 is now known as stub | ||
| === bigjools is now known as bigjools-otp | ||
| === bigjools-otp is now known as bigjools | ||
| === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | wgrant: looking at your merge proposal now. | 11:41 |
| === daniloff is now known as danilos | ||
| wgrant | henninge: Thanks. It's an old branch, so I just realised I forgot to describe some of the changes. | 11:43 |
| wgrant | I've removed some redundant templates and classes. | 11:43 |
| henninge | wgrant: yes, I already noticed ... ;) | 11:43 |
| jml | https://code.edge.launchpad.net/~jml/launchpad/expose-gpgkeys-bug-389872 <-- would someone please review this branch? | 11:43 |
| henninge | jml: put it in the queue, please. I might not get to it because I am not feeling too great and might pack up after wgrant's branch but intellectronica and abentley should be around later. | 11:47 |
| henninge | actually, were *is* intellectronica? | 11:47 |
| henninge | where | 11:47 |
| === jml changed the topic of #launchpad-reviews to: on call: henninge || reviewing: wgrant; jml || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: wgrant || queue: [jml] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jml | henninge, I thought it _was_ in the queue by virtue of being ready for review, tbh. | 11:47 |
| henninge | jml: hm, we are still using the queue here, too. | 11:48 |
| henninge | jml: to indicate that you want an OCR to do the review (and that you are likely to be around for it). | 11:48 |
| henninge | that is my understanding | 11:49 |
| jml | ok. | 11:50 |
| wgrant | bigjools: I like that buildd-manager logging fix. | 11:56 |
| bigjools | wgrant: you bet | 11:58 |
| bigjools | wgrant: it needs a little more love - like logging when stuff is givenback, etc | 11:58 |
| wgrant | bigjools: Yeah, but now it's actually a bit useful. | 11:59 |
| bigjools | it could definitely not be more useless than before | 11:59 |
| henninge | wgrant: I understand that your branch does not change the looks (apart from page_title and label) of any of the pages, right? | 12:03 |
| wgrant | henninge: It moves the heading of https://edge.launchpad.net/builders/thorium/+history to the heading slot, but apart from that no. | 12:04 |
| wgrant | (note how it's below the breadcrumbs there) | 12:04 |
| === intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: wgrant || queue: [jml] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | wgrant: that is standard 3.0 fix. Thanks for spotting that! | 12:05 |
| intellectronica | henninge, jml: i can review | 12:06 |
| henninge | intellectronica: Hi! cool | 12:06 |
| jml | intellectronica, thanks. | 12:06 |
| intellectronica | jml: expose-gpgkeys-bug-389872 ? | 12:07 |
| jml | intellectronica, thanks. | 12:07 |
| intellectronica | i'll take that as a confirmation | 12:07 |
| jml | intellectronica, thanks :) | 12:08 |
| henninge | wgrant: r=me ;) | 12:08 |
| henninge | wgrant: want me to land it? | 12:08 |
| wgrant | henninge: Please do. | 12:09 |
| wgrant | Thanks. | 12:09 |
| intellectronica | jml: the import from launchpad.interfaces in lib/canonical/launchpad/browser/logintoken.py needs to be broken up | 12:10 |
| intellectronica | i feel bad for asking you to do that, since you're just driving by, but if you don't who will? | 12:10 |
| henninge | wgrant: it's on its way ... | 12:11 |
| wgrant | henninge: Great. | 12:13 |
| jml | intellectronica, "Daddy, where were you when the interface imports needed breaking up?" etc.... | 12:17 |
| intellectronica | exactly | 12:17 |
| jml | intellectronica, sure, I can do that. (not right now though) | 12:17 |
| intellectronica | jml: the docstring for retrieveActiveKey is oddly self-referential | 12:18 |
| jml | intellectronica, in a bad way, right? | 12:18 |
| intellectronica | jml: when you say 'not right now' do you mean 'not in the next few hours' or 'not as part of this branch'? | 12:18 |
| jml | intellectronica, the former. | 12:18 |
| intellectronica | cool | 12:18 |
| jml | actually, maybe in the next few hours | 12:18 |
| jml | but not before lunch, almost certainly | 12:18 |
| === henninge changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: -, - || queue: [jml] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| intellectronica | jml: and yeah, the docstring being self-referential is kinda' bad. it's cute, but it makes it impossible to understand. | 12:19 |
| === intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: -, jml || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === henninge changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: lunch, jml || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| * henninge lunches | 12:20 | |
| intellectronica | jml: are you supposed to be able to change the keyid and fingerprint attributes via the api? | 12:23 |
| jml | uhh no, that sounds kind of horrible | 12:23 |
| intellectronica | jml: right. so i think they should be declared read only | 12:29 |
| jml | intellectronica, ok, will do. | 12:29 |
| intellectronica | jml: also, pendinggpgkeys and gpgkeys should be pending_gpg_keys and gpg_keys | 12:30 |
| * jml agrees | 12:30 | |
| === salgado is now known as salgado-brb | ||
| wgrant | intellectronica, jml: Those collections are also readonly=False. | 12:31 |
| intellectronica | wgrant: i'm not sure that means you can add items to them, though. in fact that's exactly what i'm trying to find out | 12:31 |
| intellectronica | though slapping a readonly on them surely can't hurt | 12:32 |
| wgrant | intellectronica: You can't add items to them, no. | 12:32 |
| wgrant | But it still seems like a bad idea for something like that. | 12:32 |
| wgrant | It probably has no practical effect at the moment. | 12:32 |
| intellectronica | wgrant: yeah, i agree, if only for the code to serve as documentation | 12:33 |
| wgrant | Right. | 12:33 |
| jml | agreed. | 12:34 |
| intellectronica | jml: everything else looks fine. i'm leaving the mp in needs fixing for now. | 12:35 |
| jml | intellectronica, thanks. Are you going to summarize this conversation there? (If not, I will) | 12:35 |
| intellectronica | jml: i was just about to do that. save your energies for all that interfaces work :P | 12:35 |
| jml | intellectronica, :D | 12:36 |
| === intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: lunch, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === mrevell is now known as mrevell-lunch | ||
| === wgrant changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: lunch, - || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| intellectronica | wgrant: which branch? | 12:57 |
| wgrant | intellectronica: https://code.edge.launchpad.net/~wgrant/launchpad/buildqueue-to-buildmaster/+merge/20886 | 12:58 |
| wgrant | Big, but mostly s/soyuz/buildmaster/ | 12:58 |
| intellectronica | oh joy | 12:59 |
| al-maisan | :) | 12:59 |
| === intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: lunch, wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| intellectronica | wgrant: r=me | 13:26 |
| === intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: lunch, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| wgrant | intellectronica: Thanks. Can you please (ec2)land it? | 13:27 |
| intellectronica | wgrant: sure | 13:27 |
| * wgrant throws https://code.edge.launchpad.net/~wgrant/launchpad/fix-build-breadcrumbs/+merge/20888 onto the pile, as a successor to the earlier one. | 13:31 | |
| === wgrant changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: lunch, - || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === mrevell-lunch is now known as mrevell | ||
| === salgado-brb is now known as salgado | ||
| === henninge changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: -, - || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === henninge changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: wgrant, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| wgrant | I have a 1500 line branch which moves an enum, removes a single circular import hack that becomes unnecessary as a result of the move, removes an unused list of a subset of the enum values, and fixes all of the imports. Is anybody game? 90% of it is import changes, and it's not really possible to split it up significantly... | 14:17 |
| intellectronica | wgrant: that's fine. i have a call soon, but i can review the branch when i'm done. | 14:19 |
| === henninge changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | wgrant: r=me on the breadcrumbs but I think noodles775 should formally add a ui review, too. | 14:20 |
| wgrant | henninge: Thanks. | 14:21 |
| noodles775 | Sure. | 14:21 |
| wgrant | intellectronica: Review requested. I'll hopefully be asleep by the time you get to it -- please land if you're OK with it. Thanks! | 14:28 |
| wgrant | noodles775: Thanks. | 14:28 |
| intellectronica | wgrant: will do. sweet dreams. | 14:29 |
| james_w | could someone land my two approved branches please? | 14:39 |
| adiroiban | henninge, danilos : do you think we can schedule a pre-implementation chat for IPOTemplates API ? | 14:43 |
| henninge | adiroiban: sure but not today ... ;) | 14:45 |
| adiroiban | henninge: sure. no hurry :) | 14:45 |
| danilos | adiroiban, sure | 14:46 |
| adiroiban | or maybe can do it by email ? | 14:49 |
| adiroiban | I have a prototype and maybe we can discuss around it | 14:50 |
| === henninge changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | intellectronica: I have a critical issue to handle in rosetta but it looks like smooth sailing here atm. | 14:53 |
| intellectronica | henninge: np. i have some calls, but will resume reviewing after that | 14:54 |
| danilos | adiroiban, sounds good, I am CHR today so I am unlikely to have time for it, but if you send it by email I can probably take a look at your ideas and your branch, and then we can talk some more tomorrow | 14:55 |
| danilos | adiroiban, how does that sound? | 14:55 |
| adiroiban | good :) | 14:56 |
| === matsubara is now known as matsubara-lunch | ||
| === abentley changed the topic of #launchpad-reviews to: on call: intellectronica, abentley || reviewing: -,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-lunch | ||
| * kfogel is away: reboot | 16:11 | |
| === salgado-lunch is now known as salgado | ||
| === deryck is now known as deryck[lunch] | ||
| === deryck[lunch] is now known as deryck | ||
| === jamalta is now known as jamalta-afk | ||
| === jamalta-afk is now known as jamalta | ||
| jtv | intellectronica: I'm actually asleep, but perhaps you'd like to have a look at my branch? https://code.launchpad.net/~jtv/launchpad/bug-533668/+merge/20902 | 17:53 |
| intellectronica | jtv: sorry, but i'm unlikely to get to it today | 17:53 |
| jtv | intellectronica: no worries | 17:53 |
| === gary_poster is now known as gary-lunch | ||
| === intellectronica changed the topic of #launchpad-reviews to: on call: abentley || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jamalta is now known as jamalta-afk | ||
| === matsubara-lunch is now known as matsubara | ||
| === jamalta-afk is now known as jamalta | ||
| === danilos is now known as daniloff | ||
| === matsubara is now known as matsubara-afk | ||
| === gary-lunch is now known as gary_poster | ||
| jtv | abentley: if you're bored, I've got a small branch up for review | 19:35 |
| abentley | jtv, sure. | 19:36 |
| jtv | thanks | 19:36 |
| abentley | jtv, why are you using foo.__repr__ instead of repr(foo)? | 19:40 |
| jtv | abentley: ah, I knew I was missing something. I'll fix that. | 19:40 |
| abentley | jtv, how are you expecting boom to appear in the message? "\u2639"? | 19:41 |
| jtv | abentley: I don't much care actually, as long as (1) the script doesn't crash, (2) some message gets out, and (3) the origin of the message isn't completely obscured. | 19:42 |
| abentley | jtv, do you know why the original code was special-casing unicode(e) == ''? | 19:44 |
| jtv | abentley: IIRC there was some case where the message was empty and the interesting info was in the exception type itself. | 19:45 |
| jtv | So this change takes away the need for that. | 19:45 |
| abentley | jtv, r=me | 19:53 |
| jtv | abentley: cool, thanks | 19:54 |
| === jamalta is now known as jamalta-afk | ||
| === matsubara-afk is now known as matsubara | ||
| james_w | on call: abentley || reviewing: - || queue: [james_w (https://code.edge.launchpad.net/~james-w/launchpad)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | 20:43 |
| === james_w changed the topic of #launchpad-reviews to: on call: abentley || reviewing: - || queue: [james_w (https://code.edge.launchpad.net/~james-w/launchpad)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| * james_w always seems to get it wrong once | 20:44 | |
| === salgado is now known as salgado-afk | ||
| === abentley changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [james_w (https://code.edge.launchpad.net/~james-w/launchpad)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jamalta-afk is now known as jamalta | ||
| === jamalta is now known as jamalta-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!