[02:39] <thumper> mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/new-code-import-email-show-type/+merge/20938 if you're bored
[02:39] <mwhudson> thumper: on it
[02:40] <thumper> mwhudson: so you're bored?
[02:40] <mwhudson> thumper: a bit
[02:40] <mwhudson> writing specs is tedious
[02:40] <mwhudson> also, i thoroughly approve of that feature!
[02:41] <mwhudson> thumper: do you think having RevisionControlSystems.CVS.title be "Concurrent Versions System" is helping anyone ?
[02:41] <thumper> mwhudson: no
[02:41] <thumper> mwhudson: I suppose we could add a little map
[02:41] <mwhudson> i was thinking this with my +code-imports changes the other day
[02:41] <thumper> and show CVS, Subversion, git and hg
[02:42] <thumper> mwhudson: what did you do the other day?
[02:43] <mwhudson> thumper: well, the +code-imports page will soon have a <select> for rcs type
[02:43] <mwhudson> and one of the options will be "Concurrent Versions System"
[02:43] <thumper> mwhudson: heh
[02:44] <mwhudson> same for "Subversion via bzr-svn" i guess
[02:44] <mwhudson> for Mercurial/hg, well, don't care
[02:46] <thumper> mwhudson: yeah
[02:47] <thumper> mwhudson: also https://code.edge.launchpad.net/~thumper/launchpad/description-change-email/+merge/20939
[03:05] <thumper> mwhudson: new revision pushed with nicer names
[03:05] <mwhudson> thumper: i find the description-change-email branch a bit mysterious i have to admit
[03:06] <thumper> mwhudson: ok
[03:06] <thumper> mwhudson: I'm going to be afk for a bit
[03:06] <mwhudson> ok
[03:06] <mwhudson> i'll figure it out
[08:39] <wgrant> Can I convince somebody to review https://code.edge.launchpad.net/~wgrant/launchpad/buildstatus-to-buildmaster/+merge/20892? It's supermassive due to an enum move, but trivial.
[08:41] <noodles775> wgrant: sure
[09:49] <allenap> BjornT: Would you be able to review my isolate-tests branch? It's kind of "interesting" and I'd like you to ask awkward questions of it. It's short. https://code.edge.launchpad.net/~allenap/launchpad/isolate-tests/+merge/20916
[10:07] <BjornT> allenap: sure, that looks like something that is best reviewed after lunch :)
[10:07] <allenap> BjornT: Heh :) Thank you.
[10:56] <gmb> james_w: Aha, both of your branches are ready to land now, right/
[10:56] <gmb> ?
[11:05] <noodles775> Hi gmb, when you get to it, mine is this one: https://code.edge.launchpad.net/~michael.nelson/launchpad/530180-partner-permissions/+merge/20947
[11:08] <gmb> noodles775: Thanks.
[11:21] <gmb> james_w: Is there a bug for https://code.edge.launchpad.net/~james-w/launchpad/fix-getRequestedReviews/+merge/20378? Also, can you add a commit message for it before I land it please?
[11:34] <gmb> noodles775: BTW; it's 2010. You should update your doctest copyright notice ;). (Bonus points for doing the template, too).
[11:35] <noodles775> heh, will do.
[11:55] <gmb> noodles775: Other than that, r=me.
[11:55] <noodles775> Thanks gmb
[12:29] <salgado> adiroiban, I just tried landing your branch but there are conflicts in lib/lp/registry/model/distroseries.py
[12:29] <adiroiban> salgado: I will merge with latest devel and push the changes.
[12:29] <adiroiban> I'm still trying to fix those randomly failing windmill tests
[12:30] <adiroiban> the buildd-slavescanner error was fixed in a later branch
[13:19] <salgado> adiroiban, do the windmill tests fail on a mainline branch for you as well?
[13:19] <adiroiban> yes
[13:19] <salgado> adiroiban, then it's probably not related to your changes, so I'll just resubmit your branch and see what ec2 says
[13:20] <adiroiban> doing this change, reduce the probability of failing http://paste.ubuntu.com/391757/
[14:02] <adiroiban> gmb: can you please try again to send this branch to ec2-land https://code.edge.launchpad.net/~adiroiban/launchpad/bug-512307/+merge/20442 ?
[14:03] <adiroiban> can someone please paste me the content from https://lpbuildbot.canonical.com/builders/lp/builds/648 ?
[14:03] <adiroiban> I got an email from buildbot, but I can not see that link
[14:10] <salgado> adiroiban, http://paste.ubuntu.com/391781/
[14:12] <adiroiban> salgado: strange output. I don't know why it arrived in my inbox
[14:13] <salgado> adiroiban, buildbot ran the testsuite after merging your branch and encountered these failures.  that's why you got it
[14:14] <adiroiban> which branch (there is no hint in the email)? was it landed or needs to be resubmited?
[14:15] <salgado> it's landed already.
[14:15] <salgado> http://paste.ubuntu.com/391784/ has the details about the branch
[14:17] <gmb> adiroiban: Sure, I'll re-run that.
[14:17] <adiroiban> many thanks!
[14:38] <allenap> BjornT: Can I gently nudge you again to take a look at isolate-tests?
[14:52] <BjornT> allenap: yes, you can :)
[15:14] <noodles775> Hi gmb, another simple soyuz one for ya: https://code.edge.launchpad.net/~michael.nelson/launchpad/527617_aborted_build_job/+merge/20968
[15:14] <gmb> noodles775: MutualExclusionError: Terms "simple" and "soyuz" cannot exist in the same sentence.
[15:14] <gmb> But otherwise, sure.
[15:15] <noodles775> gmb: heh, take a look and see :)
[15:15] <noodles775> Thanks!
[15:15] <gmb> Wow.
[15:16] <gmb> noodles775: I do believe that you may have just done the impossible. I expect your proposal for a perpetual motion machine next week.
[15:16] <gmb> noodles775: r=me
[15:16] <noodles775> gmb: ;), thanks.
[15:24] <leonardr> gmb, need a review of this trivial branch: https://code.edge.launchpad.net/~leonardr/lazr.restfulclient/str-or-unicode
[15:24] <gmb> leonardr: On it.
[15:24] <leonardr> gmb: i'll write a short mp
[15:25] <gmb> leonardr: Hah. Jumped the gun there, didn't I?
[15:25] <leonardr> gmb: as did i
[15:25] <leonardr> mp is up
[15:26] <gmb> Thanks.
[15:27] <gmb> leonardr: r=me
[15:33] <gmb> gary_poster: Are you happy for me to mark https://code.edge.launchpad.net/~gary/launchpad/bug529348rc/+merge/20776 as Approved? flacoste and salgado have given it the thumbs up but it's still lurking in the active reviews queue.
[15:34] <gary_poster> gmb, there were some test failures that I'm still talking to salgado about.  That said, if you want to mark it approved to get it out of your way, that's fine. I won't suddenly stop working on it. :-)
[15:34] <gmb> gary_poster: Well, since it's mostly approved barring fixing things I'll do that.
[15:34] <gary_poster> cool, thanks
[15:35] <noodles775> gmb: which template were you refering to (for a new unit-test), I wasn't aware of any?
[15:36] <gmb> noodles775: standard(_test)_template.py in the root of the tree.
[15:36] <noodles775> Thanks.
[15:36] <gmb> noodles775: But it's already been done
[15:36] <noodles775> ah.
[15:36] <gmb> (I just assumed you'd used it)
[15:36] <noodles775> Nope. But will next time.
[15:36] <gmb> noodles775: So, submit away, and forget I ever said anything.
[15:48] <sinzui> gmb: I fixed the status of pdds' branch
[15:50] <gmb> sinzui: Thanks.
[15:51] <jpds> gmb: Hi, can I have a review of https://code.launchpad.net/~jpds/launchpad/archivepublisher-log-to-file/+merge/20974 ?
[15:53] <gmb> jpds: Sure.
[15:56] <bac> gmb: i forgot to mention it, but i'm sprinting this week and won't be doing reviews today
[16:05] <gmb> bac: No worries.
[16:05] <bac> gmb:  cool.  just wanted to give you a heads up
[16:05] <gmb> Cheers.
[16:09] <gmb> jpds: r=me. Wnat me to land it for you?
[16:10] <jpds> noodles775: Would it be better to let bigjools review tomorrow? ^--
[16:10] <jpds> s/review/land/
[16:11] <gmb> jpds: Was that meant to be addressed to me?
[16:12] <noodles775> Up to you guys, personally I would (anything that affects the pubishing cycle should probably be glanced at by bigjools before landing)
[16:13] <gmb> WFM.
[16:13] <jpds> gmb: I think it would be best to let Julian take a final look before landing.
[16:14] <gmb> jpds: Agreed. You should request a review from him in the MP then.
[16:17] <jpds> gmb: Done, thanks.
[16:21] <james_w> gmb: sorry for the delay, my proposals should be ready now
[16:21] <james_w> both have bugs and commit messages
[16:21] <james_w> is there a document somewhere on how to get a branch landed?
[16:21] <james_w> it would be great to link such a thing from the topic to save on round trips
[16:25] <gmb> james_w: There isn't, AFAIK. You should file a bug on launchpad-documentation so that we remember to take care of that :)
[16:25] <gmb> james_w: I'll land those for you shortly.
[16:30] <james_w> thanks
[16:30] <james_w> "There are currently no bugs filed against Launchpad Documentation."
[16:30] <james_w> does that mean that there aren't supposed to be?
[16:31] <james_w> aha, the overview explains
[16:56] <EdwinGrubbs> bac: https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-534462-project-index-timeout/+merge/20980
[17:18] <rockstar> abentley, https://code.edge.launchpad.net/~rockstar/launchpad/bug-527450/+merge/20981
[17:20] <abentley> rockstar, r=me
[17:48] <salgado> adiroiban, did you get an email from ec2?
[17:48] <salgado> (about that branch I submitted on your behalf)
[17:48] <adiroiban> salgado: no
[17:49] <adiroiban> I am not sure if ec2 emails are working. As Henning has submited one of my branch I did not received any email
[17:50] <henninge> adiroiban: that's because I submitted it differently
[17:51] <adiroiban> :)
[17:51] <henninge> adiroiban: I created a new branch and merged yours
[17:51] <henninge> I was having problems landing so I thought this would help