=== jamalta-afk is now known as jamalta | ||
=== jamalta is now known as jamalta-afk | ||
=== jtv is now known as jtv-otp | ||
=== noodles785 is now known as noodles775 | ||
=== jtv-otp is now known as jtv | ||
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
al-maisan | noodles775: consider yourself hassled! https://code.edge.launchpad.net/~al-maisan/launchpad/unembargo-oops-526645/+merge/21126 | 09:44 |
---|---|---|
noodles775 | ha! | 09:44 |
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue: [al-maisan] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: -, - || queue: [al-maisan] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
jtv | noodles775, al-maisan: I've got 3 small ones for you... interested? | 09:55 |
jtv | tiny: https://code.edge.launchpad.net/~jtv/launchpad/bug-535661/+merge/21045 | 09:55 |
al-maisan | jtv: otp, should be available in a few minutes.. | 09:55 |
* jtv is patient | 09:55 | |
al-maisan | jtv: that's very much appreciated. | 09:56 |
jtv | :) | 09:56 |
noodles775 | jtv: sure! Just pop them in the queue. | 09:57 |
jtv | pop or push, that is the question... | 09:57 |
jtv | on call: noodles775, al-maisan || reviewing: -, - || queue: [al-maisan, jtv3] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | 09:57 |
al-maisan | noodles775: I can start on jtv's stuff .. | 10:05 |
* jtv nods frantically :) | 10:05 | |
noodles775 | al-maisan: yep, I'll be starting on yours in a tick, just updating some bugs. | 10:07 |
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: -, jtv || queue: [al-maisan] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
noodles775 | al-maisan: there were three for jtv right? | 10:15 |
jtv | right | 10:15 |
noodles775 | jelmer was going to grab one too. | 10:15 |
al-maisan | great | 10:15 |
* al-maisan is looking at https://code.edge.launchpad.net/~jtv/launchpad/bug-535661/+merge/21045 | 10:15 | |
jelmer | I'll take https://code.edge.launchpad.net/~jtv/launchpad/bug-536769/+merge/21068 in that case | 10:15 |
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jtv || queue: [jtv*2] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
jtv | jelmer: dankjewel | 10:16 |
al-maisan | hmm .. the one I picked is a hard nut ;) | 10:16 |
* al-maisan moves on to https://code.edge.launchpad.net/~jtv/launchpad/cleanups-475435/+merge/21070 | 10:21 | |
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jtv2 || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
noodles775 | al-maisan, jtv: do you guys know where the old mentat guidelines are (things to watch out for as a new reviewer). | 10:21 |
* al-maisan digs around for the guidelines | 10:21 | |
al-maisan | https://dev.launchpad.net/PreMergeReviews | 10:22 |
jtv | noodles775: the old ones were on the old internal LP wiki IIRC | 10:22 |
noodles775 | jtv: yeah, that's where I'm searching. | 10:22 |
noodles775 | (without success) | 10:22 |
jtv | but someone or other went to some effort to reorganize a lot of that stuff on the new one | 10:22 |
al-maisan | https://dev.launchpad.net/PythonStyleGuide | 10:23 |
noodles775 | al-maisan: yeah, the styleguide and review preparation notes are on the new wiki, but there used to be a page specifically for new reviewers (with lots of suggestions etc.) | 10:23 |
al-maisan | https://dev.launchpad.net/WorkingWithReviews | 10:23 |
jtv | https://launchpad.canonical.com/MentorProcess | 10:24 |
jtv | https://launchpad.canonical.com/TipsForReviewers | 10:24 |
noodles775 | jtv: gold! THanks! | 10:24 |
jelmer | jtv: thanks | 10:27 |
al-maisan | jtv: looking at lp:~jtv/launchpad/cleanups-475435, line 23 of the diff: why the question mark at the end of the line? | 10:55 |
jtv | al-maisan: I was just looking for a way to express the meaning of the parameter... if you have a better idea, I'd be happy to change it. | 10:56 |
al-maisan | ah | 10:57 |
al-maisan | jtv: your cover letter does not specify any tests to run .. how did you test the change locally? | 10:57 |
jtv | al-maisan: tbh I don't remember... I know I didn't run the windmill tests, but other than that, really don't know now | 10:58 |
jtv | I have a vague recollection of running the pagetests only | 10:59 |
* jtv tries running those now | 10:59 | |
al-maisan | jtv: please paste the command here .. | 11:00 |
jtv | al-maisan: ./bin/test -vv -t 'translations.*stories' | 11:00 |
al-maisan | thanks! | 11:00 |
jtv | al-maisan: I think I broke something, though it may also be the buildfarm stuff I'm running on the side. Want me to retract this one, have EC2 run a full test, and try again later? | 11:03 |
al-maisan | jtv: FWIW I am seeing test failures on my side as well | 11:04 |
al-maisan | with fresh trunk + your branch merged | 11:04 |
* al-maisan waits for the test run to finish | 11:05 | |
jtv | maybe I just missed the test results between reboots or something... I'll retract this one. | 11:05 |
al-maisan | jtv: fine. | 11:05 |
al-maisan | jtv: | 11:07 |
al-maisan | Ran 863 tests with 7 failures and 0 errors in 4 minutes 34.474 seconds. | 11:07 |
al-maisan | Tests with failures: | 11:07 |
al-maisan | lib/lp/translations/tests/../stories/standalone/xx-person-activity.txt | 11:07 |
al-maisan | lib/lp/translations/tests/../stories/standalone/xx-pofile-details.txt | 11:07 |
al-maisan | lib/lp/translations/tests/../stories/standalone/xx-series-templates.txt | 11:07 |
al-maisan | lib/lp/translations/tests/../stories/standalone/xx-translationmessage-translate.txt | 11:07 |
al-maisan | lib/lp/translations/tests/../stories/standalone/xx-translations-to-complete.txt | 11:07 |
al-maisan | lib/lp/translations/tests/../stories/standalone/xx-translations-to-review.txt | 11:07 |
al-maisan | lib/lp/translations/tests/../stories/importqueue/xx-translation-import-queue.txt | 11:07 |
jtv | al-maisan: I think the easiest is just to discard the branch... it was really just leftovers from exploring a different problem. | 11:07 |
jtv | Sorry for putting you to the trouble. | 11:08 |
al-maisan | fair enough .. I'll stop looking at it then. | 11:08 |
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jtv2 || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
* al-maisan moves on to https://code.edge.launchpad.net/~jtv/launchpad/bug-536769/+merge/21068 | 11:09 | |
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jtv3 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
noodles775 | al-maisan: I'm not sure if jelmer already started that one before he had to pop out? | 11:10 |
jtv | noodles775: I think he did, yes | 11:10 |
al-maisan | noodles775: it will need another review anyway | 11:10 |
al-maisan | since jelmer has not graduated as a reviewer yet | 11:10 |
al-maisan | right? | 11:10 |
* al-maisan can hold off | 11:11 | |
noodles775 | al-maisan: True, it will, but that should happen *after* his.... yeah, take an ocr break ;) | 11:11 |
al-maisan | ssure | 11:11 |
noodles775 | al-maisan: btw, I'm seeing if your queries can be done simply with storm. | 11:11 |
al-maisan | noodles775: IMHO there is no advantage in doing so since the queries are not fetching full objects that can be cached | 11:13 |
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
noodles775 | al-maisan: you can use result_set.values() to just get specific columns, but it's not for an advantage that I'm looking at it, but because (whether I like it or not) it's the ORM we're trying to use. | 11:15 |
noodles775 | Assuming there is no disadvantage for the query of course. | 11:15 |
noodles775 | al-maisan: sheesh, the required imports for doing the storm version are a pain in and of themselves! ;) | 11:34 |
al-maisan | hmm.. | 11:47 |
stub | https://code.edge.launchpad.net/~stub/launchpad/memcache/+merge/21130 (trivial) | 11:47 |
noodles775 | stub: r=me, I was wondering why we're not using the title attribute for the abbr tags though? | 11:57 |
=== matsubara-afk is now known as matsubara | ||
=== jelmer changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, - || queue: [jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
stub | noodles775: No idea on title. Ta for the review though :) | 12:19 |
stub | noodles775: Should I add the titles to the abbreviations since I'm here? | 12:19 |
noodles775 | stub: yeah, that'd be great... Thanks. | 12:20 |
stub | What is the title for CVS? | 12:21 |
noodles775 | Concurrent Versioning System? | 12:21 |
* noodles775 checks | 12:21 | |
stub | Concurrent Versions System | 12:22 |
stub | Oh - we don't use title cause it works crap in the UI, double mouse overs because we are in an <a> tag. | 12:24 |
stub | I can spell SVN Subversion easily enough | 12:25 |
noodles775 | urg, there you go. | 12:25 |
noodles775 | What's the mouse over for the <a> though? There's no title on it? Weird. | 12:26 |
stub | We underline on hover and the mouse pointer changes | 12:28 |
stub | But if you mouse over the abbr you get the ? icon and not the finger icon | 12:28 |
noodles775 | I see, yeah, that sux. | 12:29 |
stub | I'll land it as is since I've already run the tests ;) | 12:30 |
noodles775 | Great. | 12:30 |
adiroiban | danilos: hi. do you have time for talking about bug 201749? | 12:48 |
mup | Bug #201749: Impossible to mark as needing review strings already translated or with suggestions <story-translations-review> <ui> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/201749> | 12:48 |
danilos | adiroiban, some, sure | 12:49 |
adiroiban | browser/translationmessage.py 419-420 | 12:50 |
adiroiban | danilos: from here http://bazaar.launchpad.net/~adiroiban/launchpad/bug-201749/revision/10467 | 12:50 |
adiroiban | I think they are needes, as if user is not official translator | 12:50 |
adiroiban | those values will not be set to false | 12:50 |
danilos | adiroiban, how come? | 12:51 |
danilos | adiroiban, they won't be present in the form, thus .get() will use the default value of False | 12:51 |
adiroiban | danilos: but maybe someone will forge the form | 12:51 |
adiroiban | and inject those values | 12:52 |
danilos | adiroiban, so? | 12:52 |
adiroiban | and so force_diverge can be set to True | 12:53 |
adiroiban | even if the user is not a reviewer | 12:53 |
danilos | adiroiban, privileges are still checked in updateTranslation if I am not mistaken | 12:53 |
danilos | adiroiban, so, it doesn't really matter | 12:54 |
adiroiban | danilos: ok. my bad. But I didn't find the place in updateTranslation | 12:55 |
danilos | adiroiban, (I may have mentioned how updateTranslation is a nasty behemoth; well, this is one part of it :) | 12:55 |
danilos | adiroiban, look for force_diverged and where just_a_suggestion is set; updateTranslation *is* complex | 12:56 |
adiroiban | force_diverges is used in _makeTranslationMessageCurrent | 12:56 |
adiroiban | and I can not see the security check there | 12:57 |
adiroiban | http://paste.ubuntu.com/393247/ | 12:57 |
adiroiban | danilos: but we can talk about this later and I will use staging to test if this is a security problem | 12:58 |
danilos | adiroiban, that path is not entered unless just_a_suggestion is False | 12:58 |
danilos | adiroiban, you can spend time checking it, but I can assure you it's not ;) | 13:00 |
adiroiban | danilos: ok :) | 13:00 |
danilos | adiroiban, if you want, read the code to confirm it (_isTranslationMessageASuggestion is used to set just_a_suggestion) | 13:00 |
adiroiban | danilos: thanks :) | 13:01 |
=== henninge_ is now known as henninge | ||
adiroiban | danilos: I still don't know how diverged messages should be handled in this case http://paste.ubuntu.com/393253/ | 13:05 |
jelmer | noodles775, al-maisan: can either of you have a look at my branches? | 13:06 |
adiroiban | I don't understand why the new translations are going to be diverged by default | 13:07 |
danilos | adiroiban, not always, only if the existing one is already diverged | 13:07 |
adiroiban | danilos: true. but why, or how are they going to be diverged? | 13:07 |
noodles775 | jelmer: after lunch I can sure. | 13:08 |
danilos | adiroiban, we've got thousands of those already, we can't just close our eyes on it | 13:08 |
=== mrevell is now known as mrevell-lunch | ||
=== salgado is now known as salgado-afk | ||
adiroiban | danilos: is this a valid usecase for this bug https://bugs.edge.launchpad.net/rosetta/+bug/201749/comments/14 ? | 13:15 |
mup | Bug #201749: Impossible to mark as needing review strings already translated or with suggestions <story-translations-review> <ui> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/201749> | 13:15 |
danilos | adiroiban, sorry, on the phone | 13:16 |
=== mrevell-lunch is now known as mrevell | ||
=== jamalta-afk is now known as jamalta | ||
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jelmer || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
al-maisan | noodles775, jelmer: I am looking at https://code.edge.launchpad.net/~jelmer/launchpad/bug531985/+merge/21038 | 14:05 |
noodles775 | al-maisan: great, I'm off to lunch :) | 14:05 |
al-maisan | noodles775: did you rewrite my branch yet? ;) | 14:07 |
al-maisan | noodles775: ah, just saw the review email, thanks! | 14:09 |
al-maisan | jelmer: how was lp:~jelmer/launchpad/bug531985 tested? | 14:25 |
=== matsubara is now known as matsubara-lunch | ||
=== noodles775 changed the topic of #launchpad-reviews to: on call: al-maisan || reviewing: jelmer || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
=== matsubara-lunch is now known as matsubara | ||
=== rockstar changed the topic of #launchpad-reviews to: on call: al-maisan, rockstar || reviewing: jelmer, || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
al-maisan | [15:25] <al-maisan> jelmer: how was lp:~jelmer/launchpad/bug531985 tested? | 16:21 |
=== deryck is now known as deryck[lunch] | ||
jelmer | al-maisan: sorry | 16:29 |
jelmer | al-maisan: I tested by adding myself to commercial-admins | 16:29 |
al-maisan | jelmer: on your local system? | 16:30 |
al-maisan | s/local/development/ | 16:30 |
al-maisan | jelmer: r=me | 16:37 |
jelmer | al-maisan: dogfood only | 16:37 |
jelmer | al-maisan: sorry, too much conversations happening at once :_/ | 16:37 |
al-maisan | jelmer: that's even better :-) | 16:37 |
jelmer | al-maisan: thanks | 16:37 |
=== deryck[lunch] is now known as deryck | ||
=== gary_poster is now known as gary-lunch | ||
* kfogel is away: switching consoles for a bit, back soon | 18:19 | |
leonardr | gary, this isn't quite ready for review, but could i get your feedback on https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-apidoc ? | 18:23 |
leonardr | the incremental diff is http://pastebin.ubuntu.com/393449/ | 18:23 |
leonardr | i'm specifically wondering if you have any suggestions on how to put the template file somewhere else while still keeping it accessible from utilities/ (i tried pkg_resources loading from canonical.launchpad.templates but it didn't work, probably because c.l.t isn't a module) | 18:24 |
leonardr | and if you have any ideas on how to get rid of versions_and_descriptions in the namespace--i'm not very good at tales | 18:24 |
leonardr | i'm going to lunch soon, so there's no rush | 18:24 |
=== leonardr is now known as leonardr-lunch | ||
=== salgado-afk is now known as salgado | ||
=== leonardr-lunch is now known as leonardr | ||
=== gary-lunch is now known as gary_poster | ||
gary_poster | leonardr: I'll look in just a few | 19:16 |
leonardr | gary, np | 19:17 |
salgado | adiroiban, did you get a failure email from ec2 about that branch I submitted for you? | 19:24 |
adiroiban | salgado: no. | 19:24 |
adiroiban | but I don't think ec2 email notification is working | 19:24 |
salgado | it is, I got one yesterday | 19:24 |
adiroiban | there were some other branches landed on my behalf | 19:24 |
adiroiban | and I did not get any notification for them | 19:25 |
salgado | ok, then it's possible this one failed because PQM was in testfix mode | 19:25 |
* salgado submits once again | 19:25 | |
adiroiban | for the branches landed by Graham, he has forwarded those emails | 19:26 |
adiroiban | but if the branch was not landed | 19:26 |
adiroiban | it probably means it has errors | 19:26 |
salgado | gmb, when landing adiroiban's branches, did you use 'ec2 land'? | 19:28 |
henninge | rockstar: Hi! | 19:29 |
rockstar | henninge, hi there. | 19:29 |
henninge | rockstar: hey, will you be at UDS? | 19:29 |
=== rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
rockstar | henninge, yes, I believe I will. | 19:30 |
henninge | rockstar: cool, you still got my bag? | 19:30 |
henninge | ;-) | 19:30 |
rockstar | henninge, I hope I still have your bag. :) | 19:30 |
* henninge imagines rockstar scrambling round his room, looking for it ... | 19:30 | |
rockstar | (we're in the process of remodeling the downstairs) | 19:31 |
henninge | rockstar: if you find it by May, bring it along, please.... ;) | 19:31 |
henninge | ... under the snow. | 19:31 |
rockstar | It's probably in the pile of stuff from when we emptied my office. | 19:31 |
rockstar | henninge, snow's almost melted actually... first time since November. | 19:31 |
henninge | rockstar: ah, better than here. | 19:32 |
henninge | March came along and a new coat of snow with it. | 19:32 |
henninge | rockstar: anyway, I do have a branch ready for review, too. | 19:32 |
henninge | ;) | 19:32 |
henninge | but I am about to leave. | 19:32 |
henninge | rockstar: do you want to give it a go or shall I ask abel in the morning? | 19:33 |
rockstar | henninge, if it's complicated, it might have to wait. If it's simple, I can probably take it. | 19:33 |
henninge | rockstar: complicated depends on if you have been to Wellington, I guess. | 19:33 |
rockstar | henninge, UNLESS you write me a novel description of the patch and why it's so complicated. | 19:33 |
henninge | build farm stuff | 19:33 |
rockstar | henninge, okay, I'll take a look. | 19:33 |
henninge | rockstar: it *does* have a long cover letter. | 19:33 |
henninge | rockstar: cheers | 19:34 |
=== henninge changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: || queue: [henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
henninge | rockstar: oops, I never pasted this: https://code.edge.launchpad.net/~henninge/launchpad/bug-509557-invoke-pottery/+merge/21172 | 19:46 |
rockstar | henninge, I already found it. :) | 19:46 |
* henninge makes a mental note to remember to press 'enter' after input | 19:46 | |
henninge | rockstar: ok, I am outta here. If you get too confused, drop it ... ;-) | 19:47 |
rockstar | henninge, oh, I'll just make comments in the proposal for you to get to in the morning. | 19:47 |
henninge | rockstar: thanks and good night | 19:48 |
=== jelmer changed the topic of #launchpad-reviews to: rockstar || reviewing: || queue: [henninge,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
leonardr | gary, it's now a formal review request: https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-apidoc/+merge/21178 | 20:26 |
gary_poster | ok | 20:26 |
leonardr | if you're too busy, maybe flacoste could look? | 20:26 |
=== fjlacoste is now known as flacoste | ||
gary_poster | leonardr: that's fine. I will be on call until I finish talking to you | 20:30 |
leonardr | rockstar, i need to rev lazr.restful, can you review this trivial branch? | 20:31 |
leonardr | http://pastebin.ubuntu.com/393541/ | 20:31 |
rockstar | leonardr, looking | 20:32 |
rockstar | leonardr, r=me | 20:33 |
leonardr | great | 20:33 |
henninge | rockstar: I am here, btw. | 20:36 |
=== NCommander changed the topic of #launchpad-reviews to: rockstar || reviewing: || queue: [henninge,jelmer,NCommander] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
rockstar | jelmer, NCommander, I generally don't notice changes to the topic unless the changes in topic are requested first. :) | 20:47 |
jelmer | rockstar: oops, sorry :-) | 20:47 |
NCommander | rockstar: sorry, first review :-) | 20:47 |
rockstar | jelmer, NCommander, where are you merge proposals? | 20:48 |
jelmer | rockstar: https://code.edge.launchpad.net/~jelmer/launchpad/noversion/+merge/21059 | 20:49 |
NCommander | rockstar: https://code.edge.launchpad.net/~mcasadevall/launchpad/raw_source_changelog/+merge/21179 | 20:49 |
jelmer | (it's a lot of lines, but mostly removing obsolete stuff) | 20:49 |
rockstar | jelmer, NCommander, ack. I'll get to them after henninge | 20:50 |
jelmer | rockstar: thanks! | 20:50 |
=== matsubara is now known as matsubara-afk | ||
* kfogel is away: machine fan cleanup; back later | 22:29 | |
=== salgado is now known as salgado-afk | ||
=== jamalta is now known as jamalta-afk |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!