=== jamalta-afk is now known as jamalta === jamalta is now known as jamalta-afk === jtv is now known as jtv-otp === noodles785 is now known as noodles775 === jtv-otp is now known as jtv === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [09:44] noodles775: consider yourself hassled! https://code.edge.launchpad.net/~al-maisan/launchpad/unembargo-oops-526645/+merge/21126 [09:44] ha! === al-maisan changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue: [al-maisan] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: -, - || queue: [al-maisan] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [09:55] noodles775, al-maisan: I've got 3 small ones for you... interested? [09:55] tiny: https://code.edge.launchpad.net/~jtv/launchpad/bug-535661/+merge/21045 [09:55] jtv: otp, should be available in a few minutes.. [09:55] * jtv is patient [09:56] jtv: that's very much appreciated. [09:56] :) [09:57] jtv: sure! Just pop them in the queue. [09:57] pop or push, that is the question... [09:57] on call: noodles775, al-maisan || reviewing: -, - || queue: [al-maisan, jtv3] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [10:05] noodles775: I can start on jtv's stuff .. [10:05] * jtv nods frantically :) [10:07] al-maisan: yep, I'll be starting on yours in a tick, just updating some bugs. === al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: -, jtv || queue: [al-maisan] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [10:15] al-maisan: there were three for jtv right? [10:15] right [10:15] jelmer was going to grab one too. [10:15] great [10:15] * al-maisan is looking at https://code.edge.launchpad.net/~jtv/launchpad/bug-535661/+merge/21045 [10:15] I'll take https://code.edge.launchpad.net/~jtv/launchpad/bug-536769/+merge/21068 in that case === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jtv || queue: [jtv*2] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [10:16] jelmer: dankjewel [10:16] hmm .. the one I picked is a hard nut ;) [10:21] * al-maisan moves on to https://code.edge.launchpad.net/~jtv/launchpad/cleanups-475435/+merge/21070 === al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jtv2 || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [10:21] al-maisan, jtv: do you guys know where the old mentat guidelines are (things to watch out for as a new reviewer). [10:21] * al-maisan digs around for the guidelines [10:22] https://dev.launchpad.net/PreMergeReviews [10:22] noodles775: the old ones were on the old internal LP wiki IIRC [10:22] jtv: yeah, that's where I'm searching. [10:22] (without success) [10:22] but someone or other went to some effort to reorganize a lot of that stuff on the new one [10:23] https://dev.launchpad.net/PythonStyleGuide [10:23] al-maisan: yeah, the styleguide and review preparation notes are on the new wiki, but there used to be a page specifically for new reviewers (with lots of suggestions etc.) [10:23] https://dev.launchpad.net/WorkingWithReviews [10:24] https://launchpad.canonical.com/MentorProcess [10:24] https://launchpad.canonical.com/TipsForReviewers [10:24] jtv: gold! THanks! [10:27] jtv: thanks [10:55] jtv: looking at lp:~jtv/launchpad/cleanups-475435, line 23 of the diff: why the question mark at the end of the line? [10:56] al-maisan: I was just looking for a way to express the meaning of the parameter... if you have a better idea, I'd be happy to change it. [10:57] ah [10:57] jtv: your cover letter does not specify any tests to run .. how did you test the change locally? [10:58] al-maisan: tbh I don't remember... I know I didn't run the windmill tests, but other than that, really don't know now [10:59] I have a vague recollection of running the pagetests only [10:59] * jtv tries running those now [11:00] jtv: please paste the command here .. [11:00] al-maisan: ./bin/test -vv -t 'translations.*stories' [11:00] thanks! [11:03] al-maisan: I think I broke something, though it may also be the buildfarm stuff I'm running on the side. Want me to retract this one, have EC2 run a full test, and try again later? [11:04] jtv: FWIW I am seeing test failures on my side as well [11:04] with fresh trunk + your branch merged [11:05] * al-maisan waits for the test run to finish [11:05] maybe I just missed the test results between reboots or something... I'll retract this one. [11:05] jtv: fine. [11:07] jtv: [11:07] Ran 863 tests with 7 failures and 0 errors in 4 minutes 34.474 seconds. [11:07] Tests with failures: [11:07] lib/lp/translations/tests/../stories/standalone/xx-person-activity.txt [11:07] lib/lp/translations/tests/../stories/standalone/xx-pofile-details.txt [11:07] lib/lp/translations/tests/../stories/standalone/xx-series-templates.txt [11:07] lib/lp/translations/tests/../stories/standalone/xx-translationmessage-translate.txt [11:07] lib/lp/translations/tests/../stories/standalone/xx-translations-to-complete.txt [11:07] lib/lp/translations/tests/../stories/standalone/xx-translations-to-review.txt [11:07] lib/lp/translations/tests/../stories/importqueue/xx-translation-import-queue.txt [11:07] al-maisan: I think the easiest is just to discard the branch... it was really just leftovers from exploring a different problem. [11:08] Sorry for putting you to the trouble. [11:08] fair enough .. I'll stop looking at it then. === al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jtv2 || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [11:09] * al-maisan moves on to https://code.edge.launchpad.net/~jtv/launchpad/bug-536769/+merge/21068 === al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jtv3 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [11:10] al-maisan: I'm not sure if jelmer already started that one before he had to pop out? [11:10] noodles775: I think he did, yes [11:10] noodles775: it will need another review anyway [11:10] since jelmer has not graduated as a reviewer yet [11:10] right? [11:11] * al-maisan can hold off [11:11] al-maisan: True, it will, but that should happen *after* his.... yeah, take an ocr break ;) [11:11] ssure [11:11] al-maisan: btw, I'm seeing if your queries can be done simply with storm. [11:13] noodles775: IMHO there is no advantage in doing so since the queries are not fetching full objects that can be cached === al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [11:15] al-maisan: you can use result_set.values() to just get specific columns, but it's not for an advantage that I'm looking at it, but because (whether I like it or not) it's the ORM we're trying to use. [11:15] Assuming there is no disadvantage for the query of course. [11:34] al-maisan: sheesh, the required imports for doing the storm version are a pain in and of themselves! ;) [11:47] hmm.. [11:47] https://code.edge.launchpad.net/~stub/launchpad/memcache/+merge/21130 (trivial) [11:57] stub: r=me, I was wondering why we're not using the title attribute for the abbr tags though? === matsubara-afk is now known as matsubara === jelmer changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, - || queue: [jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [12:19] noodles775: No idea on title. Ta for the review though :) [12:19] noodles775: Should I add the titles to the abbreviations since I'm here? [12:20] stub: yeah, that'd be great... Thanks. [12:21] What is the title for CVS? [12:21] Concurrent Versioning System? [12:21] * noodles775 checks [12:22] Concurrent Versions System [12:24] Oh - we don't use title cause it works crap in the UI, double mouse overs because we are in an tag. [12:25] I can spell SVN Subversion easily enough [12:25] urg, there you go. [12:26] What's the mouse over for the though? There's no title on it? Weird. [12:28] We underline on hover and the mouse pointer changes [12:28] But if you mouse over the abbr you get the ? icon and not the finger icon [12:29] I see, yeah, that sux. [12:30] I'll land it as is since I've already run the tests ;) [12:30] Great. [12:48] danilos: hi. do you have time for talking about bug 201749? [12:48] Bug #201749: Impossible to mark as needing review strings already translated or with suggestions [12:49] adiroiban, some, sure [12:50] browser/translationmessage.py 419-420 [12:50] danilos: from here http://bazaar.launchpad.net/~adiroiban/launchpad/bug-201749/revision/10467 [12:50] I think they are needes, as if user is not official translator [12:50] those values will not be set to false [12:51] adiroiban, how come? [12:51] adiroiban, they won't be present in the form, thus .get() will use the default value of False [12:51] danilos: but maybe someone will forge the form [12:52] and inject those values [12:52] adiroiban, so? [12:53] and so force_diverge can be set to True [12:53] even if the user is not a reviewer [12:53] adiroiban, privileges are still checked in updateTranslation if I am not mistaken [12:54] adiroiban, so, it doesn't really matter [12:55] danilos: ok. my bad. But I didn't find the place in updateTranslation [12:55] adiroiban, (I may have mentioned how updateTranslation is a nasty behemoth; well, this is one part of it :) [12:56] adiroiban, look for force_diverged and where just_a_suggestion is set; updateTranslation *is* complex [12:56] force_diverges is used in _makeTranslationMessageCurrent [12:57] and I can not see the security check there [12:57] http://paste.ubuntu.com/393247/ [12:58] danilos: but we can talk about this later and I will use staging to test if this is a security problem [12:58] adiroiban, that path is not entered unless just_a_suggestion is False [13:00] adiroiban, you can spend time checking it, but I can assure you it's not ;) [13:00] danilos: ok :) [13:00] adiroiban, if you want, read the code to confirm it (_isTranslationMessageASuggestion is used to set just_a_suggestion) [13:01] danilos: thanks :) === henninge_ is now known as henninge [13:05] danilos: I still don't know how diverged messages should be handled in this case http://paste.ubuntu.com/393253/ [13:06] noodles775, al-maisan: can either of you have a look at my branches? [13:07] I don't understand why the new translations are going to be diverged by default [13:07] adiroiban, not always, only if the existing one is already diverged [13:07] danilos: true. but why, or how are they going to be diverged? [13:08] jelmer: after lunch I can sure. [13:08] adiroiban, we've got thousands of those already, we can't just close our eyes on it === mrevell is now known as mrevell-lunch === salgado is now known as salgado-afk [13:15] danilos: is this a valid usecase for this bug https://bugs.edge.launchpad.net/rosetta/+bug/201749/comments/14 ? [13:15] Bug #201749: Impossible to mark as needing review strings already translated or with suggestions [13:16] adiroiban, sorry, on the phone === mrevell-lunch is now known as mrevell === jamalta-afk is now known as jamalta === al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: al-maisan, jelmer || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [14:05] noodles775, jelmer: I am looking at https://code.edge.launchpad.net/~jelmer/launchpad/bug531985/+merge/21038 [14:05] al-maisan: great, I'm off to lunch :) [14:07] noodles775: did you rewrite my branch yet? ;) [14:09] noodles775: ah, just saw the review email, thanks! [14:25] jelmer: how was lp:~jelmer/launchpad/bug531985 tested? === matsubara is now known as matsubara-lunch === noodles775 changed the topic of #launchpad-reviews to: on call: al-maisan || reviewing: jelmer || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === matsubara-lunch is now known as matsubara === rockstar changed the topic of #launchpad-reviews to: on call: al-maisan, rockstar || reviewing: jelmer, || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [16:21] [15:25] jelmer: how was lp:~jelmer/launchpad/bug531985 tested? === deryck is now known as deryck[lunch] [16:29] al-maisan: sorry [16:29] al-maisan: I tested by adding myself to commercial-admins [16:30] jelmer: on your local system? [16:30] s/local/development/ [16:37] jelmer: r=me [16:37] al-maisan: dogfood only [16:37] al-maisan: sorry, too much conversations happening at once :_/ [16:37] jelmer: that's even better :-) [16:37] al-maisan: thanks === deryck[lunch] is now known as deryck === gary_poster is now known as gary-lunch [18:19] * kfogel is away: switching consoles for a bit, back soon [18:23] gary, this isn't quite ready for review, but could i get your feedback on https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-apidoc ? [18:23] the incremental diff is http://pastebin.ubuntu.com/393449/ [18:24] i'm specifically wondering if you have any suggestions on how to put the template file somewhere else while still keeping it accessible from utilities/ (i tried pkg_resources loading from canonical.launchpad.templates but it didn't work, probably because c.l.t isn't a module) [18:24] and if you have any ideas on how to get rid of versions_and_descriptions in the namespace--i'm not very good at tales [18:24] i'm going to lunch soon, so there's no rush === leonardr is now known as leonardr-lunch === salgado-afk is now known as salgado === leonardr-lunch is now known as leonardr === gary-lunch is now known as gary_poster [19:16] leonardr: I'll look in just a few [19:17] gary, np [19:24] adiroiban, did you get a failure email from ec2 about that branch I submitted for you? [19:24] salgado: no. [19:24] but I don't think ec2 email notification is working [19:24] it is, I got one yesterday [19:24] there were some other branches landed on my behalf [19:25] and I did not get any notification for them [19:25] ok, then it's possible this one failed because PQM was in testfix mode [19:25] * salgado submits once again [19:26] for the branches landed by Graham, he has forwarded those emails [19:26] but if the branch was not landed [19:26] it probably means it has errors [19:28] gmb, when landing adiroiban's branches, did you use 'ec2 land'? [19:29] rockstar: Hi! [19:29] henninge, hi there. [19:29] rockstar: hey, will you be at UDS? === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [19:30] henninge, yes, I believe I will. [19:30] rockstar: cool, you still got my bag? [19:30] ;-) [19:30] henninge, I hope I still have your bag. :) [19:30] * henninge imagines rockstar scrambling round his room, looking for it ... [19:31] (we're in the process of remodeling the downstairs) [19:31] rockstar: if you find it by May, bring it along, please.... ;) [19:31] ... under the snow. [19:31] It's probably in the pile of stuff from when we emptied my office. [19:31] henninge, snow's almost melted actually... first time since November. [19:32] rockstar: ah, better than here. [19:32] March came along and a new coat of snow with it. [19:32] rockstar: anyway, I do have a branch ready for review, too. [19:32] ;) [19:32] but I am about to leave. [19:33] rockstar: do you want to give it a go or shall I ask abel in the morning? [19:33] henninge, if it's complicated, it might have to wait. If it's simple, I can probably take it. [19:33] rockstar: complicated depends on if you have been to Wellington, I guess. [19:33] henninge, UNLESS you write me a novel description of the patch and why it's so complicated. [19:33] build farm stuff [19:33] henninge, okay, I'll take a look. [19:33] rockstar: it *does* have a long cover letter. [19:34] rockstar: cheers === henninge changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: || queue: [henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [19:46] rockstar: oops, I never pasted this: https://code.edge.launchpad.net/~henninge/launchpad/bug-509557-invoke-pottery/+merge/21172 [19:46] henninge, I already found it. :) [19:46] * henninge makes a mental note to remember to press 'enter' after input [19:47] rockstar: ok, I am outta here. If you get too confused, drop it ... ;-) [19:47] henninge, oh, I'll just make comments in the proposal for you to get to in the morning. [19:48] rockstar: thanks and good night === jelmer changed the topic of #launchpad-reviews to: rockstar || reviewing: || queue: [henninge,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [20:26] gary, it's now a formal review request: https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-apidoc/+merge/21178 [20:26] ok [20:26] if you're too busy, maybe flacoste could look? === fjlacoste is now known as flacoste [20:30] leonardr: that's fine. I will be on call until I finish talking to you [20:31] rockstar, i need to rev lazr.restful, can you review this trivial branch? [20:31] http://pastebin.ubuntu.com/393541/ [20:32] leonardr, looking [20:33] leonardr, r=me [20:33] great [20:36] rockstar: I am here, btw. === NCommander changed the topic of #launchpad-reviews to: rockstar || reviewing: || queue: [henninge,jelmer,NCommander] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [20:47] jelmer, NCommander, I generally don't notice changes to the topic unless the changes in topic are requested first. :) [20:47] rockstar: oops, sorry :-) [20:47] rockstar: sorry, first review :-) [20:48] jelmer, NCommander, where are you merge proposals? [20:49] rockstar: https://code.edge.launchpad.net/~jelmer/launchpad/noversion/+merge/21059 [20:49] rockstar: https://code.edge.launchpad.net/~mcasadevall/launchpad/raw_source_changelog/+merge/21179 [20:49] (it's a lot of lines, but mostly removing obsolete stuff) [20:50] jelmer, NCommander, ack. I'll get to them after henninge [20:50] rockstar: thanks! === matsubara is now known as matsubara-afk [22:29] * kfogel is away: machine fan cleanup; back later === salgado is now known as salgado-afk === jamalta is now known as jamalta-afk