| === jamalta-afk is now known as jamalta | ||
| === matsubara is now known as matsubara-afk | ||
| === jtv-zzz is now known as jtv | ||
| === jamalta is now known as off | ||
| === sidnei changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [adiroiban(http://tinyurl.com/yex2mcx),adiroiban(bug-522188-take-2),sidnei(http://bit.ly/bm7GX4),sidnei(http://bit.ly/b0Sg2e)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jtv1 is now known as jtv | ||
| === jelmer_ is now known as jelmer | ||
| gmb | stub, jml, BjornT: Gentle prod about https://code.edge.launchpad.net/~gmb/launchpad/bugwatchhistory-db-bug-538091/+merge/21262 | 09:27 |
|---|---|---|
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue: [adiroiban(bug-522188-take-2),sidnei(http://bit.ly/bm7GX4),sidnei(http://bit.ly/b0Sg2e)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | Hmm. This branch requires me to drink coffee. | 09:36 |
| * gmb goes to brew some | 09:36 | |
| === wgrant changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue: [adiroiban(bug-522188-take-2),sidnei(http://bit.ly/bm7GX4),sidnei(http://bit.ly/b0Sg2e),wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jelmer_ is now known as jelmer | ||
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue: [sidnei(http://bit.ly/bm7GX4),sidnei(http://bit.ly/b0Sg2e)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| wgrant | gmb: I appear to have disappeared from the queue? | 10:46 |
| gmb | wgrant: Argh, sorry. My bad. | 10:46 |
| wgrant | np | 10:46 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue: [sidnei(http://bit.ly/bm7GX4),sidnei(http://bit.ly/b0Sg2e), wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | wgrant: You may find, over time, that I absolutely suck at IRC. | 10:47 |
| wgrant | Heh. | 10:53 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: sidnei || queue: [sidnei(http://bit.ly/b0Sg2e), wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | gary_poster: I've asked for your review on https://code.edge.launchpad.net/~sidnei/lazr-js/newer-buildout/+merge/21417; I don't have the necessary knowledge to be confident in reviewing it. If you don't have time to take a look can you find someone who has the necessary knowledge and reassign it to them? | 11:12 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: sidnei || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gary_poster | gmb, ack. not me either. I'll reassign to mars. | 11:12 |
| gmb | gary_poster: Should this one go to mars too? https://code.edge.launchpad.net/~sidnei/lazr-js/better-module-config-compression/+merge/21427 | 11:12 |
| gary_poster | gmb, yes | 11:13 |
| gmb | thanks. | 11:13 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | wgrant: Is there a bug filed about the lp.registry.interfaces.person circular import? | 11:17 |
| wgrant | gmb: I don't know. It happens in lots of places. | 11:18 |
| gmb | wgrant: Okay. Please search for / file one against lp-registry and make that comment an XXX. We should track this down (not your problem, though). | 11:19 |
| wgrant | gmb: Pushing. | 11:26 |
| jtv | gmb: got a big one for you. | 11:31 |
| gmb | jtv: Define "big" | 11:31 |
| jtv | gmb: "within 10% of the review limit" | 11:32 |
| gmb | wgrant: And with that, r=me. Want me to ec2 it for you? | 11:32 |
| gmb | jtv: So between 800 and 880 lines? | 11:32 |
| jtv | gmb: ...but not actually over the review limit. | 11:33 |
| wgrant | gmb: Thanks. Please ec2. | 11:33 |
| gmb | jtv: Ah, cool. Bring it on, then. | 11:34 |
| gmb | wgrant: Running now. | 11:34 |
| jtv | gmb: great, thanks. https://code.edge.launchpad.net/~jtv/launchpad/bug-536797/+merge/21439 | 11:34 |
| wgrant | Excellent. | 11:34 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === daniloff is now known as danilos | ||
| leonardr | gmb, can i ask you to review a one-line change to an already reviewed branch? | 11:39 |
| leonardr | branch: https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-apidoc | 11:39 |
| leonardr | change: http://paste.ubuntu.com/396114/ | 11:39 |
| leonardr | the point of the change is to make sure 'make clean' will clean up a situation where there was an error generating the wadl or apidoc | 11:39 |
| gmb | leonardr: Looks fine; r=me. | 11:40 |
| leonardr | great | 11:40 |
| wgrant | leonardr: Why only during clean? | 11:41 |
| wgrant | I've struck it several times when terminating a build, and make clean would be excessive for cleaning that up. | 11:42 |
| gmb | jtv: In fact I'll go and grab some lunch now before starting your branch. | 11:42 |
| wgrant | Is there any problem with removing it immediately before create-lp-wadl is run? | 11:42 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: lunch || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jtv | gmb: I can't stick around for too long myself | 11:43 |
| gmb | jtv: No worries; I'll ask question in the review. | 11:43 |
| jtv | thx | 11:44 |
| adiroiban | henninge: hi, please let me know when you have some time to talk about the MP for bug 201749 | 11:48 |
| mup | Bug #201749: Impossible to mark as needing review strings already translated or with suggestions <story-translations-review> <ui> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/201749> | 11:48 |
| henninge | adiroiban: I'd rather do that after lunch. Can you please fix as much stuff as possible in the branch and we can then discuss the remaining issue(s)? | 11:57 |
| adiroiban | henninge: sure :) | 11:57 |
| henninge | adiroiban: thanks ;-) | 11:58 |
| danilos | adiroiban, henninge: I've also made the comment on the most important issue of whether should it behave like that; it's up to the two of you to decide on the proper behaviour, though | 12:02 |
| leonardr | gmb, when you come back, https://code.edge.launchpad.net/~leonardr/lazr.restful/multi-part-etag/+merge/21398 would like to join your review queue | 12:10 |
| === matsubara-afk is now known as matsubara | ||
| === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: lunch,jtv || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | hi gmb -- if you haven't started on jtv's review i'll take it | 12:46 |
| gmb | bac: That'd be great, thanks. | 12:47 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: leonardr,jtv || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| salgado | gmb, bac, I have a trivial one; can I add it to the queue? | 13:03 |
| bac | sure | 13:03 |
| === salgado changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: leonardr,jtv || queue: [salgado] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === mrevell is now known as mrevell-lunch | ||
| === off is now known as jamalta | ||
| abentley | gmb, bac: could you please review https://code.edge.launchpad.net/~abentley/launchpad/multiple-series-model/+merge/21260 and https://code.edge.launchpad.net/~abentley/launchpad/fix-qa-ready/+merge/21392 ? | 13:19 |
| gmb | abentley: Sure, stick 'em in the queue | 13:19 |
| === abentley changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: leonardr,jtv || queue: [salgado, abentley, abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | leonardr: Your branch looks good (and the doctest was really well written, thank you). r=me | 13:22 |
| leonardr | hurrah | 13:22 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: salgado,jtv || queue: [abentley, abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| allenap | jml: Gentle nudge re. https://code.edge.launchpad.net/~allenap/launchpad/isolate-tests/+merge/20916 (and a reminder that I'm completely happy if you're too busy and need me to ask someone else). | 13:30 |
| jml | allenap, I'll take a look now. | 13:31 |
| allenap | jml: Woohoo, thanks :) | 13:31 |
| gmb | salgado: r=me | 13:31 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: abentley,jtv || queue: [abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| salgado | thanks gmb! | 13:31 |
| allenap | jml: Thank you for the review. I'll try and turn it around asap. | 13:57 |
| jml | allenap, np. | 13:57 |
| allenap | jml: Do you have another 10-20 minutes available today? For checkwatches I've written an ensure_no_transaction() decorator to make sure we don't start doing slow things (like network calls) when there's a transaction open. It uses the raw db connection, so I wondered if you'd take a look and give me an early indication if it's going to be okay or not. Or if it's already been done somewhere. | 14:00 |
| jml | allenap, I don't know of somewhere else that does that. | 14:01 |
| allenap | jml: http://paste.ubuntu.com/396185/ (46 lines) | 14:02 |
| jml | allenap, I'll take a look at the patch though. | 14:02 |
| === mrevell-lunch is now known as mrevell | ||
| gmb | abentley: r=me on your multiple-series-model branch | 14:10 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: abentley,jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | gmb, thanks. | 14:11 |
| gmb | abentley: ... as is your fix-qa-ready branch | 14:15 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: -, jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| * gmb takes a break for bugs standup; will work on the +activereviews queue after. | 14:16 | |
| bac | hi bigjools | 14:29 |
| bigjools | hey | 14:30 |
| adiroiban | gmb: hi, can you please try a new ec2-test on this branch lp:~adiroiban/launchpad/bug-512307 ? I have merged it with devel and fixed the failing tests. | 15:17 |
| gmb | adiroiban: sure | 15:18 |
| gmb | adiroiban: Running. | 15:19 |
| === gmb changed the topic of #launchpad-reviews to: on call: bac || reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| * gmb signs off to answer a shedload of emails | 15:36 | |
| === danilos is now known as daniloff | ||
| === salgado_ is now known as salgado | ||
| leonardr | bac, can you add https://code.edge.launchpad.net/~leonardr/lazr.restfulclient/test-long-etag/+merge/21455 to your queue? | 16:05 |
| bac | leonardr: yes | 16:05 |
| leonardr | great | 16:06 |
| === salgado is now known as salgado-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === salgado-lunch is now known as salgado | ||
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: leonardr,jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | leonardr: your mp showed up as private. | 17:21 |
| === gary_poster is now known as gary-lunch | ||
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === deryck[lunch] is now known as deryck | ||
| leonardr | bac: oops, i'll fix | 18:30 |
| leonardr | bac, you were able to review the branch anyway? | 18:36 |
| bac | leonardr: yes. just thought it odd that it was privte | 18:36 |
| leonardr | bac: that is odd, i changed it | 18:36 |
| === gary-lunch is now known as gary_poster | ||
| === salgado_ is now known as salgado | ||
| rockstar | bac, hi, can I jump on your queue? | 19:59 |
| bac | rockstar: sure | 19:59 |
| === rockstar changed the topic of #launchpad-reviews to: on call: bac || reviewing: jtv || queue: [rockstar] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| rockstar | bac, https://code.edge.launchpad.net/~rockstar/launchpad/recipe-description/+merge/21479 | 20:00 |
| bac | rockstar: in your model, do you need to provide any extra params to StringCol() such as default or notNull? | 20:14 |
| rockstar | bac, I don't think so. TEXT is okay being blank I believe. That's fine. | 20:15 |
| bac | rockstar: we generally have all that goo in our classes...but i don't know if it is legacy | 20:15 |
| bac | and the sqlobject wrapper in storm doesn't provide much guidance | 20:15 |
| james_w | rockstar: hey, did my branch from yesterday disappear in to the ec2 black hole? | 20:24 |
| rockstar | james_w, it appears so. I have a script that kills ec2 instances when they run for too long. Yours probably got killed that way (I always seem to have unlucky problems with ec2) | 20:25 |
| james_w | damn | 20:25 |
| james_w | rockstar: could you have another go, or should I ask someone else? | 20:34 |
| rockstar | james_w, I'll shepherd it through. | 20:34 |
| rockstar | james_w, sorry for my recent unresponsiveness. I'm on the phone. :) | 20:34 |
| james_w | np | 20:34 |
| NCommander | I'm repushing a branch that is proposed for merging to LP; do I need to resubmit a merge request? (I had to resolve a few conflicts) | 20:54 |
| james_w | NCommander: the diff will update with your new changes | 20:57 |
| NCommander | james_w: ah | 20:57 |
| === salgado is now known as salgado-afk | ||
| bac | sinzui: https://code.edge.launchpad.net/~bac/launchpad/productseries-js/+merge/21485 -- when you have some time | 21:23 |
| sinzui | bac: thanks | 21:23 |
| === bac changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| leonardr | gary, care to review https://code.edge.launchpad.net/~leonardr/launchpadlib/529348-fix/+merge/21494 ? | 21:27 |
| gary_poster | leonardr: on it | 21:27 |
| gary_poster | leonardr: do I understand correctly that this will change nothing about the change needed now for 529348 in launchpad, because of legacy? | 21:30 |
| leonardr | gary: yes, this is 1) to get the tests passing, and 2) to simplify the 529348 fix a little bit many years from now | 21:31 |
| gary_poster | leonardr: right. Getting the test to pass this way is expedient. We actually have an explicit test to show the hack needed in launchpad. Understood. Approving branch. | 21:35 |
| gary_poster | leonardr: I was looking at https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-apidoc/+merge/21181 . I need to run, but I don't understand why you did the pt_getContext call and namespace dance rather than just call the page template with **kwargs as described in zope/pagetemplate/interfaces.py in the zope.pagetemplate egg. Can talk tomorrow. | 22:03 |
| leonardr | gary: i was copying code from lazr.restful | 22:04 |
| gary_poster | leonardr: ah. we should be able to simplify drastically | 22:05 |
| gary_poster | talk to you tomorrow | 22:05 |
| leonardr | ok, cool | 22:05 |
| leonardr | gary: the code i'm working on now looks solid | 22:06 |
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!