/srv/irclogs.ubuntu.com/2010/03/16/#ubuntu-mozillateam.txt

ccheneyasac: while cleaning up the patches trying to debug the problem i ran into a part i patched that i wasn't sure if it was safe: http://pastebin.ubuntu.com/395908/01:41
ccheneyasac: is adding those two (to_tokens / from_tokens) to the end of the struct ok in the main glib, would them being there be likely to actually break anything01:42
ccheneyasac: oh yea and what should i use for version numbers for these packages? i am guessing i need to munge them somehow to be easily upgradable between versions of ubuntu01:48
ccheneyasac: i'm going to upload everything to a ppa, i can't seem to figure out what is causing the errors, i have a few ideas of what to try but not sure if they are valid02:39
ddecatormicahg: you available to help me with quilt, or are you busy?02:47
micahgddecator: for next few minutes maybe02:47
ddecatorthe patch that's failing is the install_systray.patch02:48
micahgddecator: first, you have quilt installed?02:48
ddecatormicahg: yes02:49
micahgddecator: k, so, you need to find where the .pc directory is first02:49
ddecatormicahg: found it02:49
micahgddecator: I think it's in the top directory in songbird, right?02:50
ddecatormicahg: in the build-area, it's inside the songbird~blah folder02:50
micahgddecator: k, so you need to symlink debian/patches to whereever that is02:51
ddecatormicahg: alright, how do i do that?02:51
micahgln -s /path/to/debian/patches .02:52
micahgprobably ../../debian/patches02:52
ddecatormicahg: ok, done02:54
micahgok, then quilt push -a to try to apply all patches02:54
ddecatorfailed02:55
micahgddecator: what did it tell you?02:55
ddecatormicahg: well first, do i have to execute that in a certain directory?02:56
micahgddecator: yes, where .pc and where you symlinked patches02:56
ddecatormicahg: http://pastebin.ubuntu.com/395937/02:57
micahgddecator: no...not in.pc, but rather in teh directory with .pc02:58
ddecatormicahg: create the symlink in the parent directory too?02:58
micahgddecator: yep02:58
ddecatormicahg: alright, one sec...02:59
ddecatormicahg: http://pastebin.ubuntu.com/395939/03:00
micahgddecator: k, now, quilt push -f03:01
micahgddecator: it creates a .rej file03:01
micahgand you have to apply the patch manually to the file and then refresh the patch03:02
ddecatormicahg: right, it says it needs refresh. how do i manually apply a patch?03:02
micahgddecator: edit the file that's being patched and do what's in the .rej that's still applicable03:03
ddecatormicahg: where should the .rej file be?03:04
micahgin the same directory as the actual file, it tells you when you run quilt push -f03:04
ddecatorah, yup. i'll do that03:04
ddecatormicahg: ok, i think i got it03:09
micahgddecator: good :)03:09
ddecatormicahg: good deal =). so what is the next step?03:09
micahgddecator: once you have the patch in the real file, then quilt refresh03:10
ddecatormicahg: done03:10
micahgddecator: k, so, quilt pop -a to remove, then quilt push -a to see if you were successful03:11
ddecatormicahg: nothing failed =)03:12
micahgddecator: k, then rm your symlinked patches dir, and try to build03:12
micahgdebuild -b03:13
ddecatormicahg: failed =\03:19
micahgddecator: k03:19
micahgwhere?03:19
ddecatormicahg: it got a few Error 2's, but the last one was the debian/rules file03:20
micahgddecator: k, can you pastebin?03:20
ddecatormicahg: how much of it? starting with the errors?03:20
micahgddecator: last 10-15 lines03:21
ddecatormicahg: http://pastebin.ubuntu.com/395946/03:22
micahgddecator: need to see higher03:23
micahgwhere the errors start03:23
ddecatormicahg: that was where they started, but i'll get some extra lines03:23
ddecatormicahg: this is where the "make[#]" started, http://pastebin.ubuntu.com/395947/03:24
ddecatormicahg: well, not started...but that chunk started03:25
micahgddecator: you need the bash/dash patch from xulrunner03:25
ddecatormicahg: i don't see that patch in the patches folder...03:26
micahgddecator: no, it's new03:26
ddecatormicahg: where can i get it?03:26
micahgddecator: http://bazaar.launchpad.net/%7Emozillateam/xulrunner/xulrunner-1.9.2.head/download/micahg%40ubuntu.com-20100122051236-fi7ise29944h7uw1/fixbuildglitch.patch-20100115011725-z4fm1nx1a0kx24m6-1/fix-build-glitch.patch03:26
micahgddecator: you have to modify the path to modules/libpr0n03:27
micahgddecator: replace mozilla with songbird/dependencies/vendor/xulrunner/mozilla/compiled/xulrunner-release/03:27
ddecatormicahg: alright, thanks. i'll get started on that...03:27
micahgddecator: great03:28
ddecatormicahg: alright, modified it and added it to the patches folder03:29
micahgddecator: now add it to series as well03:30
ddecatormicahg: to series?03:30
micahgddecator: debian/patches/series03:30
ddecatormicahg: done03:31
micahgddecator: k, try to build again03:32
ddecatormicahg: with the -b argument again?03:32
micahgddecator: you can try debuild -nc03:32
micahgddecator: which is no clean03:32
ddecatormicahg: failed the same way...03:34
micahgddecator: k, debuild -b03:35
micahgddecator: forgot that patches won't apply like that03:35
ddecatormicahg: i also found a typo in the patch, so i fixed that as well03:35
micahgddecator: typo?03:36
micahgddecator: that's applied on 3 branches03:36
ddecatormicahg: i copy and pasted the path you gave me, but it put an extra "/" in there without me noticing03:36
ddecatormicahg: not the patch itself, the path i changed, no worries =p03:36
micahgddecator: k03:36
ddecatormicahg: that patch failed03:37
micahgddecator: you have the path correct?03:37
ddecatormicahg: let me check03:38
ddecatormicahg: nope, there is no mozilla/compiled/ folder03:39
micahgddecator: pastebin the patch please03:39
ddecatormicahg: http://pastebin.ubuntu.com/395950/03:40
ddecatormicahg: oh, i see -_-03:40
ddecatormicahg: is it supposed to point to the makefile in the xulrunner/mozilla/ folder for songbird?03:41
micahgddecator: no03:41
ddecatormicahg: k03:41
ddecatormicahg: there's a modules folder03:42
ddecatormicahg: got it03:42
micahgddecator: goot03:42
micahggood03:42
ddecatormicahg: hm, still failed...03:44
micahgddecator: can't do any more tonight...03:45
ddecatormicahg: no problem, thanks for the help03:45
micahgddecator: check with me tomorrow sometime...need to finish some $WORK03:46
ddecatormicahg: sounds good. i have some ideas. gl with your work03:46
micahgddecator: thanks03:46
ddecatorYES, got it to apply...04:12
micahgddecator: great :)04:13
ddecatormicahg: best way to learn is to do =)04:13
ddecatormicahg: still won't build, but we're getting somewhere...04:13
micahgddecator: as long as you're in a sandbox ;)04:13
ddecatormicahg: haha, right04:13
ddecatorand now it won't apply...04:19
ddecatorit keeps looking in the wrong place04:20
ddecatorok, there we go...04:23
ddecatori think i missed an s -_-04:23
micahg?04:23
ddecatormicahg: in the path to the file. i copy-pasted it and somewhere an extra letter got added04:24
ddecatorbuild failed again though, hmm04:24
micahgddecator: k04:24
ddecatorwhat the...04:25
ddecatorok, every time i try to build it, it doesn't try to apply the patch in the build-tree directory...04:32
ddecatorwait04:33
ddecatorbah, failed again...04:55
ddecatorC++ internal error?04:57
ddecatormicahg: is there any special variant of gcc-4.4 that i need?04:58
micahgddecator: oh...forgot about that04:58
ddecator;)04:58
micahgI wonder which version of xulrunner that is04:58
ddecatorgood question...04:59
ddecator1.9.0.1804:59
micahgthat's your version?05:00
micahgI meant in songbirf05:00
micahg*songbird05:00
ddecatorthat's the version given in the xulrunner makefile for songbird05:00
micahgdoesn't sound right05:00
ddecatorSB_VENDOR_TARGET = xulrunner05:00
ddecatorSB_VENDOR_TARGET_VERSION = 1.9.0.1805:00
micahgyeah, that's old05:02
micahgk05:02
micahgweird05:02
micahgshould build fine with gcc4.405:02
ddecatorc++: Internal error: Killed (program as)05:03
ddecatorPlease submit a full bug report.05:03
ddecatorSee <file:///usr/share/doc/gcc-4.4/README.Bugs> for instructions.05:03
ddecatorthen a bunch of make[#] errors like before05:04
micahgweird05:04
ddecatorany gcc-4.4 variants i should install and see if it helps?05:05
micahgddecator: no, I'd have to see the error and no time right now, I'd like to go to bed by 1AM :)05:05
ddecatormicahg: fair enough, haha05:06
ddecatorso it always gets close to finishing, but then it searches for 'linux-x86_64' in the 'checkout' folder, but 'linux-x86_64' is in the same folder as 'checkout'...06:14
micahgddecator: might need a patch :)06:16
ddecatormicahg: might, but i'm not sure what i would need to patch...i tried moving the folder into 'checkout', but those folders get created during the build process, so that didn't do anything06:17
micahgyeah, probably a bad makefile, I can try to look tomorrow night06:18
ddecatorsure thing. i'll be up till about 2 so i'll take a look and see if i can find it...06:18
ddecatormicahg: don't worry about this until tomorrow, i just want to put it on here before i forget: http://pastebin.ubuntu.com/395995/06:39
micahgddecator: probably a path in the rules file06:41
ddecatormicahg: thanks, i'll take a look06:41
micahgddecator: line 15306:42
ddecatormicahg: i'm lookin at 163...06:42
micahgddecator: xul-repack target06:43
micahgxul-repack.stamp actually :)06:43
ddecatoroh, my rules will be different because of the sqlite changes i made...06:44
ddecatorthere it is06:44
ddecator...06:45
ddecatormicahg: you sure it isn't in the taglib section? i'm not seeing anything with xul-repack.stamp06:46
micahgddecator: /linux-$(MACHINE)06:47
ddecatormicahg: right, which is where x86_64 is coming from06:47
micahg$(MACHINE)06:47
ddecator...i feel like this should be obvious to me06:48
ddecatorwait06:49
ddecatornope, idk what's wrong with that...06:49
micahgline 170 actually is probably it06:50
micahgddecator: you were right, the taglib section :)06:50
ddecatormicahg: thought so =)06:50
* micahg is tired06:51
ddecatorit creates 'checkout' and 'linux-x86_64' in the same folder, but 'linux-x86_64' should be inside of 'checkout'06:51
micahgddecator: I'd have to see it when I can think more06:52
ddecatormicahg: haha, fair enough, i'm trying to figure out this programming but it's new to me06:52
micahgk, good luck ddecator, night06:52
ddecatormicahg: night06:53
BUGabundo_remote0/08:49
dupondjesomebody wants to check https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/526290 ?11:28
ubottuLaunchpad bug 526290 in thunderbird "Thunderbird 3 hyperlinks broken (3.0.1)" [Undecided,Confirmed]11:28
dupondjeits quite annoying imo11:28
lfaraonewe can't sync packages that depend on iceweasel, right? (we need to merge the changes)13:01
* gnomefreak not sure what packages we have that depend on iceweasel13:02
micahggood morning/afternoon chrisccoulson15:06
chrisccoulsonhey micahg - how are you today?15:06
micahgchrisccoulson: good15:06
chrisccoulsonexcellent :)15:06
micahgchrisccoulson: slangasek approved the uploads last night15:07
chrisccoulsonyeah, that's good!15:07
BUGabundo_remotemicahg: I got a user stat list for SN, but only top 20015:08
BUGabundo_remoteyou are not even close15:08
micahgBUGabundo_remote: heh, ok15:08
BUGabundo_remoteso I can't tell you , where you got placed on Monday15:08
micahgchrisccoulson: can you look at mozilla 550823?15:11
ubottuMozilla bug 550823 in Build Config "cannot find -lmozalloc when building with gcc-4.4" [Normal,New] http://bugzilla.mozilla.org/show_bug.cgi?id=55082315:11
chrisccoulsonyeah, i can take a look at that. it will have to be a bit later on today though15:12
micahgchrisccoulson: ok, also, Thunderbird 2.0.0.24 release is probably today or tomorrow, was asac able to get you upload rights to the security PPA?15:12
chrisccoulsonhe hasn't done. can you upload to that PPA?15:13
chrisccoulsoni've got the packages built, but i just need to finish testing them really15:13
chrisccoulsoni created 4 new virtual machines yesterday for testing each of the stable releases :)15:13
micahgchrisccoulson: no, but I can bug one of the security guys to do it :)15:13
chrisccoulsoncool, thanks15:14
micahgchrisccoulson: nice15:14
micahgchrisccoulson: are the branches ready?  we should also probably prepare Seamonkey...but I have to check if there are security issues (probably same as TB) and get a USN15:15
chrisccoulsonnot yet, i can do that this afternoon though15:15
micahgchrisccoulson: k, let's chat later then, I can help you later tonight if something's left to be done with it15:16
chrisccoulsonthanks :)15:16
micahgchrisccoulson: my guess is this would take priority over fixing the dailies (the bug I showed you before), but your call15:17
chrisccoulsonyeah, that's probably right15:17
ccheneyasac: https://launchpad.net/~ccheney/+archive/ppa/+build/1564014 <- how do i fix this so it builds properly on both amd64 and i386?15:21
ccheneyasac: it seems the symbols change depending on arch15:21
jcastrohey micahg, does this tbird have the messaging indicator support that landed upstream?15:26
micahgjcastro: no, that'll only be in 3.115:26
jcastrook15:26
micahgjcastro: but that's only support, we still need to make the indicator I think15:26
jcastrook15:26
* micahg doesn't know how indicators work yet :/15:27
jcastromicahg: for next open/dev/opportunistic weeks we'll make sure there are indicator sessions of all kinds!15:27
micahgjcastro: excellent...then I can work on one for TB :)15:28
chrisccoulsonmicahg - do you use livehttpheaders?15:40
micahgchrisccoulson: I don't think so15:40
chrisccoulsonit seems quite a popular extension according to popcon, and just wonered if you had any opinion on whether we should keep it15:41
chrisccoulsonwe'd need to update it, as the version in the archive doesn't work with 3.615:41
* micahg checks what it is15:41
micahgchrisccoulson: we should update to 0.16 then...Debian is behind15:42
micahgbdrung_: do you work on updating debian ff extensions?15:43
bdrung_micahg: currently no.15:43
micahgchrisccoulson: it would be useful for web devs, so yes15:43
chrisccoulsonmicahg, thanks. we'll keep that one then, and I'll get it updated15:44
micahgchrisccoulson: also they don't update too frequently ;)15:44
chrisccoulsonthat's good then :)15:44
bdrung_micahg: a list of incopatible extensions would be good15:45
micahgbdrung_: chrisccoulson is working on it :)15:45
chrisccoulsonat some point today, there will be a list of actions at https://wiki.ubuntu.com/DesktopTeam/Specs/Lucid/FirefoxNewSupportModel/extension-list15:46
chrisccoulsonbut i'm just updating that now15:46
bdrung_why are some many extensions on the remove list?15:51
bdrung_why don't we keep the packages that are maintained by http://qa.debian.org/developer.php?login=pkg-mozext-maintainers@lists.alioth.debian.org15:52
chrisccoulsonbdrung_, are debian going to be using the same support model as us for the mozilla stack in the stable releases?15:53
bdrung_chrisccoulson: not in stable, but unstable will probably be up-to-date15:54
chrisccoulsonright, and that's the issue. we don't want to be spending efforts backporting new extensions to every stable ubuntu release each time mozilla releases a new firefox version15:55
BUGabundo_remotewhere's FTA?16:11
BUGabundo_remotei'vent seen him in a while16:11
micahgchrisccoulson: no, not same support model16:12
micahgbdrung_: we're going to be updating Firefox major versions in Stable Releases so we have to minimize the number of packages we have to change when we do that16:13
ftaBUGabundo_remote, beuuuaaahhh16:23
bdrung_micahg: we should keep at least pwdhash - i'll maintain that16:25
micahgbdrung_: k, inlcuding porting if need be to latest xulrunner?16:34
bdrung_micahg: in most cases bumping the version works. otherwise i will ask the author. the extension is small.16:35
micahgbdrung_: k, chrisccoulson did you catch that?16:35
chrisccoulsoni did16:36
chrisccoulsonbut i'm not too comfortable with special-casing some extensions. pwdhash is not particularly popular according to popcon16:37
chrisccoulson(although, i know that's not always a reliable metric)16:37
micahggtg, bbiab16:38
BUGabundo_remoteFirefox-3.7 is already running, but is not responding. To open a new window, you must first close the existing Firefox-3.7 process, or restart your system.17:10
BUGabundo_remoteI can't open FF 3.717:10
BUGabundo_remoteI always get that even if NO instance of ANY FF version is open17:10
BUGabundo_remoteaccording to ps17:10
BUGabundo_remotehi fta. welcome17:10
dupondjesomebody wants to check https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/526290 ?17:29
ubottuLaunchpad bug 526290 in thunderbird "Thunderbird 3 hyperlinks broken" [Undecided,Confirmed]17:29
dupondjeits a quite annoying 'bug', surely for new users it kills usability17:30
BUGabundo_remotenice title17:39
dupondje'Default browser not used to open hyperlinks in thunderbird 3.x'17:41
dupondje:P17:41
micahgbdrung_: congrats, now I have a third person to bug for my uploads :)18:22
=== yofel_ is now known as yofel
micahgmconnor: ping20:03
mconnormicahg: pong20:08
micahgmconnor: can we take the patch from mozilla 551152 since it doesn't affect user experience?20:09
ubottuMozilla bug 551152 in XPCOM "Symlinked components break everything" [Normal,New] http://bugzilla.mozilla.org/show_bug.cgi?id=55115220:09
micahgmconnor: the second patch specifically20:09
mconnormicahg: you want to get bsmedberg to chime in on the fix, I am not qualified to make that call20:12
mconnorand I don't know what that would break20:13
micahgmconnor: because that fixes bug 518422 for us20:13
ubottuLaunchpad bug 518422 in firefox "Firefox does not start with certain addons installed" [High,Triaged] https://launchpad.net/bugs/51842220:13
micahgmconnor: can I just ask him to review in bugzilla or do I need to ask specifically about 3.6?20:15
mconnormicahg: get review on the fix, then ask about backport20:16
micahgmconnor: do we have to wait till it's approved for branch before taking it locally in Ubuntu?20:16
micahgmconnor: should this be PM?20:17
mconnormicahg: I think that in most cases that's how it should work20:17
micahgmconnor: so when it's approved for branch, we can take locally before release?20:20
mconnormicahg: with explicit approval, yes20:21
micahgmconnor: k, then I'll work on getting it approved upstream :), thanks20:21
bdrung_micahg: my namesake became core-dev :P21:42
micahgbdrung_: yes, hence the congratts21:42
bdrung_micahg: you seam to not get the joke21:43
micahgbdrung_: no, over my head I guess...21:44
bdrung_micahg: namesake. anyway. i tried to find a way to be not responsible for sponsoring you ;)21:45
micahgbdrung_: am I really that bad?  you seem to be sponsoring for me a lot lately :)21:46
micahgbdrung_: I hope to get a mozilla packageset soon, so that would minimize sponsoring for me21:46
bdrung_micahg: nope. your patches are ok.21:46
bdrung_micahg: did i sponsor that much for you?21:47
micahgbdrung_: well, 2 things in teh last week I thin21:47
micahgthink21:47
bdrung_micahg: one - they were connected (package a replaces b)21:49
micahgbdrung_: I thought something else too...21:49
* micahg checks uploaded packages21:49
micahgbdrung_: you sponsored xiphos for me too :)21:50
micahgno, it was tuxguitar21:50
sebnerbdrung_: congrats from me too :)21:50
bdrung_thanks21:50
micahgno21:50
micahgthat was cc21:50
bdrung_cc?21:51
micahgchrisccoulson:21:51
micahgoops21:51
chrisccoulsonhi21:51
micahgI geuss not21:52
chrisccoulsonso much work to do :-/22:12
micahgchrisccoulson: indeed22:39
micahgchrisccoulson: so, what's left for TB 2.0.0.24...I'll work on it when I get home22:39
chrisccoulsonit just needs some testing really. i can host the packages somewhere before i go to bed if you like22:39
micahgchrisccoulson: can you propose merges for the branches?22:40
chrisccoulsonyeah, can do. they'll be quite simple merges ;)22:40
micahgchrisccoulson: k, at least until you have commit access to bzr22:41
chrisccoulsonyeah, no problem22:41
micahgchrisccoulson: if you can push 1 to PPA or host the orig.tar.gz somewhere, I can try to get someone to push to security PPA tonight22:41
chrisccoulsoncool, thanks22:42
micahgchrisccoulson: I assume that asac showed you how to generate the tarballs22:42
chrisccoulsonhe hasn't shown me the proper way to do that yet, and i tried to figure that out too. but, for thunderbird 2.0.0.24, i grabbed the release tarball from ftp.mozilla.org, ran remove.binonly.sh on the extraced tarball and re-packed it again22:46
chrisccoulsoni'm not sure how you normally do that, and i don't think you grab release tarballs for thunderbird 3 / firefox 3.6 etc do you?22:46
micahgchrisccoulson: no, that's not the right way :)22:50
chrisccoulsonheh ;)22:50
micahgchrisccoulson: I'm testing on the 2.0 branch to see if it works22:51
micahgfta: are the TB2 tarballs generated like everything else with DEBIAN_TAG?22:52
micahgat least for TB3/FF30/35/3622:53
chrisccoulsonmicahg, this is what asac said on friday:22:54
chrisccoulson<asac> chrisccoulson: so tbird 2 is kinda old ... its basically the only branch where we start with upstream tarballs (or ... can start with upstream tarballs)22:54
chrisccoulson<asac> the current candidate build is: ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2.0.0.24-candidates/build1/22:54
micahgchrisccoulson: k then, he did tell you for that one :)22:54
chrisccoulsonyeah, that was as far as we got22:54
chrisccoulsonso, i repacked the tarballs after running the script in the debian/ folder22:55
chrisccoulsoni wasn't sure if there was an automated way of doing that22:55
micahgchrisccoulson: for TB3/FF30/FF35/FF36, we do ./debian/rules get-orig-source DEBIAN_TAG=THUNDERBIRD_3_0_3_RELEASE=3.0.322:55
chrisccoulsonah. i thought that was how you did it for newer versions (i had a look at mozilla-devscritps on friday to try and figure out how it all works)22:56
micahgchrisccoulson: I've never actually done a TB2 release before, just TB3/FF30/FF35/FF3622:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!