/srv/irclogs.ubuntu.com/2010/03/17/#launchpad-dev.txt

* thumper gets stuck into jobs00:22
james_wwhen I log in to ec2 during postmortem, where can I actually find the LP tree it is testing?00:42
james_wor am I misunderstanding how it works?00:43
thumperjames_w: I expect that you should be able to find it, but I've never tried personally, perhaps mwhudson knows00:44
mwhudsonjames_w: /var/launchpad/test i think00:46
james_wthanks00:46
mwhudsonyeah, that00:46
james_wI have some failures in the initial branch, so I'll squash them now00:47
mwhudsonok cool00:47
thumpermwhudson: quick sanity check00:51
thumpermwhudson: during my investigations I found a pile of stuff still in canonical/launchpad/event00:52
thumpermwhudson: worth making a new pipe to move them to lp.code.event?00:52
thumpermwhudson: or perhaps lp.code.interfaces.event00:53
james_wdammit, failures in pagetests00:55
james_w    - The code import has been updated.00:56
james_w    + There is 1 error.00:56
james_w    + Enter the URL of a foreign VCS branch.00:56
james_wso something (the readonly change?) breaks +edit-import it seems00:56
mwhudsonjames_w: oh that's not so surprising00:57
mwhudsonjames_w: easy to fix though00:57
mwhudsonthumper: err00:57
james_wcare to enlighten me?00:57
mwhudsonwhat's in canonical/launchpad/event ?00:57
thumpermwhudson: interfaces for events00:57
mwhudsonyay two conversations00:57
thumpermwhudson: not a lot to be honest00:57
mwhudsonthumper: oh, lp.code.interfaces.event then i guess00:58
wgrantIf the field is writable, why should it be readonly on the API?00:58
mwhudsonwgrant: crack00:58
mwhudsonof the 'updateFromData' kind00:58
wgrantmwhudson: But the import URL should be editable by some, shouldn't it?00:59
mwhudsonwgrant: yes, but it's not edited by going "import.url = foo"00:59
wgrantOdd.00:59
james_wmwhudson: could we allow certain people to do that over the API?00:59
mwhudsonjames_w: this /should/ all be fixed to work like other objects01:00
mwhudsonbut it's quite a lot of work01:00
james_wright01:00
mwhudson<drevil>millions</drevil> of $units of tech debt01:00
james_wwe can work towards that01:01
mwhudsonjames_w: anyway, to make the edit form work again, you need to edit the EditCodeImportForm schema in lp.code.browser.codeimport01:01
james_wfor now I would like to fix the tests to make my work landable01:01
james_wI've got it open01:03
mwhudsonjames_w: to look like this: http://pastebin.ubuntu.com/396468/01:03
james_wit's fairly opaque to me though01:03
james_waha!01:03
mwhudson(warning: code typed directly into pastebin, probably right though)01:03
james_wthat's what we have tests for01:04
mwhudsonthis is what i thought would break, btw01:05
mwhudsonif nothing else is broken, that's pretty good :)01:05
mwhudsongrar testfix mode grumble01:05
mwhudsonthe testsuite seems to have problems with email at the moment01:05
james_w    KeyError: 'cvs_root' on import01:06
mwhudsonjames_w: oh haha01:06
james_wyah01:06
mwhudsons/IBranch/ICodeImport/ for the first three01:06
james_wyay for familiarity01:06
james_wbeats me spending ages last night working why doctest was giving me syntax errors on01:07
james_wimport = factory.makeCodeImport()01:07
mwhudson:)01:09
wgrantWhat's the db-lp failure?01:11
james_wsame failures with that change01:13
wgrantjames_w: s/read_only/readonly01:13
james_wthanks wgrant01:15
mwhudsonwgrant: some crap involving sending mail and not having an interaction :/01:15
mwhudsonwgrant: http://pastebin.ubuntu.com/396471/01:16
wgrantThat line is too long.01:17
* wgrant tries to read.01:17
mwhudsonwgrant: http://pastebin.ubuntu.com/396472/ better formatted01:17
wgrantAhh much better.01:18
mwhudsonit's in "Failure in test testSimpleRun (lp.soyuz.scripts.tests.test_lpquerydistro.TestLpQueryDistroScript)01:18
mwhudson"01:18
mwhudsonwhich i guess i could try running locally01:18
wgrantThat looks like there's no MTA running.01:18
mwhudsonbut on the whole launchpad tests don't actually send mail through an MTA do they?01:19
wgrantExcept for test-sampledata-setup.txt, they should not.01:20
wgrant(well, it shouldn't either, but it does)01:20
james_wthumper: https://code.edge.launchpad.net/~james-w/launchpad/export-code-import/+merge/21472 updated to pass tests. Seeing as you approved it would you now submit it for me please?01:22
thumperjames_w: I'll take a look01:23
* james_w has https://code.edge.launchpad.net/~james-w/launchpad/register-code-import/+merge/21505 on the go too, any suggestions appreciated01:24
* thumper goes to grab coffee01:24
wgrantjames_w: Why is IHasCodeImports separate from IBranchTarget?01:26
james_wwgrant: good question01:26
james_wwgrant: one good reason may be that code imports only support products so far01:27
mwhudsonbecause for better or worse we don't support code imports for !product01:27
james_wwgrant: a less good reason is that I didn't know about IBranchTarget (though I now remember you mentioning it yesterday)01:27
wgrantWhy does a code import have any idea what it's on?01:27
mwhudsongood question!01:27
james_wI want to fix that in a later branch, but perhaps it should be done earlier01:27
mwhudsoni really hope nothing uses ICodeImport['product']01:27
* james_w sends a branch nuking all those things through ec2 to get an idea of the fallout01:28
james_wthe only thing that might get in the way is ICodeImport['series'], as we can't really store that information on IBranch as far as I know01:30
mwhudsonah right01:31
wgrantIs that information used for anything?01:31
mwhudsoni doubt anything uses that either01:31
mwhudsoni'd certainly entirely forgotten about it01:31
wgrantIt's potentially useful except not really.01:31
wgrantI've never seen any hint that it's used.01:31
mwhudsonit was probably used during the transition from the old to new system01:31
james_wI'm nuking owner, product and series so that we can get an idea of where they are used01:33
mwhudsonjames_w: oh, i was going to do that, but if you're on it already...01:34
james_wassuming that anything that uses .owner should use .branch.owner, .product should be .branch.{product,sourcepackage}01:34
james_wI believe .assignee is different?01:34
mwhudsonassignee is just not used01:34
mwhudsonremove it01:34
james_wok, bye bye01:34
wgrantWhere does ICodeImport['series'] come from? I can't see it on the table.01:37
* wgrant checks the code.01:37
wgrantOh.01:37
wgrantIt searches for the ProductSeries with the branch selected.01:38
james_woh, so it only applies to focus branches?01:39
wgrantYes.01:39
wgrantSo it's not critical.01:40
wgrantSo you could always leave it alone and it will just be None, and not break anything.01:40
wgrantBut better to remove it entirely.01:40
mwhudsonyes01:41
mwhudsonif it'01:41
mwhudsons not used, kill it01:41
james_werror: (4, 'Interrupted system call')02:10
james_woh, that's a great reason to error out from an ec2 test02:10
james_wtests finally running02:31
james_wI'll call it a day02:32
james_wthanks for your help team02:32
lifelessjames_w: did you get the chance to mail me about bzr-builder?02:32
mwhudsonjames_w: thanks for working on this!02:36
james_wlifeless: no, slipped my mind, sorry, pls to be mailing me then I will remember03:18
lifelessk03:18
mwhudsonthumper: what does 'reject' mean for the puller?03:20
thumperumm03:21
thumperwhat?03:21
mwhudsonthumper: http://dev.launchpad.net/Code/RemoveHostedArea?action=diff&rev1=5&rev2=603:21
thumpermwhudson: more context?03:21
mwhudsonsorry, not a very clear question03:21
thumpermwhudson: hmm, can we not catch this while the user is pushing?03:21
mwhudsoni guess we need to be more careful about the way say codebrowse opens the branch03:22
mwhudsonthumper: not really, certainly not until we turn the vfs off03:22
thumpermwhudson: oh yeah03:22
thumperhmm...03:22
wgrantBranches aren't accessible over HTTPS at all, are they?03:23
thumperwgrant: no03:24
wgrantAh, good.03:24
thumperat least I hope not03:24
thumperwgrant: actually03:24
thumperkinda03:24
wgrantEep.03:24
thumperwgrant: from loggerhead anyway03:24
thumperwhat do you mean accessible?03:25
thumperbranchable?03:25
wgrantbut that hopefully won't serve the files directly.03:25
wgrantSince this will mean that bazaar.launchpad.net contains arbitrary user-generated files.03:25
lifelessit will serve the content03:25
wgrantAnd if that was HTTPS, then it could do horrible untold nasty things to the webapp and its cookies.03:25
mwhudsonright03:25
lifelessvia the bzr smart protocol, not as files on disk, AIUI03:25
mwhudsonwell03:26
mwhudsonloggerhead _can_ serve branches, both as dumb and smart http03:26
lifelessanyhow, personally I'd keep the mirrored area and scale it out.03:26
mwhudsonbut it doesn't on launchpad03:26
mwhudsonargh03:27
thumpermwhudson: yes?03:27
mwhudsongiven that it would be nice to serve bits of launchpad over http rather than https...03:28
mwhudsonlifeless: what do you mean?03:28
wgrantmwhudson: Don't worry, you would not be the first to be serving arbitrary files under launchpad.net.03:28
wgrantIt already happens, and worse.03:28
thumpermwhudson: the apache rewrite rules make anything not in .bzr go to loggerhead03:28
thumpermwhudson: although if someone put some random file in .bzr dir, it would be served03:29
mwhudsonthumper: i'm getting a bit worried by the fact that if we eliminate the mirrored area, people will be able to get launchpad to serve arbitrary content over http03:29
thumperwgrant: yes?03:29
thumpermwhudson: yeah...03:29
wgranteg. bug #42029203:29
mwhudsonthumper: yes, but what if people put crap in .bzr ?03:29
thumpermwhudson: exactly03:29
thumperhmm...03:29
mwhudsoncurrently what saves us here is the puller03:29
thumperI guess it comes down to "do we care enough?"03:30
mwhudsonwgrant: heh, as soon as you mentioned the number, i thought "what about ..." and guessed the outcome03:31
stubCan we add a 'bzr tidy' or similar that removes crap from .bzr directories that shouldn't be there, or is that too dangerous as users could be using plugins that store arbitrary stuff in there?03:31
mwhudsonstub: sounds difficult to get right to me03:31
stubI guess we could, as bzr tidy would just remove stuff that the mirror process skips already.03:31
mwhudsoni think plugins do store stuff03:31
thumpermwhudson: there is a bzr concept right now of extra baggage (terminology may be wrong)03:32
thumpermwhudson: where push also pushes plugin extras03:32
stubIs the goal of removing the mirror step to remove an unwanted copy, or to remove the time between upload and published?03:33
thumperstub: to save space03:33
mwhudsonclearly what we need is a file system with cow snapshots at the directory level, you could make a clone of the directory on write access, then pull from the snapshot to the original then delete the snapshot03:33
* mwhudson falls out of the blue sky03:33
mwhudsonthumper: very much at the concept stage though, right?03:34
stubSo we could mirror, then replace the original with the mirrored copy03:34
stubWhich should just remove anything that shouldn't be there03:34
thumperstub: that sounds relatively sane03:35
wgrantmwhudson: Could you abuse stacking to do something like that?03:35
mwhudsoni guess that would reduce the time we're vulnerable for03:35
mwhudsonwgrant: hnngh03:35
mwhudsonwgrant: maybe03:36
mwhudsonyou could probably do it at the transport level too i guess03:36
mwhudsonhave writes go to one area, reads fall back to another03:36
wgrantsay, a fallback repository?03:36
mwhudsonall sounds a bit crazy though03:36
mwhudsonwgrant: i think the problem with doing at the stacking level is that you don't know whether a branch is going to be written to when its opened03:37
wgrantTrue.03:37
mwhudsonso you could present every branch over a writable transport as being stacked on the real branch, but that doesn't sound very sane03:38
stubOverwriting the original branch with the mirrored copy also gives us an opportunity for other fun, like pushing revisions into the stacking target (saving two thirds of the disk space used to store Launchpad code perhaps).03:39
wgrantTrue.03:39
stubHmm... 3/4... dev branch, devel, stable, db-devel is four copies of each revision03:40
wgrantstub: You can save just about all of the space except for whatever is in db-stable.03:41
stub(for non private branches with a public stacking root)03:41
wgrantsince almost every branch will end up in db-stable, so their branch data is entirely redundant.03:41
stubYes.03:41
stubMost projects you would only save 50% though (dev branch -> trunk)03:42
mwhudsonyou could also do that in a garbo type job03:43
mwhudsonprobably fairly slow to do it for 200k branches though03:43
wgrantmwhudson: But most will end up with no revs after the first run, so they needn't be touched.03:43
stubWell... mirroring would become non-time critical so yes it could be done in batches rather than on-push03:43
stub(on-push = stick branch in queue, garbo == mirror and pack stuff from the queue)03:44
mwhudsonstub: i meant just anyway, independent of changing how mirroring worked03:44
stubok03:44
mwhudsonwgrant: point03:44
mwhudsonmaybe i should just not worry too much about the arbitrary hosting thing and assume that sooner or later we'll be able to disable vfs-level access to branches03:48
wgrantis that a valid assumption?03:49
wgrantHasn't it been happening reasonably soon for a long time now?03:49
mwhudsoni don't know, but it's not /really/ a risk as long as the cookie is marked secure03:49
wgrantRight.03:49
mwhudsonand then write a branch opener that's suitably paranoid about stacking and so on and have everything use this03:53
mwhudson(this will be easier once the hosted area/mirrored area distinction has gone away i guess)03:54
lifelessmwhudson: I mean simply that I'd keep the separation between 'mirrored and anything goes' and 'not mirrored owners only'04:05
lifelessI think its a nice data cleansing step04:06
lifelessand because the mirrored area doesn't need to worry about stuck clients or anything, its arguably easier to scale/mirror/replicate04:06
mwhudsonlifeless: that does seem to imply using twice as much disk as we in some sense need though04:07
lifelessmwhudson: we can probably save that several times over by doing a gc on stacked branches, encouraging deletes of merged branches, ...04:08
wgrantlifeless: How much data is stored in a stacked branch with no revs of its own?04:09
lifelessmwhudson: I mean, look at pg - we use several times the disk we need to there, as well :)04:10
wgrantDeleting branches is bad.04:10
mwhudsonlifeless: we use considerable more disk for branches than for postgres, i think04:10
mwhudsonnot as much as the librarian though04:10
lifelesswgrant: it depends; a stacked branch that has been merged to trunk has all the data ever written to it still04:10
wgrantlifeless: I mean after GC.04:10
wgrantIf that exists yet.04:10
lifelesswgrant: deletion is a valid thing for users to do to their own data04:10
wgrantlifeless: But it deletes MPs and invalidates recipes and blah blah, so it would be really nice to minimise it.04:11
mwhudsondeleting implies deleting the merge proposal which is a bit lame04:11
lifelesswgrant: oh, about 800 bytes or so, butprobably 25 allocation units04:11
lifelesswgrant: uhm, I *want* to delete stuff I'm done with. Its cognitive overhead I no longer care about.04:11
wgrantlifeless: Ew.04:11
lifelesswgrant: I'd like to make deletion easier, not harder.04:12
wgrantWhy do you want to?04:12
wgrantwhat's wrong if they're hidden, as they are now?04:12
lifelesswgrant: because it has no value anymore. The history is in bzr04:12
wgrantKeeping MP history is useful.04:12
lifelesswgrant: sometimes. Its not an absolute.04:12
lifelesswgrant: 'trivial fix: doit' is not valuable historical data.04:13
lifelesswgrant: big debate about the right way, which noone ever looks at, is also not valuable historical data.04:13
wgrantlifeless: It also doesn't consume a significant amount of space.04:14
lifeless*if* someone looks at it, its a different matter04:14
wgrantAnd if we delete it, it can never be looked at.04:14
lifelesswgrant: nonzero cost, nonzero benefits. You can do the math.04:14
wgrantShould we delete bugs too?04:14
lifelessanyhow, gc doesn't exist yet. It should be able to zerg stuff back to nearly empty in principle. for merged branches.04:14
wgrantRight.04:15
lifelesswgrant: there are many I'd like to, yes.04:15
lifelessthe name 'bubba' is floating in my consciousness right now04:15
wgrantHeh.04:15
stubOoh... its about to bucket down on the protestors outside.04:32
* stub goes to switch on the TV04:33
mwhudsonstub: the current government seems to have been in charge for quite a while this time04:41
mwhudsonunless i've missed a revolution or two04:42
spmmwhudson: blink and you miss 'em....04:42
stubI've lost track04:42
wgrantCan I do something like foo[0] in TALES without resorting to python: ?04:45
mwhudsonwgrant: no04:45
wgrant:(04:46
mwhudsonugh, tests are failing again in buildbot04:46
wgrantSame one?04:46
mwhudsonbasically yeah04:47
wgrantMine's the only untested rev, isn't it?04:47
wgrantBut it doesn't look at all relevant.04:47
mwhudsonwgrant: not testing any of yours in this build04:47
mwhudson10530-1053204:47
wgrantThe db-lp failure a few hours ago had me in the blamelist. Is this something else?04:47
wgrantAh.04:47
mwhudsonthis is the other builder04:48
mwhudsoni guess it's worth looking to see what these tests do04:49
mwhudsonand, wow, i hadn't realised how much i used / to start a search in ff04:49
wgrantDoesn't work in Chromium?04:49
mwhudsonnope04:50
StevenKIck04:50
lifelessctrl-F04:52
lifelessbreaks my fingers all day atm04:52
* StevenK hasn't found a compelling reason to switch04:55
lifelessit is faster04:55
lifelessmore memory hungry though04:55
wgrantAnd uses ugly widgets.04:56
lifelessby faster, I mean lp bug pages don't feel like torture04:56
mwhudsonStevenK: firefox started segfaulting continuously for me, i didn't want to switch04:56
mwhudsonit seems mostly ok04:56
wgrantlifeless: Surely you jest.04:56
mwhudsonit handles multiple windows in a rather strange way04:56
lifelesswgrant: no, I don't. The js is a huge component of bug page load times.04:57
lifelessand chromium is a lot fast at js04:57
wgrantAh, yes, particularly for multi-tasked bugs.04:57
lifelessI haven't yet done my 'open 20 tabs by ctrl-clicking on a search' thing in chromium yet04:57
lifelessbut on ff that used to take 4 or 5 minutes04:57
StevenKlifeless: Right, but then I hear people complain about things that I do constantly in a browser and I push looking at chromium further down the list04:57
stubmwhudson, wgrant: I think the db-devel and current devel failures are spurious05:03
mwhudsonstub: hmm05:07
mwhudsonstub: they're intermittent, and i suspect not directly related to the test cases that are failing05:07
mwhudsonstub: but they've started happening every other run for the last week, so _something_ has changed05:08
mwhudsonit's annoying because i have some kind of memory of looking at a checkin and going "ooh, i wonder if that's a good idea" in this sort of area05:09
mwhudsonand now i can't find it :(05:09
stubmwhudson: They seem Librarian related. The only change I could think of might have been BjornT's persistent-resources change to the test suite, making it possible to keep the Librarian and memcached running between test runs.05:12
mwhudsonstub: it's email related, really05:13
mwhudsonthe librarian is just being a canary05:13
stubOther branches were failing with Librarian issues anyway05:14
stubIn non-email sections05:14
stubLooks to me that it is failing because the logging system is trying to upload the traceback into the Librarian and this is failing.05:15
stubSo we get a different error message than expected05:16
mwhudsonthe current lp builder is definitely failing in an email related way05:18
* mwhudson grinds to a halt05:41
spmnight mwhudson05:43
mwhudsonfor the test failure, i reckon some test is putting things in the mail queue and then sometimes the mails are handled before that test process exits05:57
mwhudsonand sometimes not05:57
mwhudsonand then the next test to activate the queue processing thread blows up05:58
mwhudsonmaybe?05:58
mwhudsonit'05:58
mwhudsons a guess anyway05:58
adeuringgood morning08:33
wgrantDo I need a UI review for https://code.edge.launchpad.net/~wgrant/launchpad/show-package-sets-in-queue/+merge/21521? It's only used by a few people, and I have +1s from two of them.09:06
mrevellHowdy09:12
jmljelmer, take a look at https://code.edge.launchpad.net/~jml/launchpad/new-zope-testing/+merge/2153909:16
jmlmrevell, hello09:16
jmlmrevell, I'm in Worcestershire!09:16
jelmerhey mrevell09:16
jelmerjml: looking09:16
mrevelljml, Welcome to everything that is great about England.09:16
mrevell:)09:16
mrevellhey jelmer09:16
mrevellHow long are you chaps sprinting?09:17
jmlmrevell, just until Friday09:17
jelmerjml: yuck, hardcoded subunit version in buildout.cfg ?09:18
jmljelmer, I guess. I mean, we have hardcoded versions in versions.cfg09:20
jelmerjml: yeah, but it'd be nice to only have a hardcoded version in one place so that it's easier to update09:21
jmljelmer, I agree. I don't really know how to do that though.09:21
jmljelmer, anyway, did I end up deleting your code?09:22
jelmerjml: would it be possible to just use a checkout of a bzr tag rather than downloading the tarball?09:22
jmljelmer, not w/ the cmmi recipe09:22
jelmerjml: yep - around line 60 in the diff09:22
jmljelmer, but it's hard to tell. the docs might be incomplete because J1m only cared about writing tests.09:23
jmljelmer, do you want me to add your bit back?09:23
jelmerjml: If possible :-) But I guess it'd have to go into zope.testing now?09:24
jmljelmer, I _think_ it's equivalent to "if os.getenv("SUBUNIT_FORMATTER"): options.append('--subunit')"09:25
jmljelmer, the idea is that if the env var is defined, we do subunit, right?09:25
jelmerjml: Yep, and we pipe our subunit output into the command set in that variable09:26
jmljelmer, I'll have a look09:27
jml:\09:28
allenapjml: Building new-zope-testing fails for me, after merging into a fresh devel branch. Specifically, it breaks during the cmmi bit for subunit.09:33
jmlallenap, can you paste the error please?09:34
allenapjml: I'm having trouble replicating it.09:42
jmlallenap, so it works now?09:47
allenapjml: Not sure. I was being a muppet when trying to replicate. Having another go now.09:47
allenapjml: http://paste.ubuntu.com/396612/09:48
jmlallenap, I guess you don't have CHECK09:48
jmlallenap, I wonder if we can disable that09:48
allenapjml: Ah, "unit test framework for C"?09:50
jmlallenap, yeh09:50
jmlallenap, I guess that means I'd need to add that to deps or something09:50
allenapjml: Yes, guess so. I'm seeing if I'm missing any other deps now.09:53
pooliehello jml09:53
jmlpoolie, hi09:53
allenapjml: cppunit is missing too.09:57
deryckMorning, all.09:59
jmlallenap, I see. Is that it?10:04
jmlderyck, good morning10:04
jmlmrevell, hi10:04
mrevellhey jml10:04
allenapjml: Yep, it's building fine now (for me, anyway).10:04
allenapjml: Yes, built fine, and subunit.__file__ eventually resolves to parts/subunit/lib/python2.5/site-packages/subunit/__init__.py.10:07
allenapjml: In new-zope-testing, --save-list is gone. Do you know of a good alternative? `bin/test --list` does not produce a reusable list (it needs a fair bit of munging).10:39
jmlallenap, bin/test --subunit --list-tests | subunit-ls10:40
jmlbigjools, what do you think about me moving a bunch of stuff to lp.poppy?10:49
allenapjml: Oh, that's beautiful, thanks :)11:02
jmlI wonder what I need to do to get the check & cppunit stuff11:05
allenapjml: maxb seems to be the expert on that.11:07
allenapsoyuz: Have you seen the test failures in buildbot? They don't seem to be transient, and they're in soyuz.11:08
* bigjools looks11:08
wgrantIs this the same as the db-lp failure ~10h ago?11:08
allenapwgrant: Possibly. testMissingAction and testSimpleRun?11:09
bigjoolsthis is the librarian issue again11:10
wgrantallenap: Yeah. mwhudson was having a look at that.11:10
wgrantit is probably not actually a Soyuz bug.11:10
allenapbigjools, wgrant: Okay, sorry for the noise.11:10
stubthe current devel one is a weird traceback because librarian_client.remoteAddFile(...) is raising an AttributeError, but the exception handling code that is trying to stuff the traceback into the Librarian only deals with an UploadError.11:12
stuboh... hmm... there is a catchall there...11:13
stubThat code should die anyway - I don't think we have a valid use case for stuffing exceptions in the Librarian any more. OOPS reports exist now for a start.11:16
wgrantIt's handy for Soyuz.11:17
wgrantSince the upload processor sucks at reporting errors.11:17
wgrantSometimes you have to look at the traceback.11:17
maxballenap: hmm?11:19
allenapmaxb: jml might need to add "check" and "libcppunit-dev" to lp-dev-dependencies. You seem to be an ace at packaging :) That's all.11:20
maxbwow, C code in launchpad? :-)11:21
jmlallenap, no. C code in our dependencies11:22
jmlmaxb, allenap, maybe I should just manage subunit as a package dependency11:22
maxbworks for me, but I have a somewhat jaded view of buildout/setuptools/distribute :-)11:23
stubMaybe the librarian is a red herring there in the failure... the test seems to be expecting a single ERROR line but is getting two ERROR's (plus extra traceback cruft from the handler)11:24
wgrantWhen did this start happening?11:32
jmlmaxb, how would I add subunit as a dependency?11:43
* jml has nfi11:44
maxbFirst, you run 'rmadison python-subunit' and decide if the versions packaged across hardy-lucid are sufficient for your needs11:44
maxbThen you'd backport packages as needed11:46
maxband lastly depend on it in launchpad(-developer)-dependencies11:46
jmlmaxb, ok, thanks.11:48
jmlmaxb, so I need to backport to hardy :\11:49
jmlmaxb, it's just "subunit" fwiw.11:49
jmlwhich means I need to do more exploratory work11:49
jmlmaking changes to Launchpad is so frikking hard :(11:50
wgrantleonardr: Why can't the apport fix go into lucid as well?11:54
leonardrwgrant: i don't know anything about the apport fix, so i just preserved what was written about it earlier11:55
wgrantAh.11:57
leonardrwgrant: looking at bug 538097, i don't even thing the apport developers have been told they need to make a change11:58
mupBug #538097: +storeblob fails with "500 Internal server error" on production (works on edge) <apport-collected> <oops> <Launchpad Foundations:Fix Released by gary> <apport (Ubuntu):Invalid> <https://launchpad.net/bugs/538097>11:58
wgrantIt seems like a one line fix in apport now would be quite a bit better than 5 years of hack in LP.11:58
leonardrall right, i'm filing a bug against apport11:59
maxbjml: Hmm. subunit depends on debhelper >= 7.2.9 for the dh --without option12:00
maxbSome amount of packaging faff would be required. Not really all that hard, though12:00
=== matsubara-afk is now known as matsubara
jmljelmer, from canonical.launchpad.sqlbase import ZopelessTransactionManager12:01
jmljelmer, and then pass ZTM as txn12:01
jmlmaxb, ok cool.12:02
jmlmaxb, it will all be new ground for me anyway12:03
jmljelmer, from canonical.database.sqlbase import ZopelessTransactionManager, sorry12:03
intellectronicai have a problem logging in in my dev environment after updating. when i try to log in i get http://pastebin.ubuntu.com/396651/12:03
intellectronicaDiscoveryFailure: Error fetching XRDS document: <urlopen error (-5, 'No address associated with hostname')>12:03
intellectronicaanyone seen that, knows what this is about?12:03
wgrantintellectronica: Add testopenid.dev to /etc/hosts.12:04
maxbintellectronica: Have you got the new testopenid.dev vhost.....yes12:04
intellectronicawgrant, maxb: cheers!12:04
leonardrwgrant: bug 54021212:07
mupBug #540212: Send a Referer header when making requests to Launchpad <Apport:New> <https://launchpad.net/bugs/540212>12:07
wgrantleonardr: Thanks.12:09
jmloh look12:14
jmlthere's a thing called lucilleconfig12:14
wgrantHeh heh heh.12:15
wgrantTwo things, even.12:16
wgrantOne of which seems to be redundant.12:16
jml:(12:19
jmlbigjools, want to review https://code.edge.launchpad.net/~jml/launchpad/lp-poppy/+merge/21551 ?12:19
wgrant(DistroSeries.lucilleconfig appears to just list components, which would appear to also be the purpose fulfilled by ComponentSelection)12:19
bigjoolslucilleconfig is an abomination12:28
wgrantPfft, who needs a config in the config file.12:28
* wgrant wonders about lp.archivepublisher.library, which has been XXXed for removal for nearly four years, and has just about not changed since the start of 2005.12:31
stubWe should finally kill off ZopelessTransactionManager...12:54
=== Ursinha_ is now known as Ursinha
=== mrevell is now known as mrevell-lunch
kfogelUrsinha: wow, I like this new QA process better14:05
Ursinhakfogel: cool! what do you like best?14:06
Ursinhakfogel: and what would you change, of course -- feedback is gold :)14:07
kfogelUrsinha: so far nothing I would change.  I just like knowing that what I do is being captured by the system; also, knowing that there's an infallible way to do searches is great.  It's also interesting that we're organized by bug rather than by particular merge/commit now.14:07
Ursinhakfogel: to be honest I don't trust launchpad searches14:09
kfogelUrsinha: ?14:09
Ursinhakfogel: and I mean using the UI14:09
Ursinhakfogel: because there are default options that you may have no idea launchpad is using14:10
Ursinhayou can't even know what you were searching when in the results page14:10
Ursinha(I've filed a bug for that a while ago)14:10
kfogelUrsinha: oh yeah, that's a big one14:11
Ursinhakfogel: but it's cool to be able to do that using the api14:13
kfogelUrsinha: <3 lp APIs14:20
james_wcould someone give me some pointers towards writing a test for https://code.edge.launchpad.net/~james-w/launchpad/package-merge-proposal-permissions/+merge/21561 please?14:47
leonardrjames_w14:51
leonardrthe pagetests have different browser objects for differently-permissioned users14:51
leonardryou could use two of them to show that some users can carry out an action and some can't14:51
leonardri can't be more specific than that, but that's the general idea14:52
james_wand where would I find those tests?14:52
=== mrevell-lunch is now known as mrevell
leonardrjames_w: i think the tests closest to what you want are in lib/lp/code/stories/14:59
james_wok14:59
leonardrrockstar or someone might know which test you should add to14:59
james_wI've found some permission tests in lp.code.tests.test_branch14:59
james_wI'm tempted to do a parallel lp.code.tests.test_mergeproposal15:00
james_wbranchmergeproposal15:00
leonardrjames_w: yes, if you can do it, it would be better to test the permissions directly in a unit test15:00
james_wgreat15:00
bacreviewers meeting starting in #launchpad-meeting15:02
=== salgado is now known as salgado-lunch
=== beuno is now known as beuno-lunch
james_ware they any docs on what goes on Forms?16:49
james_wI need to provide a Product picker widget16:50
james_wthere's https://dev.launchpad.net/LaunchpadFormView, but it doesn't talk about the schema16:50
=== beuno-lunch is now known as beuno
=== matsubara is now known as matsubara-lunch
=== matsubara-lunch is now known as matsubara
=== gary_poster is now known as gary-lunch
jmljames_w, no, there aren't documents18:10
jmljames_w, or if there are, it's perhaps best to pretend there aren't.18:10
jmljames_w, the standard way of doing this sort of thing is to find some other code that does something close to what you want to do.18:11
bigjoolsjames_w: lib/canonical/launchpad/doc/launchpadform.txt18:12
bigjoolsjml hates doctests ;)18:12
=== bjf is now known as bjf-afk
=== leonardr is now known as leonardr-lunch
james_wwow18:54
james_wdeleting all the cruft from ICodeImport only gives a single failing test18:55
marsjames_w, you should get massive karma for that :)19:00
jmlI think thumper joked about giving extra karma for lines removed19:01
marsI think salgado would win19:02
jmlat least for today19:02
mwhudsonjames_w: yay19:03
mwhudsonjames_w: want a review for that branch?19:04
james_wwell, I assume we should fix the failing test first :-)19:04
mwhudsoni guess19:05
james_wplus, I can't actually kill owner without db modifications19:05
mwhudsonwhich test is it out of curiosity?19:05
mwhudsonright19:05
james_wand presumably assignee19:05
james_wpagetest for creating new code imports19:05
mwhudsonyeah, but you can just leave them lurking in the db19:05
james_wmy hacksaw job to remove the reference to product was a little too rash19:05
james_wthey have a non-NULL constraint19:06
james_wand if anyone can decode the question on https://code.edge.launchpad.net/~james-w/launchpad/export-code-import/+merge/21472 for me I would appreciate it19:14
james_w"Do we know if the security wrapper were properly defined for the exported field?"19:14
=== gary-lunch is now known as gary_poster
=== leonardr-lunch is now known as leonardr
james_wmwhudson: https://code.edge.launchpad.net/~james-w/launchpad/nuke-code-import-warts/+merge/21586 if you would19:37
james_woh, hang on, I need to set the prerequisite branch19:37
mwhudsoni was about to say19:38
=== bjf-afk is now known as bjf
james_wmwhudson: https://code.edge.launchpad.net/~james-w/launchpad/nuke-code-import-warts/+merge/21587 should be better19:41
thumperhere's a reminder that I'm not in this morning20:00
thumperjames_w: you can't just make the code import status writable20:00
thumperjames_w: unfortunately it doesn't work like that :(20:00
thumperjames_w: mwhudson may be able to shed some light on it20:01
* thumper off to the museum20:01
james_wbut it has readonly=True?20:02
mwhudsonjames_w: ignore thumper :)20:02
james_wok :-)20:02
mwhudsonjames_w: the question about "<james_w> "Do we know if the security wrapper were properly defined for the exported field?"" isn't relevant now its all readonly20:03
james_wok20:03
EdwinGrubbsmars: ping20:08
marshi EdwinGrubbs20:09
EdwinGrubbsmars: is the Makefile supposed to be smart enough to run jsbuild when one of the files is modified? Actually, it may be just bin/test that does not update it automatically?20:10
EdwinGrubbsmars: does base-layout-macros.pt still play any role in what gets combined by jsbuild?20:10
marsEdwinGrubbs, I think base-layout-macros does20:13
marsIt is scrapped for the YUI dependencies20:13
marsEdwinGrubbs, I don't know about jsbuild.  It was supposed to, but last I saw it didn't.  That was one of those "we should let make do the work" things IIRC.20:14
EdwinGrubbsmars: does jsbuild scrape base-layout-macros for the dependencies? I don't see any mention of base-layout-macros in the Makefile.20:15
marslooking, it calls a different script to scrape the template20:16
marsEdwinGrubbs, utilities/yui-deps.py20:17
EdwinGrubbsmars: just to confirm, nobody should be loading js files inside any other .pt file besides base-layout-macros?20:17
EdwinGrubbsmars: hmmm, when I run yui-deps by hand, it doesn't list any of the files from lib/canonical/launchpad/javascript.20:20
marsEdwinGrubbs, it should not list any files in lp/javascript.  I think those are handled elsewhere.20:30
marsEdwinGrubbs, it is OK to list per-page javascript files, but the support for that is shaky right now.  Whatever you need will not be included in the rollup.20:31
marsI guess it is OK for the purpose though.20:32
marsThe rollup is site-wide.   The per-page JavaScript is exactly that: files that are only needed by the given page.20:32
=== EdwinGrubbs is now known as Edwin-afk
=== matsubara is now known as matsubara-afk
=== bjf is now known as bjf-afk
=== salgado is now known as salgado-afk
=== Edwin-afk is now known as EdwinGrubbs
mwhudsonlunchtime!23:49

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!