| === StevenK changed the topic of #launchpad-reviews to: on call: - || reviewing: -|| queue: [wgrant,noodles775,wgrant,james_w(package-merge-proposal-permissions),StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jelmer changed the topic of #launchpad-reviews to: on call: - || reviewing: -|| queue: [wgrant,noodles775,wgrant,james_w(package-merge-proposal-permissions),StevenK,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara-afk is now known as matsubara | ||
| === jtv is now known as jtv-afk | ||
| === jelmer changed the topic of #launchpad-reviews to: [wgrant,noodles775,wgrant,james_w(package-merge-proposal-permissions),StevenK,jelmer,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | sinzui: thanks for your review. for some reason i didn't get a copy via email so i just now saw it. bothersome. | 14:16 |
|---|---|---|
| sinzui | bac: I used the UI for my review. | 14:17 |
| * sinzui checks his own mail | 14:17 | |
| bac | sinzui: but an email still should've been sent | 14:17 |
| sinzui | yes, and I did get a copy of my review | 14:18 |
| adiroiban | EdwinGrubbs: when you have some time, can you please review the latest changes from here https://code.edge.launchpad.net/~adiroiban/launchpad/bug-540105/+merge/21552 ? Thanks! | 14:51 |
| EdwinGrubbs | ok | 14:52 |
| rockstar | Holy crap, is that seriously the queue? | 14:56 |
| === matsubara is now known as matsubara-lunch | ||
| === rockstar changed the topic of #launchpad-reviews to: rockstar are reviewin' - wgrant - [noodles775,wgrant,james_w(package-merge-proposal-permissions),StevenK,jelmer,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| rockstar | james_w, I know what's going wrong with your ec2... I figured it out last night. | 15:11 |
| james_w | ORLY? | 15:11 |
| rockstar | james_w, basically, I was running it with my personal key credentials which kill all instances after two hours. I should be using my Canonical credentials. | 15:11 |
| james_w | ah | 15:11 |
| rockstar | Was a backup restore issue... Running new ec2 instances of a few things now, one of which is yours. | 15:12 |
| james_w | thanks | 15:13 |
| salgado | rockstar, any chance I can jump the queue with my one-liner: https://code.launchpad.net/~salgado/launchpad/bug-540697/+merge/21648 ? | 15:28 |
| === salgado is now known as salgado-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| === leonardr is now known as leonardr-lunch | ||
| === salgado-lunch is now known as salgado | ||
| === gary_poster is now known as gary-lunch | ||
| salgado | thanks for the review, rockstar! | 17:06 |
| rockstar | salgado, no problem. | 17:07 |
| noodles775 | Hey rockstar, if/when you've time, the branch referenced in the queue is this one: https://code.edge.launchpad.net/~michael.nelson/launchpad/529926-partner-override-to-main/+merge/21329 | 17:11 |
| rockstar | noodles775, yeah, I've just been looking through +activereviews and am working through them. | 17:12 |
| rockstar | noodles775, did you not take a shift at reviewing today? | 17:12 |
| noodles775 | rockstar: no, soyuz team is sprinting this week. | 17:21 |
| noodles775 | rockstar: so I've just been doing swaps :) | 17:22 |
| rockstar | noodles775, okay, that makes sense then. Was wondering why the queue was so monstrous. :) | 17:22 |
| === leonardr-lunch is now known as leonardr | ||
| === gary-lunch is now known as gary_poster | ||
| === rockstar changed the topic of #launchpad-reviews to: rockstar are reviewin' - noodles775 - [wgrant,james_w(package-merge-proposal-permissions),StevenK,jelmer,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === rockstar changed the topic of #launchpad-reviews to: rockstar are reviewin' - james_w - [StevenK,jelmer,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| rockstar | james_w, ping | 18:41 |
| james_w | hi rockstar | 18:42 |
| rockstar | james_w, where's your mp? | 18:42 |
| james_w | https://code.edge.launchpad.net/~james-w/launchpad/package-merge-proposal-permissions | 18:43 |
| rockstar | james_w, ah, jml has already reviewed it. | 18:44 |
| === rockstar changed the topic of #launchpad-reviews to: rockstar are reviewin' - LUNCHING - [StevenK,jelmer,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| james_w | rockstar: but not with my fixes | 18:45 |
| jml | james_w, sorry, I'll get to it. | 18:46 |
| james_w | thanks jml | 18:46 |
| james_w | should be straightforward, I just did as you told me | 18:47 |
| noodles785 | Hi rockstar, I see that you processed my MP in some way, but the MP hasn't been updated? | 19:19 |
| noodles785 | (sorry, I mean I saw in the topic that you processed my MP in some way) | 19:20 |
| rockstar | noodles785, bac had already looked at that | 19:22 |
| noodles785 | rockstar: he just noted there was a conflict, he didn't go any further (see my comment on the MP). | 19:23 |
| rockstar | noodles785, ah, okay. I saw the review and thought "hands off" | 19:23 |
| noodles785 | Thanks rockstar ! | 19:23 |
| === noodles785 is now known as noodles775 | ||
| rockstar | noodles785, just as I thought I was clearing the queue... | 19:24 |
| noodles775 | rockstar: it's much shorter than when you started :) | 19:28 |
| rockstar | noodles775, :) | 19:33 |
| EdwinGrubbs | adiroiban: I'll land your branch. | 19:38 |
| adiroiban | EdwinGrubbs: thanks! :) | 19:38 |
| rockstar | noodles775, your branch, I am approving it. | 19:44 |
| jml | james_w, in case you missed it, I got to it. | 19:51 |
| jml | james_w, do you need me to land it for you? | 19:51 |
| james_w | yes please | 19:51 |
| jml | james_w, (would you like commit access?) | 19:51 |
| james_w | not really, but I do have a backlog building up :-) | 19:51 |
| === salgado is now known as salgado-brb | ||
| noodles775 | Thanks rockstar | 20:35 |
| === rockstar changed the topic of #launchpad-reviews to: rockstar are reviewin' - jelmer - [jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado-brb is now known as salgado | ||
| === salgado is now known as salgado-afk | ||
| thumper | trivial code move review for someone: https://code.edge.launchpad.net/~thumper/launchpad/move-mailout-functions/+merge/21689 | 22:16 |
| mwhudson | thumper: we try to avoid code in __init__.py i thought, did you think about lp.services.mail.helpers or something? | 22:28 |
| thumper | mwhudson: hmm... could do | 22:28 |
| thumper | mwhudson: I notice there are many helpers in sendmail.py | 22:28 |
| thumper | like format_address | 22:29 |
| mwhudson | thumper: mmm, indeed | 22:29 |
| mwhudson | thumper: well, fix as much of this as you like i guess :-) | 22:29 |
| thumper | :) | 22:30 |
| thumper | although I was just thinking | 22:30 |
| thumper | the text_delta isn't explicitly mail oriented | 22:30 |
| thumper | perhaps it should go somewhere else | 22:30 |
| thumper | we could move the append_footer into sendmail.py | 22:30 |
| thumper | hmm | 22:32 |
| thumper | ObjectDelta and snapshot have been moved into lazr.lifecycle | 22:32 |
| mwhudson | thumper: it's hard to find a place for sort of miscellaneous useful stuff in our tree | 22:41 |
| mwhudson | i think there's lp.services.util or something like that | 22:41 |
| thumper | ah you're back | 22:41 |
| thumper | yeah, I've moved append_footer into sendmail.py | 22:41 |
| thumper | and text_delta into lp.services.utils | 22:41 |
| thumper | pushing now | 22:41 |
| === flacoste is now known as flacoste_afk | ||
| thumper | mwhudson: diff updated | 22:45 |
| wgrant | rockstar: Thanks for the reviews. I've fixed the issue you mentioned -- can you please land them both? | 22:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!