[14:16] <bac> sinzui: thanks for your review.  for some reason i didn't get a copy via email so i just now saw it.  bothersome.
[14:17] <sinzui> bac: I used the UI for my review.
[14:17]  * sinzui checks his own mail
[14:17] <bac> sinzui: but an email still should've been sent
[14:18] <sinzui> yes, and I did get a copy of my review
[14:51] <adiroiban> EdwinGrubbs: when you have some time, can you please review the latest changes from here https://code.edge.launchpad.net/~adiroiban/launchpad/bug-540105/+merge/21552 ? Thanks!
[14:52] <EdwinGrubbs> ok
[14:56] <rockstar> Holy crap, is that seriously the queue?
[15:11] <rockstar> james_w, I know what's going wrong with your ec2...  I figured it out last night.
[15:11] <james_w> ORLY?
[15:11] <rockstar> james_w, basically, I was running it with my personal key credentials which kill all instances after two hours.  I should be using my Canonical credentials.
[15:11] <james_w> ah
[15:12] <rockstar> Was a backup restore issue...  Running new ec2 instances of a few things now, one of which is yours.
[15:13] <james_w> thanks
[15:28] <salgado> rockstar, any chance I can jump the queue with my one-liner: https://code.launchpad.net/~salgado/launchpad/bug-540697/+merge/21648 ?
[17:06] <salgado> thanks for the review, rockstar!
[17:07] <rockstar> salgado, no problem.
[17:11] <noodles775> Hey rockstar, if/when you've time, the branch referenced in the queue is this one: https://code.edge.launchpad.net/~michael.nelson/launchpad/529926-partner-override-to-main/+merge/21329
[17:12] <rockstar> noodles775, yeah, I've just been looking through +activereviews and am working through them.
[17:12] <rockstar> noodles775, did you not take a shift at reviewing today?
[17:21] <noodles775> rockstar: no, soyuz team is sprinting this week.
[17:22] <noodles775> rockstar: so I've just been doing swaps :)
[17:22] <rockstar> noodles775, okay, that makes sense then.  Was wondering why the queue was so monstrous.  :)
[18:41] <rockstar> james_w, ping
[18:42] <james_w> hi rockstar
[18:42] <rockstar> james_w, where's your mp?
[18:43] <james_w> https://code.edge.launchpad.net/~james-w/launchpad/package-merge-proposal-permissions
[18:44] <rockstar> james_w, ah, jml has already reviewed it.
[18:45] <james_w> rockstar: but not with my fixes
[18:46] <jml> james_w, sorry, I'll get to it.
[18:46] <james_w> thanks jml
[18:47] <james_w> should be straightforward, I just did as you told me
[19:19] <noodles785> Hi rockstar, I see that you processed my MP in some way, but the MP hasn't been updated?
[19:20] <noodles785> (sorry, I mean I saw in the topic that you processed my MP in some way)
[19:22] <rockstar> noodles785, bac had already looked at that
[19:23] <noodles785> rockstar: he just noted there was a conflict, he didn't go any further (see my comment on the MP).
[19:23] <rockstar> noodles785, ah, okay.  I saw the review and thought "hands off"
[19:23] <noodles785> Thanks rockstar !
[19:24] <rockstar> noodles785, just as I thought I was clearing the queue...
[19:28] <noodles775> rockstar: it's much shorter than when you started :)
[19:33] <rockstar> noodles775, :)
[19:38] <EdwinGrubbs> adiroiban: I'll land your branch.
[19:38] <adiroiban> EdwinGrubbs: thanks! :)
[19:44] <rockstar> noodles775, your branch, I am approving it.
[19:51] <jml> james_w, in case you missed it, I got to it.
[19:51] <jml> james_w, do you need me to land it for you?
[19:51] <james_w> yes please
[19:51] <jml> james_w, (would you like commit access?)
[19:51] <james_w> not really, but I do have a backlog building up :-)
[20:35] <noodles775> Thanks rockstar
[22:16] <thumper> trivial code move review for someone: https://code.edge.launchpad.net/~thumper/launchpad/move-mailout-functions/+merge/21689
[22:28] <mwhudson> thumper: we try to avoid code in __init__.py i thought, did you think about lp.services.mail.helpers or something?
[22:28] <thumper> mwhudson: hmm... could do
[22:28] <thumper> mwhudson: I notice there are many helpers in sendmail.py
[22:29] <thumper> like format_address
[22:29] <mwhudson> thumper: mmm, indeed
[22:29] <mwhudson> thumper: well, fix as much of this as you like i guess :-)
[22:30] <thumper> :)
[22:30] <thumper> although I was just thinking
[22:30] <thumper> the text_delta isn't explicitly mail oriented
[22:30] <thumper> perhaps it should go somewhere else
[22:30] <thumper> we could move the append_footer into sendmail.py
[22:32] <thumper> hmm
[22:32] <thumper> ObjectDelta and snapshot have been moved into lazr.lifecycle
[22:41] <mwhudson> thumper: it's hard to find a place for sort of miscellaneous useful stuff in our tree
[22:41] <mwhudson> i think there's lp.services.util or something like that
[22:41] <thumper> ah you're back
[22:41] <thumper> yeah, I've moved append_footer into sendmail.py
[22:41] <thumper> and text_delta into lp.services.utils
[22:41] <thumper> pushing now
[22:45] <thumper> mwhudson: diff updated
[22:52] <wgrant> rockstar: Thanks for the reviews. I've fixed the issue you mentioned -- can you please land them both?