=== NCommand1r is now known as NCommander
=== matsubara is now known as matsubara-afk
[02:27] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/bmp-notification-email-job/+merge/21703
[02:27] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/new-reviewer-email-job/+merge/21610
[02:29] <thumper> I wish I could edit a merge proposal to add or remove a prerequisite branch
[02:29]  * thumper adds it to the todo list
[02:29] <mwhudson> change target branch too pls
[02:30] <thumper> mwhudson: yeah that's gunna be tone too
[02:30] <thumper> need it if we are going to automagically create WIP merge proposals
[06:25] <jtv> rockstar: got time for mine as well?  Very short fix.
=== jtv is now known as jtv-sick
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: -|| queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== jpds_ is now known as jpds
[09:59] <bigjools> adeuring: hi, I have a branch in the queue if you can take a look please?
[09:59] <adeuring> bugjsure
[09:59] <adeuring> bigjools: sure
[10:03] <intellectronica> adeuring: if it's ok i'll add myself to the queue too?
[10:03] <adeuring> intellectronica: sure
[10:03] <intellectronica> thanks
=== intellectronica changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: -|| queue: [intellectronica] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[10:12] <adeuring> bigjools: r=me
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: intellectronica || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[10:15] <jtv-sick> adeuring: I've got a small one
[10:15] <jtv-sick> could you take a look at it?
[10:15] <adeuring> jtv-sick: of course -- just put it in the queue
=== jtv-sick changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: intellectronica || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[10:15] <jtv-sick> thanks
[10:18] <bigjools> adeuring: thanks for the review
[10:26] <adeuring> intellectronica: what is the purpose of the variable 'that'? Can't we use 'this'?
[10:27] <intellectronica> adeuring: no, we can't use 'this' because 'this' is a magic keyword in javascript. whereas in python you pass self explicitly, in js you don't and this always binds to the current instance
[10:28] <intellectronica> adeuring: 'that' is used to capture the 'this' in the environment where the closure is defined, so that we can refer to it later.
[10:29] <adeuring> intellectronica: Ahhh, right! But the variable name is sightly confusing ;) Coud you rename it to something more meaningful?
[10:30] <intellectronica> adeuring: actually, using 'that' is kind of an idiom. we use it a lot in our js code.
[10:30] <adeuring> really? OK, let's leave it as it is then...
[10:30] <intellectronica> i can change it, but i think it's better to keep it like that. when i see 'that' in js i immediately know what's it about (and now you will too :) )
[10:30] <intellectronica> cool
[10:32] <adeuring> though the idiom will become really confusing when you have nesting. "var that = this;{ [...] var something_else = this; {... var something_completely_differet = this ; }}
[10:33] <intellectronica> i think that's quite rare. nesting more than one closure can make the code very hard to read for many other reasons too
[10:33] <intellectronica> if i got to the point where i needed such deep nesting i'd probably re-model it using proper objects
[10:37] <adeuring> intellectronica: r=me, but there are a few lint issues
[10:37] <intellectronica> adeuring: thanks, and will run lint and fix.
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[10:39] <intellectronica> noodles775: any chance you could ui-review my change? it's quite simple.
[10:46] <jml> could I get a review for https://code.edge.launchpad.net/~jml/launchpad/twisted-services/+merge/21716 please?
[10:52] <adeuring> jml: sure, once I finished the review for Jeroen
[10:52] <jml> adeuring, thanks.
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: jml || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[11:22] <adeuring> jml: r=me
[11:22] <jml> adeuring, thanks.
=== adeuring changed the topic of #launchpad-reviews to:  on call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[11:23] <noodles775> intellectronica: sorry for the delay... sprinting, but yeah, I can take a look soon.
[11:24] <intellectronica> noodles775: didn't realise you're sprinting. i'll invite you to the mp and add screenies. if you can't look at it today then no big deal.
[11:28] <noodles775> intellectronica: thanks.
[11:39] <adiroiban> henninge: hi, when you have some time, can you please add your comments regarding the latest changes for https://code.edge.launchpad.net/~adiroiban/launchpad/bug-201749/+merge/21250? Thanks. I'll go to lunch now.
=== matsubara-afk is now known as matsubara
=== salgado changed the topic of #launchpad-reviews to:  on call: adeuring,salgado || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[12:53] <salgado> adeuring, can you review a trivial one for me?
[12:53] <salgado> https://code.launchpad.net/~salgado/launchpad/remove-crap/+merge/21724
[12:54] <adeuring> salgado: sure
[13:06] <adeuring> salgado: r=me
[13:06] <salgado> thanks adeuring
=== flacoste_afk is now known as flacoste
[14:33] <NCommand1r> stub: if your around, and have a moment, I'd love if you could review my raw source changelog branch on LP
=== NCommand1r is now known as NCommander
[14:54] <abentley> adeuring, salgado: could one of you please review https://code.edge.launchpad.net/~abentley/launchpad/recipe-index/+merge/21730 ?
=== abentley changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: - || queue: [abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:57] <salgado> abentley, sure, I'll take it
[14:57] <abentley> salgado, thanks.
=== henninge_ is now known as henninge
=== deryck is now known as deryck[lunch]
=== gary_poster is now known as gary-lunch
=== EdwinGrubbs is now known as Edwin-lunch
=== salgado changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== adeuring changed the topic of #launchpad-reviews to: on call: salgado || reviewing: abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== deryck[lunch] is now known as deryck
=== matsubara is now known as matsubara-lunch
[17:21] <deryck> Hi, salgado.  I have a branch ready and would like to get in the queue.
=== deryck changed the topic of #launchpad-reviews to: on call: salgado || reviewing: abentley || queue: [deryck] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[17:22] <salgado> deryck, sure, I'll take it once I'm done with abentley's
[17:24] <deryck> salgado, thanks.  See:https://code.edge.launchpad.net/~deryck/launchpad/has-bug-heat-interface-529846/+merge/21731
=== salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: deryck || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara-lunch is now known as matsubara
=== salgado is now known as salgado-upgradin
=== maxb_ is now known as maxb
=== gary-lunch is now known as gary_poster
=== salgado changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk
=== jtv is now known as jtv-sick