[00:00] <ccheney`> http://pastebin.ubuntu.com/398071
[00:01] <ccheney`> hmm maybe i need a full copy of gtk_entry_completion also?
[00:01] <ccheney`> looks like that calls back into regular gtkentry
[00:02] <ccheney`> i had just added the parts of that class that were new
[00:03] <asac> yes, feels like it
[00:03] <ccheney`> and the new parts didn't use GtkEntry at all from what i could tell
[00:03] <asac> let me double check
[00:03] <ccheney`> ok
[00:05] <asac> i think things would be easier if we would derive from gtkentry
[00:05] <asac> then that would just work
[00:05] <asac> i would hope
[00:08] <ccheney`> how do we go about doing that, have a derived class with all the bits newer than the one in 2.12?
[00:08] <asac> ccheney`: so try to derive the GtkEntry
[00:08] <asac> that might just work
[00:09] <asac> you would drop all fields from EphyGtkEntry and EphyGtkEntryClass
[00:09] <asac> use GTK_TYPE_ENTRY in G_DEFINE_TYPE rather than GTK_TYPE_WIDGET
[00:09] <asac> also you would use GtkEntry and GtkEntryClass instead of GtkWidget and GtkWidgetClass in the EphyGtkEntry and EphyGtkEntryClass
[00:09] <asac> struct as the only member (the topmost that isnt a pointer)
[00:09] <asac> then you would use override_property
[00:10] <asac> rather than install_property for all the properties
[00:10] <asac> that are from GtkEntry
[00:10] <asac> and that should be it afaict
[00:10] <ccheney`> ok i will try that out and see how it goes
[00:11] <asac> yeah
[00:11] <asac> might be a bit tricky
[00:11] <asac> but probably easier than copying all completion and so on
[00:11] <asac> as then the accessor functions should just call us
[00:11] <ccheney`> yea
[00:12] <ccheney`> what did you mean by 19:08 < asac> struct as the only member (the topmost that isnt a pointer)
[00:12] <asac> ccheney`: search for the EphyGtkEntry and EphyGtkEntryClass struct
[00:12] <ccheney`> empty them and have a struct inside them of type GtkEntry ?
[00:12] <asac> the first elemtn is not a pointer
[00:12] <asac> thats the parent class/object
[00:13] <ccheney`> ah yea   GtkWidget  widget;
[00:13] <asac> thats currently GtkWidget and should be GtkEntry/Class
[00:13] <ccheney`> oh ok
[00:13] <asac> and all the other funcs/fields that are already in trhe gtk 2.12 entry
[00:13] <asac> should be dropped
[00:13] <ccheney`> ah ok, i thought that was what you meant but wasn't sure and wanted to make sure i didn't do something wrong :)
[00:13] <asac> and then where we assign the funcs in _class_init
[00:13] <asac> we have to assign them to GTK_ENTRY_CLASS (klass)
[00:13] <ccheney`> so then anything in my copied code that refers to old items need to point through to GtkEntry
[00:14] <asac> rather than EPHY_GTK_ENTRY_CLASS (klass)->set_background (not sure if that function exists)
[00:14] <asac> ccheney`: give me an example for the last
[00:14] <ccheney`> looking at it to see if i understand
[00:14] <asac> e.g. for "refers to old items need to point through to GtkEntry"
[00:14] <ccheney`> eg   widget_class->unmap = ephy_gtk_entry_unmap;
[00:14] <asac> yeah right. widget_class is still widget_class
[00:15] <ccheney`> ah ok
[00:15] <asac> but there probably also is entry_class or something
[00:15] <ccheney`> eg   class->move_cursor = ephy_gtk_entry_move_cursor;
[00:15] <asac> ccheney`: right so class-> should more or less be GTK_ENTRY_CLASS(class)->
[00:15] <asac> yeah
[00:16] <ccheney`> class is currently ephy_gtk_entry_class_init (EphyGtkEntryClass *class)
[00:16] <asac> you can make a gtk_entry_class = ... on top
[00:16] <asac> same as done with widget_class
[00:16] <ccheney`> so that should be ephy_gtk_entry_class_init  (EphyGtkEntryClass *class)
[00:16] <ccheney`> er stupid return
[00:16] <asac> ccheney`: that func should still be named the same
[00:16] <asac> just the class-> ... assignments have to go against the casted entry_class (aka GTK_ENTRY_CLASS (class))
[00:16] <ccheney`> ah ok
[00:17] <asac> ccheney`: i think one function didnt exist in 2.12 ... so that function might need to be added to our ephy class then
[00:17] <ccheney`> yea
[00:18] <ccheney`> then code calling it in ephy should use the new class throughout?
[00:18] <ccheney`> and/or cast back from the new class to GtkEntry if needed, i guess?
[00:19] <asac> ccheney`: well. we overload the functions
[00:20] <asac> so things we have changed to ephy_gtk_entry_something
[00:20] <asac> can usually be reverted to gtk_entry_something
[00:20] <asac> except that thing that wasnt available in gtk_entry
[00:21] <ccheney`> ok
[00:21] <ccheney`> i think i can probably determine how to do it with what you have told me above :)
[00:22] <ccheney`> probably take a hour or two to get it fully building with everything reverted though
[00:22] <ccheney`> and its late where you are so if you want i can let you know how the patching goes and you can head off to bed or whatever (being really late in germany)
[00:24] <asac> ccheney`: maybe keep what you have for now
[00:25] <asac> so in case this road isnt good we can try someting else ;)
[00:27] <ccheney`> yea i am going to keep a backup of it
[00:29] <asac> maybe also push somewhere online for desaster scenario ;)
[00:29] <asac> ok off ... will check tomorrow
[00:29] <asac> thanks
[00:34] <ccheney`> np :) have a good night
[05:47] <LLStarks> asac. you there? i have a question.
[07:15] <ccheney`> asac: haven't gotten to a point to upload yet and about to head to bed
[07:15] <ccheney`> asac: i'm currently looking at what to do for update_cursors in gtkentry for GTK_ENTRY_GET_PRIVATE
[07:16] <ccheney`> asac: i think probably copying that verbatim from gtkentry.c would work and copying the private struct into the derived class so it can see what the original gtkentry has
[07:16] <ccheney`> asac: at least the extra functions definitely need access to the private data from gtkentry to work from what i can see
[07:16] <ccheney`> asac: ttyl :)
[11:53] <asac> ccheney`: hey
[11:54] <asac> LLStarks: yews
[15:05] <asac> hmm. did micah's sdk update ever land?
[15:05] <asac> or is that staged in mozilla-devscripts?
[18:37] <ccheney`> asac: hi
[18:40] <asac> hey
[18:45] <ccheney`> so i realized last night that i was way too tired to be sanely working on the code
[18:45] <ccheney`> i think the private members aren't needed in the new code, checking that now
[18:45] <ccheney`> yea it doesn't appear to use any of them
[18:46] <asac> ccheney`: what private members are you talking about?
[18:46] <ccheney`> so i just need to create a ephyentry private struct
[18:46] <asac> ccheney`: what did you do up to now
[18:46] <ccheney`> and copy the private ones it uses from the new version of gtk into it
[18:46] <asac> how does ephyentry class look like?
[18:46] <ccheney`> asac: i reverted the ephy gtk entry calls in the code and deleted the old gtk entry copy and started copying just the bits over that are needed to derive from it
[18:47] <ccheney`> i'll pastebinit just a sec
[18:47] <ccheney`> http://pastebin.com/cww1GymP http://pastebin.com/7WYXZHQ6
[18:49] <asac> ccheney`: you dont have any TYPE_DEFINE
[18:49] <asac> and class_init
[18:49] <asac> etc.
[18:49] <asac> all that is gone ;)
[18:49] <ccheney`> yea need to add that back
[18:50] <ccheney`> i added things as the compile complained about them
[18:50] <asac> ccheney`: i dont think you can drop all the  other funcs
[18:50] <asac> my idea was to copy everything
[18:50] <asac> just change the class_init function
[18:50] <ccheney`> we already copied everything before though?
[18:50] <asac> and make the structs and the G_DEFINE_TYPE
[18:50]  * ccheney` is confused
[18:50] <asac> ccheney`: you basically need to overload all funcs of GtkEntry
[18:51] <asac> thats why you need all the impls
[18:51] <asac> we had yesterday
[18:51] <asac> and just set them to the parent class in our new class_init
[18:51] <ccheney`> so just take the code i had before and then change up the class_init, etc ?
[18:51] <asac> ccheney`: well. if you have luck it works as you did it now
[18:52] <asac> ccheney`: the original idea was to change G_DEFINE_TYPE ... class_init and the structs
[18:52] <asac> e.g. from the structs you drop all the funcs that are in GtkEntry
[18:52] <asac> and derive from GtkEntry
[18:52] <ccheney`> ah i think i misunderstood that to drop all funcs that are in GtkEntry period :)
[18:52] <asac> in class_init you just bind all the funcs
[18:52] <ccheney`> so i redid the files
[18:52] <asac> that will ensure that gtk_entry::something will call our new ::something
[18:53] <asac> and instead of install_property in class_init
[18:53] <asac> we use override_property
[18:53] <asac> so if you set/get the properties on a GTK_ENTRY casted object it will also call our get/set_property funcs
[18:54] <asac> so yeah. only drop the declaration from the structs because they are already there if you have GtkEntryClass parent_class;
[18:54] <asac> in there
[18:54] <asac> anyway. have to run now
[18:54] <asac> the instructions should be in there
[18:55] <asac> will be back in a couple of hours
[18:55] <ccheney`> ok
[22:02] <dupondje> guys, can somebody check https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/526290 ? :)
[22:23] <asac> dupondje: commented
[22:25] <dupondje> thunderbird-gnome-support was indeed not installed, tho it doesn't fix the issue it seems
[22:25] <dupondje> after install it still asks me what application to open when I click on a link
[22:30] <asac> bbin 5
[22:31] <dupondje> i'll grab some food also :P
[22:39] <asac> dupondje: works for me :/
[22:39] <asac> dupondje: sure you restarted tbird properly after installing the pkg?
[22:39] <dupondje> jl@laptopjl:~$ ps aux |grep thunder
[22:39] <dupondje> jl       22662  0.0  0.0   7556   936 pts/1    S+   23:39   0:00 grep thunder
[22:39] <dupondje> its not running :x
[22:40] <dupondje> starting it, and it asks for program :(
[22:41] <asac> dupondje: in $HOME/.thunderbird (somewhere below) there is a compreg.dat
[22:41] <asac> please paste that
[22:42] <dupondje> |grep http or ? :)
[22:42] <asac> no
[22:42] <asac> full
[22:42] <asac> there probably is no http in
[22:43] <dupondje> http://paste.ubuntu.com/398497/
[22:51] <asac> dupondje: try running sudo touch /usr/lib/thunderbird-3.0.3/.autoreg
[22:51] <asac> then start tbird
[22:51] <asac> stop it
[22:51] <asac> and paste again
[22:53] <dupondje> http://paste.ubuntu.com/398502/
[22:53] <dupondje> oh and it works btw :P
[23:00] <asac> hehe
[23:00] <asac> right
[23:01] <asac> dupondje: fix committed ;)
[23:01] <asac> will be in tomorrows dailies
[23:01] <asac> or next upload
[23:01] <dupondje> :p
[23:01] <asac> e.g. fix for componetns not getting registered if you install -gnome-support later
[23:02] <dupondje> but still you should 'smell' to install the gnome package ? :)
[23:03] <asac> dupondje: i commented that the other part should be tracked in a separate (wishlist) but
[23:03] <asac> bug
[23:03] <asac> e.g. in #4
[23:04] <dupondje> anyway thx for the fix
[23:04] <asac> so yes. we should do what we do in firefox since lucid
[23:04] <dupondje> surely for new users it was quite annoying :)
[23:04] <asac> problem is we cannot recommend gnome-support
[23:04] <asac> because of kubuntu
[23:05] <asac> they complained all the time
[23:05] <asac> dupondje: there is a nother issue ... in old tbird package
[23:05] <asac> we had a safety net that called x-www-browser
[23:05] <asac> if no gnome component was there
[23:05] <asac> we should consider to resurrect that
[23:06] <asac> chrisccoulson: ^^ maybe open those two bugs ;) ... 1. gnome integration should work even without -gnome-support ... 2. ensure that x-www-browser is used if no http handler is found through gnome integration :)
[23:06] <dupondje> it quite improves usability when you don't need to select your browser :) but we are getting close :P
[23:07] <asac> both are regression bugs over our tbird2 package
[23:07] <asac> i think for 2. we need a patch to code iirc
[23:07] <asac> as it will otherwise always prefer to use x-www-browser
[23:07] <asac> but lets first see and get those bugs ;)
[23:07] <asac> dupondje: or you can file those :)
[23:07] <asac> :)
[23:08] <asac> let me do that
[23:08] <dupondje> 591  	 Open bugs
[23:08] <dupondje> cool :P
[23:10] <asac> filed bug 543060
[23:12] <dupondje> :)
[23:12] <asac> :( slow launchpad
[23:12] <dupondje> to much thunderbird bugs ;)
[23:15] <asac> filed bug 543064 about us not using x-www-browser as a safety net.
[23:15] <asac> dupondje: well. lots of noise ;)
[23:15] <asac> those bugs are important enough, so they will get attention now :-P
[23:15] <asac> feel free to help out on bug triage so we can filter the other important ones and ensure they get fixed ;)
[23:16] <asac> starting with NEW: would be good ;) ... https://bugs.edge.launchpad.net/ubuntu/+source/thunderbird/+bugs?search=Search&field.status=New
[23:16] <asac> dupondje: ^^
[23:16] <asac> enjoy ;)
[23:16] <dupondje> i'll look :) btw, there is another bug, that thunderbird doesn't move mails when marking it as junk
[23:17] <dupondje> but its set in the setting it should move them :s
[23:19] <asac> that doesnt feel like an ubuntu specific bug. probably best filed upstream
[23:19] <asac> dupondje: do you see any errors in error console?
[23:20] <dupondje> I checked, nope :(
[23:26] <dupondje> thx for the bugs btw :)
[23:28] <dupondje> 5 bugs as incomplete :p
[23:28] <dupondje> 1 as invalid
[23:28] <dupondje> lets kill some more
[23:31] <chrisccoulson> good evening everyone
[23:32] <dupondje> hi :)
[23:32] <dupondje> asac left you some work ;)
[23:32] <chrisccoulson> yeah, i noticed ;)
[23:33] <chrisccoulson> i've got to disappear again. it seems my laptop drive has corrupted itself at some point today, so i have to go and recover
[23:39] <dupondje> I use Mint-Gloria (Mozilla Thunderbird). Which ever email I try to open, I always (hapend from5 days) get it:
[23:39] <dupondje> rofl @ stupid bugreports
[23:42] <dupondje> I user a Thunderbird mail server ...
[23:42] <dupondje> Thunderbird mail server
[23:42] <dupondje> thats new :)