/srv/irclogs.ubuntu.com/2010/03/24/#launchpad-dev.txt

wgrantjtv: Are you going to adjust Translations jobs to return a BuildStatus, or the master to not require it?00:24
jtvwgrant: my feeling is there'll be all sorts of consequences if I don't provide one...00:24
wgrantHeh, yes.00:25
wgrantIt makes sense and is easy to, and it should unbreak lots of stuff, so...00:25
jtvIn particular, it'd be nice to know whether it was OK.  :-)00:25
jtvbtw bigjools ok'ed the idea of verifying slave build ids by re-generating & comparing.00:25
jtvSo that pares the whole structure down to 1 method.  :)00:25
jtvHe didn't like the word "bake" for the cookie though.  :(00:26
wgrantWhat about IS?00:26
wgrantAnd is there any reason for the cookie?00:26
wgrantBQ + datestarted should be enough.00:26
jtvWell it's a major trust boundary... why _should_ we give it all that info?00:27
jtvSo BQ + datestarted would be enough, but I'd like to hash them.00:27
wgrantThe build ID is public in logs from the start.00:28
jtvBuild is, yes, and afaict that's used as the key.00:28
wgrantIf I'm running a build on a builder and break out of the chroot, I can easily grab the ID from the existing real slave before I take over.00:28
jtvBut no need to provide starting points for a compromised slave to make well-educated guesses as to the BQ id00:28
jtvaiui the slave knows the build id, but atm only knows the bq id because it happens to be encapsulated in the slave build id, right?00:29
wgrantRight.00:29
wgrantBut what's the problem with possessing the BQ ID?00:30
jtvWell I'm assuming it's bad for a slave to impersonate the slave build id of another slave.00:30
wgrantIt's not, really. The BQ is associated with the builder in the DB.00:30
jtvwgrant: but is association always checked?00:32
wgrantjtv: The slave ID is going to be checked by comparing the slave's ID with the ID generated from the BuildQueue associated with the slave in the DB, isn't it?00:32
jtvYes00:32
wgrantSo association is always checked.00:33
wgrantThere are one or two places on the master that use the slave build ID in logs, but they are non-critical bugs.00:33
wgrantAs long as it's not used for anything other than that check, it doesn't matter if somebody can impersonate another slave's build ID.00:33
jtvI meant, is the association between the slave build and the builder always checked?00:33
jtvAnd could a slave ever impersonate a pending or past job on the same builder?00:34
wgrantjtv: Past jobs don't have BQs. Pending jobs don't have builders assigned.00:34
wgrantthere is a unique constraint on BuildQueue.builder.00:35
jtvokay, but keep some elbow room for things like changes in replication (as an example).00:36
wgrantThe slave's build ID doesn't decide any behaviour on the master, except that it will compare the string against the one the builder is meant to have.00:36
jtvby the way, scary thought: that all evolves around the build id...  what happens when different types of job have the same build ids (but for different BuildBase classes)?00:38
wgrantIt doesn't matter. We cannot guard against malice.00:38
jtvThis would be accident.00:39
wgrantEr.00:39
wgrantWe're not talking about build IDs, are we?00:39
wgrantWe're talking about BuildQueue IDs.00:39
jtvWell looking at the code, my impression is that the real identification happens by build id, and buildqueue id is merely a recurring pattern in the slave build ids.00:39
wgrantThe current code grabs the BuildQueue ID, and checks that the BQ's build ID matches the one from the slave.00:40
wgrantBQ IDs are not reused.00:40
jtvThat's inside verifySlaveBuildID.  I'm talking about outside it.  But hopefully it's just a wrong impression.00:41
wgrantWhere outside it?00:41
jtvAh, if only I remembered that.  :)00:41
wgrantNothing outside of that should use the slave build ID.00:41
jtvmaybe I was just confused by the slave build id being passed as build_id.00:42
jtvIt's enough to drive one to glue.00:43
wgrantYeah, we should rename that.00:43
wgrantjtv: I was confused by this same thing on the day after the open sourcing. It looked like a big hole.00:48
wgrantBut a little poking around revealed that the slave build ID wasn't actually used for anything important, despite how it appears.00:48
jtvI'm still hoping to pay a small price in code, in return for having other people worry about all that after I've gutted the code and fled the scene.00:49
jtvIn fact I'm sure it's going to be easier to decide when the complexity around it is gone.00:50
wgrantYou win a thousand ponies if you can remove all references to the slave build ID except in dispatchBuildToSlave, the thing that will compare it, and the slave itself.00:51
wgrant(not hard. probably mostly grepping and changing log strings.)00:51
jtvOkay, that does sound like a good idea.00:52
mwhudsonwow03:19
mwhudsonmy crazy no-hosted-area hacking seems to work03:19
thumpercool03:20
thumpermy 'completely change the way merge proposal email' hacking seems to work too :)03:20
thumpers/email/email is sent/03:20
mwhudsonthumper: hooray for redoing the underpinnings of launchpad03:21
thumper\o/03:21
thumperwe rock!03:21
thumpermwhudson: http://pastebin.ubuntu.com/400341/03:22
thumpermwhudson: that is the new cron script :)03:22
mwhudsonthumper: cool03:23
thumperhmm :(03:25
thumper887 lines for this pipe without new tests03:25
* thumper considers breaking it up more03:25
thumpermwhudson: if you are after a break, we could have a quick call03:27
thumpermwhudson: I have a few pieces of news03:27
mwhudsonthumper: ok03:27
mwhudsongrr branch-rewrite.py is broken on lucid04:19
wgrantmwhudson: the PATH issue?04:19
mwhudsonfor really stupid reasons04:19
mwhudsonwgrant: yeah04:19
wgrantI thought that had been around for longer than that.04:19
wgrantI've seen it for more than 6 months, I'm sure.04:19
wgrantA bug was filed a couple of weeks ago against -foundations somewhere.04:19
mwhudsoni think it's time to stop for today04:45
magciusIs there a difference in types of code that goes into the canonical.launchpad and lp packages?07:01
spmmagcius: no. just the config (obviously, server specific). it all comes from the same place.07:02
magciusspm: is stuff moving from one package gradually moving to the other07:03
spmhrm. I think I may have misunderstood your question and fired from the hip. are you asking if the code that runs launchpad.net is the same as is downloaded from https://code.edge.launchpad.net/~launchpad-pqm eg lp:launchpad/devel ??07:06
thumpermagcius: stuff is moving from canonical.launchpad into lp packages07:37
thumpermagcius: we had really big moves early on for the major app bits07:37
thumpermagcius: but it has been moving slowly since then07:37
magciusthumper: what's stopping you from just doing a rope rename?07:37
thumpermagcius: I don't understand what you mean07:38
magciusthumper: http://rope.sourceforge.net/07:39
thumpermagcius: mostly because we are not sure where we want to move stuff07:40
noodles775Hey thumper, did you see the conversation re. the url traversal (and the resulting breadcrumbs) on Aaron's MP?07:41
thumpernoodles775: no07:41
thumperanything I need to know about right now?07:41
noodles775thumper: no, it's not urgent, but if you get a chance tomorrow (I'm just wondering if there's a reason we don't put recipes under the (base) branch).07:42
thumperthere was a reason07:43
thumperI'm trying to remember it07:43
thumpernoodles775: the argument went round about...07:43
noodles775The only reason I could think of (which Aaron also highlighted) is that it would be fragile if the base branch changes etc., but the original mockups didn't allow you to change the base branch of a recipe.07:43
thumpernoodles775: and I picked something07:43
noodles775thumper: no problem, as long as you guys have thought about it.07:44
thumpernoodles775: but what about changing the name of a branch?07:44
thumpernoodles775: or changing the owner07:44
thumpernoodles775: both of those change the unique name of the branch07:44
thumpernoodles775: and since the branch is accessed through the id, the recipe url would chnage07:44
thumpernoodles775: also ~user/+recipe/name is short07:45
noodles775thumper: I see, whereas both of those things wouldn't change the recipe url where it is currently? Great.07:45
* thumper nods07:45
noodles775thumper: yeah, it just came up because I noticed the breadcrumbs are Person >> Branches >> Recipes07:45
thumperwell...07:45
thumpershould be: Person >> Branches >> Recipes >> build-my-cool-stuff07:46
thumper:)07:46
noodles775Yep.07:46
thumpernoodles775: I'd love for you to finish the review, it is blocking several branches:)07:47
noodles775thumper: I'm doing it right now.07:47
thumpernoodles775: remember that we can iterate the ui07:47
thumpernoodles775: right now it isn't even enabled on edge07:47
thumperor won't be07:48
noodles775thumper: sure. It's not that I'm seeing things that are blocked, but more that I can't see all the questions you guys have already asked etc., so need to catch up by asking them :/07:48
* thumper nods07:48
thumperfair enough07:48
wgrantbigjools: Morning.08:29
bigjoolsmorning!08:30
* bigjools will disappear in a bit, my power is going out all day08:30
wgrantEww.08:30
bigjoolsI can relocate but my email is on a server at home, so ...08:30
wgrantWell, I've got two slight buildd-manager behaviour changes that are blocking buildmaster->soyuz shuffling that I was hoping you could OK quickly for me.08:32
bigjoolsif small08:32
wgranthttp://bazaar.launchpad.net/~wgrant/launchpad/refactor-slave-architecture-check/revision/10567 <- buildd-manager is about to forget about DASes, so this crack-filled check needs refactoring. I don't think this diff is too bad, considering how wrong the check is.08:34
thumperbigjools: why is your power going out?08:34
bigjoolsthumper: power co is cutting trees around lines08:34
thumperah08:35
wgrantbigjools: ... that requires turning the power off?08:35
bigjoolsapparently08:35
* bigjools shrugs08:35
wgrantHow odd.08:35
bigjoolsnot really, if the trees are all over live wires08:36
wgrantHeh, doesn't stop them here.08:37
StevenKOh yeah, they'll cut back trees if the wires are live or not.08:37
persiaDoesn't that have a tendency to cause fires?08:40
bigjoolswgrant: that looks hackish and I have to run now, I'll look more later08:41
bigjoolsmaybe noodles775 can look as well08:41
noodles775Sure08:42
* bigjools -> outta here, back in ~30mins08:42
noodles775wgrant: might even be worth creating a 'Work in progress' MP?08:42
noodles775ah nice, getting rid of builder dependency on DAS :)08:43
wgrantIt is hackish, yeah, but the current one is probably just as bad.08:43
wgrant(buildd-manager finds all the DASes. buildd-manager collects all buildds with a processor matching the DAS's family. buildd-manager iterates through the builders attached to each DAS, checking their arch tag against the DAS arch tag.)08:44
wgrantThe problem is that builders have processors in the DB, but the actual slave has an arch tag.08:45
wgrantAlthough that check will go away entirely once we have multi-arch builders.08:45
wgrantA branch further along in the series changes the above buildd-manager logic to 'iterate through all of the builders'08:46
wgrantWhich seems to make an awful lot more sense.08:46
wgrantAnd lets me delete 400 lines of code.08:46
noodles775Nice :)08:46
wgrantSo, basically, we can hugely simplify buildd-manager and remove its direct Soyuz dependency, at the cost of a temporary hack in a single Builder method, which will be fixed once we rethink builder arch affinity soon.08:48
noodles775wgrant: I don't see what's worse about your check, than the one you removed? Both check whether the slave's builder_arch matches a das.architecturetag (only difference being that the das used to be passed in)?08:53
noodles775So it seems like a good refactoring to me.08:53
wgrantRight.08:53
wgrantBoth are making the best of a terrible situation.08:53
* wgrant will argue with bigjools when he returns.08:53
noodles775wgrant: You're probably planning to anyway, but pls add a bug to that XXX reference at some point :)08:54
noodles775wgrant: Why not include the processorfamily in the original query rather than as a separate check?08:56
wgrantnoodles775: This lets us give a slightly better error.08:57
noodles775That would make your new code almost identical in functionality?08:57
noodles775Ah, ok.08:57
wgrantI suppose I could just say 'Mismatched slave architecture tag: foo'08:57
wgrantBut the old one gave the correct value too..08:58
wgrantnoodles775: Can you do a quick search for that bug? Lots of that sort of thing are still private.08:59
wgrantThere surely is one.08:59
noodles775OK, I would have thought it would have been included in the XXX if there was noe. Checking now.08:59
noodles775So just back to your raised exception, you could raise "Mismatched slave architecture, Architecture tag: %s, Processor family: %s"?09:01
wgrantnoodles775: I could, true.09:01
mrevellMorgen09:03
noodles775Hi mrevell09:04
noodles775wgrant: nope, I can't see anything. Closest was bug 2072.09:05
mupBug #2072: Processor/ProcessorFamily inconsistency in current DB model <Soyuz:Triaged> <https://launchpad.net/bugs/2072>09:05
wgrantnoodles775: OK, thanks.09:05
wgrantWe need launchpad-builfarm :(09:05
wgrantThe fact that I have not broken any tests by changing the error message concerns me greatly.09:21
noodles775wgrant: yep, grepping for "Architecture tag mismatch" or "BuildDaemonError" doesn't show any results in tests :/, but it's (yet another) chance to improved the codebase!09:25
wgrantYep.09:25
wgrantJust working out how to.09:25
wgrantBut first, dinner.09:25
noodles775Enjoy!09:25
wgrantbigjools: https://code.edge.launchpad.net/~wgrant/launchpad/refactor-slave-architecture-check/+merge/22010, now with added tests.10:34
wgrantAlso, you disabled soyuz-upload.txt in the apocalypse because it was failing. It now fails for me only because of post-apocalyptic bitrot.10:35
wgrantShould I fix and reenable it?10:36
noodles775That would be great :)10:38
bigjoolswgrant: yes please!11:00
bigjoolswgrant: IIRC it failed because either poppy or something else was failing to start11:00
bigjoolsand it was unobvious as to why11:00
wgrantSeems to work OK now.11:01
* wgrant proposed a merge.11:01
bigjoolsthere's a comment in there about random failures IIRC?11:01
wgrantDoesn't look like it.11:03
bigjoolshmmm11:04
bigjoolswgrant: there's an XXX from cprov about poppy11:05
bigjoolsthe reason I disabled it was that poppy simply would not start in that test and we had no idea why, since it started ok outside the test.11:05
wgrantThat file has enough XXXs...11:05
wgrantHmm.11:06
wgrantIt works fine inside now, though :/11:06
bigjoolsthe whole test is an XXX11:06
bigjoolswe had a load of lucid test failures last time I ran the whole suite11:07
wgrantThere is only one persistent one.11:08
wgrantThe a-f hash changes.11:08
bigjoolsyes11:08
wgrantAlthough a strange webservice-marshaller.txt one seems to have shown up recently.11:08
wgrantbigjools: Can you please have a look at that hack at some point so I can get it reviewed?11:11
wgrantnoodles775: Thanks.11:14
noodles775np11:14
bigjoolswgrant: yep11:17
bigjoolswgrant: can you mark it "needs review"11:20
wgrantbigjools: Oops.11:20
bigjoolsI want to see if I can test a theory about a bug11:20
bigjoolsif I click claim review right now, I get a "not allowed here"11:20
wgrantbigjools: 'tis now Needs Review.11:21
bigjoolshaha - noodles775 already reviewed it11:24
bigjoolsso that's why claim review didn't work11:24
wgrantAhh.11:25
wgrantthat's an odd response to that situation.11:25
bigjoolsit's a buggy response :)11:25
wgrantBut I guess I can't think of anything better.11:25
bigjoolsit shoudl redirect back to the page with a notification11:25
wgrantProbably.11:25
bigjoolsbtw we're not doing full ppa deletion in the first cut, to make life easier11:26
bigjoolsjust the repo11:26
wgrantAh, good.11:26
wgrantMuch easier.11:26
bigjoolsvery11:26
wgrantbigjools: Is the review link happier now?11:31
bigjoolswgrant: well it was the "claim review" button that I was hitting but it's gone now11:35
bigjoolsI'm just re-reading it to see what was discussed11:35
wgrantAh.11:35
bigjoolswgrant: so it's kinda yucky I guess but as long as nothing is breaking I am ok with it.  As you point out, the multi-arch builders will shake things up somewhat.11:40
wgrantbigjools: There were no tests before, there are now, and it works in practice.11:41
wgrantAnd it isolates the hack to a single method.11:41
bigjoolsyep11:41
wgrantWhereas it's currently deeply ingrained embedded in buildd-manager.11:41
* bigjools grumbles about "make run" bailing out when there's no process running as per a PID file11:42
bigjoolsI also discovered this morning that the local launchpad.dev doesn't work without an internet connection :/11:42
wgrantUrgh. What goes wrong?11:43
bigjoolsdidn't get far enough to work out why11:43
wgrantI've done it lots of times on the train.11:43
bigjoolsapache bails out saying it can't resolve11:43
bigjoolsI've done it before too, but this laptop is a new lucid installation11:43
bigjoolsso I suspect something has changed that's not part of the upgrade manager11:43
wgrantHmm.11:44
wgrantbigjools: Thanks for the approval. I suppose you can't test today, so somebody else will have to land it?11:45
bigjoolsyeah sorry11:46
* noodles775 sends it off.11:47
wgrantnoodles775: Thanks.11:47
wgrantbigjools: np11:47
noodles775wgrant: np, wanna add the commit msg?11:48
wgrantnoodles775: Done.11:49
=== mrevell is now known as mrevell-lunch
=== matsubara-afk is now known as matsubara
deryckallenap, hi.  Did that CP for checkwatches land?13:07
=== jamalta_ is now known as jamalta
=== mrevell-lunch is now known as mrevell
pabelangerDoes launchpad's ppa support building powerpc?13:37
noodles775Hi pabelanger, the PPA overview has the list of currently supported architecturse: https://help.launchpad.net/Packaging/PPA13:42
gary_posterbac, Google thinks we have reviewer mtg in 9.  Is it on Google-Calendar-doesn't-have-a-UTC-timezone crack?13:52
bacgary_poster: the meeting has been moved to 1400UTC, which is at the top of the hour13:53
gary_posterbac, ah, cool thanks13:53
bacgary_poster: is that what you see?13:53
gary_posterbac, yes.  btw, if there is not an action item to ask if leonardr has a demo on how to use launchpadlib to test in launchpad, you should add one, and ask him. :-)13:54
bacgary_poster: oh, it is ready?  cool!13:54
gary_posteryeah :-)13:54
baccool13:54
leonardrbac: yes, look at lib/canonical/launchpad/pagetests/webservice/launchpadlib.txt13:54
bacreminder, reviewer's meeting in 2 minutes in #launchpad-meeting13:58
allenapderyck: Yes, and it's in LPS, ready for CP when possible.14:00
deryckallenap, excellent, thanks.14:01
deryckI thought the reviewer meeting was in an hour according to UTC, bac ?  if not, I'm late. :-)14:02
bacderyck: recall we had the discussion last week to move to 1400UTC.14:03
deryckah, ok14:03
kfogelWhat's our preferred term for The Entity Known Either As A "Person" Or A "Team"?  Do we just say IPerson colloquially?14:30
kfogelderyck: ^^14:32
deryckkfogel, yeah, I think IPerson, Person, or person is the common usage.14:32
kfogelderyck: ok14:33
barrygary_poster, flacoste howdy!  what are your thoughts about upgrading lp:lazr.enum to 2a format?14:52
flacostebarry: JFDI14:52
barryflacoste: i like your style!14:52
flacostebarry: you should be able to do that by clicking a button on LP14:52
barryflacoste: /should/ being the operative word.  it's failed for me in the past :(14:53
* barry has his jfdi hat on today... literally14:53
jmlbarry, if it doesn't work, let me know.14:53
barryjml: cool14:53
barryjml: button pushed14:53
gary_posterbarry: fwiw, go, go jfdi ;-)14:55
barrygary_poster: rock!  thumper asked me to package it for lucid, which i've done and now i want to get it into universe14:56
gary_postergreat14:56
barryjml: can you check to see what's going on.  the button provides no feedback but the page still shows it in 0.92 format15:10
jmlbarry, no, I can't.15:10
barryjml: :(15:10
jmlbarry, it shows 2a for me though15:11
barryjml: it must have *just* finished! yay.  thanks15:12
jmlbarry, np. I'm glad it actually worked.15:12
jmlalthough a little disappointed we still haven't figured out ajax for this sort of thing.15:13
sinzuibac: call? coffee and tea first?15:13
bacsinzui: i require no refreshments.  give a ring when you're ready15:13
* jml afk for lunch15:14
barryjml: yeah15:16
=== salgado is now known as salgado-lunch
=== flacoste is now known as flacoste_lunch
leonardrflacoste, i'm going to write a launchpadlib branch that uses 1.0 instead of beta for the web service. i remember agreeing that changing it across the board was a better solution than having edge use devel and everything else use 1.0. (either because it's more consistent or because it's too big a change to launchpadlib to get into post-freeze lucid)16:00
leonardrlet me know if you disagree or remember differently16:01
jmlso16:13
jmlthe weird-ass error I was getting trying to update the ec2 image was caused by a bug in openjdk16:13
jmlfixed by the wonderful folks at Ubuntu Server16:14
=== matsubara is now known as matsubara-lunch
=== Ursinha is now known as Ursinha-lunch
=== leonardr is now known as leonardr-lunch
=== beuno is now known as beuno-lunch
bdmurraywhat's the process for chaning a bug from qa-needstesting to qa-ok?16:55
bigjoolsjust edit the tag16:55
bdmurraybigjools: after testing it though right?16:55
bigjoolsnaw just change it :)16:56
=== salgado-lunch is now known as salgado
=== flacoste_lunch is now known as flacoste
flacosteleonardr-lunch: i don't recall that, i don't think using a frozen version on edge makes sense17:07
=== matsubara-lunch is now known as matsubara
=== beuno-lunch is now known as beuno
cody-somervilleDoes anybody run into this issue when running make? http://pastebin.ubuntu.com/400683/17:44
cody-somervillebigjools, ^^17:44
bigjoolscody-somerville: first time you've run make?17:44
cody-somervilleon this branch? possibly, yes.17:45
bigjoolsi see it sometimes17:45
bigjoolsgoes away if you make again17:45
* bigjools has to run17:46
bigjoolsg'night all17:46
cody-somervillebye bye17:47
=== deryck is now known as deryck[lunch]
mrevellG'night all17:59
=== Ursinha-lunch is now known as Ursinha
=== deryck[lunch] is now known as deryck
salgadodoes anybody know why/how lib/lp/archivepublisher/tests/archive-signing.txt uses lucille as its db user?18:21
salgadoas usual, once you ask the question you find the answer:18:24
salgadodef archivepublisherSetUp(test):18:24
salgado    """Setup the archive publisher script tests."""18:24
salgado    setUp(test)18:24
salgado    LaunchpadZopelessLayer.switchDbUser(config.archivepublisher.dbuser)18:24
salgadoexcept that this function is not used anywhere. crap18:27
salgadolp/archivepublisher/tests/test_publisher_documentation.py has a copy of that, and this one's used.  nice18:29
gary_posterheh18:36
derycksinzui, ping18:41
sinzuihi deryck18:41
derycksinzui, hi.  there are 4 unassigned bugs on the 10.03 milestone for malone, which you added.  Are these things you and registry are planning to tackle?  Or was my team supposed to be looking into them?18:42
sinzuiah, I was looking for those 30 minutes ago18:43
sinzuideryck: There are 5 bugs I think18:44
derycksinzui, yes.  apparently I cannot count.18:44
sinzuideryck: Those look like the one I want to fix by creating a single page to configure bug tracking18:44
deryckoh, I would love that!18:44
deryckWe have another bug that could be fixed trivial with that, too.18:45
sinzuideryck: I am moving them to 10.04. My teams needs to complete code configuration before we can start that.18:45
derycksinzui, ok, cool.  thanks for taking on this work!18:46
deryckbug 538053 can be fixed when that work is done, too.18:46
mupBug #538053: "Enable bug tracking" link takes me to project edit form <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/538053>18:46
sinzuiyep, that will be fixed18:47
* sinzui has a single form and new url for that, but need a rocking bug tracker widget to make sense of expiration and remote project fields18:48
sinzuideryck: I assigned all the bug tracker configuration bugs to the registry team. I think that will make it clear what we are doing18:56
derycksinzui, thanks.18:57
jmlsinzui, I'll look at it tomorrow.19:00
marssinzui, ping: question for you about the <style> definition in base-layout-macros.pt19:00
sinzuihi mars19:00
marshi sinzui19:00
marssinzui, was looking at the output of bzr annotate lib/lp/app/templates/base-layout-macros.pt -r 8752.2.119:00
marssinzui, and we pull in the 3.0 stylesheet using an @import directive.  Why was that done?19:01
sinzuimars: that is following the beta through 2.0 rules. inheritance and overrides handled better when using that syntax19:02
marssinzui, "handled better"?19:03
sinzuisome rules are ignored using the common loading technique. That instruction was copied from the old template19:04
=== leonardr-lunch is now known as leonardr
marssinzui, what is the comma loading technique?19:04
sinzuisorry common way of using a href19:04
marssinzui, so you are saying that browsers ignore some rules if one uses a <link href=""> to load the stylesheet, and that can be avoided by using an @import ?19:05
cody-somervilleHow do I run a specific unit test?19:07
sinzuimars: There is some historic problems using simple href when rules need to override or set context like media. The import directive also hides the style rules from older or insane browsers19:07
marscody-somerville, bin/test -t the_specific_unit_test_name19:08
sinzuimars: The use of @import may not be as needed in 2010 as it was in 200519:08
marscody-somerville, be prepared for it to take a bit to load up all the layers.19:08
cody-somervilleah19:09
cody-somervilleholy crap19:09
cody-somervillemy test passes19:09
leonardrflacoste: ok, i'll make it per-server. any other defaults? how about staging?19:09
marssinzui, ok.  I'm investigating IE caching, and one hypothesis for IE not caching the stylesheet is SSL+@import.  So I will look into that.19:10
marssinzui, the other hypothesis is that IE sucks, and because of SSL, will load the stylesheet regardless of what I tell it.19:10
sinzuimars: Yes, I think you are on the right trail. I do not think we will be hurt if we change our syntax now. I think we only need to verify the !important instruction19:11
marssinzui, have a page that uses it?19:11
marssinzui, a test case I can follow?19:11
leonardrflacoste, here's the rationale for making 1.0 the default on staging19:12
leonardrfor most people, staging isn't for trying out the new web service19:12
leonardrit's for trying out your new application19:12
sinzuimars I do not have a test case, search the css for the few rules we have. They are probably color rules19:12
leonardrmost people will want to just change the service root to switch over to production19:12
marssinzui, ok, thanks for the guidance.19:12
leonardrif the default for edge is devel and the default for production is 1.0, everyone will have to know that when you develop against staging you need to also specify version 1.019:13
flacosteleonardr: are you sure? i would think that the common use case for using staging is to try out the app you are developping, not trying out a new application19:13
flacosteleonardr: which would hint at using the same default than edge19:13
marssinzui, I would never have guessed as to the reason for the @import technique.  browser code pain.19:13
leonardrwhen i said "trying out a new application" i meant the same thing as you meant when you said "Try out the app you are developing"19:14
sinzuimars: it is easier to hide css rules using @import, and IE is still broken :)19:14
leonardrflacoste: my basic argument is that an app should not break just because you changed root="edge" to root="lpnet"19:14
flacosteleonardr: it won't break19:14
flacosteleonardr: hmm, well it may19:14
flacosteif you are using features that aren't deployed19:15
leonardryeah19:15
flacostebut that's a problem for the app developer19:15
leonardrsure, but why cause problems for the app developer?19:15
flacostehe's deploying an app for which the server service isn't production ready yet19:15
leonardrhe wrote an app thinking that edge and production were the same19:15
flacostewell19:15
flacosteeither way the app developer has trouble19:16
flacosteeither he needs to switch to using an unfrozen API19:16
flacostebecause he wants to use latest features19:16
flacostehmm19:16
leonardrin that case he at least knows what's going on19:17
flacostesince 1.0 gets all new features eventually anyway19:17
flacosteunless they are backward incompatible19:17
flacosteit's probably safe to use 1.0 across the board19:17
flacosteand opt-in to using devel19:17
leonardrall right19:18
deryckkfogel, can any of your branches move to landed now?  I need some room in the bugs lane. ;)19:18
kfogelderyck: I believe they are landed, let me just check19:18
marssinzui, does this patch look sane? (4 lines changed) list-style-type:none;19:20
marsmargin:0 !important;19:20
marspadding-left:0 !important;19:20
mars}19:20
marsargh19:20
marssinzui, http://pastebin.ubuntu.com/400729/19:20
kfogelderyck: all landed: bugs <suppressing mup> 78565, 538226, and 48132419:21
deryckkfogel, thanks.19:21
james_wleonardr: does lib/canonical/launchpad/pagetests/webservice/xx-wadl.txt lie about using canonical/launchpad/apidoc/wadl-testrunner-devel.xml? If not, when is that file generated?19:28
leonardri thought i got rid of any such claims...19:28
james_woh, silly me, it's shipped in the source19:29
james_wI just deleted it as there doesn't seem to be an easy way of regenerating just the wadl without a full make clean19:29
james_wand the failure mode of that test when you remove that file is rather unhelpful19:29
leonardrjames_w: as of this morning there should no longer be any wadl-testrunner-devel.xml19:30
james_wit just serves you the full development wadl, leading the doctest to print out several hundred lines of CML19:30
james_wXML19:30
james_wah, I haven't pulled yet today19:31
didrockskfogel: flacoste: I think I pinged you yesterday about merging my ssh branch, did you have some time to have a look at it so that I can release Quickly 0.4?19:32
leonardrjames_w: you'll be happier with that test if you pull19:32
james_wthanks19:32
kfogeldidrocks: I don't think I saw that, but let me look now19:32
leonardrjames_w: if you just want to regenerate the wadl you can delete apidoc/* and make apidoc19:33
james_wyeah, I can now19:34
didrockskfogel: https://code.edge.launchpad.net/~didrocks/launchpad/expose-sshkeys-bug-357235/+merge/20995 should do it :)19:34
kfogeldidrocks: note I'm not a reviewer, but I can comment19:34
didrockskfogel: sure, I guess the branch is quite in a good state (and if it can help to get an hack by flacoste or gmb, it will be good :))19:35
kfogeldidrocks:  what is the change at @@ -519,8 +520,8 @@ for?  It seems to be unrelated to this change.19:37
didrockskfogel: right, it was when I worked with jml as he liked to have PEP compliant file and it was more than 80 character IIRC :)19:39
kfogeldidrocks: well, phooey on jml for introducing unrelated changes, but I suppose he's far away over the water and I can't reach him :-).19:39
didrocksit should be in a separate commit, not sure as it's quite old now :)19:40
flacostedidrocks: we usually refrain from exposing DB id publically (in URL especially) could we use the keyid there instead?19:40
kfogeldidrocks: I see you have flacoste now, I cede the floor to him as he's actually competent to review this (witness the above comment).19:42
didrocksflacoste: I didn't find any keyid key in the file, hence exposing the id, what should be exposed?19:42
didrockskfogel: thanks in any case ;)19:42
flacostedidrocks: there is keyid19:45
flacostedidrocks: and you have IGPGKeySet.get(key_id)19:45
flacosteit will also make the URLs printed in the test stable19:46
didrocksflacoste: I'm starting my VM right now and check again on the file, one sec19:46
james_wdidrocks: your tests don't seem to be doing as they state19:46
flacostedidrocks: err19:46
james_wdidrocks: it says that the user should have no ssh keys to start with, but they have 1, then it says it is adding an ssh key and adds a GPG key19:46
flacostedidrocks: i'm looking at GPGKey, you are doing SSH! doh!19:47
didrocksflacoste: yes, it's SSH :)19:47
james_wplus, should the collection link be <person>/sshkeys or <person>/+ssh-keys?19:47
flacostedidrocks: yeah, that's fine then19:47
flacostejames_w: it should be sshkeys, collection field have the field name19:48
flacosteuse the field names19:48
flacosteit could be renamed though19:48
flacostethe field could be calles ssh_keys19:48
james_wok, I need to fix code-import then I think19:48
flacostejames_w: does it work?19:49
james_wyes19:49
flacostehmm19:49
flacostethen it might not be a problem19:49
flacostei recall that we have special traversal logic to look for a collectionfield19:49
didrocksjames_w: right, I have to fix the testsuite so19:50
james_woh, sorry, code_imports isn't a collection, it's a single object19:50
james_w<branch>/+code-import19:50
flacostejames_w: right19:54
flacostethat's different19:54
flacostecollection field must use the same name19:54
flacostenot even sure exported_as would work here19:54
sinzuimars: That looks good to me19:55
flacosteyeah, it doesn't19:56
marssinzui, ok, I tried the patch, wasn't the issue.  Another hypothesis: the CSS does not come from the same domain as the HTML.19:56
* flacoste files a bug19:56
marssinzui, and the homepage is caching properly!  (where everything does come from the same URL)19:56
marss/URL/domain/19:56
marssinzui, in a template, how do I pull the current vhost?  base-layout-macros is pulling the mainsite root domain URL right now.19:57
marssinzui, looking at line 281, base-layout-macros.pt19:57
marsmaybe I could just make the URL relative19:59
marsso use /+icing instead of foo.bar.com/+icing19:59
sinzuimars: I am confused here. when the url is relative the browser always makes the request to the same domain.19:59
sinzuiif I load https://launchpad.net/ and am loading https://launchpad.net/+icing/style.css20:00
marssinzui, looks like base-layout-macros.pt is setting up an absolute URL, not a relative URL.  I might be able to change that.20:00
sinzuimars: I understand you caching issue when I am on the bugs vhost, but when I am on the mainsite, there the URLs are the same.20:02
marssinzui, yep.  Experimenting now.  I'll let you know how it goes.20:03
didrocksjames_w: so, name12 has an ssk key, do you know other users that I can put in the testsuite without one?20:06
james_wdidrocks: you could use the factory20:07
james_wperson = factory.makePerson(name="ssh-user")20:07
didrocksjames_w: thanks, sounds easy to create a user :)20:07
flacostedidrocks: review reply sent20:08
flacostedidrocks: basically I suggest you use another user (no-priv) and use makeSSHKey instead of makeGPGKey in the test (and a couple of related suggestions)20:08
didrocksflacoste: ok, thanks, I'm fixing that20:08
didrocksflacoste: I'm just wondering how we can find the ssh public key id so. is it the keytext?20:17
flacostedidrocks: yes20:17
didrocksflacoste: ok, make sense :)20:18
marssinzui, gary, it worked!  http://www.webpagetest.org/result/100324_68A1/1/details/cached/20:21
gary_postermars, heh, awesome :-)20:22
marsstill fishy though.  Why does Mochikit refuse to die?20:22
sinzuibecause no one has time to convert the old hide/show js rules to yui...20:23
marsgary_poster, here is what we had before: http://www.webpagetest.org/result/100324_689B/1/details/cached/20:23
marsstrange strange.  launchpad.js disappeared all on its own?20:23
sinzuimars: since no one is adding a feature to replace the rules, there is little incentive to update the callsites20:23
gary_posterfewer bytes, but same net time :-/20:24
marswow20:24
mars40%? fewer bytes20:24
marsand two fewer requests.  Something really fishy here.20:25
marssee?  The request for the lp-gem 64x64 logo disappeared as well20:26
marsand here is what is used to look like.  10 requests, 183KB weight: http://www.webpagetest.org/result/100308_5SEE/1/details/cached/20:26
marsIt shaved 1.2 seconds off the load time at least.20:27
marsInternet Explorer is insane.  It is the only rational explanation.20:31
gary_postermars, you said "here is what we had before: http://www.webpagetest.org/result/100324_689B/1/details/cached/ " and then you said "here is what is used to look like.  10 requests, 183KB weight: http://www.webpagetest.org/result/100308_5SEE/1/details/cached/ "  Quick clarification of what is what?20:36
sinzuigary_poster: ping20:51
gary_postersinzui: pong, but high latency20:51
sinzuigary_poster: I was going to add a simple link to https://login.launchpad.net/ for users to change their password from the person+edit page. But I see the new SSO page, and I wonder if it would be better to add a "Manage your account" to the person profile page (where the Change password link was)20:53
gary_postersinzui: and where would this link?  We are planning to be a true openid consumer sometime this year, so if the link would be to login.launchpad.net, then that would be a problem.20:56
sinzuiokay, we have a bigger problem then...20:57
sinzuigary: users do not know how to change their password. We took the link away.20:57
marsgary_poster, the second link, with 10 requests, was recorded at the beginning of the month.  The first link you replied with has changed the <style>@import()</style> to a <link>.20:57
gary_postermars: ah, cool20:58
marsgary_poster, so changing @import to <link> added one cache hit, seemingly without reason.  Changing the <link> domain added yet another cache hit.20:58
marsoh, two, actually.20:58
gary_postersinzui: ok how is this for a plan20:59
marsonce again, without reason.20:59
gary_postersinzui: add a simple link now.20:59
sinzuigary_poster: I can mark the bug as wontfix, and let chr deal the frustrated users, or we provide a link for the user to do this. maybe the answer is that we include a link from the profile page to an faq explaining that the user needs to find the login site and we do not know what that is20:59
gary_postersinzui: when we switch to random openid, we sniff.  if canonical, then we show the link21:00
gary_posterif otherwise, we link to wiki page as you describe21:00
sinzuigary_poster: then maybe we should always link the the faq (we already have one) and the let the user use the link from the faq21:00
gary_postersinzui: ok, +1, easier21:01
didrocksflacoste: ok, I guess I fixed what needed to be fixed. When you have some time, if you can give it a look, it would be awesome: https://code.edge.launchpad.net/~didrocks/launchpad/expose-sshkeys-bug-357235/+merge/22067 Thanks! (just saw there is a conflict in configure.zcml now, but it's just removing the conflict tag and add the ssh exposal, if you want me to do this, feel free to ping me :))21:07
flacostedidrocks: just approved it21:09
didrocksflacoste: sweet, thanks!21:09
flacostedidrocks: i'm in the middle of an update and haven't use ec2 land since last month, so i'm not reliable to land this21:10
flacostedidrocks: you can bribe anyone on the team to land it for you though21:10
didrocksflacoste: ok, I'll ping people tomorrow :) I can ping everyone on the LP team or should they be in a particular area of LP?21:11
flacostedidrocks: anyone21:14
didrocksflacoste: ok, thanks a lot :) good luck with your update!21:14
flacostethanks, it's finishing downloading, i'll know how lucky i am in a few minutes21:15
didrocksheh21:15
mwhudsondidrocks: i can land your branch21:16
didrocksmwhudson: great, do you need anything on my side? (the related bug is in the branch name)21:16
mwhudsondidrocks: i guess i need you to push the revision that fixes the conflict21:17
didrocksmwhudson: sure, so I merge with ~launchpad-pqm/launchpad/devel/ right?21:18
mwhudsonyes21:18
marssinzui, fixed the JS domains: a 58% speedup overall!  \o/21:24
marssinzui, http://www.webpagetest.org/result/100324_68B9/1/details/cached/21:24
sinzuiwow21:24
marsfrom 5.28s to 2.24s21:25
marsnow, tea!21:26
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk
didrocksmwhudson: should be ok now21:37
mwhudsondidrocks: i don't see  a new revision in the branch21:39
didrocksmwhudson: sorry, the push wasn't finished, my VM is slow :/ it's ok now21:41
lifelessis there a VM suitable for lp development around ?21:44
rockstarlifeless, I have one that I stealed from abentley earlier this year.21:46
rockstarOf course, it's 10GB, and I think that may cost you a lot if you're in a country that charges by data transfer.21:46
rockstarlifeless, I've been working on a script that will shoehorn rocketfuel-setup into a chroot.  I've found the chroot is more helpful for what I want.21:47
lifelesscool21:48
lifelessWell, I'll roll my own VM for now, then.21:48
* rockstar nods21:48
lifelessI just got a new laptop21:48
lifelesswhich should be able to let me do the odd lp thing without excruciating pain21:48
rockstarlifeless, congrats! Boy or girl? Weight? Size?  :)21:49
lifelesslenovo x201s, 8G and 128G SSD21:49
* rockstar wonders if he can convince his wife he needs a new laptop.21:54
mwhudsondidrocks: argh, it seems you should have merged  ~launchpad-pqm/launchpad/db-devel/ not devel :/22:00
didrocksmwhudson: oh isn't what I wrote above? no pb, can uncommit, revert, remerge and push --overwrite22:02
mwhudsondidrocks: that would be better it think, thanks22:05
* mwhudson apologizes for launchpad's slightly bonkers development process22:05
didrocksmwhudson: I'm used to strike with Launchpad when I thought about contributing. That's ok, still happy that my changes can land :)22:08
didrocksmwhudson: seems to be pushed :)22:08
marslifeless, gary_poster and bigjools both run them.  bigjools has instructions that I've been meaning to get from him.22:11
lifelessit would be nice if it was as simple as bzr; I don't think thats on the cards anytime soon :)22:12
marslifeless, how about "lp-vmbuilder --from-branch=lp:foo" ?22:15
mwhudsondidrocks: one last think, can you set a commit message in the merge proposal?22:15
mwhudsonthing not think22:15
mwhudson(the diff looks much saner now)22:15
marslifeless, that is about all you need really, isn't it?  vmbuilder to do the bundling, and a script in a bazaar branch to bootstrap the process.22:15
didrocksmwhudson: I don't get the "set a commit message in the merge proposal". On the Launchpad merge proposal page? (don't know where to add that)22:16
mwhudsondidrocks: just under "Tis proposal supersedes a proposal from 2010-03-10." on the merge proposal page22:17
lifelessmars: thats today, or as a vision of the future ?22:17
marslifeless, preferably near future.  bigjools and gary know how to do it, we just have to script it and share it.22:18
didrocksmwhudson: oh, never noticed that. sweet :) and done (short but descriptive, I guess)22:19
marsvm-based development was one thing the Lean training came up with as a solution to a number of developer issues.22:19
mwhudsondidrocks: thanks!22:19
didrocksmwhudson: thanks to you!22:19
lifelessmars: so, that would be interesting, but its still a much higher barrier than bzr has, even bzr-loggerhead22:20
marslifeless, yeah, true.  It could be improved towards a bzr-like setup, but I think dev's need to fiddle with systems-level things like apache get in the way, too.22:23
marslifeless, and adding another level of abstraction is so much easier22:23
lifelessmars: all problems in CS can be solved by adding a layer of abstraction, except ...22:24
lifelesshaving too many layers of abstraction22:24
mars:D22:24
jelmerlifeless: except performance problems :-P22:24
lifelessjelmer: sometimes they can be solved that way, othertimes they are instances of 'too many layers' ;)22:24
jelmer:-)22:25
marssinzui, oops, my calculations were wrong.  Turns out the IE improvements result in a 66% speedup.22:25
thumpersomeone want to tackle the conflict in stable -> db_devel?22:26
mwhudsonsome kind of user-local /etc/hosts file would sure help with launchpad22:27
marslifeless, off the top of my head, some problems with a bzr-like setup for LP dev: It is difficult to see a path to it; Some devs need Apache, Postgres, etc.;  It takes longer than just wrapping everything in a VM22:27
marstwo problems of perception, one of technique22:28
lifelessmars: so, bzr devs need gcc, pyrex etc too - deps are deps.22:29
lifelessapache, pgsql can be privately configured as regular users - there are even [shudder] buildout recipes I think22:29
marslifeless, yeah, but isolating Apache for local use by code?  I think you would have to ask mwhudson how easy that would be :)22:30
lifelessI think the key thing I'm agitating for is not needing to alter system parameters to do tests - essentially the same isolation we'll want to do concurrent test runs anyway22:30
lifelessmars: its easy22:30
marsbuild recipes?  wow.22:30
lifelessmars: isolating apache is pretty straight forward (if a little verbose). Definitely tractable, and once the code is written, its written.22:31
marslifeless, I guess the question to ask then is: If the work has always been straight-forward, why haven't we done it?22:34
lifelessmars: people may not have considered it straight forward22:34
lifelessfear-of-the-unknown perhaps22:34
marsGot repeat-view pages times down to 3.6 seconds in China.  Much better.22:40
marsAnd a bit more work can drop that to 2.6 seconds.22:41
marsAnd if we drop SSL: 1.6 seconds.22:42
thumpermars: can you make it faster in nz too please :)22:42
marsthumper, dropping SSL is your only hope!22:43
thumper:(22:43
mwhudsondidrocks: your branch is away in ec2 fwiw22:46
didrocksmwhudson: sweet! Thanks ;-)22:47
marslifeless, you wouldn't happen to know how Zope serves resources like /@@/product-logo, would you?22:54
marslifeless, I'm looking to add Cache-control headers to the response22:54
marslifeless, actually, nevermind.  It is probably better to turn them into real image resources coming from +icing, same as every other static resource.22:58
thumper:(23:05
mwhudsonoops, i need to merge _stable_ into db-devel23:18
mwhudsonnot devel23:18
=== _thumper_ is now known as thumper
mwhudsonlunch time23:22
* thumper is installing lucid for the second time today23:32
thumperholy crap23:32
thumper1818M will be downloaded23:33
thumperonto my poor little laptop23:33
thumperthat's what you get for having both kubuntu-desktop and ubuntu-desktop installed23:33
* thumper goes to get some lunch while it downloads23:34
wgrantSo, I'm guessing that the OCR topic in #launchpad-meeting last night referred mostly to me.23:37

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!