=== mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell [14:02] #startmeeting [14:02] Meeting started at 09:02. The chair is bac. [14:02] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [14:02] sorry i'm late [14:02] welcome to the LP Reviewers meeting. who is here today? [14:02] me! me! me! [14:02] hi gary_poster! [14:02] hi :-) [14:03] leonardr, mars, salgado reviewer's mtg [14:03] me [14:03] me [14:03] me [14:03] Me [14:03] me [14:03] * gmb , allenap and abel are sprinting [14:03] gmb: thanks [14:03] danilos, bigjools: ping [14:04] sinzui: ping [14:04] me [14:04] bac, sorry, sprinting [14:04] danilos: ok [14:04] (along with the rest of translations team) [14:05] abentley: ping [14:05] me [14:05] flacoste: hi [14:05] [topic] agenda [14:05] New Topic: agenda [14:05] * Roll call [14:05] * Agenda [14:05] * Outstanding actions [14:05] * New topics [14:05] * Peanut gallery [14:05] hi bac [14:06] sorry for the confusion over the time. going forward it is at 1400UTC and i believe is correct on our google calendar [14:06] [topic] outstanding actions [14:06] New Topic: outstanding actions [14:06] [topic] * rockstar to update bugs to reflect new naming convention and will update the style guide [14:06] New Topic: * rockstar to update bugs to reflect new naming convention and will update the style guide [14:07] is rockstar here? [14:07] i'll check with him in the ASIAPAC meeting [14:07] [topic] * bac to update wiki re: interim status of community reviewers and committers [14:07] New Topic: * bac to update wiki re: interim status of community reviewers and committers [14:07] i have not done this. :( [14:07] i did talk to andrewsinclair yesterday but he deferred any opinion to amanda [14:08] i've been trying to talk to her on IRC but haven't been successful [14:08] so, i'll keep this item around [14:08] and, for some very welcome news [14:08] [topic] * leonardr to create an example for automated lplib tests in the launchpad tree. (revisit 24-Mar). [14:08] New Topic: * leonardr to create an example for automated lplib tests in the launchpad tree. (revisit 24-Mar). [14:09] hello [14:09] i just landed the branch that demonstrates this [14:09] take a look in lib/canonical/launchpad/pagetests/webservice/launchpadlib.txt [14:09] me [14:09] there's a Launchpad object available as 'launchpad' [14:10] so you can just do this: [14:10] >>> print launchpad.me.name [14:10] salgado [14:10] leonardr: is it easy to get a non-salgado person or an anonymous one? [14:11] bac: you'd have to set it up in pages.py, similar to anon_browser and anon_webservice [14:11] anonymous access would be easy. i don't know about non-salgado access, because i don't know if there are oauth credentials set up for non-salgado users [14:11] me [14:11] ok. i think it's be useful, especially since we have had problems getting some collections for anonymous access [14:12] yeah, anonymous is easy [14:12] thanks a lot leonardr for setting this up. it'll help close a big gap in our testing. [14:13] sure [14:13] I would like to move webservice/* tests out of stories. but I do not know where to. [14:13] I fear for the performance but that's a separate topic for another day [14:14] * sinzui wonders is interfaces/tests is better, or api/tests [14:15] we have no new items on the agenda [14:15] [topic] peanuts [14:15] New Topic: peanuts [14:15] any one have a discussion topic? [14:16] going once... [14:16] twice... [14:16] oh, i do! [14:16] thanks to abentley for the reminder about +activereviews. please do your part to land or change the status of those festering branches. [14:16] heh [14:17] thanks for coming everyone. have a good day. [14:17] #endmeeting [14:17] Meeting finished at 09:17. === salgado is now known as salgado-lunch === flacoste is now known as flacoste_lunch === Ursinha is now known as Ursinha-lunch === leonardr is now known as leonardr-lunch === salgado-lunch is now known as salgado === flacoste_lunch is now known as flacoste === Ursinha-lunch is now known as Ursinha === leonardr-lunch is now known as leonardr === salgado is now known as salgado-afk [21:31] thumper, mwhudson, rockstar : ping [21:31] hi [21:31] hey y'all around for a quick meeting? [21:32] bac: hi [21:32] yep [21:32] mwhudson: you'll be please i found a 'flood control' setting on my irc client that was not set up right. hope to not repeat the flooding. [21:33] the big news from today's AMEU meeting came from leonard [21:33] he just landed a branch that has an example of how to write launchpadlib tests that get run in our test suite [21:33] that's something we've been needing for a good long time [21:34] ah cool [21:34] "take a look in lib/canonical/launchpad/pagetests/webservice/launchpadlib.txt" [21:34] there is a 'launchpad' object that is connected as salgado [21:35] that location makes me sad [21:35] * rockstar i here [21:35] * thumper wishes for lp/services/webservice/doc or something [21:35] thumper: yeah, sinzui was asking for a better place to put webservice tests [21:35] hi rockstar [21:36] thumper, the type of test is what makes me sad [21:36] leonard said it would be trivial to have a lp object for anonymous testing. he didn't commit to doing it right away so it's open. [21:36] and bigjools is sad that the tests will probably be slow [21:36] we'll make sure it works in unit tests well :) [21:36] we sure are a gloomy lot [21:36] thumper, yes, yes we will. [21:36] bac, :) [21:37] hey rockstar you have an outstanding action item...the details of which i cannot remember. do you? [21:37] bac, yes, and they are done. [21:37] this is what makes me more sad: "pre-authenticated with salgado's permissions" [21:37] why do we insist on continuing with sample data tests? [21:37] cool, rockstar. remind us of what you did [21:37] bac, basically, I needed to change the Javascript coding standards for the new module names. [21:37] particularly given that salgado is an admin in the sample data!! [21:38] ah, right. did you file a bunch of bugs? [21:38] :(( [21:38] ^^ sad and fat? [21:38] rockstar: just really sad [21:38] thumper would you like to voice your sadness on the ML? [21:39] sure [21:39] bac, also, launchpad-ui-reviewers is a good team to use to remind yourself to go find a ui reviewer. [21:39] it's not ideal but i'm glad we've gotten something we can automate [21:39] No one on the team is going to just pick up the requested review, so it's solely up to the reviewee to go find a specific person on the team. [21:40] ok [21:40] bac, can I suggest one thing? [21:40] rockstar: so it's only nominally better than looking at a wiki page [21:40] sure [21:41] bac, so, I have found that the general attitude of the on call reviewer has kinda started feeling like review lackey recently. [21:41] People just come into #launchpad-reviews, pop themselves on the queue, and then disappear. [21:42] rockstar: well, if you don't agree to it beforehand they are supposed to stick around [21:42] and you're free to drop their review if they aren't going to be around for interaction [21:42] I think a nice reminder that it's the submitter's responsibility to get a review and not the reviewer's job to just figure it out. [21:42] it's a good thing to bring up [21:43] bac, yes, I know that. Community contributions tend to have this issue more than anyone else, but I think a gentle reminder might be helpful. [21:43] ok [21:43] rockstar: i'll send out an email to lp-dev [21:43] Last week I came into my review day and saw that 9 people were on a queue that had no OCR. [21:44] rockstar: and i've found people in the queue with no MP in +activereviews [21:44] it's anarchy! [21:44] bac, yeah, it's gotten a little messy. Just a reminder of the social contracts would be helpful. [21:44] good idea. [21:45] any other topics? [21:45] ok, thanks for coming. see you next week. [21:45] nope [21:45] thanks bac [21:45] Thanks bac! [21:45] hey thumper, i saw your comment about squeezeserver [21:46] is it currently not supported in lucid? [21:46] bac, it has been renamed [21:46] squeezeboxserver [21:46] so it's just an irritant? [21:46] for now [21:46] upgrade still in progress [21:47] downloading 1345 of 1749 [21:47] cool. mine is on a gutsy server so i won't be upgrading it until lucid is released [21:47] * thumper nods [21:47] hard to believe it's time for another LTS === _thumper_ is now known as thumper [23:20] bac: Gutsy? Gutsy has been unsupported for a year. Your server is horribly insecure. [23:45] It could be worse.... there's a server running edgy at my office :-(