| === wgrant changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jelmer changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [wgrant,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === wgrant changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [wgrant,jelmer,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === mrevell is now known as mrevell-lunch | ||
| === matsubara-afk is now known as matsubara | ||
| === jamalta_ is now known as jamalta | ||
| === mrevell-lunch is now known as mrevell | ||
| NCommander | bac: any luck with EC2? | 13:45 |
|---|---|---|
| bac | NCommander: running again now without the --headless option so i can keep an eye on it | 13:46 |
| bac | NCommander: tried running locally last night but had failures b/c we have an issue with lucid ATM | 13:46 |
| NCommander | bac: ugh. I feel like I sonehow managed to generate a whole lot of extra work for you | 13:47 |
| bac | NCommander: no! you've given us a nice branch. i'll get it landed for you. | 13:47 |
| leonardr | bac, want to review my fix to your bug? | 14:40 |
| leonardr | https://code.edge.launchpad.net/~leonardr/lazr.restfulclient/shorten-cache-filename-again/+merge/22030 | 14:40 |
| bac | leonardr: sure | 14:41 |
| bac | leonardr: your MP is private again. how do you do keep doing that unintentionally? | 14:42 |
| leonardr | bac: i have no idea | 14:43 |
| leonardr | i think the branch might be private | 14:43 |
| bac | leonardr: it doesn't bother me just thought i'd mention it | 14:43 |
| bac | leonardr: and are you going to release this version and update LP to use it? | 14:44 |
| bac | leonardr: looks great. r=bac | 14:45 |
| leonardr | bac: i'll release it. if it's really bothering you i'll do an lp update, but that's kind of a pain | 14:46 |
| leonardr | i like to do that in batches | 14:46 |
| bac | leonardr: i know, but without it ec2 will not run for people using ecryptfs | 14:46 |
| leonardr | all right, i'll do a launchpad branch | 14:47 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [wgrant,jelmer,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | great | 14:55 |
| === sinzui changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [wgrant,jelmer,wgrant, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-lunch | ||
| === flacoste is now known as flacoste_lunch | ||
| james_w | EdwinGrubbs: hi, a small one for you: https://code.edge.launchpad.net/~james-w/launchpad/fix-webservice-test-isolation/+merge/22040 | 16:09 |
| === matsubara is now known as matsubara-lunch | ||
| EdwinGrubbs | james_w: is it the request.publication.endRequest() that does the same thing as clear_request_started()? I don't understand why you use different methods of cleaning up the tests. | 16:32 |
| james_w | endRequest() calls clear_request_started() and does some other things | 16:33 |
| james_w | In the code I added I just went for symmetry with the test setup | 16:34 |
| EdwinGrubbs | james_w: ok, r=me | 16:34 |
| james_w | I have no real idea what a lot of the rest of endRequest() is doing. Do you know of someone that could advise? | 16:34 |
| === leonardr is now known as leonardr-lunch | ||
| EdwinGrubbs | james_w: I just noticed there are some lint errors that I would like you to clean up. I'll add them to the mp. | 16:35 |
| EdwinGrubbs | james_w: I didn't even notice that Gary had already approved your mp. I guess I really should get some coffee. | 16:36 |
| james_w | ah, neither did I :-) | 16:36 |
| EdwinGrubbs | of course, it is a little confusing that the mp is still in "Needs review" status which is separate from an individual reviewer's approval. | 16:37 |
| EdwinGrubbs | wgrant: which one of your branches would you like me to review first? | 16:46 |
| james_w | EdwinGrubbs: would you still like me to fix the lint? | 16:54 |
| EdwinGrubbs | james_w: don't worry about it, since it has already been reviewed. | 16:58 |
| james_w | great, thanks | 16:58 |
| james_w | would you land it for me please? | 16:58 |
| EdwinGrubbs | james_w: sure | 17:00 |
| james_w | thanks | 17:00 |
| === salgado-lunch is now known as salgado | ||
| === flacoste_lunch is now known as flacoste | ||
| EdwinGrubbs | james_w: is there a bug for that branch? | 17:13 |
| james_w | nope | 17:14 |
| === matsubara-lunch is now known as matsubara | ||
| bac | NCommander: did you see the failure message? | 17:54 |
| === deryck is now known as deryck[lunch] | ||
| NCommander | bac: no | 18:06 |
| bac | NCommander: it should've gone to your gmail acct | 18:06 |
| NCommander | bac: wait, just got it | 18:07 |
| bac | NCommander: your testOversizedFile had a bug in it | 18:07 |
| bac | i can fix it and land | 18:07 |
| NCommander | bac: How'd I break it? | 18:07 |
| NCommander | ugh | 18:07 |
| * NCommander thought he tested this before I submitted >.<; | 18:07 | |
| bac | NCommander: 2*20 * 10 instead of 2**20 * 10 | 18:09 |
| NCommander | bac: d'oh >.<; | 18:16 |
| NCommander | bac: I feel like an idiot now :-/ | 18:17 |
| bac | just a typo | 18:17 |
| NCommander | bac: so re-ec2 it? | 18:19 |
| === deryck[lunch] is now known as deryck | ||
| bac | NCommander: no, i've fixed the test and shown it to work locally. i'll just go directly to pqm with it | 18:20 |
| * bac saves $4 | 18:20 | |
| NCommander | bac: so then pqm will run the test suite, and assuming it doesn't go boom, it will land on db-devel, right? | 18:20 |
| bac | NCommander: not quite. pqm will accept it and later buildbot will bundle up a bunch of revisions and run them together. they all pass or fail together and if they fail we fix and resubmit | 18:21 |
| sinzui | EdwinGrubbs: jml: can either of you comment on bug 538024. I want to submit a patch to address this tomorrow, or I need to make this feature not be released next week. | 18:23 |
| mup | Bug #538024: No way of saying "This project is not packaged" <Launchpad Registry:Triaged> <https://launchpad.net/bugs/538024> | 18:23 |
| bac | NCommander: http://pastebin.ubuntu.com/400701/ | 18:23 |
| NCommander | bac: so if it fails, buildbot goes into textfix mode, right? | 18:31 |
| bac | yes | 18:31 |
| NCommander | bac: sweet. So how does it usually takes to run | 18:38 |
| bac | NCommander: normally pqm is pretty quick, unless a job is in front that needs to run the entire test suite. | 18:39 |
| NCommander | bac: pqm doesn't run the entire test suite? | 18:40 |
| bac | no, that changed a good while ago | 18:41 |
| NCommander | bac: didn't know that | 18:42 |
| NCommander | bac: so how long does it take to run | 18:44 |
| bac | NCommander: PQM? generally about 10 minutes per branch. your branch is 3rd in line | 18:45 |
| NCommander | bac: is there a place to watch? :-) | 18:46 |
| bac | https://pqm.launchpad.net/ | 18:46 |
| === leonardr-lunch is now known as leonardr | ||
| deryck | sinzui, could I request a *very* easy UI review from you? :-) | 19:10 |
| sinzui | yes | 19:11 |
| deryck | sinzui, https://code.edge.launchpad.net/~kirkland/launchpad/532624/+merge/20775 | 19:12 |
| deryck | sinzui, I just want an ack that the renaming is sane, for kirkland's branch. | 19:12 |
| deryck | makes sense to me, but since this is from before my time and all :-) | 19:13 |
| sinzui | deryck: They get my +1 | 19:13 |
| deryck | sinzui, excellent, thanks! | 19:14 |
| deryck | sinzui, I requested a review from you on that MP, just to get the rubberstamp "approved" | 19:27 |
| EdwinGrubbs | sinzui: I commented on bug 538024. I can review your brimstone-and-treacle branch now. | 20:12 |
| mup | Bug #538024: No way of saying "This project is not packaged" <Launchpad Registry:Triaged> <https://launchpad.net/bugs/538024> | 20:12 |
| sinzui | fab and fab | 20:12 |
| leonardr | edwin, i have 2 very simple branches that need review | 20:50 |
| leonardr | https://code.edge.launchpad.net/~leonardr/launchpadlib/use-1.0/+merge/22064 and https://code.edge.launchpad.net/~leonardr/launchpad/lucid-updates/+merge/22065 | 20:51 |
| NCommander | bac: sweet. my branch merged!. So, next stupid question, when will db-devel be merged into db-staging? | 21:02 |
| bac | NCommander: some light reading: https://dev.launchpad.net/Trunk | 21:03 |
| bac | with pretty pictures | 21:03 |
| NCommander | bac: oops >.<; | 21:05 |
| * NCommander hangs head | 21:05 | |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [wgrant,jelmer,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
| === sinzui changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [wgrant,jelmer,wgrant,sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [wgrant,jelmer,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === _thumper_ is now known as thumper | ||
| wgrant | EdwinGrubbs: Sorry, I meant to be around, but no EU reviewer appeared. | 23:27 |
| wgrant | (and there is no APAC OCR) | 23:27 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!