/srv/irclogs.ubuntu.com/2010/03/24/#launchpad-reviews.txt

=== wgrant changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== jelmer changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [wgrant,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== wgrant changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [wgrant,jelmer,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== mrevell is now known as mrevell-lunch
=== matsubara-afk is now known as matsubara
=== jamalta_ is now known as jamalta
=== mrevell-lunch is now known as mrevell
NCommanderbac: any luck with EC2?13:45
bacNCommander: running again now without the --headless option so i can keep an eye on it13:46
bacNCommander: tried running locally last night but had failures b/c we have an issue with lucid ATM13:46
NCommanderbac: ugh. I feel like I sonehow managed to generate a whole lot of extra work for you13:47
bacNCommander: no!  you've given us a nice branch.  i'll get it landed for you.13:47
leonardrbac, want to review my fix to your bug?14:40
leonardrhttps://code.edge.launchpad.net/~leonardr/lazr.restfulclient/shorten-cache-filename-again/+merge/2203014:40
bacleonardr: sure14:41
bacleonardr: your MP is private again.  how do you do keep doing that unintentionally?14:42
leonardrbac: i have no idea14:43
leonardri think the branch might be private14:43
bacleonardr: it doesn't bother me just thought i'd mention it14:43
bacleonardr: and are you going to release this version and update LP to use it?14:44
bacleonardr: looks great.  r=bac14:45
leonardrbac: i'll release it. if it's really bothering you i'll do an lp update, but that's kind of a pain14:46
leonardri like to do that in batches14:46
bacleonardr: i know, but without it ec2 will not run for people using ecryptfs14:46
leonardrall right, i'll do a launchpad branch14:47
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [wgrant,jelmer,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
bacgreat14:55
=== sinzui changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [wgrant,jelmer,wgrant, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado is now known as salgado-lunch
=== flacoste is now known as flacoste_lunch
james_wEdwinGrubbs: hi, a small one for you: https://code.edge.launchpad.net/~james-w/launchpad/fix-webservice-test-isolation/+merge/2204016:09
=== matsubara is now known as matsubara-lunch
EdwinGrubbsjames_w: is it the request.publication.endRequest() that does the same thing as clear_request_started()?  I don't understand why you use different methods of cleaning up the tests.16:32
james_wendRequest() calls clear_request_started() and does some other things16:33
james_wIn the code I added I just went for symmetry with the test setup16:34
EdwinGrubbsjames_w: ok, r=me16:34
james_wI have no real idea what a lot of the rest of endRequest() is doing. Do you know of someone that could advise?16:34
=== leonardr is now known as leonardr-lunch
EdwinGrubbsjames_w: I just noticed there are some lint errors that I would like you to clean up. I'll add them to the mp.16:35
EdwinGrubbsjames_w: I didn't even notice that Gary had already approved your mp. I guess I really should get some coffee.16:36
james_wah, neither did I :-)16:36
EdwinGrubbsof course, it is a little confusing that the mp is still in "Needs review" status which is separate from an individual reviewer's approval.16:37
EdwinGrubbswgrant: which one of your branches would you like me to review first?16:46
james_wEdwinGrubbs: would you still like me to fix the lint?16:54
EdwinGrubbsjames_w: don't worry about it, since it has already been reviewed.16:58
james_wgreat, thanks16:58
james_wwould you land it for me please?16:58
EdwinGrubbsjames_w: sure17:00
james_wthanks17:00
=== salgado-lunch is now known as salgado
=== flacoste_lunch is now known as flacoste
EdwinGrubbsjames_w: is there a bug for that branch?17:13
james_wnope17:14
=== matsubara-lunch is now known as matsubara
bacNCommander: did you see the failure message?17:54
=== deryck is now known as deryck[lunch]
NCommanderbac: no18:06
bacNCommander: it should've gone to your gmail acct18:06
NCommanderbac: wait, just got it18:07
bacNCommander: your testOversizedFile had a bug in it18:07
baci can fix it and land18:07
NCommanderbac: How'd I break it?18:07
NCommanderugh18:07
* NCommander thought he tested this before I submitted >.<;18:07
bacNCommander: 2*20 * 10 instead of 2**20 * 1018:09
NCommanderbac: d'oh >.<;18:16
NCommanderbac: I feel like an idiot now :-/18:17
bacjust a typo18:17
NCommanderbac: so re-ec2 it?18:19
=== deryck[lunch] is now known as deryck
bacNCommander: no, i've fixed the test and shown it to work locally. i'll just go directly to pqm with it18:20
* bac saves $418:20
NCommanderbac: so then pqm will run the test suite, and assuming it doesn't go boom, it will land on db-devel, right?18:20
bacNCommander: not quite.  pqm will accept it and later buildbot will bundle up a bunch of revisions and run them together.  they all pass or fail together and if they fail we fix and resubmit18:21
sinzuiEdwinGrubbs: jml: can either of you comment on bug 538024. I want to submit a patch to address this tomorrow, or I need to make this feature not be released next week.18:23
mupBug #538024: No way of saying "This project is not packaged" <Launchpad Registry:Triaged> <https://launchpad.net/bugs/538024>18:23
bacNCommander: http://pastebin.ubuntu.com/400701/18:23
NCommanderbac: so if it fails, buildbot goes into textfix mode, right?18:31
bacyes18:31
NCommanderbac: sweet. So how does it usually takes to run18:38
bacNCommander: normally pqm is pretty quick, unless a job is in front that needs to run the entire test suite.18:39
NCommanderbac: pqm doesn't run the entire test suite?18:40
bacno, that changed a good while ago18:41
NCommanderbac: didn't know that18:42
NCommanderbac: so how long does it take to run18:44
bacNCommander: PQM?  generally about 10 minutes per branch.  your branch is 3rd in line18:45
NCommanderbac: is there a place to watch? :-)18:46
bachttps://pqm.launchpad.net/18:46
=== leonardr-lunch is now known as leonardr
derycksinzui, could I request a *very* easy UI review from you? :-)19:10
sinzuiyes19:11
derycksinzui, https://code.edge.launchpad.net/~kirkland/launchpad/532624/+merge/2077519:12
derycksinzui, I just want an ack that the renaming is sane, for kirkland's branch.19:12
deryckmakes sense to me, but since this is from before my time and all :-)19:13
sinzuideryck: They get my +119:13
derycksinzui, excellent, thanks!19:14
derycksinzui, I requested a review from you on that MP, just to get the rubberstamp "approved"19:27
EdwinGrubbssinzui: I commented on bug 538024. I can review your brimstone-and-treacle branch now.20:12
mupBug #538024: No way of saying "This project is not packaged" <Launchpad Registry:Triaged> <https://launchpad.net/bugs/538024>20:12
sinzuifab and fab20:12
leonardredwin, i have 2 very simple branches that need review20:50
leonardrhttps://code.edge.launchpad.net/~leonardr/launchpadlib/use-1.0/+merge/22064 and https://code.edge.launchpad.net/~leonardr/launchpad/lucid-updates/+merge/2206520:51
NCommanderbac: sweet. my branch merged!. So, next stupid question, when will db-devel be merged into db-staging?21:02
bacNCommander: some light reading: https://dev.launchpad.net/Trunk21:03
bacwith pretty pictures21:03
NCommanderbac: oops >.<;21:05
* NCommander hangs head21:05
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [wgrant,jelmer,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk
=== sinzui changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [wgrant,jelmer,wgrant,sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [wgrant,jelmer,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== _thumper_ is now known as thumper
wgrantEdwinGrubbs: Sorry, I meant to be around, but no EU reviewer appeared.23:27
wgrant(and there is no APAC OCR)23:27

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!