[00:24] mwhudson, someday, we'll need to clear out all those merge proposals for loggerhead [00:24] I feel very bad for all the unused code :( [00:24] morning [00:25] is it possible (via bzr-svn) to set a file property [00:26] beuno: yeah, me too [00:33] * hazmat wonders if a web browser on a bzr repository can be fast [00:39] I feel so fumble fingered on this new keyboard [00:41] lifeless: Is that your new envy-inducing laptop of supreme power? [00:41] yes [00:41] its not actually /that/ fast [00:42] as its a mobile edition, its relatively slow clock rate (2.13Ghz, idling at 1.2Ghz) [00:42] but the memory is really nice [00:42] and the SSD is pretty zippy [00:42] And it's quad-core, isn't it? [00:42] bzr selftest --parallel=fork took 6 minutes [00:42] 2 core, with threads so linux sees 4 cpus [00:44] Aaah. Still, 8gb of ram must be all sorts of fun. [00:44] yes [00:44] once i finish bugfixing ubuntu-vm-builder I'm going to make a lucid VM for lp patches [00:45] I've got 20G free, which is strange [00:45] I had a 60GB disk in my old laptop [00:45] rsynced across, and I have 86G used === verterok_ is now known as verterok [00:46] there is 5 GB in a recovery partition I didn't have the heart to blow away, and 1GB in swap, just in case it really wants it [00:47] What laptop is this? [00:47] Meths: my new one [00:48] make/model? [00:48] x201s [00:48] i7 640, 8G ram, 128G samsung SSD [00:49] pretty sweet [00:49] yeah :) [00:50] a separate vm so that it doesn't mess with your general system configuration? [00:50] yeah [00:50] I dont' want pgsql and apache running when I'm flying to $destination [00:50] and i'd forget to shut em all off if I had them installed-and-running by default [00:50] mm me too [00:51] is it possible (via bzr-svn) to set a file property [00:56] hazmat: no === jelmer_ is now known as jelmer [01:35] james_w, we'd especially like to get it in for https://bugs.edge.launchpad.net/bzr/+bug/521989 [01:35] Ubuntu bug 521989 in bzr "errors when importing WorkingTree on a thread due to signals" [Undecided,Confirmed] [01:36] ah, hi [01:36] is it bugfix only? [01:39] our x.y.z, z>0 releases will always be bugfix only [01:39] poolie: could you send me a mail and I will look tomorrow? IRC is too easy to forget. [01:39] fsvo 'always' i guess :) [01:39] should be a 2 minute job for me in that case [01:39] thanks, i will [01:39] yeah, there's bugfix an there's bugfix :-) [01:56] sent [02:00] loggerhead needs alot of love [02:02] hazmat: yeah [02:02] mwhudson, is there anyone with dedicated time on loggerhead? [02:03] hazmat: as much as anyone, it's me, but i've been doing other things lately [02:05] doesn't max? [02:05] doesn't max what? [02:06] poolie: true [02:06] have some time on loggerhead [02:06] i don't know if that's still true [02:12] a couple things worth looking at.. switching out to chamelon for page templates, use an aggregate js file, slimming down the html by using css. [02:12] Another new templating language? Sounds fun. [02:12] Peng: it's another implementation of the same one [02:12] its a page template engine, almost entirely compatible with the existing templates [02:12] Oooh. Neato. [02:12] god knows simpletal isn't very nice [02:13] its mostly faster because it compiles out to python code, instead of a using a template engine interpreter [02:13] FWIW, I wrote code to use Yahoo!'s aggregate JS file for YUI. Nothin' for Loggerhead's JS, though. [02:15] it would be nice if loggerhead didn't have to scan the repo and (re)build a cache to serve, but its not clear if that can be worked around, i assume that's mostly to avoid xml parse [02:16] hazmat: we don't use xml these days [02:16] hazmat: Patches welcome. :P [02:16] hmm.. so perhaps the loggerhead whole history cache is uneeded [02:16] Seriously, though, re-evaluating that is on the to-do list. [02:16] i notice trac-bzr doesn't bother with it.. it actually seems reasonably fast on a small repo [02:17] Not all repos are small. [02:17] Peng, i no.. i'm using the launchpad repo as my test case for performance analysis of loggerhead. [02:17] s/no/know === mnepton is now known as mneptok [02:17] <3 [02:59] is there a way i can see what a pull will bring in without actually doing it [03:00] hazmat: "bzr missing" [03:00] Peng, thanks [03:01] hazmat: That shows what both pull and push would do. See "bzr help missing" for the arguments to pass if you only want to see one or the other. [03:01] poolie: pm? [03:03] Eep. [03:04] I broke poolie. :( [03:06] Now you have to take his place. [03:19] i looking at bug #304320 seems easy enough to add --clean-obsolete-packs option [03:19] Launchpad bug 304320 in bzr "bzr pack should (optionally?) delete obsolete packs" [High,Confirmed] https://launchpad.net/bugs/304320 [03:21] in order to actually delete the dir contents i am thinking of adding an additional parameter to transport.delete_tree that allows skipping delete for container [03:21] http://pastebin.com/JbaQhzxD [03:21] this should ensure that if the operation is terminated for some reason .bzr/repository/obsolete_packs folder is still there. is this a reasonable approach? [03:30] parthm: I think that's reasonable. You should add a per_transport test for the new param. [03:30] mm [03:30] spiv: thanks for the pointer. i will add the per_transport tests. [03:30] there is functionality to delete the contents of obsolete_packs already [03:31] Please don't use the transport api to get at the private functionality of the repository - use that existing code instead. [03:32] Hello. How to use keywords plugin? I can't understand where do i need to place rules file [03:32] lifeless: where can I find this function? bzrlib.repository? [03:37] parthm: bzrlib.repository.repofmt/pack_repo.py - somewhere in there [03:37] obsolete packs is cleaned out when we do a pack - right before we do the pack. [03:37] lifeless: i see a private method, repofmt.pack_repo._clear_obsolete_packs. [03:37] yup [03:37] its a private task :) [03:38] add a parameter to the pack() call - something like 'assume_disk_will_write_immediately' or the like - its very risky deleting obsolete_packs folder, we really don't want people using this in API code in a casual manner [03:38] its particularly unsafe to use over SFTP/HTTP/NFS [03:39] lifeless: i agree, i have added this to the pack command help. [03:39] http://pastebin.com/JbaQhzxD [03:39] assume_immediate_write sounds like a good way to do it. [03:41] parthm: on the transport change, which might be nice in and of itself, how about 'children_only' rather than 'skip_container' [03:41] container isn't used elsewhere in the docs for transports [03:41] yes. children_only sounds good. maybe i should file it as a bug so it can be tracked separately. [03:41] sure [03:42] i was wondering if it makes sense to have a --clean-obsolete-packs-only option. pack can sometimes be time consuming. this would give the user to just remove obsolete packs without going through pack process. [03:44] sure [03:44] there may be a bug on that even [04:02] I notice that only RepositoryPackCollection has a _clean_obsolete_packs method and not KnitPackRepository. both have the pack method. whats the different between the two? [04:05] RepositoryPackCollection is not an implementation of the Repository interface [04:05] It's an implementation of ._pack_collection of (pack format) repositories. [04:05] So, the difference is different layers. [04:08] spiv: ah. i get it. so repository.pack internally maintains _pack_collection which it calls pack on. thanks. [06:04] Anyone know off hand the Subversion equivalent of `bzr revert`? Is there one? [06:05] AfC: svn revert -R . ? [06:06] hm [06:06] oh [06:06] how did I not see that. Grrr [06:06] sorry. Thanks mwhudson [06:14] mwhudson: 'bzr revert' [06:14] Yeah, use bzr-svn. :D [06:55] i am planning to add tests for bug #304320 to tests.blackbox.test_pack http://pastebin.com/C51qWKUH [06:55] Launchpad bug 304320 in bzr "bzr pack should (optionally?) delete obsolete packs" [High,In progress] https://launchpad.net/bugs/304320 [06:55] is the pack operation guaranteed to generate packs? [06:56] i am thinking of doing a transport.list_dir() and making sure its len is 0 [06:56] with --clean-obsolete-packs [07:03] parthm: its not guaranteed, no - but pragmatically thats fine [07:03] just do two commits, then a pack. [07:03] (because one commit would be fully packed already) [07:04] if, in future, we change bzr to auto clean when we can tell things have hit disk or whatever, we can change the test. [07:05] lifeless: right now when are the obsolete packs cleared? [07:05] parthm: when bzr packs [07:06] lifeless: ok. i will go with the two commits approach. thanks. [07:32] hi all! [07:35] vila: hi [07:40] is there a way to put a print in a test case and view it? selftest -v doesn't seem to do it. [07:44] parthm: if you're running blackbox tests, keep in mind that stdin/stdout/stderr are redirected.... [07:45] parthm: which also means you can't put pdb breakpoints in the code run by the inner run_bzr [07:46] vila: yes. i am using the blackbox tests. right now i just dump the info i need into a temp file but i think that a very crude way. [07:48] parthm: try to write whitebox tests instead :) [07:48] vila: ok. thanks :) [07:49] parthm: they are generally far more precise and easier to debug too :) === dcoles_ is now known as dcoles [08:15] jelmer_: Just to check I'm understanding you correctly with that bug, bzr serve --git _can't_ serve bzr branches? Only bzr-git ones? [08:43] hi vila [08:43] hi Ian [08:54] * igc dinner === nlisgo_ is now known as nlisgo [09:03] dcoles: yes [09:04] jelmer_: Ah. OK. [09:05] Then my other bug was when you try and serve git branches in a shared repo [09:05] I'll make a working test and then report that. === weigon_ is now known as weigon === jelmer_ is now known as jelmer [11:56] lifeless: I just read your comment about the news_merge plugin in https://code.launchpad.net/~gagern/bzr/bug513322-first/+merge/22045 [11:56] Hadn't known there was such a plugin. Does pqm make use of it? I assume it does. [11:56] What got me worried was the fact that the launchpad merge preview reported conflicts. I guess this is difficult to avoid right now, because the per-branch configuration isn't versioned. So launchpad users would have to configure each of their branches, which requires a lot of UI and work. [11:56] I think it would be better if one could configure the plugin in such a way that it works on all branches. To me that sounds like an application of the proposed .bzrmeta directory. Has this been discussed before? [12:05] BTW: That config issue makes me think of another thing I've been repeatedly thinking about recently: handling of ZIP files. [12:05] There is quite a number of file formats out there that are ZIP under the hood, but handled as a single document by some application, and usually have a file name extension other than ZIP. Examples are Microsoft OOXML, Google KMZ, Apple iWork formats, JAR files, and so on. [12:05] I often would have wished for a plugin to handle these things as a single ZIP in a working tree, but as a directory of members inside the branch. I guess I'd wish for morege conflicts to cause directory layout in the working tree as well, until those conflicts are resolved. [12:05] I don't have the time to implement this, but I'd still be interested in your opinion. Do you think this useful? Feasible? How would you want to configure such a plugin? Can you think of use cases likely to cause trouble I haven't thought of yet? Do you know of any efforts in that direction? [12:22] * igc night === salgado_ is now known as salgado [12:28] hello, anyone here using zsh? [12:32] dipnlik: not me, but I'm still curious why you're asking. [12:33] MvG: i'm having autocomplete issues when i'm on a repository folder [12:34] I'm the one maintaining bash-completion-plugin. [12:34] cd ~/my-repo ; bzr st gives me an error [12:34] I haven't looked at how zsh completion works, but I would assume that it should be possible to extens my plugin for zsh if there is need and some help. [12:34] bzr: ERROR: Not a branch: "/Users/dip/my-repo/.bzr/branch/": location is a repository [12:35] * MvG is looking at the zsh completion script right now. [12:36] OK, the zsh completion works on file names, not only command arguments. In that case, sensible autocompletion is harder, and also slower because it usually requires a call to bzr. [12:38] dipnlik: If the path only contains a repo and no branch or working tree, then running the status command, the only completion to "st" that I can see, doesn't make too much sense, does it? [12:39] dipnlik: zsh does execute "bzr ls --versioned", which should give you the same error message. [12:39] Of course, if you want to print the status of some file in some subdir, that would be a different thing... [12:40] i'm on a repo with some branches on it [12:40] i only wanted to autocomplete the branch name for the bzr ls command [12:42] In my opinion, the zsh completion is either too clever, or not clever enough. [12:42] that's what I think too [12:42] For bash for example, I only complete command arguments, but not file and directory names, as for the latter the built-in completion tends to be better. Therefore this kind of problem doesn't occur with my bash completion. [12:43] s/command arguments/command options/ [12:43] that's nice [12:44] so, I think it's more a zsh problem than a bzr problem, right? [12:44] I think it's a problem of whoever wrote the zsh completion script. [12:45] Which seems to be Steve Borho in 2005. [12:45] ouch >.< [12:46] Judging from the log, the script is unmaintained since then. [12:47] isn't Steve Borho a TortoiseHG developer? :) [12:47] The bash script shipped with bzr is in an equally bad shape, which caused me to write the bash plugin in the first place. [12:50] luks: There is some evidence to that fact on the web, yes. Can't say I know, though. [12:50] yes, he is [12:51] so there is probably little interest in fixing the script :) [12:51] MvG: any chance of a simple hack to at least avoid the error message? [12:52] dipnlik: Sure: redirect errors to null in _versionedFiles: fileList=(${(ps:\0:)"$(bzr ls --null --versioned 2>/dev/null)"}) [12:54] MvG: i think I'll need more details to use that :( [12:54] OK, dipnlik. All I have is a bzr source tree checkout, which contains a file contrib/zsh/_bzr which in turn contains the completion instructions. [12:55] You should have a copy of that file somewhere on your system, probably in a path mentioned in $fpath. [12:55] You need to find and edit that file. [12:56] Lines 48-53 of that file describe a function _versionedFiles, where line 50 does a bzr ls invocation. [12:57] After the --versioned but before the )"}) you insert a space and 2>/dev/null [12:57] Then you restart your zsh, and see if things work. [12:58] will try that, thanks a lot [12:59] Out of curiosity: what makes you use zsh? [13:00] trying it out of curiosity and because it fixes my main problem with bash: the command history [13:00] let's say i have two bash tabs on terminal, one with tail something and other where I type all the commands I use [13:01] if I exit the "main tab" then exit the "tail tab", all history on the main tab is gone [13:02] dipnlik: "shopt -s histappend" should fix this for bash. [13:04] zsh promises to do other things better, but for now it isn't really THAT better [13:04] oh-my-zsh also makes some promises [13:14] MvG: oh, thank you for that! [13:14] The histappend? I think it should be standard on any system. It is on Gentoo. [13:15] yeah [13:15] I always hated that it overwrote the file, but I just accepted it as a fact [13:17] I have a 'parent' directory magically appearing. Is it from bzr? [13:17] appearing after what action? [13:17] it's not any stadnard bzr directory [13:19] i don't know. i just made another new repo and it did not happen. init add commit : are candidates. You answered my question, I think. [13:21] are bzr vs. git discussions allowed here? i'm still not that into any of these but git seems to be overly complicated [13:23] dipnlik: as long as they're discussions not flamewars :-) [13:24] dipnlik: we'd be happy to discuss the differences in features of both systems and the advantages/disadvantages [13:25] jelmer: yay [13:26] has someone published/posted comparisons of efficiency scaling with history depth and repository size? I know git did have trouble scaling to large repository sizes within a module [13:28] i've seen comparisons and maybe git is technically better, but bzr is targeted for users, and that's a GREAT advantage [13:31] problem is: "everyone" is using git :( [13:32] so I don't know if I learn both or if I go with the flow [13:34] dipnlik: There is a bzr completion script shipped with zsh (4.3.10 in my case) which seems to be different and slightly more up to date than that shipped with bzr itself. So maybe you should file a bug report with zsh, after ensuring your script actually comes from a plain zsh setup. [13:37] lifeless: wrt my messages somewhere up there: just filed https://bugs.launchpad.net/bzr/+bug/546899 [13:37] Ubuntu bug 546899 in launchpad-code "Use news_merge plugin for launchpad merge preview" [Undecided,New] [13:39] MvG: i'm on zsh 4.3.9, which comes with OSX. edited /usr/share/zsh/4.3.9/functions/_zsh as you told me and it at least doesn't show the errors anymore, it helped a lot :) [13:46] dipnlik: have you seen comparisons of the scaling behaviour? I'm thinking of a graph that shows how memory consumption and processing time vary with varying code size or history. [13:50] dipnlik: from my experience, most people from "everyone" that are using git don't *really* know how to use git [13:52] edakiri: no I didn't, not really into which is better on the long run but since I'm only starting with version control and don't have big projects, that's not an issue for me (at least for now) [13:54] luks: what do you mean? I think I want to *really* know how to use either git or bzr, just not sure which i'll definitely use [13:55] also, github looks really great, maybe that is why "everyone" uses git [13:56] dipnlik: I mean that most people using git are using git just because it's popular [13:57] no any other reason [14:01] luks: i'm using bzr because it seems it's easier but still not sure if I try to get used to git or not. what do you think? [14:01] it's nice to use popular tools sometimes [14:15] My biased experience on git vs. bzr: 1. git pickaxe approach for history examination is nice. 2. git having to add stuff before committing is annoying, but commit -a helps. 3. bzr commands are much closer to svn and therefore easier for newbies, I think. 4. bzr send feels much easier than git patch formatting stuff. 5. I like the clear distinction between repo, branch and working tree bzr offers, to each its own dir. That way you can have multiple bran [14:24] dipnlik: git allows you to very easily screw things up [14:24] dipnlik: other than that, it's not that bad [14:25] MvG: 1 and 4. i've no idea /o\ 2. here on bzr i have to add new files before commiting 3 and 5. agreed [14:25] dipnlik: after you fully understand bzr, it should be easy to use git [14:27] 2. only if they are new, not if they are just edited. The latter is much more frequent in most cases. [14:29] MvG: ouch, adding edited files is weird. is there a good reason for that? [14:30] dipnlik: git uses a thing called 'index' [14:30] it contains changes that are meant to be committed [14:30] you can change a file, git add it, change it again but only the first version will be committed unless you add it again [14:31] git add is really very different from bzr add [14:31] and diff compares indexed state to working tree by default, so after the add but before the commit, a diff without options shows you nothing. [14:31] hi, can someone explain this error / how i can fix it ? [14:31] bzr: ERROR: Revision {('filehandler.py-20100312144733-dlv7tjsgt7fubqdc-1', 'om@om-20100319173025-gugcm11qrsdlksij')} not present in "CHKInventoryRepository('file:///home/om/Ubuntu%20One/reprap/software/pyreplicator/.bzr/repository/')" [14:32] oly: What command did you execute? [14:32] i well i tried a merge it said my tree was out of date so i tried a bzr update [14:32] and got that message [14:33] oly: can you pastebin your whole session, starting at the first command causing the out of date error message? [14:34] http://pastebin.com/dKfL6323 [14:34] theres not really anything to it though [14:35] is there a way i can force a merge it may overwrite what ever is causing the issue then [14:36] oly: Can you also add the output of "bzr info"? [14:36] oly: As far as I can tell, you are on a lightweight checkout, and the branch associated with that checkout was modified in some incomatible way since you created the checkout. [14:37] http://pastebin.com/LGzyJrch [14:37] could be, i do move between ubuntu lucid and karmic so the versions of bzr are likely different [14:37] OK, my assumption was wrong. [14:40] oly: I guess I'd first make a copy of that whole directory, just to be safe. Then I'd try to create a lightweight checkout of the branch head: "bzr co --lightweight . prhead" or similar. If that succeeds, I'd diff those two. [14:42] oly: The diff should show you both differences in the working tree format, possibly caused by different bzr versions, as well as the differences you'd wish to commit. [14:43] hum it checked out okay [14:43] oly: Passing -Derror to commit will print a back trace, which might give us additional information as to what revision it expects and why it isn't there. [14:43] diff pyreplicator/ /home/om/Ubuntu\ One/reprap/software/pyreplicator/ [14:43] is that how i should do the diff ? [14:44] i usually use meld and am only comparing individual files [14:44] diff -ur pyreplicator pyhead [14:44] or prhead, or whatever you have named it. [14:45] I'd be particularly interested in anything mentioning the .bzr/checkout subdirectory [14:46] is that on the new checkout [14:48] It should exist in both places. [14:48] And differences might be an indication of what's causing your error. [14:52] jelmer: ping [14:54] bialix: hey [14:55] heya [14:55] http://pastebin.com/M9RCxdAD [14:56] jelmer: does bzr-svn supports tags a-la bzr tags? [14:56] does not look like theres anything noticably different other than the source files [14:56] which is why i am trying to commit them :p [14:56] jelmer: see Bug 546906 [14:56] Launchpad bug 546906 in bzr-scmproj "crash for svn branches" [Undecided,New] https://launchpad.net/bugs/546906 [14:56] jelmer: any suggestion how I should fix this in scmproj? [14:56] bialix: yep, it does [14:58] jelmer: apparently other_branch.tags.get_tag_dict() where other_branch is svn://xxx does not [14:58] well, i'm leaving, thanks a lot for the help everyone, i'll stick with bzr and bzr-svn :) [14:59] bialix: only if you have a branch layout for which it is not known where the tags should be [14:59] jelmer: oh [14:59] jelmer: cause Guessed repository layout: TrunkLayout(0), guess layout to use: CustomLayout(['trunk/libavcodec'],[]) [15:00] that's it? [15:00] bialix: TrunkLayout(0) puts all tags in tags/ [15:00] bialix: for a custom layout it's not known where to put the tags [15:01] jelmer: so... maybe I just should catch that error and suppress it? [15:01] oly: Those u1conflict files look suspicious to me. [15:02] Any idea where they might come from? How do they differ from those without the .u1conflict extension? [15:02] okay, i dont think there in the repository at leat they should not be [15:03] there cause when there is a sync error between my two computers [15:03] they are generally the same file but a different version that did not sync [15:03] oly: I guess some such sync error garbled your working tree or branch. [15:04] bialix: it depends on what you're trying to do :-) [15:04] ah, i did wonder if it could be todo with the file sync [15:04] bialix: if you're pulling from that branch, I would just ignore the tags [15:04] oly: Safe thing would be, clone your branch and apply the source tree diff manually, without touching the .bzr dir. [15:05] jelmer: I'm checking if I need to pull first [15:05] okay or maybe easier, can i just revert to the online copy ? [15:05] and hit save in my editor again for the newer versions and then commit ? [15:09] * bialix waves at amanica [15:09] hi bialix :-) [15:09] hi dude [15:09] oly: Revert to online using "pull --overwrite" might work, but I'd not feel as sure with that. [15:11] okay, will have a play see what else i can break :) [15:11] oly: In my experience, synchronization of bzr branches using other sync tools is a bad idea. Didn't work out for me with unison either. Sooner or later you happen to modify things at one end but forget the other, and then a file-based sync easily breaks stuff. I'd suggest synking using bzr pull instead. [15:12] I meant modify at both ends and forget to sync in between. [15:12] okay, [15:12] yeah i asked some one about it a while ago if it was likely to cause problem they suggest it would be okay [15:12] but apparently not :p [15:13] is should be if you keep things strictly sequential, but that's hard. [15:14] yeah, anyway fixed [15:14] i had a better idea [15:15] move the .bzr folder to tmp, then copy the .bzr from a newely checked out copy [15:15] then run the commit :) [15:16] That's fine. [15:16] simple and seems to work which is what i like :) [15:21] When a merge proposal into bzr.dev was reviewed "Needs Fixing" by one person and has status "Needs review", do I have to resubmit the proposal after fixing the issue, or should I simply wait? [15:22] https://code.launchpad.net/~gagern/bzr/bug513322-first/+merge/22045 in particular. [15:22] Thanks for the help by the way MvG :) [15:22] np [15:24] Um...I'm not sure. You can push again and the merge proposal will be magically updated. [15:24] You can also file a new merge proposal, and that will magically handle everything too. [15:28] Peng: thx. I noticed the magic update. I guess I'll wait a while, see if waiting is enough. After all, "Needs Fixing" sounds less problematic than "Resubmit", which is a possible review comment as well. === salgado is now known as salgado-lunch [16:07] Is it a bug that urlutils.local_path_from_url barfs on a "readonly+file://" URL? [16:28] Peng: I don't think it's the correct URL to use in local_path_from_url [16:28] readonly+ is the prefix for bzr transport [16:32] Ohh? [16:32] Hmm. [16:32] Do readonly transports have a copy of the URL without that prefix, then? [16:32] Plus, IIRC the prefix is kept in Branch.base. [16:40] Peng: IIRC readonly transport is the wrapper for plain transport [16:41] so yes, there should be copy of URL w/o readonly+ somewhere inside [16:56] jam: Do you think I should mark bug 546899 as affecting PQM as well? [16:56] Launchpad bug 546899 in launchpad-code "Use news_merge plugin for launchpad merge preview" [Wishlist,Triaged] https://launchpad.net/bugs/546899 [16:56] MvG: reasonable to do so, I'm not really sure what would be done about it [16:56] it is more that bzr's pqm setu [16:56] it doesn't really affect bzr-pqm itself [16:56] so on second thought [16:56] maybe add bzr [16:56] but don't add bzr-pqm [16:58] Hmmm... hadn't known there was a bzr-pqm in addition to "plain" pqm... :-) [16:58] ah, sorry [16:58] pqm is the robot [16:58] bzr-pqm is a plugin to submit to the robot [16:58] And the robot should be the more likely one to complain about broken news, right? [16:59] s/broken/conflicting/ [16:59] regardless, adding 'bzr' might be reasonable, but it is probably more of a sysadmin thing than a bug in the program itself [16:59] There is no sysadmin subproject, is there? [17:02] Come to think of it, it already DOES affect bzr, because news_merge is part of the bzr.dev source tree. === deryck is now known as deryck[lunch] === salgado-lunch is now known as salgado === beuno is now known as beuno-lunch === deryck[lunch] is now known as deryck === beuno-lunch is now known as beuno === radoe_ is now known as radoe [18:31] jam: hi [18:32] jam: So, BtreeIndex seems very slow adding new entries after ~200k entries [18:32] 200k entries? Are you doing something evil? :D [18:32] I would never do evil things. [18:33] You use libsvn. :P [18:33] So does Google. [18:33] And Google doesn't do evil. [18:34] Ergo, I don't do evil. [18:34] QED :_P [18:34] Ah! Your logic is flawless. [21:11] hmm.. trac-bzr performs just as poorly as loggerhead on large repos [21:11] worse actually [21:11] the cache isn't just there because i'm an idiot :) [21:12] mwhudson, its interesting to see how performant bzr can be for a web ui without building a complete secondary index [21:12] hazmat: the biggest problem is revision numbering [21:13] mwhudson, i've disabled the dir ancestry stuff (dir rev appears as latest of contents), and i'm running it through repoze.profiler atm... [21:13] mwhudson, yeah.. i think thats what i'm seeing now.. still not 100% though [21:15] hazmat: what version of trac-bzr? [21:15] MvG, trunk, with trac 0.11.7 [21:15] trying it out on the launchpad repo [21:16] 110k revs it looks like [21:16] page loads are about 10s when it touches bzr [21:16] jelmer: the code dumps data to disk [21:16] you can look at the builder parameter "dump keys at" [21:17] hazmat: OK, thats a large number of revisions for sure. What page are you referring to? [21:17] hazmat: there is this bzr-historycache plugin that might help [21:18] MvG, mostly any browser pages below the root.. but the timeline also but thats mostly because theirs a few k changesets in the last 30 days. [21:19] mwhudson, my end goal is to see if bzr can do a fast web interface, the first thing i'm trying to reason is if a cache is required for that [21:19] hazmat: OK, in browser my first bet would be dir revision calculating, but assuming you deactivated all effects of that, conversion of revids to dotted revnos is my next best bet. [21:19] hazmat: ok, i can tell you that you will have a problem with revision numbering for off-mainline revisions without some kind of cache [21:20] hazmat: My current belief is that it is, but in many scenarios a in-memory cache would suffice. [21:20] igc has a plugin for that [21:20] MvG, yeah.. mwhudson mentioned that as well.. it does appear to be that (revid->revno mapping) [21:20] lifeless: caching those revs? [21:20] jam: Thanks [21:20] jam: I tried to reproduce it with a trivial script but I can't for some reason :-/ === salgado is now known as salgado-afk [21:23] hazmat: If you want to dig closer into improving trac-bzr using caches, we should have a longer talk. [21:23] I've spent some time already thinking about how I'd do this, what kind of info I'd whish to cache, and what kind of features that'd allow for trac-bzr. [21:24] MvG, if it can't work without caches, i'm going to try and spend time on improving loggerhead, i'm definitely up for the discussion though [21:24] jam: Also, I'm interested in looking at using bzr-based formats for bzr-svn [21:25] jam: basically something like the revisions VF together with some bzr-svn specific indexes, how would I go about doing that? [21:25] MvG: yes [21:27] so, it depends [21:27] I'm working on refactoring the code to do something like that for annotations [21:28] so if you're willing to wait, it should be easier [21:28] mwhudson, MvG as you both suggested, its definitely the string_rev (6s, 2.5s on two of the calls), although one of the calls to get_changeset also takes 2.5s. [21:28] jam: I'm happy to wait [21:28] jam: This is intended for 2.3 ? [21:29] My current idea is three caches, most easily explained in terms of relational database tables. [21:29] One would be for the whole shared repo, and contain one line per revision. With date, revid, maybe some internal primary key, parents. [21:29] Second would be per branch, with dotted revno, merge point, next rev on path to that merge point, index in the order "bzr log -n0" would print it. [21:29] Third would be for dirs, in order to determine svn-style last modifying revisions. For this I'd order revisions in a tree, with full fileid to revid mapping only for power of two history length, and relative information for others, to keep the amount of data down. [21:31] Both the well-defined "next" (child) revision and the "dir last modified" revision info are highly svn-like, but I think it useful nevertheless. [21:31] probably in the 2.2 series [21:31] b1 is only this week [21:31] MvG: 'what revs a fileid is present in' should be answerable pretty fast from 2a repos [21:31] lifeless: using what API? [21:32] the chk maps; probably not well exposed today. [21:32] Because what trac-bzr does right now already looks painfully slow [21:33] so just using revid, and sans the svn:style dir revs, the performance is passable.. genshi floats to the top in the profiler now ;-) [21:33] lifeless: can you give me a fully qualified name pydoc will accept? [21:33] MvG: bzrlib.inventory.CHKInventory [21:33] hazmat: So there is hope still. :-) [21:33] MvG: its not a trivial thing; I'm saying that our core db format should be ok at this point [21:33] so there will be somethinking needed [21:34] and api improvements to show it 'publically' [21:34] MvG: Loggerhead could use the same thing. [21:35] Peng: Loggerhead is already making massive use of caching. [21:35] One would be for the whole shared repo, and contain one line per revision. With date, revid, maybe some internal primary key, parents. [21:35] MvG: no point caching that, get_revision is plenty fast [21:35] MvG: Yes but it sucks. :D [21:35] And I found the implementation there so unreadable that I decided not to copy it to trac-bzr. [21:35] MvG: Exactly! [21:37] mwhudson: The initial string-based lookup already feels wrong, I'd have expected faster access using e.g. a 64bit internal identifier. But maybe I'm wrong here. [21:38] MvG: bzr has pretty efficent code for mapping strings to "stuff" [21:38] Another thing to note is that for the dir to rev cache, I'd need to store for every revision the appropriate ancestor relative to which differences are noted. [21:38] sure, some kind of hyperoptimized binary data type key value store might be faster [21:39] but not much and not enough to be worth the pain of keeping the cache up to date imho [21:39] So that's one more item to store with each rev, not branch-dependant, and not suitable for the main bzr repo. [21:40] Or do you know of an efficient API to 1. tell me the history length of a given rev and 2. find a preceding history element with a given history length? [21:43] lifeless: Looking at CHKInventory, I realize that 'what revs a fileid is present in' is not the question I'm asking. [21:43] MvG: what quewstion are you asking? [21:45] Rather this: Given revision r, what's the latest element in the history of r where the dir d looks like it does at revision r, i.e. all files had the same contents, names and so on. And for that mainline revision, is there a sideline revision where it already looked the same as well, and if so, recurse down that sideline, until I get to the earliest revision that made the dir what it is today. [21:46] s/latest/earliest/ [21:46] and "today" only if r is the tip, otherwise "what it is in r". [21:47] The problem is that I have to deal with multiple revisons of multiple files, which scales badly. [21:47] basically you want the latest rev of the children of a directory at a given rev [21:48] One solution is walking history, looking at deltas, see when things were last modified. The other is looking at last modifications of files and trying to relate them via the graph. Neither is really cheap. [21:48] MvG: you can paraphrase that as 'find the end of the subgraph with the closest (topologically speaking) changes to any fileid under (d,r)' [21:49] lifeless: To get the semantics clear: do you mean the "subgraph of changes" and the "end which is topologically closest"? [21:50] subgraph of the revision graph [21:50] bzr doesn't store changes [21:50] and yes to the second question [21:51] anyhow, I've speculated in the past about having a 'subtree revisionid' as well as the 'this item changed' revisionid on directories. [21:51] lifeless: Still, it's not it. If I branch, modify one file on one graph and another file on another graph, then merge the two, then I want the merge, even as it touches neither file, because only the merge makes the dir what it is. [21:51] we don't have one today; such a thing would be a) constant, b) derivable [21:51] MvG: you would get the merge under the definition I offered [21:52] The I still misunderstood the definition... let me have another look, it's getting late here... [21:53] With "subgraph of changes" I meant the subgraph by taking only the nodes that contain changes to a subtree. Was that your intention? [21:53] no [21:53] subgraph of the fullgraph [21:53] Restricted on what criterion? [21:54] having the same contents of the subtree [21:54] Ah! [21:54] conversely, the adjacent revisions must change the subtree [21:55] Anyhow, this is something that you could cache. [21:55] but I'd try to build a fast implementation of it first; if only so that your cache loading will be efficient :P [21:56] jam: ah, cool [21:56] I know how to derive this informations by walking all deltas. That's the incremental way to do things, in contrast to recursing on directory tree structure from files to the root. [21:56] jam: Is there anything I could play with yet? [21:57] But deltas feel more expensive than I would like. How expensive are they, when I don't actually calculate text differences, but just request the list of touched files? [21:58] jelmer: it is still pretty early, but the code is up at lp:~jameinel/bzr/2.2.0b2-pack-collection [21:58] and eventually lp:~jameinel/bzr/2.2.0b2-contained-pack [21:58] It is pulling the "PackCollection" out of "RepositoryPackCollection" [21:59] What has me worried is the amount of data. Every commit would change the revid of the root. In most projects most commits would touch the src subdir. That's a lot of modifications, which made me think of this tree organization. [21:59] btw, I'll be (as long as it's approved) doing an "introduction to bzr" in a future Linux Format :D [22:01] MvG: deltas are very fast [22:01] MvG: we can walk 30K in a few seconds [22:01] Glad to hear that, then I'll be using those. [22:01] specifically iter_changes [22:02] there is a repository api to do iter_changes of many revisions [22:06] I plan to make the trac-bzr caching highly modular, to separate data generation from data access from data storage, and all of these from the rest of trac-bzr. Maybe that way parts of it can be useful to others as well, in a plugin to be shared with loggerhead or who else might be interested. [22:07] hi [22:07] The only thing I now need is a lot of free time to implement this, which I don't currently have. [22:07] with fast-export, how does one string a file/directory from a tree? [22:16] MvG: make the bits bzr plugins then, IMO [22:16] AfC: btw, 'bzr revert' in an svn checkout does what 'bzr revert' in a bzr branch would do [22:17] AfC: you signed off too fast the other day, but I was about to answer your question with 'bzr revert' :P [22:17] lifeless: sure. I'm not using bzr-svn though, but thanks [22:17] lifeless: dunno. AT least for trac-bzr development, having them as part of that code base is easier, and avoids having to deal with a possibly misisng plugin. But I'll keep a bzr plugin future in mind, to ensure it can be moved one day. === davidstrauss_ is now known as davidstrauss [22:45] hi, just wondering... first time with Bazar explorer.... initiated a project... for a php thing in ~/work/bzr/tr. should i move there content of /var/www/tr/ or ../www/tr/* ? [22:49] hey lifeless, got a question for you for the high level locking hooks === Peng___ is now known as Peng_ [22:54] dvheumen: shoot [22:55] well, I'm wondering if there's any way to find out if a lock that's already active is a read or write lock. I'm kind of lost in the lockable_files/lock_dir and all the locking mechanism directly or via transport [22:57] dvheumen: so lockable_files are always write locks [22:57] dvheumen: read locks don't have a lock object [22:58] okay ... let me have a look at the code to see if that's all I needed ... [22:58] but most importantly [22:58] Branch etc always know what sort of lock they have [22:58] queryable via e.g. is_read_locked() and is_write_locked() [23:01] I cannot find is_read_locked anywhere, and is_write_locked is only available for repository ... (or I'm grepping the wrong way ...) [23:04] anyways, maybe it's good to give you some context: I'm trying an initial implementation of the hooks in classes MutableTree, Branch and Repository. And I was working on triggering the callbacks on lock_{read, write, tree_write} and that's not too difficult. But for unlock and break I need to know whether I am breaking a read or a write lock, so how would you go about this? [23:06] lifeless: ^ [23:07] dvheumen: why do you need to know ? [23:07] dvheumen: and secondly, you know, in unlock, what the lock type was [23:08] dvheumen: within each object type,t hat is. [23:08] dvheumen: as for break, you can't break a high-level locked object anyhow, it always refers to a stale disk lock [23:08] lifeless: I was planning on reporting the type of lock during the triggering of the callbacks [23:09] okay, so there's no (sensible) thing as a broken lock hook for high level locks? [23:09] well, there may be, but its not part of the lock/unlock sequence [23:10] in aprticular there isn't a break-lock for read locks. [23:10] hello all [23:10] okay, so I'll scratch that. [23:10] hi [23:11] dvheumen: as for the type - check the details of e.g. RemoteRepository.unlock [23:11] dvheumen: you can see it knows the lock type [23:15] Hi all [23:15] yeah I've seen the _lock_mode for repository before. And I now discover that there is peek_lock_mode for Branch [23:15] I'm looking for info on the different exit status that bzr returns. [23:16] I've greped the docs, and googled, but not found any thing. [23:16] From testing: 0 = success [23:17] lifeless: okay, I think it's clear. Do you think there's any value in returning the LockResult instance that is used for the low-level lock hooks? (At least, I think it's still available, but I don't think it makes much sense.) [23:17] no [23:17] a) SvnRepository etc won't have them [23:17] 1 = has diff (from diff) [23:17] b) not all Bzr repos have them either [23:17] aha okay [23:17] dvheumen: peek_lock_mode probably isn't what you want [23:17] 2 = result has conflicts [23:17] 3 = error [23:18] Any thing I'm missing? [23:18] lifeless: isn't it? What's wrong with peek_lock_mode? I have seen that sometimes control_files are shared with the repository, but then the locking mechanism is shared too right? [23:18] dvheumen: they don't track read locks [23:19] dvheumen: in the general case [23:19] dvheumen: uhm, that said - whatever works [23:19] we haven't managed to delete self.control_files yet. [23:22] lifeless: hi, I'm tetsing xmloutput with latest bzr.dev, and I'm getting a bunch of this errors: http://pastebin.ubuntu.com/401439/ any ideas? [23:22] bla - I was looking in the wrong place. Found some of what I was looking for @ bzr help diff [23:22] *testing [23:22] okay, well, I think that's enough info for me to continue with (some) implementation of the hooks. Is there any documentation on locking? (because I couldn't find much) [23:27] verterok: thats fun [23:27] verterok: I haven't been tracking bzr closely recently, so I can't really comment. poolie ^ ? [23:27] lifeless: :) [23:28] verterok: AFAIK there is still only one branch reference around [23:28] lifeless: ok, I can poke vila, as this is tests stuff ;) [23:28] so its got to be some sort of bug/regression in the way you're using bzrlib - unintentional I presume. [23:28] thanks [23:42] lifeless: found the problem, target_branch is now a kwarg :) [23:44] did we move its position ? [23:45] if so thats an api break, if we haven't done a stable release with the change we can fix it [23:46] oh jelmer [23:47] a checkout made using bzr-svn is exhibiting the behaviour described in #380069 [23:47] would you like me to do things to figure out what happened? :) [23:48] i'm using bzr 2.1 and bzr-svn 1.0.2 [23:51] hup! too late. I did bzr up in another branch in the same repo and the problem went away. [23:51] lifeless: looks like it was moved. revno 5085 [23:51] that's really annoying. [23:52] lifeless: hmmm, sorry it was a kwarg, but now a new kwarg is before it [23:52] * verterok brb [23:55] verterok: yes thats a move [23:55] verterok: file a bug, and a patch please!