| === jelmer_ is now known as jelmer | ||
| === flacoste is now known as flacoste_afk | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: wgrant || queue: [jelmer,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | Hi wgrant, in addition to the lucid-related failure with your soyuz-upload.txt, I also see a bunch of deprecation warnings after line 746 (printing stderror). | 08:32 |
|---|---|---|
| * wgrant looks. | 08:33 | |
| intellectronica | noodles775: hi, i have a tiny js/ui review for you (that placement fix jtv asked for). can i add it to the queue? | 08:35 |
| wgrant | noodles775: That *is* odd. | 08:36 |
| noodles775 | intellectronica: of course. | 08:37 |
| wgrant | Why did that not appear before... | 08:37 |
| noodles775 | wgrant: so it wasn't there ear... | 08:37 |
| === intellectronica changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: wgrant || queue: [jelmer,wgrant, intellectronica] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | yeah. | 08:37 |
| wgrant | Ah. | 08:38 |
| wgrant | Guess which package was upgraded overnight. | 08:38 |
| noodles775 | aha. | 08:38 |
| wgrant | I guess I could filter those warnings in ftpmaster.py | 08:39 |
| wgrant | But it probably makes other stuff fail too. | 08:39 |
| wgrant | It's tempting to leave that for now, rerun the test suite tonight, and fix all the introduced failures in one lot tomorrow. | 08:39 |
| noodles775 | wgrant: yeah, since I assume there will be a whole bunch of new lucid errors for soyuz tests :/ | 08:40 |
| wgrant | I think filtering those warnings in a couple of places should do it, but we'll find out. | 08:40 |
| wgrant | That test should pass fine on Hardy still. | 08:40 |
| noodles775 | OK. I'll update the MP. | 08:40 |
| wgrant | Yay for huge API changes in the last month of an LTS. | 08:41 |
| noodles775 | wgrant: sorry, just to check: do you want me to approve and land this branch, since the tests will pass on hardy? | 08:42 |
| wgrant | Thanks. | 08:42 |
| wgrant | noodles775: Please do. | 08:42 |
| wgrant | I'll fix all the new Lucid failures tomorrow. | 08:43 |
| noodles775 | Wonderful :) | 08:43 |
| noodles775 | wgrant: with your rescueiflost/updatestatus branch, couldn't we do something like rescueIfLost = Builder.rescueIfLost on the MockBuilder if the code is the same? (and not have to define the functions?) | 09:10 |
| wgrant | noodles775: Bound methods check the type of the first argument. | 09:10 |
| wgrant | So no, it's not quite that easy :( | 09:10 |
| wgrant | Er, unbound methods. | 09:10 |
| noodles775 | Ok. | 09:10 |
| noodles775 | wgrant: in which case, is there an obvious reason that I'm missing for why MockBuilder couldn't inherit from Builder and just overload all its methods as needed? | 09:22 |
| wgrant | noodles775: It looks like a few other mocks do that. So maybe I could. | 09:27 |
| noodles775 | wgrant: OK, I'll leave it up to you - I personally think it would improve the code. | 09:27 |
| noodles775 | r=me | 09:27 |
| wgrant | noodles775: It would, yes. | 09:27 |
| wgrant | Thanks. | 09:27 |
| * wgrant will fix. | 09:27 | |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: intellectronica || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | intellectronica: where's your MP? I can't see it on active reviews? | 09:33 |
| intellectronica | noodles775: because it's a lazr branch. https://code.edge.launchpad.net/~intellectronica/lazr-js/choiceedit-horizontal-position/+merge/22106 | 09:34 |
| noodles775 | Thanks. | 09:34 |
| wgrant | noodles775: Mmmm, because Builder inherits SQLBase it's not that simple. Simply initialising it tries to add it to the DB, and then all hell breaks loose... | 09:48 |
| noodles775 | wgrant: :/ | 09:50 |
| wgrant | So it's probably best to leave it as it is now, although it's ugly. | 09:56 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: intellectronica || queue: [StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | intellectronica: I approved your MP, but please see the subsequent comment and see what you think. | 10:18 |
| noodles775 | I didn't think it was an issue at first (and hence didn't discuss it here), but it may be worth considering. | 10:19 |
| intellectronica | noodles775: yeah, i'm not sure what's the appropriate solution (and it's very much a corner case). we could avoid doing the correction, so that at least you get to see the leftmost content | 10:21 |
| intellectronica | then again, is it really likely that people will be using this from a screen smaller than the widget? | 10:21 |
| intellectronica | on my phone, for example, there's enough space for the widget to display | 10:22 |
| noodles775 | intellectronica: yeah, it is a corner case, and I don't know what the average pixel width of a phone is. Given that it's not hard to avoid it, I personally think it'd be worth the extra line or two, but up to you. | 10:25 |
| noodles775 | intellectronica: that is, if you avoid the correction in that case, the user can always scroll right to see the rest. But in the current case, they can never scroll left beyond 0. | 10:25 |
| intellectronica | noodles775: yeah, i think simply not doing the correction is the right way to go. the widget is going to be cut anyway, but at least it will be cut on the right. | 10:25 |
| === wgrant changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: intellectronica || queue: [StevenK,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | jelmer_: do you want to look at wgrant's first? | 10:51 |
| jelmer_ | noodles775: sure | 11:02 |
| wgrant | jelmer's a mentat now? | 11:06 |
| noodles775 | Yeah. | 11:10 |
| wgrant | Nice. | 11:11 |
| noodles775 | [, 10 | 11:24 |
| noodles775 | oops, wrong kb layout ;) | 11:24 |
| bigjools | are you a crazy dvorak dude? | 11:25 |
| === jelmer_ is now known as jelmer | ||
| * wgrant would recognise that mistake anywhere. | 11:26 | |
| === noodles785 is now known as noodles775 | ||
| === matsubara-afk is now known as matsubara | ||
| === jelmer changed the topic of #launchpad-reviews to: on call: noodles775, jelmer || reviewing: wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado_ is now known as salgado | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, jelmer || reviewing: wgrant,sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, jelmer || reviewing: wgrant, lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| leonardr | noodles775, jelmer, i need review of two tiny branches | 12:57 |
| leonardr | https://code.edge.launchpad.net/~leonardr/launchpad/lucid-updates | 12:57 |
| leonardr | https://code.edge.launchpad.net/~leonardr/launchpadlib/use-1.0 | 12:57 |
| leonardr | noodles775, jelmer: actually just the lucid-updates one | 12:59 |
| leonardr | i'm going to redo that merge proposal actually to get rid of conflicts | 12:59 |
| leonardr | noodles775: https://code.edge.launchpad.net/~leonardr/launchpad/lucid-updates/+merge/22123 | 13:04 |
| === flacoste_afk is now known as flacoste | ||
| === wgrant changed the topic of #launchpad-reviews to: on call: noodles775, jelmer || reviewing: wgrant, lunch || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| wgrant | https://code.edge.launchpad.net/~wgrant/launchpad/sprb-package-branch-db-permission/+merge/22128 <- about as trivial as they get. | 13:32 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, jelmer || reviewing: wgrant, wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | lol | 13:49 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, jelmer || reviewing: bigjools, wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-lunch | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, jelmer || reviewing: -, wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| leonardr | noodles775, still waiting for a review of https://code.edge.launchpad.net/~leonardr/launchpad/lucid-updates/+merge/22123 | 14:26 |
| noodles775 | leonardr: I approved it 40mins ago? | 14:27 |
| noodles775 | s/40/31 ;) | 14:27 |
| leonardr | ?? | 14:28 |
| leonardr | noodles775: so you did, for some reason it still says needs review | 14:28 |
| noodles775 | leonardr: yes, the status doesn't update automatically, as you might need multiple reviews (ui/code etc.) before you want to set the MP as approved. | 14:29 |
| leonardr | ok, i guess i don't do many launchpad branches | 14:30 |
| noodles775 | leonardr: you've got the perms to update the status though right? | 14:31 |
| leonardr | noodles775: yes | 14:31 |
| noodles775 | Great. | 14:31 |
| === wgrant changed the topic of #launchpad-reviews to: on call: noodles775, jelmer || reviewing: -, wgrant || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, jelmer || reviewing: wgrant, wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | wgrant: around? With your MP, just wondering if you think it's worth adding ISPRecipe.base_branch (simply proxy to SPRData.base_branch which already exists) for use in the title? | 15:13 |
| noodles775 | Instead of including *all* the referenced branches? | 15:13 |
| wgrant | noodles775: I considered that. I guess including all could get a bit long sometimes. | 15:13 |
| noodles775 | Yeah. | 15:13 |
| noodles775 | With that, r=me. | 15:14 |
| noodles775 | oh, I didn't send of your second branch to land yet... | 15:14 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: jelmer || reviewing: wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| * noodles775 retires for the day to do some qa. | 15:16 | |
| wgrant | Thanks noodles775. | 15:16 |
| === matsubara-lunch is now known as matsubara | ||
| wgrant | noodles775: I've fixed that branch. Do you have a moment to send it off to EC2? | 15:37 |
| noodles775 | wgrant: Sure. | 15:37 |
| wgrant | lp:~wgrant/launchpad/sprb-package-branch-db-permission appears to be approved too -- is that in EC2 somewhere? I guess it can probably just land directly. | 15:39 |
| === salgado is now known as salgado-lunch | ||
| === jelmer changed the topic of #launchpad-reviews to: on call:|| reviewing: wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === deryck is now known as deryck[lunch] | ||
| === salgado-lunch is now known as salgado | ||
| === deryck[lunch] is now known as deryck | ||
| === salgado changed the topic of #launchpad-reviews to: on call:|| reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-afk | ||
| === fjlacoste is now known as flacoste | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!