| persia | https://wiki.ubuntu.com/Bugs/HowToFix?action=recall&rev=16 | 00:01 |
|---|---|---|
| persia | But that's not a live page. If you want that page to be live, chat with dholbach. | 00:01 |
| nigelb | I was thinking of making it a page under reviewers team knowledge base | 00:01 |
| dholbach | good morning | 07:18 |
| nigelb | dholbach: doing a session on patch review during UOW might be a bit too technical? | 12:14 |
| nigelb | I'm planning, but unsure if the topic fits into UOW | 12:15 |
| dholbach | no, I think it's fine | 12:15 |
| dholbach | we've had technical sessions there before | 12:15 |
| nigelb | the thing I fear is, the entry barrier might be a bit too high | 12:15 |
| dholbach | I think it's fine if you set expectations | 12:16 |
| dholbach | it's perfectly acceptable to demo something that is not for everybody | 12:16 |
| nigelb | like, we expect you to know $foo1, $foo2, etc? | 12:16 |
| dholbach | if you make it clear what's required people at least will have heard about it | 12:16 |
| dholbach | and if they decide "this is not for me" that's fine | 12:16 |
| nigelb | aha, okay. I'll get around to doing it then :) | 12:17 |
| nigelb | btw, a session is planned for april 7th too! | 12:17 |
| dholbach | awesome! | 12:17 |
| dholbach | good work | 12:17 |
| nigelb | :) | 12:17 |
| nperry | hello guys, just wanted to introduce myself. My name is Neil Perry, and this afternoon I'm very much going to help review these patches | 12:32 |
| nigelb | nperry: great :) | 12:32 |
| nigelb | you can see the topic for a link to the wiki | 12:32 |
| nigelb | so, basically, just keep reviewing the subscribed bugs | 12:32 |
| nigelb | if you get stuck, have any questions, please ask here | 12:32 |
| nperry | Just to confirm the basic workflow. Pick a patch, download patch, download source, apply patch, test if it builds, test if it fixes the bug, forward upstream | 12:32 |
| nigelb | yup, pretty much | 12:33 |
| nigelb | nperry: but ask the reviewer if he can forward, so he can receive feedback appropriately | 12:33 |
| nigelb | like follow $foo guidelines or $foo1 style guide | 12:34 |
| nigelb | nperry: ugh, s/reviewer/submitter ^^ | 12:34 |
| nperry | Oh right, so patch maker forwards. | 12:34 |
| nperry | nigelb: I knew what you meant :P | 12:34 |
| nigelb | yep, if he doesn't respond, forward after you fw days, you can do it with credit to himher | 12:35 |
| nperry | nigelb: Is it best if i assign the buy to myself or mark it in progress? | 12:35 |
| nperry | t/buy/bug | 12:35 |
| nigelb | we dont change the bug status until someone is actually working to get it into ubuntu | 12:36 |
| nigelb | i.e. packaging it | 12:36 |
| nigelb | nperry: https://wiki.ubuntu.com/ReviewersTeam/GettingInvolved might help | 12:36 |
| nperry | Ok, just wanted to check as i don't want to tread on anyones feet as to speak | 12:36 |
| nigelb | nperry: there are very few feet here ;) | 12:37 |
| nperry | Ok, do you suggest me working with a package i know to start off with? | 12:38 |
| nigelb | start with bugs which the reviewers team are subscribed | 12:38 |
| nigelb | you see the link in /topic | 12:38 |
| nigelb | https://bugs.launchpad.net/~ubuntu-reviewers/+subscribedbugs | 12:38 |
| yofel | I set bug 546220 to accepted by debian as they fixed it, is that right? and I guess the reviewer teams should be unsubscribed now. | 12:43 |
| ubot3 | Malone bug 546220 in nginx "Include GeoIP support in nginx" [Wishlist,Triaged] https://launchpad.net/bugs/546220 | 12:43 |
| yofel | s/teams/team | 12:43 |
| nigelb | yofel: done. you might want to do a sync after getting an ffe | 12:47 |
| yofel | thx | 12:52 |
| nperry | nigelb: Right so ive got a patch in bug 251335 that won't patch | 12:57 |
| ubot3 | Malone bug 251335 in synaptic "Synaptic searches on UI thread" [Medium,Confirmed] https://launchpad.net/bugs/251335 | 12:57 |
| nperry | Getting Hunk #1 FAILED at 47. | 12:57 |
| yofel | that reminds me, now that we have a proper wiki the link on https://edge.launchpad.net/~ubuntu-reviewers should be adjusted | 12:59 |
| nperry | nigelb: whats the best thing to do? | 12:59 |
| nigelb | nperry: checking | 13:02 |
| nigelb | nperry: something on line 47 is failing. i.e. the patch does not apply cleanly | 13:03 |
| nperry | nigelb: Do i myself recreate the patch or just tell the submitter? | 13:07 |
| nigelb | tell the submitter, if you dont get a response with reasonable amount of waiting, you can get down to it | 13:08 |
| nperry | Ok :) | 13:08 |
| nperry | nigelb: Might be helpful for somone to make a replied wiki page :P | 13:10 |
| nigelb | nperry: replied? | 13:10 |
| nperry | Yeah, changed tag too :) | 13:11 |
| nigelb | oh, you mean list that has been worked on? | 13:22 |
| nigelb | thats what the tags are for, you only work on bug with only patch tag | 13:22 |
| nperry | nigelb: I know :) i just changed it to patch-needswork | 13:23 |
| nigelb | so, when I see that you've changed a tag, I skip the bug | 13:24 |
| nperry | nigelb: Or do you want there to be two tags patch & patch-needswork? | 13:26 |
| nigelb | nperry: just one. there is a script which needs to be edited, dont worry about that | 13:41 |
| nigelb | subscribe to the bug | 13:41 |
| nigelb | and give me bug# so I can unsubscribe reviewers | 13:41 |
| nigelb | dholbach: can you point the launchpad reviewers page to the new wiki page? | 13:42 |
| nigelb | https://wiki.ubuntu.com/ReviewersTeam | 13:42 |
| dholbach | done | 13:49 |
| dholbach | can you see if bdmurray can have a look over the pages? | 13:50 |
| nigelb | dholbach: will do :) | 14:07 |
| nigelb | I asked bryce to take a look and he did some review | 14:07 |
| === yofel_ is now known as yofel | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!