[00:01] https://wiki.ubuntu.com/Bugs/HowToFix?action=recall&rev=16 [00:01] But that's not a live page. If you want that page to be live, chat with dholbach. [00:01] I was thinking of making it a page under reviewers team knowledge base [07:18] good morning [12:14] dholbach: doing a session on patch review during UOW might be a bit too technical? [12:15] I'm planning, but unsure if the topic fits into UOW [12:15] no, I think it's fine [12:15] we've had technical sessions there before [12:15] the thing I fear is, the entry barrier might be a bit too high [12:16] I think it's fine if you set expectations [12:16] it's perfectly acceptable to demo something that is not for everybody [12:16] like, we expect you to know $foo1, $foo2, etc? [12:16] if you make it clear what's required people at least will have heard about it [12:16] and if they decide "this is not for me" that's fine [12:17] aha, okay. I'll get around to doing it then :) [12:17] btw, a session is planned for april 7th too! [12:17] awesome! [12:17] good work [12:17] :) [12:32] hello guys, just wanted to introduce myself. My name is Neil Perry, and this afternoon I'm very much going to help review these patches [12:32] nperry: great :) [12:32] you can see the topic for a link to the wiki [12:32] so, basically, just keep reviewing the subscribed bugs [12:32] if you get stuck, have any questions, please ask here [12:32] Just to confirm the basic workflow. Pick a patch, download patch, download source, apply patch, test if it builds, test if it fixes the bug, forward upstream [12:33] yup, pretty much [12:33] nperry: but ask the reviewer if he can forward, so he can receive feedback appropriately [12:34] like follow $foo guidelines or $foo1 style guide [12:34] nperry: ugh, s/reviewer/submitter ^^ [12:34] Oh right, so patch maker forwards. [12:34] nigelb: I knew what you meant :P [12:35] yep, if he doesn't respond, forward after you fw days, you can do it with credit to himher [12:35] nigelb: Is it best if i assign the buy to myself or mark it in progress? [12:35] t/buy/bug [12:36] we dont change the bug status until someone is actually working to get it into ubuntu [12:36] i.e. packaging it [12:36] nperry: https://wiki.ubuntu.com/ReviewersTeam/GettingInvolved might help [12:36] Ok, just wanted to check as i don't want to tread on anyones feet as to speak [12:37] nperry: there are very few feet here ;) [12:38] Ok, do you suggest me working with a package i know to start off with? [12:38] start with bugs which the reviewers team are subscribed [12:38] you see the link in /topic [12:38] https://bugs.launchpad.net/~ubuntu-reviewers/+subscribedbugs [12:43] I set bug 546220 to accepted by debian as they fixed it, is that right? and I guess the reviewer teams should be unsubscribed now. [12:43] Malone bug 546220 in nginx "Include GeoIP support in nginx" [Wishlist,Triaged] https://launchpad.net/bugs/546220 [12:43] s/teams/team [12:47] yofel: done. you might want to do a sync after getting an ffe [12:52] thx [12:57] nigelb: Right so ive got a patch in bug 251335 that won't patch [12:57] Malone bug 251335 in synaptic "Synaptic searches on UI thread" [Medium,Confirmed] https://launchpad.net/bugs/251335 [12:57] Getting Hunk #1 FAILED at 47. [12:59] that reminds me, now that we have a proper wiki the link on https://edge.launchpad.net/~ubuntu-reviewers should be adjusted [12:59] nigelb: whats the best thing to do? [13:02] nperry: checking [13:03] nperry: something on line 47 is failing. i.e. the patch does not apply cleanly [13:07] nigelb: Do i myself recreate the patch or just tell the submitter? [13:08] tell the submitter, if you dont get a response with reasonable amount of waiting, you can get down to it [13:08] Ok :) [13:10] nigelb: Might be helpful for somone to make a replied wiki page :P [13:10] nperry: replied? [13:11] Yeah, changed tag too :) [13:22] oh, you mean list that has been worked on? [13:22] thats what the tags are for, you only work on bug with only patch tag [13:23] nigelb: I know :) i just changed it to patch-needswork [13:24] so, when I see that you've changed a tag, I skip the bug [13:26] nigelb: Or do you want there to be two tags patch & patch-needswork? [13:41] nperry: just one. there is a script which needs to be edited, dont worry about that [13:41] subscribe to the bug [13:41] and give me bug# so I can unsubscribe reviewers [13:42] dholbach: can you point the launchpad reviewers page to the new wiki page? [13:42] https://wiki.ubuntu.com/ReviewersTeam [13:49] done [13:50] can you see if bdmurray can have a look over the pages? [14:07] dholbach: will do :) [14:07] I asked bryce to take a look and he did some review === yofel_ is now known as yofel