/srv/irclogs.ubuntu.com/2010/03/29/#launchpad-dev.txt

* thumper twiddles his thumbs while the tests run01:09
spmthumper: do you twiddle clockwise or anti? or switch from one t'other? enquiring minds wish to know.01:09
thumperspm: I alternate01:09
thumperlike current, but not as fast01:10
* spm looks for a report on the intrawebsfont-of-all-knowledge as to what that says about thumpers mental state of being01:10
spmsadly, reckon I could google for that and get a semi-credible answer.... :-)01:10
thumperspm: an answer yes, a semi-credible one? now that is a question all in itself01:15
spmha01:15
* mwhudson lunches01:25
* thumper is having test failures with GpgmeError: (32, 176, 'Unknown error code')01:56
wgrantthumper: There is a patch needed for Lucid.02:07
thumper:(02:08
wgrantI think it's in trunk now.02:08
wgrantpygpgme trunk, that is.02:08
thumperis it in LP code somewhere?02:08
thumperI'm running the tests through ec2 now anyway02:08
wgrantmwhudson actually approved the sourcedeps.conf change a few days ago.02:09
wgrantIt just hasn't been landed yet.02:09
thumperok02:10
thumperI thought I had seen something about pygpgme fly past02:10
mwhudsonbad jelmer02:11
pooliewgrant: re bug 549323, i did try to tell them so03:06
mupBug #549323: Discourages bug fixes <Launchpad Bugs:New> <https://launchpad.net/bugs/549323>03:06
* thumper has finally started writing the tests for iterReady03:23
lifelesswgrant: ugh, is this deliberate or a bug ?03:30
thumpermwhudson: happy with bug 532210?04:02
mwhudsonthumper: yes04:03
mwhudsondidn't i change the tag already?04:03
mwhudsonno04:03
thumpernot yet04:03
mwhudsonok04:04
mwhudsonnow i have :)04:04
thumperta04:04
thumpermwhudson: do we have a reasonable branch to test https://bugs.edge.launchpad.net/launchpad-code/+bug/532402 on?04:15
mupBug #532402: record last_revision used to determine partial success before doing import <code-import> <qa-needstesting> <trivial> <Launchpad Bazaar Integration:Fix Committed by mwhudson> <https://launchpad.net/bugs/532402>04:15
mwhudsonthumper: not really04:19
thumpermwhudson: I suppose we should just test the imports on staging and see that they work still04:20
mwhudsonthumper: i can think of some slightly contrived ways to test it by getting a losa to SIGSTOP the import processs04:20
mwhudsonthumper: yeah04:20
mwhudsonthumper: doing that already in fact :)04:20
spmif only there was a friendly losa around....04:20
thumpercool04:20
thumperspm: yeah, know any?04:20
mwhudsonthumper:  https://code.staging.launchpad.net/~vcs-imports/gedit/head04:20
spmthumper: not on the key criteria no. losa's around? yup. friendly? no.04:21
mwhudsonit's also a fiddle, the only public svn repo i can think of is codespeak, and bzr-svn tends to break on that04:21
mwhudson(thanks to svn bugs)04:21
thumpermwhudson: that subversion import is via cscvs, you knew that right?04:29
* thumper afk for a bit04:29
mwhudsonthumper: ah balls04:36
mwhudsonthumper: thanks04:36
* mwhudson stops05:38
wgrantlifeless: Is which deliberate?06:56
wgrantpoolie: I decided not to. I've almost given up trying to convince people nicely.06:56
lifelesswgrant: bug 54932306:56
mupBug #549323: confirmation dialog on bug status change discourages bug fixes <Launchpad Bugs:Confirmed> <https://launchpad.net/bugs/549323>06:56
wgrantlifeless: It's quite deliberate.06:56
wgrantIf you're not a bug supervisor, you're not meant to change the status.06:56
poolielifeless: read the other bug linked from it06:57
pooliewgrant :-(06:57
lifelesswgrant: if we're doing that, we should delete 'in progress'06:57
poolie?06:57
lifelesspoolie: so that there is no bug state that contributors who aren't bug supervisors need to set the bug to06:58
poolieoh i don't know06:58
lifelessI think 'assignee' is sufficient to indicate in progress06:58
lifelessconfirmed|triaged + assigned06:58
pooliei see06:58
pooliethis is a different issue06:58
pooliefwiw i think you can say "some work has been done on this but nobody owns it at the moment"06:59
pooliehowever06:59
pooliethe point here is not that people cannot set the state06:59
pooliejust an attempt to reduce erroneous settings06:59
poolieand a confirmation dialog is a very poor way to accomplish that06:59
lifelesspoolie: arguably though, it won't progress when noone owns it.07:00
lifelesspoolie: yes, I can see the dialog being a poor way issue07:00
poolieright, i don't think you should leave bugs in this state for long07:00
pooliebut they can be there07:00
poolieit's like saying you shouldn't be allowed to have open critical unassigned bugs :)07:00
lifelesstrue07:01
lifelessI think it depends on what you take 'in progress' to mean.07:01
lifelessif you mean 'started but not finished', then I agree that it can be in that state.07:01
wgrantAn alert() which users cannot bypass is a *particularly* poor way to accomplish it.07:01
lifelessif you mean 'being worked on', then I don't agree.07:01
lifelessAnd I think most users take 'in progress' to mean 'progressing' not 'started but not finished'07:02
pooliei don't think "actually being worked on now" is modelled very well by a single field on the task07:05
poolieit will be out of date07:05
lifelessagreed07:06
pooliewgrant: is it really 'bug supervisor' not, as promised in bug 531963, 'bug contributor'?07:09
mupBug #531963: Add a confirmation step when setting the bug status if the user is not a bug contributor <qa-ok> <Launchpad Bugs:Fix Committed by intellectronica> <https://launchpad.net/bugs/531963>07:09
wgrantpoolie: 'bug contributor' doesn't exist, except by karma.07:10
wgrantpoolie: The review I snooped at checked for importance privileges.07:10
* wgrant checks the source.07:10
wgrant+            'status_requires_confirmation': not self.user_can_edit_importance,07:12
wgrantpoolie: ^^07:12
poolieok, thanks07:13
poolieso there is no escape07:13
lifelessperhaps it would be better if it was more sophisticated than that07:14
wgrantApart from Greasemonkey.07:14
lifeless\o/07:14
wgrantlifeless: Indeed.07:14
adeuringgood morning07:49
wgrantnoodles775: Morning.07:53
noodles775Hi wgrant and adeuring :)07:57
adeuringhi noodles775!07:57
wgrantHi adeuring.07:57
adeuringhi wgrant!07:57
wgrantnoodles775: Since LP won't have emailed anybody, again, have a https://bugs.edge.launchpad.net/soyuz/+bug/550233. Also https://bugs.edge.launchpad.net/soyuz/+bug/550049, but I've already poked Julian about that.07:58
* noodles775 looks07:58
pooliewgrant: urk, now i get that dialog about bzr in ubuntu08:09
wgrantpoolie: Ha ha ha.08:09
wgrantGive them hell.08:09
* wgrant heads trainward.08:12
* thumper is having trouble stopping09:08
StevenKthumper: Me too09:10
lifelessthumper: switch to your other project09:10
bigjoolshis wife?09:11
bigjoolslifeless: congrats BTW09:11
lifelessbigjools: thanks :)09:11
bigjoolslifeless: is this a hacking honeymoon? :)09:12
lifelessbigjools: honeymoon will be later this year09:12
lifelesswaaay to much on right now to do it atm09:12
mrevellMorning09:37
fayceHi all ! I'd like to install Launchpad on a Ubuntu box, but I wonder how hard it would be to make it scalable09:50
lifelessfayce: launchpad itself - depends on what you mean by scalable09:54
faycethank you lifeless, I meant by "scalable" the fact that I can load balance it trough different physical (or virtual) servers without too much work09:56
fayceI guess that launchpad is designed that way... kind of stateless ?09:57
lifelessits not stateless09:57
lifelessbut the state lives in a db09:57
wgrantbigjools: What in IBuildFarmJob says that it is a DB object?09:57
wgrant(I don't know how it manages to not live in the DB; that is Code magic.)09:59
fayceok, thanx. I'm about to get the source code and try to install it.10:00
jmlhello all10:00
wgrantMorning jml.10:00
bigjoolswgrant: I don't understand your first comment, but the second one is exactly what bothers me10:08
bigjoolsI don't want magic10:08
wgrantbigjools: By calling Store.remove(some IBuildFarmJob), we are violating IBuildFarmJob.10:08
bigjoolshow?10:08
wgrantNothing in the interface says that it can be removed from a store.10:09
bigjoolsit's no different to destroySelf, except I don't want any more of the latter10:09
bigjoolsIBuildFarmJob should have a concrete table behind it somewhere10:09
wgrantIBFJ now defines destroySelf. verifyObject will correctly catch if something is missing it.10:09
bigjoolsthat's my point10:09
wgrantIt should.10:09
wgrantAnd we should really work out a solution to that, true.10:10
bigjoolsright - so I prefer that to hacking something in10:10
stubcreate an IStorm interface and attach it to storm.base.Storm objects with ZCML.10:11
wgrantstub: I thought we couldn't do that.10:12
stubwhy not?10:12
stubYou could also adapt the object to IMasterObject, which would give you a Storm object or fail.10:14
wgrantDidn't I see a comment suggesting that the I*Store adapters registered on Interface because you can't tell Zope that a class and all its derivatives implement an interface.10:14
wgrant?10:14
stubmaybe. I don't recall.10:15
wgrantlib/canonical/launchpad/webapp/adapter.py, just before get_store.10:15
stubOh... that is classes.10:16
stubWe adapt classes to I*Store, which is the problem. This would be adapting instances which is fine. Just declare Storm implements IStorm and all Storm instances will provide that interface.10:16
wgrantOh, right.10:17
wgrantThat makes more sense ow.10:17
stubBut if a class provides an interface, subclasses don't automatically provide it too.10:17
stub(Which I think is a bug? Not sure, but it isn't going to be fixed any time soon if it is)10:17
bigjoolssounds like a bug to me10:21
bigjoolswgrant: anyway as I said on the bug I'm of a mind to mark it invalid10:21
wgrantbigjools: Well, when is the data model rework going to happen?10:21
bigjoolswgrant: noodles775 is working on it right now10:21
wgrantExcellent.10:21
bigjoolswe need it for builder history10:21
bigjoolsand jtv needs to fix his stuff too :)10:22
wgrantYep.10:22
wgrantBut with that and my other Saturday fixes, translations jobs work perfectly.10:22
noodles775wgrant, bigjools: *was* going to start working on it today, but other things came up ;)10:22
bigjools:)10:22
bigjoolshave you ever been to a blackhat wgrant? :)10:22
wgrantbigjools: No.10:23
bigjoolsanyway, UI should drive all other features, not the other way around.  jml would agree with me.10:23
wgrant+inf10:23
bigjoolsheh10:23
lifelessbigjools: I would say user experience, not ui10:24
lifelessI think its closer to the spirit of the issue10:24
bigjoolsamounts to the same thing for me, but yeah10:24
deryckMorning, all.11:00
=== deryck changed the topic of #launchpad-dev to: Launchpad Development Channel | Week 4 of 10.03 | PQM is in RC mode | Release manager: deryck | https://dev.launchpad.net/ | Get the code: https://dev.launchpad.net/Getting | On-call review in irc://irc.freenode.net/#launchpad-reviews | Use http://paste.ubuntu.com/ for pastes |
wgrantderyck: Hi. Can I please have your blessing for https://code.edge.launchpad.net/~wgrant/launchpad/bug-540819-fix-builder-list-icons/+merge/22288?11:09
deryckHi wgrant.  Let me take a look....11:09
deryckwgrant, can you get the normal reviews from someone else first please?  Then I'll consider it for an RC.  But my initial reaction is I have no qualms about this going in.11:12
deryckI think we will also have someone from bugs back out the confirmation dialog for status change, until it has been correctly done.11:13
wgrantderyck: Ah, OK.11:14
wgrantderyck: +1 from me on backing out the confirmation dialog, clearly...11:14
stubHas meliae become a new dependency, but not been added to buildout or -dependencies?12:22
=== fayce_ is now known as fayce
stubAhh... forgot to rebuild my eggs.12:27
=== Ursinha-afk is now known as Ursinha
=== matsubara-afk is now known as matsubara
=== flacoste_afk is now known as flacoste
jmlgror backlight14:29
bachey salgado are you CHR today?15:34
salgadoI should be but had completely forgotten about it15:35
salgadothanks for reminding me, bac15:35
bacsalgado: there are some questions in #launchpad15:35
adeuringam I right that we now need a referer header for each POST request?16:06
leonardradeuring: right16:06
adeuringleonardr: gah... I can't use firefox to edit any LP page...16:07
leonardrmwhudson, if you're around i have a question about http://www.mail-archive.com/launchpad-dev@lists.launchpad.net/msg02999.html16:07
adeuringbut the important detail:16:07
adeuringWe don't get any longer new submissions to the HDWB16:07
adeuringsince when do we have this referer check?16:08
leonardradeuring: a couple weeks ago. it was a security measure16:10
adeuringleonardr: sure, I understand that. Is it possible to switch this off for selected forms?16:10
=== matsubara is now known as matsubara-lunch
leonardradeuring: yes, i'm finding the information for you now16:11
leonardradeuring: the bug is https://bugs.edge.launchpad.net/launchpad-foundations/+bug/52934816:11
adeuringleonardr: thanks!16:11
leonardrnp16:12
adeuringgary_poster: I just got a head-up from cr3 and jcastro that LP does not accept any longer ay HWDB submission. The reason is simple: The data is posted by checkbox, and the request does not contain a referer header. Can you give me a clue how to best fix this?16:33
adeuringthere is this exemption for "/+storeblob" and a few other URLs, should we extend that?16:34
gary_posteradeuring: yes, I suppose so, with associated tests, and quite possibly with an associated bug or two against the webservice saying that whatever the HWDB is doing now should be doable with the webservice, at which point we can remove the exceptions.16:35
gary_posteradeuring: what do you mean "The data is posted by checkbox"?16:36
adeuringgary_poster: the program that collects the data on a user's machine is called checkbox.16:36
gary_posterah, ok16:37
adeuringand it seems to POST without a referer16:37
gary_posterI thought it was a form element :-)16:37
adeuringgary_poster: ;)16:37
=== salgado is now known as salgado-lunch
gary_posteradeuring: so...actually, I also suggest that they change their script now to include a REFERER.  That way eventually legacy clients will "just work," and sooner than if they wait to be able to do whatever it is they need to do through the webservice API16:39
adeuringgary_poster: yes, checkbox should do that. But it is installed by default on every Ubuntu system, and getting rid of old version will ned quite some time...16:40
gary_posteradeuring: ack, so let's get started ;-)  getting the change into lucid would be a *big* win in that regard16:41
adeuringright16:41
=== deryck is now known as deryck[lunch]
=== matsubara-lunch is now known as matsubara
=== Ursinha is now known as Ursinha-lunch
=== salgado-lunch is now known as salgado
=== beuno is now known as beuno-lunch
=== deryck[lunch] is now known as deryck
derycksinzui, ping18:29
sinzuihi deryck18:35
derycksinzui, hi.  should Bug #550980 be a registry bug instead of malone?  (I realize anyone can fix it, just curious who normally owns that script.)18:37
mupBug #550980: Ordering of Bug importance is wrong <Launchpad Bugs:New> <https://launchpad.net/bugs/550980>18:37
* deryck fixes the title18:37
sinzuiIt is a registry bug18:38
sinzuiIt is also browser based. webkit shows things very wrong. firefox is kind of right18:38
deryckah, ok.  I'll retarget to you guys then.18:39
sinzuialready done18:40
deryckand there's our friend the NotImplementedError. :-)  You did beat me18:40
gary_posterjml, james_w: I'd really rather leonardr and I not consider the adapter question until we've dealt with other things on our schedule, and I'd really rather decisions assuming a given solution (which is what I--perhaps mistakenly--understand the current resolution of your mail thread) to be postponed.  I understand that you want changes, but pushing for too much at once will lead to flailing, I'm afraid.18:41
gary_posterah, disappointments: the local paneras no longer allows ssh connections apparently :-/18:43
gary_posterleonardr: my concern expressed about the adapter thread (and the original question about exposing newCodeImport), if you do have any quick wisdom or ideas to share with james_w and jml, please do.18:45
sinzuideryck: That bug was a duplicate of a foundations bug. I also found the same bug reported in malone. I duped them so that it was clear that there is one universal webkit js problem in launchpad18:52
derycksinzui, excellent, thanks!18:52
=== beuno-lunch is now known as beuno
leonardrgary, looking19:09
=== matsubara is now known as matsubara-afk
james_wgary_poster: I don't think I'm rushing ahead, I'm just responding to the only replies I have had on the topic. If you want to defer exposing anything that uses adapters until there is a general solution in place then please tell me and I shall go work on something else.19:46
gary_posterjames_w: fair enough.  My concern is jml encouraging an approach when we don't have an agreement yet, and, as he said, we have (already too many) other things to focus on right now.  I don't know the API you are trying to expose.19:54
gary_posterIf your approach to exposing does not assume a particular general solution, and is something that would really be a big win for you, then I'll not feel comfortable discouraging you.  If it is a minor win, or if it involves changes to launchpadlib itself, then I'll be skeptical that this should be pursued until Leonard and I have bandwidth to discuss it.19:54
james_wI can expose it anyway you like19:55
james_wI definitely do not intend to change launchpadlib19:55
james_wand the fact that I am working on LP rather than continue to wait for the change to bubble to the top of an LP developers stack should indicate that it is important for us19:56
=== Ursinha-lunch is now known as Ursinha
leonardrjames_w, gary: i've responded via email19:59
james_wthanks leonardr19:59
gary_posterjames_w: "expose any way you like": if it is within the range of the current standard tools to expose APIs, please consider me out of your way.  The code team (and probably Jono, with his experience there) are the ones to guide you.20:03
gary_poster"do not intend to change launchpadlib": OK sorry, that was a question I had when I read that a change would be on the "client side."  A misunderstanding.20:03
gary_posternot waiting for LP developers: understood.20:03
gary_posterI don't want to be a hindrance.  It doesn't sound like I need to be one.  Sorry for the noise.20:03
james_wgary_poster: thanks, let's continue discussion on the mailing list to decide what the best way to proceed is, at least in the short-term.20:09
gary_posterjames_w: cool.20:10
=== dpm is now known as dpm-afk
leonardris there an easy way to look up a member of an enum by token?20:33
mwhudsonleonardr: what do you mean by 'token' ?20:47
leonardrmwhudson: i'm looking at a dbenum value and it has a number of fields: .token, .sort_key, etc20:48
leonardrthat's the token i mean20:48
mwhudsonum20:52
mwhudsoni don't see token on this dbitem20:52
thumpermorning20:53
thumperleonardr: yes20:53
thumperleonardr: I think20:53
mwhudsonleonardr: it looks like the class has a getTermByToken method though20:53
leonardrok, let me get precise about what i'm seeing20:55
leonardr<DBEnumeratedType 'OAuthPermission'>20:56
leonardrit has a .description and an __iter__20:57
leonardr[x for x in OAuthPermission] is a bunch of lazr.enum._enum.TokenizedITem objects20:57
leonardreach has a .title, a .token, and a .value20:57
* thumper nods20:58
leonardri don't see any lookup methods anywhere. i get the feeling this is on a different level of abstraction from DBItem20:58
thumperleonardr: the item lookup is abstracted21:00
thumperleonardr: for no good reason21:00
leonardri'm getting the feeling it's not worth figureing this out to save a couple lines of code21:00
thumperwhat are you wanting?21:01
leonardrhere's my code21:01
leonardr        for check_permission in OAuthPermission:21:01
leonardr            if check_permission.token == permission:21:01
leonardr                permission = check_permission.value21:01
leonardr                break21:01
thumperto get the enuerated value from the token name?21:01
leonardri'd like to write permission = OAuthPermission.getByToken(permission)21:01
thumperpermission = OAuthPermission.items[permission]21:02
thumperassuming permission is the string21:02
thumper>>> i21:03
thumper<lazr.enum._enum.TokenizedItem object at 0x77526d0>21:03
thumper>>> i.token21:03
thumper'WRITE_PRIVATE'21:03
thumper>>> t21:03
thumper<DBEnumeratedType 'OAuthPermission'>21:03
thumper>>> t.items[i.token]21:03
thumper<DBItem OAuthPermission.WRITE_PRIVATE, (50) Change Anything>21:03
thumperleonardr: that work for you?21:05
leonardryes, that seems to work21:08
thumpercoolio21:08
leonardrthanks21:14
lifelessmoin21:44
=== salgado is now known as salgado-afk
* mwhudson rebooting22:27
thumper✁☹22:37
thumperthat is for whoever decided that preferredemail was better than preferred_email22:38
thumperand while we're at it22:38
thumperdisplayname instead of display_name22:38
mwhudsonthumper: ancient history isn't it?22:38
thumperprobably22:38
mwhudsonfor a while _ wasn't allowed in column names in the db22:38
thumperstupid22:39
thumperevery time I need to access preferredemail I get it wrong22:40
thumpermwhudson: got a minute to talk through something twisted?22:57
thumperhmm.. that could be a no22:57
=== matsubara-afk is now known as matsubara
mwhudsonwell, that was err, fun23:07

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!