[10:43] abentley, can you take a look at https://code.edge.launchpad.net/~leonardr/launchpad/launchpadlib-pagetests-take-2/+merge/22444 ? [10:53] leonardr: The catastrophic test failures did actually occur on EC2, buildbot and locally. But they were sufficiently catastrophic that they killed the test suite in such a way that the failure wasn't detected by the outer test process. [10:54] leonardr: did you see https://code.edge.launchpad.net/~mwhudson/launchpad/aiee-everything-is-broken/+merge/22185 ? [10:55] mind you i think your branch is mostly better [11:00] mwhudson: i hadn't seen that. it sucks that we duplicated work [11:02] leonardr: well, if i'd actually run the tests after my last commit on friday... [11:02] mwhudson: shall i go ahead with my branch? is there anything you'd like me to change? [11:02] leonardr: the work i did since friday took about 5 minutes, so i don't mind really [11:02] ok [11:02] leonardr: i didn't see anything to change, let me have another look [11:03] all right [11:03] you can do the review if you want, i haven't heard from abentley [11:06] Looks like he tried to unassign himself from the topic many hours ago, but instead spoke the new topic into the channel. [11:07] ahh === leonardr changed the topic of #launchpad-reviews to: on call: - || reviewing: -|| queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [11:10] leonardr: done [11:11] mwhudson: fyi, the xx-wadl thing [11:11] previously there was a pre-cached 'testrunner wadl file' which was used in xx-wadl.txt [11:11] if you tried to use launchpadlib from a pagetest, it would pick up the testrunner wadl file and believe that launchpad had no capabilities at all, since the testrunner wadl file was basically empty [11:11] leonardr: ah [11:11] that makes sense [11:12] so i removed the testrunner wadl file, but then i needed a bigger test to prove that launchpad's wadl caching worked [11:15] The WADL's not generated for every test, right? [11:24] the wadl is generated when it's requested and not present on disk [11:25] and not present in the in-memory cache [11:26] Great. [11:26] that's one wadl generation per version requested per launchpad restart [11:27] Excellent. === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: -|| queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [13:22] morning everyone. bring out yer dead. === sinzui changed the topic of #launchpad-reviews to: on call: bac || reviewing: -|| queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [16:03] bac: I have a short branch when you have time. I will have spm test it to verify we want to land the trivial fix. === deryck is now known as deryck[lunch] [16:24] bac, can you review https://code.launchpad.net/~salgado/launchpad/bug-547054/+merge/22460 for me? === salgado changed the topic of #launchpad-reviews to: on call: bac || reviewing: -|| queue: [sinzui,salgado] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === salgado is now known as salgado-lunch [16:53] sinzui: are you seeking a r-c for your branch? [16:53] no [16:54] ok, i'll mark it approved then === deryck[lunch] is now known as deryck === matsubara is now known as matsubara-lunch === salgado-lunch is now known as salgado === matsubara-lunch is now known as matsubara === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: -|| queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === leonardr is now known as leonardr-afk [19:51] some brave soul might want to review https://code.edge.launchpad.net/~jml/launchpad/ssh-key-auth/+merge/21801 -- but please don't feel obliged [19:51] I'll look at it later to try to break it down into smaller branches. [19:52] mentioning in case someone would prefer to spare me the trouble [19:52] thanks for the review, bac. :) [19:53] salgado: np [19:54] jml: is it mostly mechanical? [19:54] bac, sadly no. [19:54] jml: ick [19:54] bac, I mean, a lot of it is just moving stuff into another place and then tweaking it a little [19:55] bac, but it deserves quite a thorough review, IMO. [19:55] jml: right [19:55] jml: sadly for you i was experimenting with using a smallest-first approach to +activereviews today [19:56] bac, heh, that's ok :) [19:56] bac, I'll leave it in the IRC backlog just in case someone is feeling really really generous. === matsubara_ is now known as matsubara === sinzui changed the topic of #launchpad-reviews to: on call: bac || reviewing: -|| queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [21:08] bac: https://code.launchpad.net/~sinzui/launchpad/auto-yui-tests/+merge/22485 could unblock you [21:08] sinzui: and you move to the front of the queue [21:08] well, you were already at the front [21:09] I am also at the back of the que :( [21:09] And I lost a "ue" [21:09] potato/potato [21:09] potatoe! [21:09] thanks you happy campers [21:11] * sinzui ponders how two Bush presidents could pick such diametrically opposed VPs [22:09] sinzui: your yui test runner only works for lp.registry, right? [22:09] yes [22:10] but my JS for product series was moved to lp.code. [22:10] :( [22:10] I can make a small change to include other tests [22:10] yeah, we'll have to. but it would've been nice to keep it isolated [22:11] I need to set the layer dynamically [22:11] Subclass the test runner for code [22:11] * sinzui could move the test class to lp.testing === salgado is now known as salgado-afk [22:15] bac: Do you want me to move the class into lp.testing then subclass it for registry? [22:16] yes i guess that makes the most sense. [22:16] then i'll do it for code [22:16] or move into lp.testing and dynamically set the test name/layer part [22:16] the former makes more sense to me [22:17] okay === matsubara is now known as matsubara-afk [22:49] bac ping [22:49] hi [22:50] bac: I moved the base test class to lp.testing... [22:50] I got a circular import for canonical.launchpad.testing.pages... [22:50] ok, can you paste a diff and put a link in the MP? [22:51] doh [22:51] * bac hides [22:52] https://pastebin.canonical.com/29881/ [22:54] bac: I think paste of the actual code is easier to read [22:54] https://pastebin.canonical.com/29883/ [22:57] yeah, the diff is a mess since the file got gutted [22:57] but the change looks great [22:57] I think I know how to make timelines work... [22:57] maybe I'll do that for edwin to review tomorrow === bac changed the topic of #launchpad-reviews to: on call: - || reviewing: -|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews