| wgrant | How is the discussion about community committers/reviewers going? | 00:07 |
|---|---|---|
| mwhudson | it's petered out | 00:09 |
| === almaisan-zzz is now known as almaisan | ||
| === almaisan is now known as almaisan-zzz | ||
| thumper | mwhudson: had lunch yet? | 01:22 |
| mwhudson | thumper: no | 01:22 |
| thumper | you should grab something to eat, then we can talk about reviews :) | 01:23 |
| mwhudson | thumper: just finished with kiko | 01:38 |
| thumper | :) | 01:39 |
| thumper | ok | 01:39 |
| mwhudson | thumper: so yeah, i need to eat, and then we should talk | 01:51 |
| * mwhudson lunches | 01:55 | |
| === Ursinha is now known as Ursinha-afk | ||
| mwhudson | huh, x has gone odd and i need to restart anyway so... | 02:20 |
| mwhudson | argh | 02:35 |
| mwhudson | i've managed to uninstall gnome-panel somehow :/ | 02:35 |
| thumper | :( | 02:50 |
| thumper | mwhudson: ping | 03:15 |
| mwhudson | thumper: pong | 03:17 |
| mwhudson | (sorry, no notifications with no panel!) | 03:17 |
| thumper | heh | 03:17 |
| thumper | mwhudson: when do you want to do a call? | 03:17 |
| mwhudson | thumper: now is good | 03:18 |
| wgrant | I pushed a couple of new revs to a branch 12 minutes ago... still awaiting scanning. | 05:16 |
| spm | looking.... | 05:23 |
| wgrant | It's scanned now. | 05:24 |
| wgrant | Just took ages. | 05:24 |
| wgrant | Not quite 2006-ages, but getting close. | 05:24 |
| spm | hrm... | 05:24 |
| spm | :-) | 05:24 |
| wgrant | Part of that could be slave lag too, I guess. | 05:24 |
| spm | slave lag? as in DB? shouldn't be that bad! | 05:25 |
| wgrant | I'd hope not. | 05:25 |
| lifeless | thumper: mwhudson: have you guys seen beanstalkd ? | 06:00 |
| mwhudson | lifeless: no | 06:04 |
| StevenK | Bah, registering an MP just gave me a timeout error | 06:44 |
| mwhudson | StevenK: the branch was probably still being scanned | 06:45 |
| lifeless | mwhudson: apparently designed 'to make websites faster by doing slow tasks asynchronously' | 06:45 |
| lifeless | http://flapjack-project.com/ references it | 06:46 |
| mwhudson | StevenK: wait a minute or so and resubmit | 06:46 |
| mwhudson | lifeless: on the face of it, that sentence doesn't make sense :) | 06:46 |
| mwhudson | but i guess i know what they're driving at | 06:46 |
| StevenK | mwhudson: Aye, will do | 06:46 |
| lifeless | i paraphrased an equally not-quite-sane quote | 06:46 |
| lifeless | anyhow, might be worth a gander | 06:47 |
| mwhudson | lifeless: it seems a bit like gearman, maybe? | 06:47 |
| lifeless | maybe, more lightweight and message bussy I think | 06:47 |
| StevenK | mwhudson: Worked, thanks | 06:47 |
| mwhudson | StevenK: np, it's just another reason to kill the branchrevision table... | 06:48 |
| mwhudson | lifeless: it does have a "simple enough to possibly work" sort of feel to it | 06:50 |
| lifeless | auxesis told me about it a year or so back | 06:51 |
| lifeless | and I blanked on it when the whole reinvent wheels was going on | 06:51 |
| lifeless | just got reminded, so - saying;) | 06:51 |
| adeuring | good morning | 08:01 |
| === almaisan-zzz is now known as al-maisan | ||
| mrevell | Morning | 09:10 |
| === jelmer is now known as Guest17661 | ||
| thumper | lifeless: I don't understand what beanstalked is | 09:17 |
| wgrant | noodles775: So, apart from the state thing, how does the proposal look? | 09:18 |
| noodles775 | wgrant: It looks great so far... I usually find some things come out in the wash, hence putting together the schema change. But it allows everything we discussed earlier (common shared data, shared data for package builds etc.) | 09:25 |
| noodles775 | wgrant: I'll create a WIP mp when it's ready and add you to it to get your feedback/thoughts. | 09:26 |
| wgrant | noodles775: Great, thanks. | 09:26 |
| === mthaddon changed the topic of #launchpad-dev to: Launchpad will be down/in read-only from 11:00 UTC until 13:00 UTC for a code update | Launchpad Development Channel | Week 4 of 10.03 | PQM is in RC mode | Release manager: deryck | https://dev.launchpad.net/ | Get the code: https://dev.launchpad.net/Getting | On-call review in irc://irc.freenode.net/#launchpad-reviews | Use http://paste.ubuntu.com/ for pastes | ||
| wgrant | noodles775: http://people.ubuntu.com/~wgrant/launchpad/buildfarm/new-build-model-again.png <- now with fewer missing attributes, more compliant names, and proper lp.* division | 10:27 |
| noodles775 | wgrant: thanks. | 10:27 |
| wgrant | The layout seems quite a bit busier, but it is hopefully more accurate. | 10:28 |
| wgrant | Hm, early release? | 10:29 |
| === almaisan-zzz is now known as almaisan | ||
| noodles775 | wgrant: how do you feel about s/job/build_farm_job so we don't have confusion over the job table? | 10:36 |
| wgrant | noodles775: Good point. | 10:36 |
| noodles775 | wgrant: also, am I right that there's a bunch of stuff missing atm? (like IBuild.package_upload -> PackageBuild?, IBuild.can_be_retried/rescored -> BuildFarmJob?) | 10:42 |
| noodles775 | I'll do an initial change, and then check for missing fields in the new schema, probably easier. | 10:42 |
| noodles775 | erm, forget the last two... properties. | 10:43 |
| noodles775 | actually, forget I spoke at all :) | 10:44 |
| wgrant | Yeah, all properties. | 10:44 |
| wgrant | They should probably be included, but that would get very big. | 10:44 |
| noodles775 | Yeah, we can include them when updating the iface/model code. | 10:44 |
| wgrant | Yay, Sphinx. | 11:09 |
| * wgrant loves Sphinx. | 11:09 | |
| wgrant | Evening jtv! | 11:23 |
| jtv | hi wgrant! Sorry to have been ignoring you... half a world of travel plus tonsilitis. | 11:23 |
| jtv | But I suggest you visit Thailand someday and we'll fix that. I'll personally guarantee that you have a good time. :) | 11:23 |
| wgrant | Ew, tonsilitis. | 11:23 |
| jtv | (I'm gushing a bit because of the "oh btw I fixed the bugs" thing :-) | 11:24 |
| * wgrant is still not quite over the Wellington whooping cough. | 11:24 | |
| jtv | whoa | 11:24 |
| wgrant | Yeah, it likes to stick around for a couple of months. | 11:24 |
| jtv | yes, it sort of contradicted for me the whole theory that January is midsummer on that hemisphere... | 11:24 |
| wgrant | Heh. | 11:24 |
| jtv | So, what were the remaining bugs? | 11:25 |
| wgrant | So, yeah, template builds and uploads work with a couple of my branches. 'tis encouraging. | 11:25 |
| * wgrant digs up the branches. | 11:25 | |
| wgrant | https://code.edge.launchpad.net/~wgrant/launchpad/bug-549340-fix-buildqueue-destruction <- this one has been rejected, but should be resolved by noodles' model redesign. | 11:26 |
| wgrant | And the last three revs on https://code.edge.launchpad.net/~wgrant/launchpad/get-translations-jobs-working | 11:26 |
| * jtv looks | 11:27 | |
| jtv1 | BTW thanks for unifying the slaveStatus... for our use case it was painfully obvious that something like that was needed, but I just didn't have enough overview to be sure about the other use-cases. | 11:28 |
| jtv1 | okay I shouldn't have touched that cable... | 11:28 |
| === jtv1 is now known as jtv | ||
| jtv | bit awkward here with a main machine that won't boot and a router that throws up packet storms... means I had to plug the iffy wall cable straight into my laptop. | 11:29 |
| wgrant | Hah. | 11:30 |
| wgrant | Yeah, that slaveStatus branch should be landed right after PQM opens. | 11:30 |
| wgrant | Then I'll get the others in soon after, although things won't work completely until the modle rework. | 11:32 |
| wgrant | So we might actually have three working build farm jobs in 10.04... maybe. | 11:32 |
| jtv | We're certainly hoping we can manage that. | 11:33 |
| jtv | By the model rework you mean the simplification with build attempts etc. that you sketched out two weeks or so ago? | 11:33 |
| wgrant | No attempts any more. I believe noodles is currently attempting to realise something like http://people.ubuntu.com/~wgrant/launchpad/buildfarm/new-build-model-again.png | 11:34 |
| noodles775 | jtv: yep, I'll have a WIP MP with a very early schema change in a few mins. | 11:35 |
| jtv | cool! | 11:35 |
| jtv | noodles775: meanwhile, we've been talking about replacing getName/verifySlaveBuildID with a single generateSlaveCookie method that produces a hashed cookie. Verification consists of re-generating it and seeing that it matches what the slave says. | 11:35 |
| wgrant | jtv: I've another branch which rips the slave build ID out of everywhere except rescueBuilderIfLost, so you will be able to completely replace it without breaking anything else. | 11:36 |
| noodles775 | jtv: yeah I saw. Is that related to wgrant's branch that removes the builder dependency on ... | 11:36 |
| jtv | it gets better and better :) | 11:36 |
| noodles775 | wgrant, jtv, bigjools: If you want to take an early look, grab the branch from https://code.edge.launchpad.net/~michael.nelson/launchpad/db-build-generalisation-db-changes/+merge/22527 before LP goes down in 10mins :) | 11:48 |
| bigjools | good call :) | 11:48 |
| * wgrant grabs. | 11:48 | |
| jtv | noodles775: thanks | 11:48 |
| noodles775 | There are a lot of notes/todos in there, but it'll give you a chance to let me know if it's heading in the right direction. | 11:49 |
| wgrant | I think they might've turned off the cron jobs off already. | 11:49 |
| noodles775 | OK, I'll paste a diff. | 11:49 |
| jtv | that'd make sense, let things quiet down. | 11:49 |
| wgrant | There's no mirrored copy of the branch, nor diff. :( | 11:49 |
| bigjools | gah | 11:49 |
| bigjools | branching failed | 11:50 |
| noodles775 | wgrant, jtv, bigjools: http://pastebin.ubuntu.com/406980/ | 11:50 |
| wgrant | noodles775: Thanks. | 11:50 |
| bigjools | ta | 11:51 |
| wgrant | I was thinking that it was rather simple. But of course there's no non-binary job data, so it can be... | 11:53 |
| wgrant | Convenient. | 11:53 |
| noodles775 | wgrant: Yeah, if we don't have to populate with any future SPRBuild data, it will be convenient. | 11:54 |
| wgrant | noodles775: I'd like to make BFJ.virtualized NOT NULL while we're at it. | 11:57 |
| noodles775 | Noted. | 11:57 |
| jtv | noodles775: what's the stuff with the sequence for? | 11:58 |
| wgrant | Virtualisation is very much something that you can't care about here. | 11:58 |
| wgrant | Er, can't *not* care about. | 11:58 |
| noodles775 | jtv: It's just because I created the tables using CREATE TABLE blah AS (as I think it's a bit more readable, enabling the table creation based on existing data/types etc.) | 11:59 |
| noodles775 | But the only way I could see to have a primary key as the first column using this method was to explicitly create the sequence. | 11:59 |
| jtv | noodles775: that's true... the other way to do it would be a conventional CREATE TABLE followed by INSERT INTO | 11:59 |
| noodles775 | (adding a primary key afterwards works fine, but it ends at the end of the table). | 12:00 |
| noodles775 | jtv: Yeah, I guess I thought the advantage of inheriting all the column defs from the existing tables was nice... but maybe it's not worth it? | 12:00 |
| noodles775 | It's really just the value+type. | 12:01 |
| jtv | noodles775: it's not going to be all that important (barring mistakes), but personally I prefer to have all the constraints and indexes in there from the start. Also makes it easier to catch little things like fixed-size columns following text columns. | 12:02 |
| noodles775 | jtv: yep. OK, I'll switch it over. | 12:03 |
| noodles775 | jtv1: yep. OK, I'll switch it over. | 12:03 |
| jtv1 | cool, thanks for accommodating my OCD. :) | 12:05 |
| === almaisan is now known as almaisan-afk | ||
| === jtv1 is now known as jtv | ||
| jtv | Can anyone (esp. Registry I guess) shed some light on this shortlist exception? OOPS-1550O2497 | 12:10 |
| wgrant | noodles775: I wondered about build_warnings. I guess we should just drop it. | 12:19 |
| === almaisan-afk is now known as al-maisan | ||
| === matsubara-afk is now known as matsubara | ||
| noodles775 | wgrant: yeah, i can only see it in the schema. | 13:12 |
| === mrevell is now known as mrevell-lunch | ||
| wgrant | noodles775: Are you going to leave buildduration in the model as an abstraction? We'll hopefully be able to fill it in properly soon. | 13:19 |
| noodles775 | wgrant: as a property on the model, sure, but I'm not sure why we'd want to fill it in (ie. for it to be a db column?). | 13:23 |
| noodles775 | Or that's what you meant? | 13:24 |
| wgrant | noodles775: It has been thought for a while that we should eventually retrieve the real duration from the slave. | 13:24 |
| noodles775 | wgrant: ah I see. Well, I'm guessing rather than "We'll be using it real soon", we'll just have to add it later then ;) | 13:25 |
| wgrant | noodles775: Yep, just leave it as a property for now. | 13:26 |
| === Ursinha-afk is now known as Ursinha | ||
| sinzui | I just saw an interesting test failure in ec2. object-milestones failed because the test data used 2010-04-01 and 2010-04-02 and the test is verifying those dates...but the UI shows the dates as "in 22 hours" as the moment counts down. | 13:46 |
| sinzui | jpds: you can ignore the error in the test, there is nothing for you to do. | 13:46 |
| jpds | sinzui: I figured so. :) | 13:47 |
| wgrant | Hah. | 13:47 |
| wgrant | We are in the future now. | 13:47 |
| sinzui | We were promised jet packs in the future, where is mine? | 13:50 |
| === mthaddon changed the topic of #launchpad-dev to: Launchpad will be down/in read-only from 11:00 UTC until 14:00 UTC for a code update | Launchpad Development Channel | Week 4 of 10.03 | PQM is in RC mode | Release manager: deryck | https://dev.launchpad.net/ | Get the code: https://dev.launchpad.net/Getting | On-call review in irc://irc.freenode.net/#launchpad-reviews | Use http://paste.ubuntu.com/ for pastes | ||
| === leonardr_ is now known as leonardr | ||
| deryck | another hour on release time, for those who missed the channel change or the chatter on #launchpad | 14:05 |
| kfogel | adeuring: did you have a chance to review my bug #538219 branch before LP went read-only? (I'm having trouble reaching the branch right now, or I'd just look.) | 14:11 |
| adeuring | kfogel: sorry -- I missed completely your review request ( | 14:12 |
| kfogel | adeuring: np, just when you have a chance (and lp is back) take a look | 14:13 |
| adeuring | kfogel: to avoid such a mess in the future, please ping me on IRC and I'll do the review ASP | 14:13 |
| kfogel | adeuring: I think it's a pretty small change. I didn't refactor some duplicated in the tests because it didn't seem worth it yet. | 14:13 |
| kfogel | adeuring: oh, you were definitely asleep when I made the MP :-) | 14:13 |
| adeuring | kfogel: well, oh, right, that was around midnight my time... But anyway, somehow I do not notice the review requests in my inbox properly... | 14:14 |
| kfogel | adeuring: it's really no mess, don't worry. Considering that the next release is a month away, it's okay if there's a day delay in reviewing this change! (I just wish I'd finished it sooner.) | 14:15 |
| noodles775 | wgrant: around? I keep finding my self saying, BuildFarmJob, PackageJob, BinaryPackageJob, insteada of PackageBuild, BinaryPackageBuild. | 14:25 |
| noodles775 | I'm keen for the Build ending, but wondering if we shoud update BuildFarmJob to SomethingFarmBuild? | 14:25 |
| === mrevell-lunch is now known as mrevell | ||
| leonardr | flacoste, before we can put launchpadlib 1.5.8 into lucid (that's the one that uses web service 1.0 by default) | 14:43 |
| leonardr | we need to port all the packages that use launchpadlib to api version 1.0 | 14:43 |
| leonardr | jamesw identified 9 such packages | 14:43 |
| leonardr | apport | 14:43 |
| leonardr | bughugger | 14:43 |
| leonardr | bzr-builddeb | 14:43 |
| leonardr | bzr-pqm | 14:43 |
| leonardr | groundcontrol | 14:43 |
| leonardr | lptools | 14:43 |
| leonardr | quickly | 14:43 |
| leonardr | ubuntu-dev-tools | 14:43 |
| leonardr | ubuntu-qa-tools | 14:44 |
| leonardr | pitti ported apport yesterday | 14:44 |
| leonardr | some of these probably don't need to be ported, but we need to at least check | 14:44 |
| flacoste | oh shit | 14:44 |
| flacoste | that's a lot of work :-/ | 14:44 |
| flacoste | when the beta2 is coming out in a week | 14:44 |
| leonardr | yeah | 14:44 |
| leonardr | i'm happy to help but we need to coordinate with the owners of those packages | 14:44 |
| leonardr | the porting is easy (assuming these apps have unit tests) | 14:45 |
| leonardr | the coordination is a time sink | 14:45 |
| james_w | we don't really have owners of packages in Ubuntu | 14:47 |
| james_w | I can help you make the changes easily | 14:47 |
| leonardr | ok, that makes things look better | 14:48 |
| leonardr | flacoste, gary, should i go for it? (gary: this would mean putting off the launchpadlib pagetest thing) | 14:49 |
| leonardr | gary: or i can finish the pagetest branch first | 14:49 |
| flacoste | leonardr, gary_poster: since that item has a Due date, i think it makes sense to push that forward first | 14:49 |
| gary_poster | leonardr: Yeah, I'm +1 on working on that | 14:50 |
| flacoste | gary_poster, leonardr: especially if it means we don't need to support the /beta webservice for 5 years! | 14:50 |
| leonardr | all right | 14:50 |
| gary_poster | right :-) | 14:50 |
| leonardr | james_w, do you have time? | 14:50 |
| leonardr | if not i can send you recommendations via email | 14:50 |
| james_w | right now? | 14:50 |
| leonardr | james_w: i'm going to start right now, but like i said, if you're not free, you can come in late | 14:51 |
| james_w | I'll be with you in 20 | 14:51 |
| leonardr | all right | 14:52 |
| james_w | leonardr: ok, I'll take bzr-builddeb obviously, and ubuntu-qa-tools | 15:00 |
| leonardr | james_w: there don't seem to be any changes necessary to ubuntu-qa-tools, but look it over to double check | 15:00 |
| james_w | oh, ok | 15:00 |
| james_w | should we make it explicit anyway? | 15:01 |
| === mthaddon changed the topic of #launchpad-dev to: Launchpad Development Channel | Week 4 of 10.03 | PQM is in RC mode | Release manager: deryck | https://dev.launchpad.net/ | Get the code: https://dev.launchpad.net/Getting | On-call review in irc://irc.freenode.net/#launchpad-reviews | Use http://paste.ubuntu.com/ for pastes | ||
| james_w | leonardr: are we changing the constructor call to make it explicit, or just allowing them to pick up the default? | 15:21 |
| leonardr | james_w: allowing them to pick up the default | 15:21 |
| james_w | ok | 15:21 |
| leonardr | i'm concerned about 1) uses of named operations not present in 1.0 | 15:21 |
| leonardr | 2) explicit references to "beta" | 15:21 |
| james_w | I agree that ubuntu-qa-tools is fine, bughugger is done | 15:21 |
| leonardr | because of 2) i just realized that ubuntu-qa-tools is not fine | 15:22 |
| james_w | ok | 15:22 |
| james_w | bzr-builddeb is fine | 15:22 |
| leonardr | all right | 15:22 |
| james_w | bzr-pqm is broken | 15:22 |
| leonardr | there are several calls to launchpad.load() which include a "beta" url | 15:22 |
| james_w | yeah | 15:24 |
| james_w | what should they use there? | 15:25 |
| james_w | lp.load(SERVICE_ROOT + "bugs/" ... | 15:25 |
| james_w | or does it need the version in there too? | 15:25 |
| leonardr | the version does need to be in there | 15:28 |
| leonardr | let me try to find a better solution | 15:28 |
| james_w | urg, we would have to use lp._root_uri | 15:29 |
| leonardr | yeah | 15:30 |
| leonardr | but, that's better than having a hard-coded version | 15:30 |
| james_w | yeah | 15:30 |
| james_w | would be great if lp.load could interpret a relative URL as being relative to the service root | 15:30 |
| gary_poster | deryck, did you decide on a "consider opening up PQM" time? | 15:32 |
| leonardr | james_w: yeah, that's bug 524775 | 15:32 |
| mup | Bug #524775: Launchpad.load doesn't like relative urls <launchpadlib :New> <https://launchpad.net/bugs/524775> | 15:32 |
| deryck | gary_poster, thinking about that now actually. | 15:32 |
| gary_poster | cool | 15:32 |
| leonardr | james_w: i could fix that easily, but releasing a 1.5.7.1 launchpadlib would be a bit of a pain. do you think it's worth it? | 15:32 |
| james_w | we can just use lp._root_uri + | 15:33 |
| leonardr | yeah | 15:34 |
| gary_poster | how much of a pain leonardr? and is this the only app that does this? | 15:34 |
| leonardr | gary: no, it's all over | 15:34 |
| gary_poster | ... | 15:34 |
| leonardr | lifeless even put a special hack into lptools/launchpad.py to fix bug 524775 | 15:34 |
| mup | Bug #524775: Launchpad.load doesn't like relative urls <Launchpad Foundations:Triaged> <launchpadlib :Triaged> <https://launchpad.net/bugs/524775> | 15:34 |
| gary_poster | james_w, leonardr, how tight is time? | 15:35 |
| gary_poster | and how long will this take? | 15:35 |
| leonardr | gary: james_w and i agree it's not worth it right now | 15:35 |
| leonardr | we'll just use _root_uri | 15:35 |
| gary_poster | ...don't like it, but ok. | 15:36 |
| james_w | we can take a list of the ones we do it to and followup with a correct fix once it is fixed in lplib | 15:36 |
| leonardr | yeah | 15:36 |
| gary_poster | ok | 15:37 |
| gary_poster | might as well dump that info in the bug report, once you have it | 15:37 |
| leonardr | james_w: my proposed changes to ubuntu-qa-tools | 15:42 |
| leonardr | http://paste.ubuntu.com/407091/ | 15:42 |
| leonardr | gary: so far all the changes are "now it has to support multiple versions" changes, not 1.0-specific changes | 15:42 |
| james_w | my bughugger change: https://code.edge.launchpad.net/~james-w/bughugger/fix-api-usage/+merge/22536 | 15:43 |
| gary_poster | leonardr: good, and not surprising | 15:43 |
| james_w | leonardr: looks good to me | 15:43 |
| leonardr | apport was the only app that actually used those features | 15:43 |
| leonardr | james_w: i'm pushing a branch | 15:43 |
| james_w | bzr-pqm: https://code.edge.launchpad.net/~james-w/bzr-pqm/fix-service-roots/+merge/22540 | 15:44 |
| leonardr | https://code.edge.launchpad.net/~leonardr/ubuntu-qa-tools/fix-api-usage | 15:46 |
| leonardr | james_w, taking a look at yours | 15:46 |
| === jelmer is now known as Guest91560 | ||
| === deryck is now known as deryck[lunch] | ||
| leonardr | james_w: i have a bad feeling about the get_bazaar_host calls in bzr-pqm | 16:06 |
| === Ursinha is now known as Ursinha-lunch | ||
| leonardr | investigating | 16:06 |
| leonardr | eh, i guess theres' tests for it, they'l'l fail if something's wrong | 16:07 |
| leonardr | james_w: i'm pretty sure quickly doesn't need any changes | 16:09 |
| james_w | good | 16:10 |
| leonardr | lptools does need changes, working on them now | 16:10 |
| leonardr | https://code.edge.launchpad.net/~leonardr/lptools/multiversion-support/+merge/22544 | 16:20 |
| * leonardr does not look forward to searching for "1.0" in 5 years when we're trying to deprecate 1.0 | 16:27 | |
| leonardr | perhaps we should give the api versions ubuntu release-like names that do not conflict with ubuntu release names | 16:28 |
| james_w | lptools looks good to me | 16:31 |
| leonardr | i don't see any problems with groundcontrol, i'm confirming with doctormo | 16:31 |
| leonardr | james_w: the only one i don't have information for is bzr_builddeb. what does that look like? | 16:33 |
| james_w | I'll fix it | 16:33 |
| james_w | it's got an lp.load | 16:33 |
| leonardr | all right | 16:33 |
| leonardr | confirmed that the lp.load is the only problem | 16:35 |
| === salgado is now known as salgado-lunch | ||
| === al-maisan is now known as almaisan-afk | ||
| === almaisan-afk is now known as al-maisan | ||
| === al-maisan is now known as almaisan-afk | ||
| === almaisan-afk is now known as al-maisan | ||
| abentley | bigjools, re: http://pastebin.ubuntu.com/407124/ can self.can_copy_to_context_ppa ever evaluate false in this loop? | 16:45 |
| bigjools | looking | 16:45 |
| abentley | bigjools, (and if so, would you really want to present it as a potential copy target to the user?) | 16:47 |
| bigjools | abentley: it could do in some weird situations | 16:47 |
| abentley | bigjools, so in those situations, it would make sense as a copy target? | 16:48 |
| bigjools | no, it doesn't | 16:48 |
| bigjools | that's what the loop's doing isn't it? | 16:48 |
| abentley | bigjools, the loop says it will be included as a possible target if the user can't upload to it. | 16:48 |
| abentley | If it evaluates false, the and expression is false, and so it will be included in the list of terms. | 16:49 |
| jtv1 | sinzui: thanks for the help with the shortlist issue. I now remember it was adeuring who came across before, and I reviewed the branch myself. Is anyone fixing it or shall I? | 16:49 |
| bigjools | abentley: ah no it's excluding the context PPA | 16:50 |
| jtv1 | abentley: hi! Did you claim a review for me and not get around to finishing it? | 16:50 |
| === jtv1 is now known as jtv | ||
| abentley | jtv, oh, maybe. | 16:50 |
| bigjools | abentley: it's just doing it in a very odd way | 16:50 |
| jtv | abentley: hope "maybe" is not your vote on the MP. ;-) | 16:51 |
| abentley | jtv, yes, I forgot about that. Sorry. I'll do it next. | 16:52 |
| jtv | abentley: cool, thanks. I wasn't going to force you, but would be grateful. | 16:52 |
| === gary_poster is now known as gary-lunch | ||
| abentley | bigjools, if the context ppa is included in self.ppas_for_user, and self.can_copy_to_context_ppa evaluates False, the context PPA will be included in the list of target PPAs. | 16:53 |
| bigjools | abentley: yeah that's what I mean by that code being weird! | 16:55 |
| abentley | bigjools, because the "and" expression will evaluate False, which means we won't continue. | 16:55 |
| bigjools | indeed | 16:56 |
| bigjools | abentley: I've no idea why the first condition is there | 16:56 |
| abentley | bigjools, my guess is that the context PPA should be excluded all the time. But "required" should only be set False if both conditions are true. | 16:57 |
| bigjools | abentley: the archive in question is not always a PPA | 16:57 |
| bigjools | it can be a copy archive | 16:57 |
| bigjools | which uses the PPA views/templates | 16:58 |
| bigjools | I think that's why it's there | 16:58 |
| abentley | bigjools, The context may not be a PPA or the "ppa" variable may not be a PPA? | 16:58 |
| bigjools | abentley: potentially both but the context usually | 16:59 |
| bigjools | the ppa variable is 99% a ppa | 17:00 |
| bigjools | unless there's a bug somewhere | 17:00 |
| === al-maisan is now known as almaisan-afk | ||
| abentley | bigjools, that suggests that 1% of the time, getPPAsForUser will return archives that are not PPAs. Is that what you mean? | 17:07 |
| abentley | bigjools, and if so, how to I force it to give me only ppas? | 17:07 |
| === almaisan-afk is now known as al-maisan | ||
| bigjools | abentley: it can happen if the user owns a non-PPA archive. This is very rare. | 17:08 |
| bigjools | abentley: actually let me check the code again | 17:08 |
| abentley | bigjools, but in both selects, it's requiring the ArchivePurpose==PPA. | 17:09 |
| bigjools | abentley: yes it does, my mistake, I was making a stupid assumption | 17:09 |
| abentley | bigjools, so let's rewind. I said "bigjools, my guess is that the context PPA should be excluded all the time. But "required" should only be set False if both conditions are true." | 17:11 |
| abentley | bigjools, do you agree with that now? | 17:11 |
| * jml afk | 17:15 | |
| bigjools | abentley: I agree | 17:17 |
| abentley | bigjools, cool. I'll tweak that as I refactor it, then. | 17:18 |
| === al-maisan is now known as almaisan-afk | ||
| === almaisan-afk is now known as al-maisan | ||
| bigjools | abentley: thanks - are you making a vocabulary out of it? | 17:19 |
| abentley | bigjools, I'll at least extract a function that turns a list of archives into a SimpleVocabulary. | 17:20 |
| bigjools | cool | 17:20 |
| abentley | bigjools, haven't made vocabularies before, so it's a bit new. | 17:21 |
| abentley | Because my context won't be an archive, I don't think the copy packages page can share an archive with the request-a-build page. | 17:22 |
| abentley | Because my context won't be an archive, I don't think the copy packages page can share *a vocabulary* with the request-a-build page. | 17:23 |
| bigjools | the vocab is dependent on the user | 17:23 |
| abentley | bigjools, but the vocab on the copy packages page is also dependent on the context ppa, and this won't be true for my case. | 17:24 |
| bigjools | that is true | 17:25 |
| bigjools | but it's a bit of a hack | 17:25 |
| === al-maisan is now known as almaisan-afk | ||
| === almaisan-afk is now known as al-maisan | ||
| abentley | bigjools, I haven't seen the UI, but it seems like another option would be to include the context PPA in the vocabulary, and select it using the "initial_values". | 17:27 |
| === matsubara is now known as matsubara-lunch | ||
| === deryck[lunch] is now known as deryck | ||
| sinzui_ | join #launchpad | 17:40 |
| === salgado-lunch is now known as salgado | ||
| === gary-lunch is now known as gary_poster | ||
| === beuno is now known as beuno-lunch | ||
| === sinzui_ is now known as sinzui | ||
| === matsubara-lunch is now known as matsubara | ||
| === curtis is now known as Guest6121 | ||
| === Guest6121 is now known as sinzui | ||
| jml | g'night all | 18:42 |
| james_w | leonardr: oops _root_uri isn't going to work: https://code.edge.launchpad.net/~leonardr/ubuntu-qa-tools/fix-api-usage/+merge/22541 | 18:48 |
| === al-maisan is now known as almaisan-afk | ||
| leonardr | james_w: we can convert that uri to a string easily enough | 18:56 |
| james_w | yep | 18:56 |
| === beuno-lunch is now known as beuno | ||
| === danilos is now known as daniloff | ||
| sinzui | gary_poster, ping | 19:36 |
| gary_poster | sinzui: on call pong you later? | 19:36 |
| sinzui | gary_poster, sure. barry and I want to know if there is a python 2.6 list of issues | 19:36 |
| gary_poster | no; that's my next task tho | 19:39 |
| barry | gary_poster, sinzui that's the #1 thing holding up my work on integrating lp w/ mm3 (which requires py2.6) | 19:41 |
| gary_poster | barry: it will be tackled this cycle | 19:42 |
| barry | gary_poster: fab | 19:42 |
| === pgquiles__ is now known as pgquiles | ||
| === jelmer is now known as Guest50585 | ||
| leonardr | james_w: any progress on bzr-builddeb? that's the only one i don't know about | 20:02 |
| james_w | leonardr: nope, I've been working on other things. | 20:03 |
| james_w | it's an easy job though | 20:03 |
| leonardr | james_w: i'll take a look if you want | 20:03 |
| james_w | no, it's fine | 20:03 |
| leonardr | all right, just let me know when you've got something so i can send another email | 20:03 |
| === Ursinha-lunch is now known as Ursinha | ||
| kfogel | sinzui: not sure if this is something you can answer, but the definition of lib/lp/bugs/browser/bugcomment.py:BugComment.can_be_shown() puzzles me and I'd like to ask someone about it. I expected it to contain code determining if getUtility(ILaunchBag).user can view this comment or not -- but instead, it's just about bugwatches. | 20:46 |
| kfogel | sinzui: Is there some other method that does what I expected can_be_shown() to do? I don't see any... (this is all for bug #546943, by the way). | 20:47 |
| mup | Bug #546943: Hidden bug comments still have a direct link/page that is visible <easy> <spam> <Launchpad Bugs:In Progress by kfogel> <https://launchpad.net/bugs/546943> | 20:47 |
| sinzui | kfogel, the rule may be vestigial. we hid imported bug comments for many months | 20:48 |
| kfogel | sinzui: I guess I'm looking for the condition that says "this comment is hidden", in the way meant by bug #546943. I thought this method was it, but it looks like not. | 20:49 |
| mup | Bug #546943: Hidden bug comments still have a direct link/page that is visible <easy> <spam> <Launchpad Bugs:In Progress by kfogel> <https://launchpad.net/bugs/546943> | 20:49 |
| kfogel | oh, maybe self.visible | 20:49 |
| sinzui | ah | 20:49 |
| sinzui | kfogel, .hidden means private. that is how we remove spam | 20:50 |
| kfogel | sinzui: i.e., it's nothing to do with authn perms that might differ by user -- "hidden" in this context means "hidden from everyone" | 20:50 |
| sinzui | kfogel, admins need to see them, maybe chr too | 20:50 |
| kfogel | ? | 20:50 |
| kfogel | sinzui: hmm, this prop might be on IMessage instead | 20:51 |
| * kfogel pokes around more | 20:51 | |
| sinzui | can_be_shown is from comment imports. .visible is from spam control. In this case losas need to see them so that they can find what needs to be reenabled | 20:52 |
| sinzui | kfogel, is the comment view guarded by a security checker? one that asks of the comment is .hidden and decides if the user can see it? | 20:53 |
| kfogel | sinzui: yes -- that was how I got to can_be_shown() in the first place | 20:53 |
| * sinzui thinks the comment and the link to it should have the same security rule. | 20:53 | |
| kfogel | sinzui: i.e., lib/lp/bugs/templates/bugtask-index.pt | 20:53 |
| sinzui | okay. I think I see | 20:53 |
| kfogel | sinzui: although bugcomment-index.pt also has that rule, ... | 20:54 |
| kfogel | but I think that may be a red herring | 20:54 |
| sinzui | We need up update the security rule on the view to do something like return user.is_admin or context.hidden | 20:55 |
| sinzui | we want the link to reuse the rule | 20:55 |
| kfogel | sinzui: thaht would be the clean fix, absolutely | 20:56 |
| kfogel | sinzui: I started my journey by trying to find out what the rule ought to be :-) | 20:56 |
| kfogel | sinzui: which is how I ended up here in the Emerald City | 20:56 |
| mwhudson | morning | 20:59 |
| kfogel | mwhudson: morning | 21:02 |
| kfogel | sinzui: I think I've got it now; thanks for the help. | 21:03 |
| sinzui | fab | 21:03 |
| kfogel | sinzui: hmm. I'm trying to test this on launchpad.dev now. Do you have any idea *how* the admins set a comment as hidden? | 21:08 |
| kfogel | I don't see any UI for it. | 21:08 |
| sinzui | kfogel, there is no ui :( | 21:10 |
| kfogel | sinzui: db tweak? | 21:10 |
| sinzui | they use an api script | 21:10 |
| kfogel | aaaah | 21:10 |
| kfogel | sinzui: ok, on it, thx | 21:10 |
| sinzui | I was thinking that we could provide an form for anything that provides IMessage that allows the admin to edit or hide the message. | 21:11 |
| === almaisan-afk is now known as al-maisan | ||
| sinzui | one day we will support this: /bugs/1/message/2/+edit | 21:12 |
| mup | Bug #1: Microsoft has a majority market share <iso-testing> <ubuntu> <Clubdistro:Invalid> <Computer Science Ubuntu:Invalid by compscibuntu-bugs> <EasyPeasy Overview:Invalid by ramvi> <Ichthux:Invalid by raphink> <JAK LINUX:Invalid> <OpenOffice:Invalid by lh-maviya> <Tabuntu:Invalid by tinarussell> <Tivion:Invalid by shakaran> <Ubuntu:In Progress by sabdfl> <ubuntu-express (Ubuntu):Invalid by jahyire2006> <Ubuntu Jaunty:In Progress> <ubuntu-expre | 21:12 |
| kfogel | sinzui: mup bit you :-) | 21:12 |
| sinzui | mup is a luser | 21:12 |
| kfogel | mthaddon: ping | 21:12 |
| kfogel | mthaddon: Do you have the script that admins use to set a bug comment as "not visible"? I'd like to see that script, if you do. | 21:13 |
| sinzui | I want re re-enable bug expiration and expire it | 21:13 |
| kfogel | losas, see above question I addressed to mthaddon | 21:14 |
| kfogel | sinzui: Victory! I think: I used psql to set the 'visible' boolean column to False for a comment I just added; now when I'm logged in as Foo Bar (i.e., launchpad.dev admin user), I still see that comment on the bug's page, but it's highlighted yellow now. Do you know if this is the expected behavior? | 21:20 |
| kfogel | ah, yes, and as anon user, I cannot see the comment. | 21:21 |
| sinzui | I do not know about a highlight rule | 21:23 |
| sinzui | I think gmb implemented the hid bug feature | 21:23 |
| === al-maisan is now known as almaisan-away | ||
| kfogel | sinzui: that helps. I'm pretty sure what I'm seeing is the intended behavior, though (I mean, modulo the bug I'm trying to fix) | 21:28 |
| wgrant | Hmm. Does anyone know if the PPA download counts script is running yet? | 21:30 |
| thumper | I've started getting: /usr/lib/pymodules/python2.6/lazr/uri/__init__.py:19: UserWarning: Module launchpadlib was already imported from /usr/lib/pymodules/python2.6/launchpadlib/__init__.py, but /usr/lib/pymodules/python2.6 is being added to sys.path | 21:50 |
| thumper | when I use bzr | 21:50 |
| thumper | anyone seen this? | 21:51 |
| thumper | or know how to fix it? | 21:51 |
| mwhudson | i see it | 21:54 |
| james_w | leonardr: lptools, ubuntu-qa-tools, bughugger and bzr-pqm all fixed in Ubuntu, bzr-builddeb will uploaded tomorrow | 22:01 |
| leonardr | great, i'll send an update | 22:07 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| kfogel | sinzui: wouldn't mind a little Captain Obvious, if you have a sec: http://paste.ubuntu.com/407277/ | 22:48 |
| kfogel | I'm pretty sure I've got some kind of wrong-type-of-object issue going on, but so far haven't been able to determine how to get to the object I need. | 22:48 |
| wgrant | kfogel: That's a fake BugComment. | 22:51 |
| wgrant | The real object is BugMessage. BugComment is a browser-specific wrapper. | 22:51 |
| wgrant | And it probably doesn't expose .visible yet. | 22:51 |
| === Guest50585 is now known as jelmer | ||
| wgrant | Hm, but it looks like it is. Odd. | 22:53 |
| === jelmer is now known as Guest45990 | ||
| kfogel | wgrant: looks like it is what? | 22:53 |
| wgrant | Oh, it's just not in IBugComment. | 22:53 |
| wgrant | kfogel: .visible is on BugComment, but not IBugComment. | 22:53 |
| kfogel | wgrant: you'd think I'd have all these laysers straight by now, but noooooooo. | 22:54 |
| wgrant | So it's accessible internally, but not externally. | 22:54 |
| kfogel | ah | 22:54 |
| kfogel | hmmm | 22:54 |
| kfogel | I wonder if exposing it is the right approach. | 22:54 |
| kfogel | What I really want is for the comment to 404 if visited via direct URL (e.g., bugs/54/comments/37) | 22:54 |
| === Guest45990 is now known as ctrlsoft | ||
| wgrant | Right, I was about to ask why you were doing it this way. | 22:54 |
| kfogel | right now, the effect that code would have (if it were working) would be to show a bug comment page, but with an empty space where the comment text should be | 22:55 |
| kfogel | wgrant: I'm not persuaded I should be doing it this way. | 22:55 |
| kfogel | wgrant: do you know a better way, a way to make the page pretend not to exist at all? | 22:55 |
| wgrant | kfogel: Change BugTaskNavigation.traverse_comments | 22:55 |
| kfogel | wgrant: ? hmrm. Let me look, bbiab | 22:56 |
| wgrant | Although you should probably 403 it instead. | 22:56 |
| wgrant | Rather than denying its existence. | 22:56 |
| wgrant | But I wonder how much other stuff that would break. | 22:56 |
| kfogel | wgrant: def traverse_comments(self, name): | 22:56 |
| kfogel | """Traverse to a comment by id.""" | 22:56 |
| kfogel | wgrant: I have to admit, that's a mismatch between method name and documentation :-) | 22:56 |
| wgrant | kfogel: 'name' is a universal idiom. | 22:57 |
| kfogel | wgrant: it's the "traverse_comments" plural part that bugs me. The method is named for its implementation strategy rather than its effect. What it's really doing is taking you to a comment; how it gets there is its own business, IMHO. | 22:57 |
| wgrant | kfogel: Ah, right. | 22:58 |
| kfogel | wgrant: anyway, I'm going to try a patch based on your idea. | 22:59 |
| wgrant | kfogel: For an example of a similar 404 thing, check LaunchpadRootNavigation.traverse's person privacy handling. | 22:59 |
| kfogel | wgrant: thanks! | 22:59 |
| wgrant | But I really think it would be better to just revoke launchpad.View for hidden comments and deal with fallout. That would be the proper solution. | 23:00 |
| kfogel | wgrant: how does one "revoke launchpad.View" ? | 23:00 |
| wgrant | kfogel: Alter the ViewBugMessage security adapter to return True only if the comment is visible or the user is an admin. | 23:02 |
| kfogel | wgrant: ooooh, btw, so far this patch has exactly the effect I wanted: http://paste.ubuntu.com/407283/ | 23:03 |
| kfogel | wgrant: trying your view-revokation method now | 23:03 |
| wgrant | kfogel: Except that patch makes it impossible to show again without DB access. | 23:03 |
| kfogel | wgrant: ?? | 23:03 |
| kfogel | wgrant: (I mean, I still have to add the user == admin condition in there, but that's not related to your comment just now I think) | 23:04 |
| wgrant | kfogel: Ah, right, once you add the user == admin thing it will be fine. | 23:04 |
| kfogel | wgrant: toggling visibility of comments is done through DB at the moment, true, but the lack of UI for it is not related to this change. | 23:04 |
| wgrant | kfogel: Isn't there an API to do it? | 23:04 |
| kfogel | wgrant: that is, even if the admin could still see the comment, they'd still need to use the DB to change the visibility | 23:04 |
| kfogel | wgrant: nope, no UI yet | 23:05 |
| kfogel | wgrant: now, it's true that an admin will *see* the comment (it'll have a yellow background, too, to highlight that it's not visible to the rest of the world) | 23:05 |
| wgrant | kfogel: Admins may set visibility through the API with bug.setCommentVisibility. | 23:05 |
| kfogel | wgrant: sorry, I confused API with UI, yes. | 23:06 |
| wgrant | Though since it's on bug, not bug_message, it doesn't require the comment to be traversable. | 23:06 |
| kfogel | wgrant: yes they can do it via API -- but that would be true either way | 23:06 |
| kfogel | right | 23:06 |
| kfogel | wgrant: http://paste.ubuntu.com/407285/ seems to have all the desired effects; care to have a look? | 23:09 |
| kfogel | (I guess there's a style question of whether those parens are really needed, but whatevs.) | 23:10 |
| wgrant | kfogel: That looks about right. | 23:10 |
| kfogel | wgrant: ok, now I'm going to learn about "bzr shelve" and try your other proposed way :-) | 23:10 |
| wgrant | Except that this whole visibility thing is implemented by working around the Zope security machinery. | 23:10 |
| * wgrant cannot live without shelve. | 23:10 | |
| kfogel | wgrant: yeah... I have the feeling that if I had a wider/deeper picture of how Launchpad fits into Zope, I'd be more dissatisfied with this solution. Ignorance truly is bliss sometimes. | 23:11 |
| wgrant | kfogel: Do you know what the status of checkwatches is? see #launchpad | 23:25 |
| kfogel | wgrant: btw, I don't think the LaunchpadRootNavigation.traverse() solution is actually better here. It does 301 redirects, not 404s, and I think we actually want a 404 here (which my patch gets by simply returning None). I guess I could do the "raise NotFound(self.context, name)" trick, but what's the advantage? | 23:33 |
| wgrant | kfogel: Right, the NotFound case is what I was thinking of. But it's not really comparable, since you can just return None from a normal traversal method and get the same effect. | 23:34 |
| kfogel | exactly | 23:34 |
| maxb | For some reason launchpadlib 1.5.6 is missing its bzr tag. Please could someone who is a member of ~lazr-developers add it: | 23:35 |
| maxb | bzr tag -d lp:launchpadlib -r revid:leonard.richardson@canonical.com-20100304202437-68ykm4fpbio8jdid 1.5.6 | 23:35 |
| wgrant | (I didn't actually look at the method first, sorry) | 23:35 |
| maxb | I've checked the branch against the tarball to verify the revision | 23:35 |
| wgrant | spm: How do I get the PPA log parser script set up? | 23:46 |
| spm | this'd be similar ot the Q&D checks we did the other week? | 23:47 |
| wgrant | I don't think I know about those checks. | 23:48 |
| spm | wild stab in the dark guess that... | 23:48 |
| wgrant | I guess I'm not even sure if the prod config has been fixed yet. And Julian won't be around for several days. | 23:48 |
| spm | wgrant: in any event it's a two step. 1. it's in the code tree cronscripts/<file>.py 2. a request is made - RT is preferred cc'ing team lead/whome ever to get the nod that this is sane etc | 23:49 |
| spm | some are part of a release cycle - code* are the most notable here - so they get added to the Production Status page as a special rollout request. | 23:49 |
| spm | some are an *integral* part of .... | 23:50 |
| wgrant | spm: Do you know if there's an RT about it already? | 23:50 |
| spm | I don't - I'll check.... | 23:51 |
| wgrant | Julian suggested that he would organise it last week, but I can't see LPS or RT or anything at all to check its status. | 23:54 |
| thumper | woo.. just slammed my big branch into ec2 test | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
