| thumper | sinzui: timelines? | 01:22 |
|---|---|---|
| thumper | sinzui: as in project and person timelines? | 01:22 |
| === jtv1 is now known as jtv | ||
| === jtv1 is now known as jtv | ||
| === matsubara-afk is now known as matsubara | ||
| === mrevell is now known as mrevell-lunch | ||
| sinzui | bac: ping | 13:57 |
| bac | hi sinzui | 13:58 |
| sinzui | spm tested my cache-country-mirrors fix. The fix revealed another problem that was also a known bug. This is my permission fix: https://pastebin.canonical.com/29899/ | 13:59 |
| bac | sinzui: were the permissions wrong on the orginal file or did shutil.move not copy them properly? | 14:00 |
| sinzui | The original file I assume since this is a bug that was already reported | 14:00 |
| sinzui | The dir mask was correct though | 14:01 |
| bac | ah, ok. r=bac | 14:01 |
| === leonardr_ is now known as leonardr | ||
| === mrevell-lunch is now known as mrevell | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: -|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | sinzui: it doesn't look like you pushed your changes to the auto-yui branch | 15:31 |
| sinzui | bac: pushed | 15:32 |
| bac | thx | 15:32 |
| allenap | EdwinGrubbs: Can you take a look at my branch please? https://code.edge.launchpad.net/~allenap/launchpad/dynamic-batch-size-bug-546085/+merge/22538 | 15:38 |
| === allenap changed the topic of #launchpad-reviews to: on call: Edwin, allenap || reviewing: -, - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| EdwinGrubbs | allenap: sure | 15:38 |
| === allenap changed the topic of #launchpad-reviews to: on call: Edwin, allenap || reviewing: -, - || queue: [allenap] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === deryck is now known as deryck[lunch] | ||
| === salgado is now known as salgado-lunch | ||
| allenap | jml: I can review your ssh-key-auth branch. As far as I can tell, only the first 156 lines are worth reviewing; the rest are sampledata changes. Does that sound right? | 16:43 |
| === jtv1 is now known as jtv | ||
| === gary_poster is now known as gary-lunch | ||
| jml | allenap, uhhh, no. | 17:13 |
| jml | allenap, it's actually about 4200 lines of relevant diff. It needs to be re-proposed to have the correct merging though. | 17:13 |
| jml | allenap, and I'm convinced that I can do it with fewer lines of diff by being smart about renaming | 17:13 |
| jml | allenap, thank you very much for the offer though. | 17:14 |
| * jml takes it off the list | 17:14 | |
| allenap | jml: Okay, cool :) | 17:14 |
| allenap | Thanks EdwinGrubbs :) | 17:16 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin, allenap || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-lunch | ||
| === deryck[lunch] is now known as deryck | ||
| abentley | jtv, I'm almost inclined to think makeCurrentUpstream and makeCurrentUbuntu should be the same function with different parameters. | 17:36 |
| jtv | abentley: yes, they are probably going to become wrappers for the same meta-function | 17:37 |
| jtv | But we'll see what shape it takes before we try to get clever. | 17:37 |
| abentley | jtv, you could use storm.locals rather than storm.store, which would simplify future imports a bit. What do you think? | 17:38 |
| jtv | abentley: oh, is storm.store obsolescent? | 17:38 |
| abentley | jtv, no, but storm.locals is meant to provide access to everything you need. | 17:39 |
| jtv | abentley: I didn't know—why and how is that? | 17:39 |
| === salgado-lunch is now known as salgado | ||
| abentley | jtv, "why" is to simplify imports; most everything a Storm client needs can be imported from there. I assume for "how", they just import from the relevant modules and list things in __all__. | 17:41 |
| abentley | jtv, r=me either way. | 17:43 |
| jtv | abentley: then sure, I'm pushing the change now. | 17:43 |
| jtv | abentley: thanks! | 17:43 |
| === gary-lunch is now known as gary_poster | ||
| === sinzui_ is now known as sinzui | ||
| === matsubara-lunch is now known as matsubara | ||
| === curtis is now known as Guest6121 | ||
| === Guest6121 is now known as sinzui | ||
| === danilos is now known as daniloff | ||
| leonardr | salgado, can you review the incremental diff of https://code.edge.launchpad.net/~leonardr/launchpad/launchpadlib-pagetests-take-2/+merge/22444 ? it's all oauth stuff | 21:07 |
| salgado | leonardr, is that r10609? | 21:10 |
| salgado | iow, how do I get the incremental diff? | 21:10 |
| leonardr | salgado: i pasted it in the mp | 21:10 |
| salgado | oh, the pastebin | 21:11 |
| salgado | + return context | 21:13 |
| leonardr | salgado: the function wasn't returning its result | 21:13 |
| salgado | leonardr, I suppose that's fixing an oversight from a previous revision? | 21:14 |
| leonardr | right | 21:14 |
| salgado | ok, looks good to me | 21:14 |
| === allenap changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| allenap | EdwinGrubbs: Are you still around to do an sort-of-emergency review? https://code.edge.launchpad.net/~allenap/launchpad/debbugs-should-not-sync-comments-bug-552725/+merge/22566 | 21:20 |
| EdwinGrubbs | allenap: sure, I can do that. | 21:21 |
| allenap | Thanks! | 21:22 |
| allenap | EdwinGrubbs: Actually, can you hold on that; I've realised I've made a mistake. | 21:23 |
| allenap | EdwinGrubbs: Actually, it's okay. Sorry for the confusion. | 21:25 |
| EdwinGrubbs | allenap: your test says that debbugs supports back-linking, but the implements() doesn't contain ISupportsBackLinking. | 21:42 |
| allenap | EdwinGrubbs: Ah, yes, you're right; I just counted three interfaces. Wow, you're thorough :) | 21:42 |
| EdwinGrubbs | allenap: you just need to set the module docstring in the test file. r=me | 21:47 |
| allenap | EdwinGrubbs: Thanks! | 21:48 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!