[01:22] <thumper> sinzui: timelines?
[01:22] <thumper> sinzui: as in project and person timelines?
[13:57] <sinzui> bac: ping
[13:58] <bac> hi sinzui
[13:59] <sinzui> spm tested my cache-country-mirrors fix. The fix revealed another problem that was also a known bug. This is my permission fix: https://pastebin.canonical.com/29899/
[14:00] <bac> sinzui: were the permissions wrong on the orginal file or did shutil.move not copy them properly?
[14:00] <sinzui> The original file I assume since this is a bug that was already reported
[14:01] <sinzui> The dir mask was correct though
[14:01] <bac> ah, ok.  r=bac
[15:31] <bac> sinzui: it doesn't look like you pushed your changes to the auto-yui branch
[15:32] <sinzui> bac: pushed
[15:32] <bac> thx
[15:38] <allenap> EdwinGrubbs: Can you take a look at my branch please? https://code.edge.launchpad.net/~allenap/launchpad/dynamic-batch-size-bug-546085/+merge/22538
[15:38] <EdwinGrubbs> allenap: sure
[16:43] <allenap> jml: I can review your ssh-key-auth branch. As far as I can tell, only the first 156 lines are worth reviewing; the rest are sampledata changes. Does that sound right?
[17:13] <jml> allenap, uhhh, no.
[17:13] <jml> allenap, it's actually about 4200 lines of relevant diff. It needs to be re-proposed to have the correct merging though.
[17:13] <jml> allenap, and I'm convinced that I can do it with fewer lines of diff by being smart about renaming
[17:14] <jml> allenap, thank you very much for the offer though.
[17:14]  * jml takes it off the list
[17:14] <allenap> jml: Okay, cool :)
[17:16] <allenap> Thanks EdwinGrubbs :)
[17:36] <abentley> jtv, I'm almost inclined to think makeCurrentUpstream and makeCurrentUbuntu should be the same function with different parameters.
[17:37] <jtv> abentley: yes, they are probably going to become wrappers for the same meta-function
[17:37] <jtv> But we'll see what shape it takes before we try to get clever.
[17:38] <abentley> jtv, you could use storm.locals rather than storm.store, which would simplify future imports a bit.  What do you think?
[17:38] <jtv> abentley: oh, is storm.store obsolescent?
[17:39] <abentley> jtv, no, but storm.locals is meant to provide access to everything you need.
[17:39] <jtv> abentley: I didn't know—why and how is that?
[17:41] <abentley> jtv, "why" is to simplify imports; most everything a Storm client needs can be imported from there.  I assume for "how", they just import from the relevant modules and list things in __all__.
[17:43] <abentley> jtv, r=me either way.
[17:43] <jtv> abentley: then sure, I'm pushing the change now.
[17:43] <jtv> abentley: thanks!
[21:07] <leonardr> salgado, can you review the incremental diff of https://code.edge.launchpad.net/~leonardr/launchpad/launchpadlib-pagetests-take-2/+merge/22444 ? it's all oauth stuff
[21:10] <salgado> leonardr, is that r10609?
[21:10] <salgado> iow, how do I get the incremental diff?
[21:10] <leonardr> salgado: i pasted it in the mp
[21:11] <salgado> oh, the pastebin
[21:13] <salgado> +    return context
[21:13] <leonardr> salgado: the function wasn't returning its result
[21:14] <salgado> leonardr, I suppose that's fixing an oversight from a previous revision?
[21:14] <leonardr> right
[21:14] <salgado> ok, looks good to me
[21:20] <allenap> EdwinGrubbs: Are you still around to do an sort-of-emergency review? https://code.edge.launchpad.net/~allenap/launchpad/debbugs-should-not-sync-comments-bug-552725/+merge/22566
[21:21] <EdwinGrubbs> allenap: sure, I can do that.
[21:22] <allenap> Thanks!
[21:23] <allenap> EdwinGrubbs: Actually, can you hold on that; I've realised I've made a mistake.
[21:25] <allenap> EdwinGrubbs: Actually, it's okay. Sorry for the confusion.
[21:42] <EdwinGrubbs> allenap: your test says that debbugs supports back-linking, but the implements() doesn't contain ISupportsBackLinking.
[21:42] <allenap> EdwinGrubbs: Ah, yes, you're right; I just counted three interfaces. Wow, you're thorough :)
[21:47] <EdwinGrubbs> allenap: you just need to set the module docstring in the test file. r=me
[21:48] <allenap> EdwinGrubbs: Thanks!