| === thumper changed the topic of #launchpad-reviews to: on call: || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-afk | ||
| === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| stub | henninge: https://code.edge.launchpad.net/~stub/launchpad/memcache/+merge/22849 | 08:06 |
|---|---|---|
| stub | henninge: Security issue that needs to land before the edge update (about 55 mins?) | 08:06 |
| wgrant | stub: The branch isn't in stable yet. | 08:06 |
| wgrant | it's fine. | 08:06 |
| henninge | stub: looking | 08:07 |
| wgrant | (and probably won't be until some hours after edge updates tonight) | 08:07 |
| henninge | stub: Shouldn't that comment be an XXX that links to a bug number where the issue is tracked? | 08:09 |
| stub | Its not a bug though. | 08:09 |
| stub | Actually, I just realized I need to turn off caching entirely to not lose functionality, as the tooltips will continue to display old summaries when bugs are changed. | 08:10 |
| stub | I could put a lower timeout, but that is getting really pointless. | 08:10 |
| henninge | stub: unfortunately I am not at all familiar with caching issues ... | 08:11 |
| henninge | stub: but this still sounds like a quick fix to me that needs further investigation to find a proper solution and we should track that in a bug in order not to forget it. | 08:12 |
| stub | I'm not sure what the bug is. Marked up test is uncachable due to Launchpad features. We either put up with it, or change Launchpad features. Its a discussion. | 08:14 |
| stub | I've removed the cache: stanza entirely, so the diff is just a reversal of some work that landed an hour ago and an additional comment. I can remove the comment if you like, as I think it is throughout Launchpad rather than a bug comment specific issue. | 08:16 |
| henninge | stub: ok, that sounds reasonable. | 08:23 |
| stub | henninge: Reasonable enough for an approve vote? | 08:39 |
| henninge | stub: certainly, I was waiting for the new push ... ;-) | 08:40 |
| henninge | stub: r=me | 08:40 |
| stub | Ta :) | 08:40 |
| === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jml | henninge, could I persuade you to take a look at cjwatson's branch? | 12:05 |
| henninge | jml: branch of what? ;-) I don't see anything on activereviews... | 12:07 |
| * jml looks | 12:08 | |
| jml | ahh, he asked deryck specifically | 12:08 |
| jml | never mind | 12:08 |
| deryck | jml, henninge -- sorry, I missed he requested the review due to mail filters. Will get it today. | 12:10 |
| jml | deryck, thanks. | 12:11 |
| === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: on call: henninge, bac || reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | good morning | 13:21 |
| bac | hi deryck | 13:30 |
| deryck | bac, Hi. | 13:30 |
| bac | deryck: did you coordinate with brian at all on https://code.edge.launchpad.net/~brian-murray/launchpad/fix-date-closed-definition/+merge/22836? | 13:31 |
| bac | it's really trivial but appears to not have had a pre-imp call (required but overkill) nor manage the bug at all | 13:31 |
| deryck | bac, not having looked yet, I don't recall talking about that with him, no. looking now.... | 13:31 |
| bac | deryck: just thought you may want to speak to him about triaging the bug and claiming it before starting work | 13:32 |
| bac | the fix itself is trivial... | 13:32 |
| deryck | bac, sure, we can discuss it. He's on my team next month, so it becomes even more important then. :) | 13:32 |
| bac | great | 13:33 |
| deryck | bac, I suspect he does sooooo much bug triage currently that he just wanted to drive by fix something and not worry about the rest. :-) | 13:33 |
| bac | walking on the wild side, he is | 13:33 |
| deryck | ah, I had never triaged the bug initially either. He was likely waiting on me. | 13:35 |
| deryck | all fixed up now. | 13:35 |
| === matsubara-afk is now known as matsubara | ||
| wgrant | bac: Sorry, I was planning to get Soyuz approval, but we have been rather lacking in the Soyuz department for the past several days. | 13:56 |
| bac | wgrant: yeah, with julian out of pocket i can see that | 13:57 |
| === henninge changed the topic of #launchpad-reviews to: on call: henninge, bac || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === henninge changed the topic of #launchpad-reviews to: on call: henninge, bac || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === james_w changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, - || queue: [james_w] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| james_w | henninge, bac: https://code.edge.launchpad.net/~james-w/launchpad/code-import-request/+merge/22727 when you get a few minutes please | 14:12 |
| bac | james_w: will do | 14:13 |
| james_w | Merci | 14:13 |
| === kfogel is now known as emacs | ||
| === emacs is now known as kfogel | ||
| sinzui | bac: can you look at http://people.canonical.com/~curtis/package-suggestion-portlet.png and think about how to fix the UI? I am tempted to revert the a button and link for packaging links, and moving the Not Packaged button somewhere else in the portlet | 15:08 |
| james_w | sinzui: heh, looks like you've already fixed the bug I just filed :-) | 15:12 |
| leonardr | abentley, can you take another look at https://code.edge.launchpad.net/~leonardr/launchpad/no-cookie-vary-header/+merge/22812 ? | 15:13 |
| abentley | leonardr, sure. | 15:13 |
| leonardr | gary, i'd like your opinion on the Vary:Authorization issue as well | 15:13 |
| leonardr | abentley, give it a minute to regen the diff | 15:14 |
| sinzui | james_w, which bug? | 15:14 |
| james_w | sinzui: filed like 2 minutes ago, that "[ Link to this Ubuntu package] or (+) Link to Ubuntu Package" confused me | 15:14 |
| gary_poster | leonardr: ack will look | 15:15 |
| sinzui | oh, damn, this UI is going to kill me since the current one really confused abentley | 15:15 |
| sinzui | bac: james_w maybe we need a list of options with a single button. Two of the options are "another unlisted package" and "this project is not packaged in Ubuntu" | 15:16 |
| james_w | sinzui: that would work for me. I'm also ok with your mockups there. | 15:17 |
| abentley | sinzui, what happened to you yesterday? You disappeared while I was asking review questions. | 15:18 |
| sinzui | henninge, you could not see anything in devel because sample data was wacky. It will be fixed soon. That is why I create a screen shot...you do not want to see my mark harness changes to create sane spph | 15:19 |
| sinzui | abentley, you assumed you needed to choose "an unlisted package" to use the "This is Not Packaged in Ubuntu" button. | 15:20 |
| abentley | sinzui, I assumed that was meant to be the constant item between the two screenshots. | 15:21 |
| abentley | sinzui, I asked you a bunch of questions yesterday that you did not reply to. One was "would it reasonable to present "not packaged in ubuntu" as a radio button?" | 15:22 |
| sinzui | It is. the option means "select another package not in this list" and maybe that is the wording I should have used | 15:22 |
| gary_poster | leonardr: xx-service.txt looks like it would fail now. Your code says self.response.setHeader('Vary', 'Accept') but your test says | 15:23 |
| gary_poster | 83+ >>> response = webservice.get( | 15:23 |
| gary_poster | 84+ ... 'http://bugs.launchpad.dev/api/devel/') | 15:23 |
| gary_poster | 85+ >>> print response.getheader('Vary') | 15:23 |
| gary_poster | 86+ Authorization, Accept | 15:23 |
| leonardr | gary: thanks, don't know how i missed that | 15:23 |
| sinzui | abentley, I think that is the best solution. I need to find new wording for the button. | 15:23 |
| abentley | sinzui, Yeah, but the submit buttons were also constant. | 15:23 |
| gary_poster | cool | 15:23 |
| leonardr | maybe i spent all my time writing that comment and didn't rerun the test | 15:23 |
| bac | sinzui: i don't think "an unlisted package" makes sense, especially in the "portlet without suggestion" example | 15:24 |
| sinzui | bac: "select a package using the package finder?" | 15:25 |
| bac | yes, better | 15:25 |
| bac | perhaps when there are suggestions "select some other package using the package finder" and what you wrote for the 'without suggestions' case | 15:25 |
| === bac changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, wgrant || queue: [james_w] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === deryck is now known as deryck[lunch] | ||
| === sinzui changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, wgrant || queue: [james_w, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| sinzui | bac: henninge: if you have time, can you review https://code.launchpad.net/~sinzui/launchpad/moderate-empty-messages/+merge/22870 | 15:52 |
| henninge | bac: you had agreed to do james' branch, right? | 15:54 |
| bac | henninge: no, i was speaking for the both of us. if you are free it is next up. | 15:54 |
| henninge | bac: ok, I'll take that first, then. | 15:54 |
| bac | thanks henninge. how do you like OCR on tuesdays? much better, right? | 15:55 |
| henninge | bac: yeah, a lot better ... ;-) | 15:55 |
| henninge | although, to me this Tuesday is like a Monday ... ;) | 15:55 |
| bac | ah, right, ye of the four day weekend... | 16:00 |
| henninge | ;-) | 16:00 |
| henninge | over much too quick ... | 16:00 |
| === matsubara is now known as matsubara-lunch | ||
| === henninge changed the topic of #launchpad-reviews to: henninge, bac || reviewing: james_w, wgrant || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | james_w: did you have a pre-implementation chat/call with someone from the code team about requestImport? (more recent than the Karmic UDS) | 16:18 |
| james_w | I did not | 16:18 |
| henninge | james_w: Especially when adding stuff to the API, I think it's better to be sure that you and them are still on the same page. | 16:19 |
| henninge | james_w: So, maybe simplest would be to ask somebody from that team to review the branch, then. OK? | 16:20 |
| james_w | sure | 16:23 |
| henninge | thanks | 16:23 |
| === henninge changed the topic of #launchpad-reviews to: henninge, bac || reviewing: sinzui, wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | leonardr, I don't know if you're still wanting my re-review. I was waiting for the test fix. | 16:42 |
| leonardr | abentley: should be pushed, let me check | 16:42 |
| abentley | leonardr, maybe my page was stale. | 16:43 |
| leonardr | abentley: yes, it's rev 10623 | 16:43 |
| abentley | leonardr, looks fine. r=me | 16:45 |
| leonardr | great | 16:45 |
| === deryck[lunch] is now known as deryck | ||
| === henninge changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | sinzui: review done. | 16:52 |
| === bac changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| * bac high-fives henning...empty queue | 16:55 | |
| henninge | yeah, cool! ;) | 16:57 |
| * sidnei wonders where rockstar's review stands | 17:14 | |
| rockstar | sidnei, it's a big review. :) I'm working on it though. | 17:14 |
| sidnei | cool, thanks! | 17:14 |
| rockstar | sidnei, so, maybe I should ask you: could you please write up a doc or email or something detailed the changes necessary for yui 3.1? | 17:15 |
| === salgado is now known as salgado-lunch | ||
| sidnei | rockstar, i don't know all the changes necessary yet. so far only lazr-js specific, and those were mostly css and making the tests pass, which only involved changing tests themselves. | 17:16 |
| rockstar | sidnei, okay. Could we you maybe start a wiki page on the dev.launchpad.net about it then, so we can add to it? | 17:16 |
| sidnei | rockstar, sounds like a plan. | 17:16 |
| rockstar | sidnei, basically, I want a doc that shows us a clear migration plan of the things that definitely need to change. | 17:16 |
| === danilos is now known as daniloff | ||
| === henninge changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara-lunch is now known as matsubara | ||
| sidnei | rockstar, https://wiki.canonical.com/Rhinos/YUI/MigrationIssues | 17:47 |
| rockstar | sidnei, great. Can you send that to the Rhinos list? | 17:48 |
| sidnei | rockstar, sure. | 17:48 |
| rockstar | bac, can I hop in your queue in about 15? | 18:13 |
| === salgado-lunch is now known as salgado | ||
| === gary_poster is now known as gary-lunch | ||
| === leonardr is now known as leonardr-lunch | ||
| bac | rockstar: sure | 19:30 |
| rockstar | bac, it'll be a bit. Dealing with conflict hell currently. | 19:30 |
| rockstar | bac, so, here's the little one: https://code.edge.launchpad.net/~rockstar/launchpad/branch-bug-display/+merge/22887 | 19:41 |
| rockstar | bac, the other one I'm still trying to sort out dependent branch on. | 19:41 |
| bac | ok | 19:41 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [rockstar1, rockstar2] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === leonardr-lunch is now known as leonardr | ||
| === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [rockstar] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| leonardr | gary, ec2 turned up some very minor test failures on https://code.edge.launchpad.net/~leonardr/launchpad/no-cookie-vary-header . can you review my recent changes? | 21:14 |
| leonardr | i also had to do a launchpadlib branch, which is here: https://code.edge.launchpad.net/~leonardr/launchpadlib/test-fix/+merge/22905 | 21:14 |
| leonardr | abentely, if you're still around, you could take care of this instead | 21:14 |
| leonardr | abentley | 21:14 |
| salgado | bac, care to review https://code.launchpad.net/~salgado/launchpad/bug-556594/+merge/22906 for me? | 21:15 |
| bac | salgado: sure | 21:16 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: salgado || queue: [rockstar] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | leonardr, r=me | 21:16 |
| leonardr | great | 21:17 |
| gary_poster | leonardr: on call. do you still need me? | 21:19 |
| leonardr | gary: no | 21:19 |
| gary_poster | ok cool | 21:19 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [rockstar] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| rockstar | bac, here's the other one to review: https://code.edge.launchpad.net/~rockstar/launchpad/ihasrecipes/+merge/22890 | 21:24 |
| salgado | thanks for the review, brad. (and I did that change you suggested) | 21:24 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: rockstar || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| EdwinGrubbs | bac: I have a tiny branch that will be ready in a couple of minutes. | 21:44 |
| bac | EdwinGrubbs: ok | 21:44 |
| === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [edwin] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| salgado | bac, if you have a few more minutes, I've updated that m-p you just reviewed with the actual fix for the bug | 22:00 |
| bac | salgado: ok | 22:00 |
| EdwinGrubbs | bac: here it is: https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-552619-suggesting-removed-packages/+merge/22912 | 22:00 |
| bac | EdwinGrubbs: i'm way ahead of you. :) | 22:01 |
| === bac changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
