=== thumper changed the topic of #launchpad-reviews to: on call: || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === matsubara is now known as matsubara-afk === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [08:06] henninge: https://code.edge.launchpad.net/~stub/launchpad/memcache/+merge/22849 [08:06] henninge: Security issue that needs to land before the edge update (about 55 mins?) [08:06] stub: The branch isn't in stable yet. [08:06] it's fine. [08:07] stub: looking [08:07] (and probably won't be until some hours after edge updates tonight) [08:09] stub: Shouldn't that comment be an XXX that links to a bug number where the issue is tracked? [08:09] Its not a bug though. [08:10] Actually, I just realized I need to turn off caching entirely to not lose functionality, as the tooltips will continue to display old summaries when bugs are changed. [08:10] I could put a lower timeout, but that is getting really pointless. [08:11] stub: unfortunately I am not at all familiar with caching issues ... [08:12] stub: but this still sounds like a quick fix to me that needs further investigation to find a proper solution and we should track that in a bug in order not to forget it. [08:14] I'm not sure what the bug is. Marked up test is uncachable due to Launchpad features. We either put up with it, or change Launchpad features. Its a discussion. [08:16] I've removed the cache: stanza entirely, so the diff is just a reversal of some work that landed an hour ago and an additional comment. I can remove the comment if you like, as I think it is throughout Launchpad rather than a bug comment specific issue. [08:23] stub: ok, that sounds reasonable. [08:39] henninge: Reasonable enough for an approve vote? [08:40] stub: certainly, I was waiting for the new push ... ;-) [08:40] stub: r=me [08:40] Ta :) === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [12:05] henninge, could I persuade you to take a look at cjwatson's branch? [12:07] jml: branch of what? ;-) I don't see anything on activereviews... [12:08] * jml looks [12:08] ahh, he asked deryck specifically [12:08] never mind [12:10] jml, henninge -- sorry, I missed he requested the review due to mail filters. Will get it today. [12:11] deryck, thanks. === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === bac changed the topic of #launchpad-reviews to: on call: henninge, bac || reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [13:21] good morning [13:30] hi deryck [13:30] bac, Hi. [13:31] deryck: did you coordinate with brian at all on https://code.edge.launchpad.net/~brian-murray/launchpad/fix-date-closed-definition/+merge/22836? [13:31] it's really trivial but appears to not have had a pre-imp call (required but overkill) nor manage the bug at all [13:31] bac, not having looked yet, I don't recall talking about that with him, no. looking now.... [13:32] deryck: just thought you may want to speak to him about triaging the bug and claiming it before starting work [13:32] the fix itself is trivial... [13:32] bac, sure, we can discuss it. He's on my team next month, so it becomes even more important then. :) [13:33] great [13:33] bac, I suspect he does sooooo much bug triage currently that he just wanted to drive by fix something and not worry about the rest. :-) [13:33] walking on the wild side, he is [13:35] ah, I had never triaged the bug initially either. He was likely waiting on me. [13:35] all fixed up now. === matsubara-afk is now known as matsubara [13:56] bac: Sorry, I was planning to get Soyuz approval, but we have been rather lacking in the Soyuz department for the past several days. [13:57] wgrant: yeah, with julian out of pocket i can see that === henninge changed the topic of #launchpad-reviews to: on call: henninge, bac || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === henninge changed the topic of #launchpad-reviews to: on call: henninge, bac || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === james_w changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, - || queue: [james_w] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [14:12] henninge, bac: https://code.edge.launchpad.net/~james-w/launchpad/code-import-request/+merge/22727 when you get a few minutes please [14:13] james_w: will do [14:13] Merci === kfogel is now known as emacs === emacs is now known as kfogel [15:08] bac: can you look at http://people.canonical.com/~curtis/package-suggestion-portlet.png and think about how to fix the UI? I am tempted to revert the a button and link for packaging links, and moving the Not Packaged button somewhere else in the portlet [15:12] sinzui: heh, looks like you've already fixed the bug I just filed :-) [15:13] abentley, can you take another look at https://code.edge.launchpad.net/~leonardr/launchpad/no-cookie-vary-header/+merge/22812 ? [15:13] leonardr, sure. [15:13] gary, i'd like your opinion on the Vary:Authorization issue as well [15:14] abentley, give it a minute to regen the diff [15:14] james_w, which bug? [15:14] sinzui: filed like 2 minutes ago, that "[ Link to this Ubuntu package] or (+) Link to Ubuntu Package" confused me [15:15] leonardr: ack will look [15:15] oh, damn, this UI is going to kill me since the current one really confused abentley [15:16] bac: james_w maybe we need a list of options with a single button. Two of the options are "another unlisted package" and "this project is not packaged in Ubuntu" [15:17] sinzui: that would work for me. I'm also ok with your mockups there. [15:18] sinzui, what happened to you yesterday? You disappeared while I was asking review questions. [15:19] henninge, you could not see anything in devel because sample data was wacky. It will be fixed soon. That is why I create a screen shot...you do not want to see my mark harness changes to create sane spph [15:20] abentley, you assumed you needed to choose "an unlisted package" to use the "This is Not Packaged in Ubuntu" button. [15:21] sinzui, I assumed that was meant to be the constant item between the two screenshots. [15:22] sinzui, I asked you a bunch of questions yesterday that you did not reply to. One was "would it reasonable to present "not packaged in ubuntu" as a radio button?" [15:22] It is. the option means "select another package not in this list" and maybe that is the wording I should have used [15:23] leonardr: xx-service.txt looks like it would fail now. Your code says self.response.setHeader('Vary', 'Accept') but your test says [15:23] 83 + >>> response = webservice.get( [15:23] 84 + ... 'http://bugs.launchpad.dev/api/devel/') [15:23] 85 + >>> print response.getheader('Vary') [15:23] 86 + Authorization, Accept [15:23] gary: thanks, don't know how i missed that [15:23] abentley, I think that is the best solution. I need to find new wording for the button. [15:23] sinzui, Yeah, but the submit buttons were also constant. [15:23] cool [15:23] maybe i spent all my time writing that comment and didn't rerun the test [15:24] sinzui: i don't think "an unlisted package" makes sense, especially in the "portlet without suggestion" example [15:25] bac: "select a package using the package finder?" [15:25] yes, better [15:25] perhaps when there are suggestions "select some other package using the package finder" and what you wrote for the 'without suggestions' case === bac changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, wgrant || queue: [james_w] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === deryck is now known as deryck[lunch] === sinzui changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, wgrant || queue: [james_w, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [15:52] bac: henninge: if you have time, can you review https://code.launchpad.net/~sinzui/launchpad/moderate-empty-messages/+merge/22870 [15:54] bac: you had agreed to do james' branch, right? [15:54] henninge: no, i was speaking for the both of us. if you are free it is next up. [15:54] bac: ok, I'll take that first, then. [15:55] thanks henninge. how do you like OCR on tuesdays? much better, right? [15:55] bac: yeah, a lot better ... ;-) [15:55] although, to me this Tuesday is like a Monday ... ;) [16:00] ah, right, ye of the four day weekend... [16:00] ;-) [16:00] over much too quick ... === matsubara is now known as matsubara-lunch === henninge changed the topic of #launchpad-reviews to: henninge, bac || reviewing: james_w, wgrant || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [16:18] james_w: did you have a pre-implementation chat/call with someone from the code team about requestImport? (more recent than the Karmic UDS) [16:18] I did not [16:19] james_w: Especially when adding stuff to the API, I think it's better to be sure that you and them are still on the same page. [16:20] james_w: So, maybe simplest would be to ask somebody from that team to review the branch, then. OK? [16:23] sure [16:23] thanks === henninge changed the topic of #launchpad-reviews to: henninge, bac || reviewing: sinzui, wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [16:42] leonardr, I don't know if you're still wanting my re-review. I was waiting for the test fix. [16:42] abentley: should be pushed, let me check [16:43] leonardr, maybe my page was stale. [16:43] abentley: yes, it's rev 10623 [16:45] leonardr, looks fine. r=me [16:45] great === deryck[lunch] is now known as deryck === henninge changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [16:52] sinzui: review done. === bac changed the topic of #launchpad-reviews to: henninge, bac || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [16:55] * bac high-fives henning...empty queue [16:57] yeah, cool! ;) [17:14] * sidnei wonders where rockstar's review stands [17:14] sidnei, it's a big review. :) I'm working on it though. [17:14] cool, thanks! [17:15] sidnei, so, maybe I should ask you: could you please write up a doc or email or something detailed the changes necessary for yui 3.1? === salgado is now known as salgado-lunch [17:16] rockstar, i don't know all the changes necessary yet. so far only lazr-js specific, and those were mostly css and making the tests pass, which only involved changing tests themselves. [17:16] sidnei, okay. Could we you maybe start a wiki page on the dev.launchpad.net about it then, so we can add to it? [17:16] rockstar, sounds like a plan. [17:16] sidnei, basically, I want a doc that shows us a clear migration plan of the things that definitely need to change. === danilos is now known as daniloff === henninge changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === matsubara-lunch is now known as matsubara [17:47] rockstar, https://wiki.canonical.com/Rhinos/YUI/MigrationIssues [17:48] sidnei, great. Can you send that to the Rhinos list? [17:48] rockstar, sure. [18:13] bac, can I hop in your queue in about 15? === salgado-lunch is now known as salgado === gary_poster is now known as gary-lunch === leonardr is now known as leonardr-lunch [19:30] rockstar: sure [19:30] bac, it'll be a bit. Dealing with conflict hell currently. [19:41] bac, so, here's the little one: https://code.edge.launchpad.net/~rockstar/launchpad/branch-bug-display/+merge/22887 [19:41] bac, the other one I'm still trying to sort out dependent branch on. [19:41] ok === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [rockstar1, rockstar2] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === leonardr-lunch is now known as leonardr === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [rockstar] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [21:14] gary, ec2 turned up some very minor test failures on https://code.edge.launchpad.net/~leonardr/launchpad/no-cookie-vary-header . can you review my recent changes? [21:14] i also had to do a launchpadlib branch, which is here: https://code.edge.launchpad.net/~leonardr/launchpadlib/test-fix/+merge/22905 [21:14] abentely, if you're still around, you could take care of this instead [21:14] abentley [21:15] bac, care to review https://code.launchpad.net/~salgado/launchpad/bug-556594/+merge/22906 for me? [21:16] salgado: sure === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: salgado || queue: [rockstar] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [21:16] leonardr, r=me [21:17] great [21:19] leonardr: on call. do you still need me? [21:19] gary: no [21:19] ok cool === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [rockstar] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [21:24] bac, here's the other one to review: https://code.edge.launchpad.net/~rockstar/launchpad/ihasrecipes/+merge/22890 [21:24] thanks for the review, brad. (and I did that change you suggested) === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: rockstar || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [21:44] bac: I have a tiny branch that will be ready in a couple of minutes. [21:44] EdwinGrubbs: ok === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [edwin] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [22:00] bac, if you have a few more minutes, I've updated that m-p you just reviewed with the actual fix for the bug [22:00] salgado: ok [22:00] bac: here it is: https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-552619-suggesting-removed-packages/+merge/22912 [22:01] EdwinGrubbs: i'm way ahead of you. :) === bac changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === salgado is now known as salgado-afk === matsubara is now known as matsubara-afk