| wgrant | abentley, bac: Can you please land my branches that you reviewed? They're all Soyuz-approved™. | 00:20 |
|---|---|---|
| === Ursinha is now known as Ursinha-afk | ||
| abentley | wgrant, I'm not currently able to run the test suite to completion. | 02:04 |
| wgrant | abentley: Urgh. Anyway, mwhudson has EC2ed them. | 02:05 |
| abentley | mwhudson, thanks! | 02:05 |
| abentley | wgrant, wait-- do you mean that they've been tested but mwhudson isn't landing them. | 02:05 |
| abentley | ? | 02:05 |
| wgrant | abentley: They are in the process of landing through ec2. | 02:06 |
| abentley | wgrant, cool. | 02:06 |
| thumper | https://code.edge.launchpad.net/~thumper/launchpad/package-branch-listing-speedup/+merge/22993 1070 lines | 03:59 |
| thumper | sorry | 03:59 |
| * thumper popping out to get real coffee and drop off some children's dvds back to the video store | 04:07 | |
| StevenK | thumper: The question is, who watched them? | 04:07 |
| thumper | StevenK: I watched a part of the black stallion, but not all, nor the sequal | 04:08 |
| wgrant | Is it just me, or does download-cache only have a 2.6 x86_64 meliae egg, and not a 2.6 i386 one? | 04:11 |
| StevenK | Sigh, devkit-disks, I hate you. | 04:18 |
| StevenK | Why does it only mount Mass Storage devices *sometimes* | 04:19 |
| wgrant | StevenK: Isn't that one of DX's new decisions? | 04:19 |
| StevenK | Oooh, bitter much | 04:20 |
| wgrant | Well, "why not" is enough rationale. | 04:20 |
| * StevenK puts his fingers in his ears and says Lalalalala a lot | 04:21 | |
| wgrant | Heh. | 04:22 |
| === mup_ is now known as mup | ||
| jtv | mwhudson: hi, any news on allow-import-password? | 06:28 |
| mwhudson | jtv: no, got kind of sidetracked | 06:28 |
| === henninge_ is now known as henninge | ||
| === noodles775 changed the topic of #launchpad-reviews to: On call: noodles775 || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | jelmer: do you want to take a look at james_w' branch first? (it's a non-soyuz one ;) ), otherwise I'll jump right in. | 11:13 |
| james_w | it's rather simple :-) | 11:14 |
| noodles775 | Oh, I was going by the line count before you resolved the conflicts :) | 11:14 |
| noodles775 | jelmer: nm. | 11:14 |
| noodles775 | lol | 11:14 |
| noodles775 | r=me | 11:14 |
| james_w | thanks | 11:15 |
| james_w | please twiddle the knobs and I'll throw it at ec2 | 11:15 |
| noodles775 | Done. | 11:15 |
| james_w | and I need to use [testfix], correct? | 11:15 |
| noodles775 | Yep, `bzr log --limit 50 | grep testfix` will show you an eg or two. | 11:17 |
| james_w | thanks | 11:19 |
| james_w | sent | 11:19 |
| * james_w just used --textfix | 11:19 | |
| * noodles775 didn't know about that option... great. | 11:19 | |
| === Ursinha-afk is now known as Ursinha | ||
| === matsubara-afk is now known as matsubara | ||
| === salgado-afk is now known as salgado | ||
| bac | wgrant: is mwhudson landing all of your approved branches or do you need me to help? | 13:36 |
| wgrant | bac: They're all approved and all but one is tested, but PQM rejected three of them due to testfix. | 13:45 |
| bac | wgrant: i'll be glad to help but i don't want to duplicate effort. why don't you send me an email with the URLs of the MPs and what you need me to do for each. please copy noodles775 and mwhudson. | 13:47 |
| bac | i'll then land them when we're out of testfix | 13:47 |
| jml | ... which should be any moment now- | 13:50 |
| noodles775 | bac, wgrant : I've sent off ~wgrant/launchpad/bug-549907-stop-using-slave-build-id a few hours ago too. | 14:24 |
| noodles775 | (still playing) | 14:25 |
| * bac wishes he could send a branch off for testing and landing from the MP page | 14:28 | |
| === daniloff is now known as danilos | ||
| wgrant | PQM is alive? | 14:56 |
| wgrant | If it is... can someone please land https://code.edge.launchpad.net/~wgrant/launchpad/bug-538844-master-side/+merge/22681, https://code.edge.launchpad.net/~wgrant/launchpad/more-buildmaster-cleanup/+merge/22735 and https://code.edge.launchpad.net/~wgrant/launchpad/remove-dbnote/+merge/22736? They all passed ec2test a few hours ago (with the current devel rev), but were rejected by PQM. | 14:59 |
| noodles775 | Sure. Hrm, how do I land something *not* via ec2, without branching? | 15:03 |
| * noodles775 looks at ec2 land code. | 15:03 | |
| wgrant | noodles775: bzr lp-land, maybe? | 15:05 |
| noodles775 | wgrant: yep, was just reading bzr help lp-land, thanks! | 15:06 |
| wgrant | Not sure if that handles generating the [r=foo] stuff, though. | 15:06 |
| noodles775 | ugh, bzr: ERROR: exceptions.ValueError: Cannot determine Bazaar host. "https://api.edge.launchpad.net/beta/" not a recognized Launchpad API root. | 15:07 |
| wgrant | Yay, version-naïve code. | 15:08 |
| * noodles775 updates pqm plugin | 15:08 | |
| noodles775 | OK, that helped, but now it complains about lacking revisions... I'm guessing lp-land still requires a local branch? | 15:10 |
| noodles775 | bzr: ERROR: Public branch "bzr+ssh://bazaar.launchpad.net/~wgrant/launchpad/bug-538844-master-side" lacks revision "launchpad@pqm.canonical.com-20100407001252-2bvaz1hi60knsrnp". | 15:10 |
| * noodles775 branches and tries. | 15:10 | |
| === noodles775 changed the topic of #launchpad-reviews to: On call: - || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === leonardr_ is now known as leonardr-afk | ||
| === matsubara is now known as matsubara-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === matsubara-lunch is now known as matsubara | ||
| === rockstar changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-lunch | ||
| === deryck[lunch] is now known as deryck | ||
| === leonardr-afk is now known as leonardr | ||
| === salgado-lunch is now known as salgado | ||
| === Ursinha is now known as Ursinha-brb | ||
| === Ursinha-brb is now known as Ursinha | ||
| rockstar | abentley, can you do a review (maybe two) for me? | 19:58 |
| abentley | rockstar, sure. Working up the description for my merge request right now. | 19:59 |
| rockstar | abentley, great. | 20:01 |
| rockstar | abentley, here's the easy one: https://code.edge.launchpad.net/~rockstar/launchpad/ihasrecipes-person/+merge/23045 | 20:04 |
| rockstar | abentley, the next one still needs changes since I'm not making DistroSeries implement IHasRecipes | 20:04 |
| abentley | rockstar, I recommend using lp-propose (née lp-submit) and the lp_review_body plugin. | 20:09 |
| rockstar | abentley, yeah, I've been meaning to set that up. | 20:11 |
| abentley | rockstar, maybe I'll walk you through that on our next call. | 20:12 |
| abentley | rockstar, test_person_implements_hasbranches looks misnamed. | 20:13 |
| abentley | rockstar, similarly test_product_implements_hasbranches | 20:14 |
| abentley | rockstar, test_product_getRecipes comment looks wrong. | 20:15 |
| abentley | rockstar, docstring in lib/lp/registry/model/product.py is wrong. | 20:16 |
| rockstar | abentley, argh. c-n-p errors... | 20:17 |
| abentley | rockstar, originally you were going to try adaptation, right? What problems did you run into with that? | 20:18 |
| rockstar | abentley, the fact that I wanted to get something done and not fart around with zope oddities. | 20:19 |
| === Ursinha is now known as Ursinha-lunch | ||
| rockstar | The docstring was a thinko, not a c-n-p error. *facepalm* | 20:21 |
| abentley | rockstar, adding coupling between Person and Recipe seems like tech debt. could you file a bug to reexamine it? | 20:21 |
| rockstar | abentley, what do you mean "adding coupling" ? | 20:22 |
| abentley | rockstar, Person (and Product, I guess) now have to know what a Recipe is. | 20:22 |
| abentley | There is a dependency now that wasn't there before. | 20:23 |
| rockstar | abentley, yeah, I guess you're right. I'll file a bug and say "let's think about adapters again" | 20:23 |
| abentley | rockstar, cool. | 20:23 |
| rockstar | abentley, by that reasoning though, IHasBranches should probably also be an adapter. | 20:23 |
| abentley | rockstar, yes, there should be an adapter for Person that provides IHasBranches. | 20:24 |
| rockstar | abentley, yeah, I bet that would happen more often if zope wasn't stingy. :) | 20:25 |
| abentley | rockstar, at least in the ideal, registry doesn't depend on us and we don't depend on other apps like Soyuz. | 20:25 |
| * rockstar nods | 20:26 | |
| sinzui | abentley, yes, and we must do better at decoupling the features | 20:26 |
| rockstar | sinzui, we aren't in the habit of it. I think that's what the problem really is. | 20:27 |
| abentley | rockstar, could you ping me when you've updated those doc errors? | 20:27 |
| rockstar | We haven't really focused on not coupling features. | 20:27 |
| sinzui | rockstar, indeed. It is easier to see the problem now that we have separate trees | 20:27 |
| rockstar | abentley, pushed, waiting for scanner... | 20:27 |
| rockstar | sinzui, yeah, that is helpful. | 20:27 |
| abentley | rockstar, cool. I'll watch it then. | 20:28 |
| rockstar | It would probably reduce the risk of circular imports by an order of magnitude also. | 20:28 |
| rockstar | abentley, just noticed one of the comments is still wrong... :/ | 20:33 |
| * rockstar waits for scanner again. | 20:35 | |
| rockstar | abentley, alright, everything should be kosher now. | 20:43 |
| abentley | rockstar, looking... | 20:44 |
| abentley | rockstar, products can have sourcepackage branches, but your product.getRecipes() doesn't include them, right? | 20:46 |
| rockstar | abentley, good question. I have no idea. | 20:47 |
| rockstar | abentley, I was under the assumption that querying the Branch table would bring them all in. | 20:47 |
| rockstar | If that's not the case, "eep." | 20:47 |
| abentley | I don't think it would do that. | 20:48 |
| abentley | I thought you were deliberately excluding them. | 20:48 |
| rockstar | abentley, I don't know why I would deliberately exclude them. | 20:48 |
| abentley | AIUI, sourcepackagebranches do not necessarily have a product. | 20:48 |
| rockstar | abentley, ah, well, in that case, they wouldn't come up associated with the product then. | 20:48 |
| abentley | You need to have a link between the sourcepackage and the product. | 20:48 |
| abentley | And then to find sourcepackagebranches, you'd need to find the branches whose sourcepackage was linked to that product. | 20:49 |
| rockstar | abentley, hm, I question whether or not it matters then. If the source package doesn't have a product, than it shouldn't show up by product anyway. | 20:49 |
| rockstar | I suspect we'll probably want related recipes for a source package, but I wasn't going to implement that until someone wanted it. | 20:49 |
| abentley | rockstar, if you want to exclude sourcepackagebranches for now, you need to tweak your comment slightly. | 20:50 |
| abentley | "IProduct.recipes should provide all the SourcePackageRecipes attached to that product." => "IProduct.recipes should provide all the SourcePackageRecipes attached to that product's branches" | 20:51 |
| rockstar | abentley, Sure. | 20:51 |
| rockstar | abentley, done. | 20:51 |
| abentley | rockstar, r=me. | 20:52 |
| rockstar | abentley, cheers. | 20:52 |
| abentley | rockstar, could you please review https://code.edge.launchpad.net/~abentley/launchpad/answer-ordering/+merge/23050? | 21:35 |
| abentley | rockstar, Also, request-build is ready for review: https://code.edge.launchpad.net/~abentley/launchpad/request-build/+merge/22570 | 21:36 |
| rockstar | abentley, gotcha. I'm on it. | 21:37 |
| rockstar | abentley, r=me on the ordering one, looking at the other one now. | 21:37 |
| rockstar | abentley, what's up with pylint now? | 21:39 |
| abentley | rockstar, I don't know. | 21:40 |
| rockstar | abentley, I wonder why we still have pylint when it never seems to do anything but give us false positives. | 21:40 |
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!