[07:26] good morning [08:47] dholbach, hey. got some time? [08:47] nigelb: a bit, yes [08:47] can you do a review of the current https://wiki.ubuntu.com/ReviewersTeam/GettingInvolved [08:48] the problem is we haven't run into all the use cases yet, so I'm still actively reviewing to come into all the use cases so I add them as examples [08:48] sure [08:48] who should I mail with my feedback? [08:48] just ping me :) [08:48] persia, bryce, bdmurray, james_w, you? somebody else? [08:48] or mail me [08:48] I just thought it'd be good to keep the discussion in the team going :) [08:49] but I can mail just you too [08:49] dholbach, if you want to start a new thread with the entire discussion, I think thats fine too :) [08:49] I'll do it a bit later today, I first need to get some other stuff done [08:49] but I'll definitely do it today [08:49] thanks for your work on this! [08:49] lot more to go :) [08:49] :-) [08:50] oh and just to keep the motivation going [08:50] we have only 135 bugs in the "to be reviewed queue" [08:53] nigelb: are those pre-freeze reviews? [08:54] Ciemon, well, we'll try to get as many before freeze as possible [08:54] but I dont think much will happen [08:54] ok [08:54] like, I'm working on 6 bugs now. I'll probably try and get all of them it :) [08:54] I have some time, but my new patching knowledge often needs guidance [08:55] ask Daviey :) [08:55] Ciemon, what part are you having trouble with [08:56] oh, not trouble.. just lack of knowledge. [08:56] :) [08:57] you can always ask in #ubuntu-motu, the responses are fairly fast [08:57] yep, thanks [09:04] Ciemon wants to close 4 bugs with his branch [09:04] so that'll help the stats ! :) [09:05] you can do that :) [09:05] (actually encouraged, so that you dont clutter the rev numbers) [09:06] nigelb: yeah, he did have it as two items.. but the first one hadn't been sponsored yet, so he cleaned it down to 1 [09:06] Daviey, nice :) === dholbach_ is now known as dholbach [16:26] persia, any thoughts regarding what I PM'd you a few days back? [16:30] So, the last couple times you asked me, I replied in /query, and it seems not to have stuck. [16:30] Anyway, geser summed up my opinion fairly well in -motu when you asked there. [16:30] it was an unsure move anyway [16:31] so, any intersted devs can straight away join is better? [16:31] No. [16:31] But I suspect that any developer that comes by here and reads our procedures ought get in speedy-like. [16:32] the trouble I'm facing is recruiting review leads [16:32] Yeah, I'm expecting most of them to end up being me. [16:32] Although I hope you'll fill in any times you can. [16:32] I will [16:33] btw, cypher_mox has agreed to help too :) [16:33] and james__w and maco_ will depending on schedule then [16:33] Be aware that some folks have nifty highlighting that _ doesn't skip. [16:33] persia, I tried :D [16:34] crimsun if his schedule permits though his suspects he might be busy that week [16:34] I suspect many folks will be busy dealing with the sync flush + UDS preparation [16:34] if their script catches their name, not my fault :D [16:35] yup, thats what I'm afraid of [16:39] persia, if its any consolation, only 132 bugs in review queue [16:39] It can be reduced to 117 since a few of them are kernel or packages we need to ignore [16:42] Cool. I've a couple things on my plate now, but will take a swipe through sometime tonight: maybe we can get down to < 100 :) [16:42] thats what I'm hoping for [16:43] what happens if we get it down to 0? party? :D [16:47] If you like, but there's still all the old patches to tackle. [16:48] If we get *that* down to 0, someone needs to start a new patch creation initiative. [16:48] yeah, its down to 1797 [16:48] lol, so we'll have patch creation team :D [16:49] So, I'm expecting that in maverick+1 or maverick+2 we'll be able to have classes "How to fix bugs" for bugsquad again, and get more people contributing fixes. [16:49] Right. [16:49] And we'll encourage the patch creation team to follow-up with upstream, etc. [16:49] But that's the future: let's concentrate on the bugs we have now :) [16:49] we'd then we a *really really good* distro [16:49] s/we/be [16:50] I guess. My thought is more that we ought leverage our strong point (lots of users) as much as possible to help everyone. [16:51] I was thinking we move the starting date up for the script once we get to less than 20 [16:51] Sounds reasonable. [16:51] Let me get to work on a few patches, some of them can still be removed from review queue [16:52] ah, dan has given me more work on the wiki [16:52] are you up-to-date on mails? [16:53] dholbach, the patch-rejected-tag is to be used when upstream doesn't want to incorporate it in, when they want changes to it, it becomes patch-needswork. See bug 33288 [16:54] Malone bug 33288 in poppler "Evince doesn't handle columns properly" [Unknown,Confirmed] https://launchpad.net/bugs/33288 [16:54] nigelb: right, I'm asking "when is patch-*-rejected tag going to be != patch-needswork" [16:54] dholbach, I'll hunt down a use case from gnome upstream [16:55] it would mean "ok we forwarded it upstream, they don't want it, but we'll use it anyway", right? [16:55] its like work that ayatana does [16:55] some stuff is ubuntu specific that upstream doesnt want in their code base [16:56] so they reject the patch, but if its something we'd like it, we'll know it was forwarded and they didn't want it in [16:57] persia, got anything to add to ^ [16:58] I think it'd be better if we made the decision process so that we don't need those tags :-) [16:58] but it's basically just a foot note [16:58] nothing too important [16:58] I'd just prefer if we had less tags ;-) [16:58] I've had patched rejected as not-needswork. [16:59] For example, a patch to implement some feature that upstream said didn't belong in the software at all. [16:59] right [16:59] (I know: let's make dpkg a mailreader!) [16:59] in that case it'd still be a patch-needswork for us [16:59] hehe. we could just change it to patch-rejected and add comments as to which upstream (debian vs all the way upstream) [16:59] we have an open bug that we want to resolve somehow [16:59] dholbach: Why? How is adding mail reader support to dpkg "needs-work"? [16:59] if upstream says "please do it differently" that's the decision we want to hear [16:59] There's no sensible work that can improve that? [17:00] ok, then we won't fix the bug too [17:00] then we'd like to see why as soon as we open the bug [17:01] But patch-rejected-upstream != patch-rejected [17:02] all I'm saying is: if I have difficulties getting the sense of these tags, there will probably be a bunch of others who have more problems [17:02] :) [17:02] Quite possibly. [17:02] the decision tree is not quite clear and "patch-rejected-upstream" is in no way a "final stage of the bug or patch" [17:02] I suspect we need a significant body of data to actually interpret the tags properly. [17:02] I personally would have preferred tags that indicate what needs to be done with the bug / patch [17:02] so we could use them as working lists [17:02] No, patch-rejected-upstream only says that upstream didn't want it: we might want to carry it, or we might want to rework it. [17:03] but anyway [17:03] dholbach: Do you have an alternate strategy/workflow for all the tags? If you've a better one, I'm sure the rest of us would be willing to adjust. [17:04] I proposed something in a mail I sent to the first discussions of the team [17:04] but I have a call coming up now [17:06] I see that, but I can't imagine how we can know what has been sent upstream, or what upstream responses we have with that. [17:06] Anyway, tell me after your call if you like :) [17:07] i'll try incorporate what you've suggested and yes, we're open to suggestions :) [17:31] So, when to forward to debian? When issues are in something inside /debian and when upstream is dead and we still sync from debian? [17:50] persia, can reply ^ when you get time [17:53] I think we should forward to Debian whenever the issue expresses itself in Debian [17:53] That means testing in Debian, of course. [17:54] If we *also* forward upstream, it's trivial to tell the Debian BTS that it's been forwarded upsteam, and the Debian maintainer can make a determination as to how to proceed. [18:05] persia, lost power for 10 mins just after I asked you. but got the answers :) [18:12] ok, so replied to dholbach's mail :) [18:27] persia, we need to come up with something for bugs like bug 511502 [18:27] Malone bug 511502 in xdvik-ja "TeXLive 2009 transition: libkpathsea5" [Undecided,Fix released] https://launchpad.net/bugs/511502 [18:28] there are patches, but all sponsored, but there are open tasks, so end up in review queue [18:28] I think the real solution is to convince people not to file those bugs, and complain when they do. [18:28] huh? [18:28] It's duplicate information (see the NBS page), and mostly useless. [18:28] Plus it annoys all sorts of folk who are subscribed to the packages. [18:29] yeah [18:29] There are a couple more of those bugs. I'm waiting for update to the script to deal with these for now [18:29] Making them go away takes time and education. [18:30] isn't it easier to open multiple bugs? [18:30] No. It's trivial to open a bug with lots of tasks. [18:30] It just happens to be completely useless for that class of issue. [18:30] Its mostly our developers themselves who do it :( [18:31] I know. [18:31] For now, I suggest the reviewers team completely ignore them. [18:31] If I can make them go away, I will, but I'm unsure I can do that easily. [18:31] or create lots of noise that people stop fililng it :D [18:35] persia, *sigh* oh well, your point just got re-emphasized [18:36] can PM me what you said after "nigelb> or create lots of noise that people stop fililng it :D" ? [18:37] No, because you're not here :) But I didn't say anything, so perhaps I can, as the receipt of nothing would comply with the request to send nothing :) [18:38] persia, sometimes I wish you spoke English. [18:38] * nigelbabu smirks [18:41] persia, so is there a way to show only 1 instace of those type of bugs? [18:43] Search only for a given source package :) [18:44] persia, :P I meant in the review queue [18:45] I don't think so: we've had that issue in the sponsoring queue before. Since the only sensible justification for those massive bugs is to help sponsor other people's NBS work, this makes it useless even for it's intended purpose. [18:46] sigh :x