| * maxb grimaces at tests which only fail in a full test-run | 00:19 | |
| maxb | lp.services.scripts.tests.test_all_scripts.ScriptsTestCase is the testcase of doooooom | 00:27 |
|---|---|---|
| maxb | I worry that it's going to melt my laptop | 00:27 |
| spm | maxb: it won't melt; but it might get a bit soft and wobbly/deform.... | 00:38 |
| maxb | It's when the laptop starts to smell a little like a soldering iron that I worry :-) | 00:39 |
| spm | maxb: so long as the smoke doesn't escape? everything is gravy! | 01:04 |
| === matsubara is now known as matsubara-afk | ||
| mwhudson | spm: can i get you to apply a patch to strawberry pls? | 01:39 |
| spm | sure | 01:39 |
| mwhudson | spm: http://pastebin.ubuntu.com/413405/ | 01:39 |
| mwhudson | spm: *should* apply to the tree on there, not completely sure though | 01:40 |
| mwhudson | if it doesn't i'll just get you to replace the entire file i guess | 01:40 |
| spm | kk | 01:41 |
| mwhudson | spm: in news that may please a sysadmin, this patch is essentially telling bzr to stop being clever and be very stupid instead | 01:42 |
| spm | :-) applied | 01:43 |
| mwhudson | spm: can you kill the running import on strawberry ? | 01:43 |
| spm | mwhudson: with great and a deep sense of satisfaction and pleasure; done. | 01:44 |
| spm | mwhudson: fyi. afk for a sec. delivery arrival... | 01:46 |
| mwhudson | ok | 01:52 |
| spm | back | 01:52 |
| mwhudson | stupid > smart | 01:53 |
| mwhudson | in this case | 01:53 |
| spm | :-) | 01:53 |
| mwhudson | noop import before patch: 1hr 10 minutes | 01:53 |
| mwhudson | noop import after patch: three minutes | 01:53 |
| jelmer | mwhudson: the create_tree_if_local argument to sprout() doesn't work as expected? | 01:54 |
| spm | \o/ | 01:54 |
| mwhudson | jelmer: it doesn't? | 01:54 |
| mwhudson | jelmer: the problem seems to be mainly that 2a fetch is terribly slow | 01:54 |
| jelmer | mwhudson: I'm not sure, just trying to work my head around what your patch does differently | 01:54 |
| mwhudson | jelmer: my patch uses copy_tree_to_transport rather than sprout | 01:55 |
| mwhudson | jelmer: i think that counts as fairly different | 01:56 |
| wgrant | Oh, nice! | 01:56 |
| jelmer | mwhudson: heh | 01:57 |
| wgrant | Do I spy a bzr bug coming soon? | 01:57 |
| mwhudson | (credit to abentley for the idea) | 01:57 |
| jelmer | mwhudson: I missed that, surprised bzr doesn't do that itself.. | 01:57 |
| jelmer | mwhudson: (in those cases where it's possible_ | 01:57 |
| jelmer | ) | 01:57 |
| jelmer | mwhudson: should the branch scanner work ? | 01:57 |
| wgrant | The puller times out :( | 01:58 |
| mwhudson | next on the hit list: having the puller use a similar hack for import branches | 01:58 |
| wgrant | Hm. So it takes 37 seconds to copy directly, and slightly under 70 minutes for bzr to do it? | 02:00 |
| mwhudson | something like that yes :( | 02:02 |
| mwhudson | aragh | 02:06 |
| mwhudson | Transport operation not possible: Transport <bzrlib.transport.http._urllib.HttpTransport_urllib url=http://localhost:10899/0000004d/> has not implemented list_dir (but must claim to be listable to trigger this error). | 02:06 |
| wgrant | It pulls over HTTP!? | 02:06 |
| mwhudson | yes | 02:06 |
| mwhudson | actually not on staging, so this patch will probably work there.... | 02:07 |
| wgrant | Hm, but that's probably actually faster than using the smartserver here. | 02:07 |
| mwhudson | yes, smartserver is /mostly/ a squeeze on latency | 02:07 |
| mwhudson | and bandwidth in some cases i guess, but we have lots of one and very little of the other so... | 02:07 |
| mwhudson | the error message seems to be lying fwiw | 02:09 |
| * mwhudson hacks, mightily | 02:26 | |
| mwhudson | spm: hi, could you apply this patch to the tree on tellurium please? http://pastebin.ubuntu.com/413423/ | 02:40 |
| mwhudson | warning: do no attempt to read said patch | 02:40 |
| mwhudson | *not | 02:40 |
| spm | :-) | 02:41 |
| spm | aaaaaaa. I am blinded and cannonit see | 02:44 |
| spm | mwhudson: applied | 02:44 |
| spm | need codehost restarted? looks like not.... | 02:44 |
| mwhudson | spm: no | 02:45 |
| wgrant | It's taking a while.. | 02:50 |
| mwhudson | spm: is there a mirror-branch.py process running on tellurium? | 02:51 |
| spm | 000 3944 97.1 18.5 653364 382120 ? R 02:48 3:25 \_ /usr/bin/python2.5 /srv/bazaar.staging.launchpad.net/staging/launchpad/scripts/mirror-branch.py /home/supermirror/importd-push-branches/0004ea4b lp-mirrored:///~mwhudson/linux/trunk 322123 ~mwhudson/linux/trunk IMPORTED 1 | 02:52 |
| mwhudson | spm: okay | 02:53 |
| mwhudson | seems maybe my hacks aren't helping all that much | 02:53 |
| mwhudson | spm: can you du -sh /home/supermirror/importd-push-branches/0004ea4b /srv/bazaar.staging.launchpad.net/mirrors/00/04/ea/4b ? | 02:53 |
| spm | 620M /home/supermirror/importd-push-branches/0004ea4b | 02:54 |
| spm | 61M /srv/bazaar.staging.launchpad.net/mirrors/00/04/ea/4b | 02:54 |
| spm | thats an impressive mismatch? | 02:54 |
| mwhudson | bah | 02:54 |
| mwhudson | spm: can you apply this patch to tellurium too? /home/supermirror/importd-push-branches/0004ea4b | 02:58 |
| mwhudson | no | 02:58 |
| mwhudson | spm: http://pastebin.ubuntu.com/413428/ <- this patch | 02:59 |
| spm | sure | 03:00 |
| spm | patched | 03:01 |
| mwhudson | spm: can you zap the mirror-branch process? | 03:02 |
| * spm reaches under the desk for the larger hammer..... | 03:02 | |
| spm | yo stub | 03:03 |
| stub | put the hammer down... | 03:03 |
| spm | <whine> but *stub* I was gunna make you plural! | 03:04 |
| mwhudson | spm: ok, can you sync the puller logs from tellurium to devpad please? | 03:05 |
| spm | mwhudson: 1000 4772 99.5 8.0 436900 165584 ? R 03:04 0:53 \_ /usr/bin/python2.5 /srv/bazaar.staging.launchpad.net/staging/launchpad/scripts/mirror-branch.py /home/supermirror/importd-push-branches/0004ea4b lp-mirrored:///~mwhudson/linux/trunk 322123 ~mwhudson/linux/trunk IMPORTED 1 | 03:05 |
| spm | mwhudson: synced | 03:07 |
| === poolie1 is now known as poolie | ||
| mwhudson | oh goody oops reporting is broken | 03:12 |
| mwhudson | i guess i'll give up for now and have lunch | 03:14 |
| adeuring | good morning | 07:58 |
| lifeless | thumper: mwhudson: if you're still around, I need a pointer to the twisted vfs stuff in the lp code base - the policy on permitted file names specifically. | 08:06 |
| lifeless | thumper: mwhudson: nevermind, found it, drive by patch submitted | 08:15 |
| wgrant | bigjools: How many years is it since buildd-sequencer has been used? | 09:19 |
| bigjools | since Jan 2009 | 09:20 |
| wgrant | Oh. | 09:20 |
| bigjools | cprov wrote it in the back of the van at UDS Mountain View :) | 09:21 |
| wgrant | I thought buildd-slave-scanner was used before buildd-manager, and buildd-sequencer came before slave-scanner. | 09:21 |
| bigjools | wait | 09:22 |
| bigjools | it's *not* been used since 2009 | 09:22 |
| bigjools | I mean cprov wrote b-m in the van | 09:22 |
| bigjools | slave-scanner is the same thing as buildd-sequencer | 09:23 |
| bigjools | we like to use as many different confusing names as possible | 09:23 |
| wgrant | Er, is it? | 09:23 |
| wgrant | lib/canonical/buildd/sequencer.py seems reasonably unrelated to cronscripts/buildd-slave-scanner.py | 09:23 |
| wgrant | Or is buildd/sequencer not actually buildd-sequencer? | 09:25 |
| === wgrant changed the topic of #launchpad-dev to: Launchpad Development Channel | Week 1 of 10.04 | PQM is open | https://dev.launchpad.net/ | Get the code: https://dev.launchpad.net/Getting | On-call review in irc://irc.freenode.net/#launchpad-reviews | Use http://paste.ubuntu.com/ for pastes | ||
| bigjools | wgrant: I've no idea what the former is, since it's in the buildd dir then it's part of the slave | 09:35 |
| wgrant | Ah: | 09:36 |
| wgrant | The task sequencer is a simple twisted daemon which looks after making | 09:36 |
| wgrant | sure that the buildd tasks (E.g. slave scanner, queue builder etc) are | 09:36 |
| wgrant | only run one at a time, and potentially more often than once per | 09:36 |
| wgrant | minute. | 09:36 |
| wgrant | Sounds useless, is in the wrong place, and breaks slightly with Python 2.6. | 09:37 |
| bigjools | no kidding | 09:37 |
| wgrant | And hasn't been touched significantly since 2005. | 09:37 |
| wgrant | bigjools: So, will anybody miss it if I remove it and its doctest as a step towards Python 2.6 support? | 10:12 |
| bigjools | wgrant: where's the test? | 10:18 |
| wgrant | bigjools: lib/lp/soyuz/doc/buildd-sequencer.txt | 10:18 |
| bigjools | good grief | 10:19 |
| wgrant | Hm? | 10:19 |
| bigjools | delete it with prejudice | 10:19 |
| * wgrant destroys. | 10:19 | |
| wgrant | It's impossible to remove config schema elements at the moment, right? | 10:40 |
| bigjools | huh? | 10:46 |
| wgrant | Didn't rollouts explode last week because a config key had been removed, so the production configs (which still had a value for it) were invalid? | 10:47 |
| wgrant | Ah, yes, bug 557271. | 10:49 |
| mup | Bug #557271: Unable to remove config entries from the schema <Launchpad Foundations:New> <https://launchpad.net/bugs/557271> | 10:49 |
| bigjools | hmmm | 11:00 |
| deryck | Morning, all. | 11:01 |
| bigjools | howdy deryck | 11:05 |
| sidnei | jml, where's that patch you wanted me to land again? | 11:06 |
| jml | https://bugs.edge.launchpad.net/zope.testing/+bug/560259 | 11:07 |
| mup | Bug #560259: Subunit output formatter doesn't handle layer setup errors <zope.testing:In Progress by sidnei> <https://launchpad.net/bugs/560259> | 11:07 |
| jml | sidnei: it's the branch linked to that, and the attached patch | 11:07 |
| sidnei | jml, both? or either? | 11:08 |
| jml | either | 11:08 |
| jml | same patch | 11:08 |
| sidnei | oh, looks trivial. | 11:08 |
| sidnei | jml, you need a new release too? | 11:23 |
| jml | sidnei: yes please | 11:24 |
| jml | sidnei: and yes, it's really trivial :) | 11:24 |
| sidnei | jml, done | 11:31 |
| jml | sidnei: woot! thanks! | 11:32 |
| sidnei | np! | 11:32 |
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| henninge | sidnei_: can you come over to #lp-review, please? ;) | 13:30 |
| === sidnei_ is now known as sidnei | ||
| Ursinha_ | leonardr, ping | 13:56 |
| leonardr | hi ursinha_ | 13:57 |
| Ursinha_ | leonardr, hi, I hit an error with one of my lpapi scripts, I wonder if you know what could it be | 13:57 |
| Ursinha_ | leonardr, "SyntaxError: no element found: line 16363, column 186" | 13:57 |
| Ursinha_ | this is the error, when I try to login_with | 13:58 |
| leonardr | that sounds like there's a problem with the wadl | 13:58 |
| Ursinha_ | leonardr, yeah, but I have no idea why, since it works with another user | 13:58 |
| Ursinha_ | leonardr, invalid credentials? | 13:58 |
| leonardr | you would get a 400 error. is that the entire error? | 13:58 |
| leonardr | there's no headers? | 13:59 |
| Ursinha_ | leonardr, let me show you the traceback | 13:59 |
| leonardr | no, i guess there wouldn't be since it's not an http error | 13:59 |
| Ursinha_ | leonardr, this is the traceback: https://pastebin.canonical.com/30486/ | 14:00 |
| leonardr | ursinha_: i suggest catching the exception in _browser.py#get_wadl_application and printing out 'content' | 14:01 |
| Ursinha_ | leonardr, sure, a moment | 14:04 |
| Ursinha_ | leonardr, this is weird, it seems that the end of that 'content' is missing | 14:50 |
| Ursinha_ | leonardr, line 16363, column 186 is the last line of that content, and it's not complete | 14:54 |
| deryck | kfogel, ping | 15:02 |
| kfogel | deryck: on phone, bbiab | 15:04 |
| deryck | ack | 15:04 |
| leonardr | Ursinha_ that content comes from a file on disk. lib/canonical/launchpad/apidoc/wadl-*-*.xml | 15:04 |
| leonardr | check that file and see if it's truncated | 15:04 |
| Ursinha_ | aha | 15:04 |
| leonardr | if so, remove that directory and make again | 15:04 |
| Ursinha_ | leonardr, hmm, thing is I'm running my script on devpad | 15:06 |
| Ursinha_ | works with one user and doesn't work with another | 15:06 |
| Ursinha_ | leonardr, and I can't reproduce the error locally | 15:08 |
| leonardr | Ursinha_: i don't use devpad so i don't know what that means. you don't have access to the apidoc/*.xml? | 15:09 |
| Ursinha_ | leonardr, exactly | 15:10 |
| leonardr | Ursinha_: i suggest you escalate to someone who does have access | 15:10 |
| wgrant | Aren't the API scripts running against prod/edge? | 15:11 |
| wgrant | So it's probably a client-side cache. | 15:11 |
| Ursinha_ | leonardr, but I'm running the script with edge lp api | 15:11 |
| Ursinha_ | what wgrant said | 15:11 |
| Ursinha_ | wgrant, cache huh | 15:11 |
| leonardr | ursinha_: on phone, sorry | 15:11 |
| Ursinha_ | leonardr, no problem, thanks so far | 15:12 |
| wgrant | Ursinha_: Try obliterating/moving ~/.launchpadlib/api.edge.launchpad.net/cache | 15:12 |
| Ursinha_ | wgrant, yeah, that worked | 15:21 |
| Ursinha_ | wgrant, thanks | 15:21 |
| deryck | gmb, bug 294223 is done, right? | 15:26 |
| mup | Bug #294223: Bugs missing after import from SourceForge <Launchpad Bugs:In Progress by gmb> <https://launchpad.net/bugs/294223> | 15:26 |
| gmb | deryck, Yep. | 15:27 |
| gmb | Forgot about that | 15:27 |
| deryck | gmb, can you update and assign to the current milestone please? | 15:27 |
| gmb | deryck, Sure | 15:31 |
| gmb | Done | 15:31 |
| deryck | gmb, thanks | 15:32 |
| deryck | adeuring, can you update bug 261254 with linked branch, status, and assign to the current milestone? I believe this is done, yes? | 15:43 |
| mup | Bug #261254: Launchpad couldn't connect to ALSA Bug Tracker. <bugwatch> <oops> <story-reliable-bug-syncing> <ubuntu-qa> <Launchpad Bugs:In Progress by adeuring> <https://launchpad.net/bugs/261254> | 15:43 |
| adeuring | deryck: sure | 15:43 |
| deryck | adeuring, thanks! | 15:43 |
| mars | sinzui, ping, do you have some time today to chat about changing some more /@@/ icons into sprites? I have a question or two about it. | 15:49 |
| mars | sinzui, if you have time, whenever you have time | 15:49 |
| sinzui | mars, I will after 3:00+. I do not know much about how icons become sprites. EdwinGrubbs wrote the tools that generate the sprite and css | 15:50 |
| SlonUA | maxb: how is going ? =) | 15:51 |
| maxb | hello :-) | 15:51 |
| mars | sinzui, ok. EdwinGrubbs, do you have time to chat about sprites some time today? | 15:51 |
| SlonUA | maxb: do u know how to enable karma .. just to see may digging =) | 15:51 |
| EdwinGrubbs | mars: sure | 15:51 |
| mars | EdwinGrubbs, what time for you? | 15:52 |
| maxb | I know nothing more than it involves a cronscript somewhere | 15:52 |
| EdwinGrubbs | mars: I can do it now, but it might be a little noisy since I'm at a coffee shop. | 15:52 |
| mars | heh | 15:52 |
| mars | EdwinGrubbs, that should be fine | 15:52 |
| mars | EdwinGrubbs, skype or mumble? | 15:52 |
| SlonUA | maxb: i see 'karma has expired.' all time | 15:52 |
| EdwinGrubbs | mars: skype | 15:54 |
| === Ursinha_ is now known as Ursinha-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| mars | intellectronica, online? | 16:16 |
| intellectronica | mars: yes | 16:16 |
| intellectronica | how can i help you? | 16:16 |
| mars | Tom, I'm looking at turning some of the /@@/edit icons in the bug status table into sprites | 16:17 |
| mars | intellectronica, can you see an issue with me doing so? | 16:17 |
| mars | this is in the name of improved page performance, btw :) | 16:18 |
| intellectronica | mars: nothing i can think of off the top of my head. looks like a net win to me. | 16:18 |
| mars | intellectronica, cool. I'll ask someone on the bugs team for a review when I'm done, just to make sure your team thinks my changes are sane. | 16:19 |
| intellectronica | cool | 16:20 |
| mars | thanks! | 16:20 |
| === barry is now known as flufl | ||
| === flufl is now known as barry | ||
| === deryck[lunch] is now known as deryck | ||
| jml | I'm forcing a rebuild of the recently failed 'lp' buildslave | 17:06 |
| jml | "no space left on device" seems to be the originating error | 17:07 |
| === beuno is now known as beuno-lunch | ||
| * jml discovers CachingIterator | 17:32 | |
| jml | it's just like lists in Haskell! | 17:32 |
| jelmer | ooh, there is something like that? | 17:36 |
| * jelmer has reimplemented it at least twice :-) | 17:36 | |
| jelmer | jml: where does it live? | 17:37 |
| jml | jelmer, lp.services.utils | 17:37 |
| jml | jelmer, which is the best known home for such a thing | 17:37 |
| jelmer | oh, in Launchpad itself. It'd be a great thing to have in itertools... | 17:37 |
| jelmer | jml: Thanks anyway, I'm sure this will come in useful sometime :-) | 17:38 |
| jml | yeah | 17:38 |
| === Ursinha-lunch is now known as Ursinha | ||
| * bigjools reboots from karmic into lucid | 17:38 | |
| jml | jelmer, I should also add synchronize and dichotomy to itertools, I guess | 17:38 |
| jml | jelmer, I didn't write it, fwiw. I just found it. | 17:38 |
| jml | given the docstring, I'll wager abentley wrote it | 17:38 |
| jelmer | jml: you can tell that just from the docstring? | 17:39 |
| jml | jelmer, "Some generators and iterators are expensive to calculate, like calculating the merge sorted revision graph for a bazaar branch" | 17:40 |
| jelmer | ah, the reference to Bazaar | 17:40 |
| jml | jelmer, nope, thumper. | 17:41 |
| === leonardr is now known as leonardr-afk | ||
| === beuno-lunch is now known as beuno | ||
| kfogel | deryck: pong | 18:18 |
| kfogel | deryck: can't remember if your ping was internal or external channel :-) | 18:18 |
| deryck | did I ping? :-) | 18:19 |
| deryck | oh, this morning... right | 18:20 |
| deryck | kfogel, are you working on stats for patch project? Do I recall that correctly? | 18:20 |
| kfogel | deryck: yup | 18:21 |
| kfogel | deryck: https://code.edge.launchpad.net/~kfogel/tuolumne-lp-configs/patches-time-to-closing | 18:22 |
| kfogel | deryck: queries there; not much code yet | 18:22 |
| kfogel | deryck: abel is helping w/ queries btw | 18:22 |
| deryck | kfogel, ok, that's all I needed to know. I've been meaning to get back to stats for that project and wondered if your work included lpstats stuff. | 18:23 |
| deryck | kfogel, btw, you'll have to subscribe me to that branch to see it. | 18:23 |
| kfogel | deryck: oh, it's private? one sec | 18:25 |
| kfogel | deryck: you want rev notifications too, or just branch attribute notifications? | 18:25 |
| deryck | kfogel, just attrs. | 18:25 |
| kfogel | deryck: done | 18:26 |
| === gary_poster is now known as gary-lunch | ||
| deryck | kfogel, thanks. and thanks for getting the stats together. | 18:28 |
| kfogel | deryck: you're welcome; but thank me when it's done -- it's hard to measure this thing! | 18:30 |
| kfogel | not use, but benefit, I mean | 18:30 |
| deryck | yeah, that's why I hadn't got round to working on it yet. | 18:30 |
| sinzui | jpds, ping | 18:48 |
| === dpm is now known as dpm-afk | ||
| === leonardr-afk is now known as leonardr | ||
| jpds | sinzui: Hello. | 19:11 |
| sinzui | jpds, have you tested that you can control the official country mirror status using api? | 19:12 |
| jpds | sinzui: Yes. | 19:12 |
| sinzui | jpds, as you represent the primary user of the feature, you want to update this bug's tag to qa-oa: https://bugs.edge.launchpad.net/launchpad-registry/+bug/361650 | 19:14 |
| mup | Bug #361650: launchpad could know about official country mirror status <feature> <mirror> <qa-needstesting> <Launchpad Registry:Fix Committed by jpds> <https://launchpad.net/bugs/361650> | 19:14 |
| jpds | sinzui: Sure, done. | 19:14 |
| sinzui | thanks | 19:15 |
| Ursinha | hi gary-lunch, I filed a bug now, bug 562486, are you aware of this issue? and, is that really foundations? | 19:41 |
| mup | Bug #562486: accessing pending_gpg_keys using the api fails to some users <api> <oops> <Launchpad Foundations:New> <https://launchpad.net/bugs/562486> | 19:41 |
| === gary-lunch is now known as gary_poster | ||
| gary_poster | Ursinha: I was not aware of the issue. It's definitely a foundations issue, and if it is a matter of how the code is exported rather than infrastructure, it is also a registry issue. I'll ask leonardr for his opinion...once the oops tools are fixed :-) | 20:02 |
| Ursinha | gary_poster, :) | 20:03 |
| Ursinha | gary_poster, thanks | 20:03 |
| gary_poster | thank you | 20:03 |
| sinzui | gary_poster, Ursinha there are two issues that relate to this bug... | 20:05 |
| sinzui | gary_poster, 1, the seem to be available in one database and not another, leading to many oopses.... | 20:06 |
| sinzui | but there is a second debacle from last release where gpgkeys were renamed to gpg_keys, not not all the code was updated | 20:06 |
| sinzui | Ursinha, EdwinGrubbs is landing a fix for the latter. | 20:07 |
| gary_poster | sinzui: "seem to be available in one database and not another": which different databases? Do you mean replication slaves and masters? | 20:08 |
| sinzui | gary_poster, yes, gpgkeys are manages via logintokens | 20:08 |
| sinzui | gary_poster, we also saw this happen in the CoC web UI | 20:09 |
| gary_poster | sinzui: does that maybe mean that you need to always connect to the master for these queries, using one of stub's context manager things? | 20:10 |
| sinzui | gary_poster, I do not know | 20:10 |
| * gary_poster doesn't really know context so is probably not helpful | 20:10 | |
| gary_poster | it sounds like it | 20:10 |
| gary_poster | sounds like a race condition | 20:10 |
| gary_poster | and if it is a race condition with the slaves, force using the master. | 20:11 |
| gary_poster | if you think that sounds reasonable, and you are not sure about stub's context manager, I can hunt up an example for you, sinzui | 20:11 |
| EdwinGrubbs | sinzui: regarding the bug with +claim, does this mean that the Account.activate() method is also problematic since it sets a password that might be different from what was entered on the LoginService? | 20:29 |
| leonardr | james_w, can you give me the specific failure you get when you trigger bug 561521? | 20:29 |
| mup | Bug #561521: Success of PATCH request dependent on dict iteration order <lazr.restful:New> <https://launchpad.net/bugs/561521> | 20:29 |
| james_w | leonardr: it was in the mailing list post | 20:29 |
| leonardr | james_w: ok, i'll find it and put it into the bug | 20:30 |
| sinzui | EdwinGrubbs, I do not know. /me looks | 20:30 |
| sinzui | EdwinGrubbs, isn't the account the SSO account, I do not think there is a Launchpad Account | 20:31 |
| james_w | leonardr: note that it's a followon error that is in the thread. If you want the exception thrown by the mutator then modify the test mentioned in the bug to print the response from the patch request. | 20:32 |
| sinzui | EdwinGrubbs, the use case we are trying to avoid is a non-login user working with profiles and account. So if the user can access Account.activate() without being logged into the SSO server, there is a problem | 20:33 |
| leonardr | james_w: i can't find the relevant post in my mailbox. what was the subject? | 20:35 |
| james_w | "Test failures on some platforms due to lazr.restful bug" | 20:35 |
| EdwinGrubbs | sinzui: the reason I ask is that +claim gives you a login token that takes you to the ClaimProfileView in c/l/browser/logintoken.py and that calls emailaddress.account.activate(), so it would seem like the non-login user could access it. | 20:36 |
| leonardr | ok, i got it | 20:36 |
| sinzui | EdwinGrubbs, yes, that is taking the wrong path bad= person > email > account | 20:36 |
| sinzui | EdwinGrubbs, good = account > email > person | 20:37 |
| sinzui | EdwinGrubbs, so I think Account.activate is not a problem, but the callsite must know when/how to call it. claim does not | 20:38 |
| EdwinGrubbs | sinzui: huh, does that just mean that we don't want to link a launchpad person that has the same email as the account but isn't already linked to that account directly? | 20:39 |
| sinzui | EdwinGrubbs, we do want to link person to emails, we have to since emails are unique | 20:39 |
| EdwinGrubbs | sinzui: I'm just trying to clarify why account>email>person is good. | 20:40 |
| sinzui | EdwinGrubbs, I think this discussion is moot. there are two callsites, and you are removing one of them | 20:40 |
| sinzui | EdwinGrubbs, So we can limit our discussion to Person.setPreferredEmail | 20:41 |
| sinzui | EdwinGrubbs, Maybe we should change the guard in setPreferredEmail() and raise an exception instead of trying to fix the issue? | 20:43 |
| EdwinGrubbs | sinzui: do you think it could be broken, or do you just want to get rid of the kludge? | 20:45 |
| sinzui | EdwinGrubbs, We need to be careful in this method, I believe reset password switched the account from deactivated (by the user) back to activated. we may need to ensure the callsites (SSO!) has updated the account first. | 20:45 |
| sinzui | EdwinGrubbs, ^ reset password switcheS THE ACCOUNT USING THIS METHOD | 20:46 |
| sinzui | EdwinGrubbs, maybe I am over thinking this issue. setPreferredEmail() has no issues with active activated and deactivate accounts. suspend accounts cannot get here. so the problem is only when the account is not active. | 20:48 |
| sinzui | EdwinGrubbs, I see scripts are calling setPreferredEmail. This could be very ugly. | 20:49 |
| EdwinGrubbs | hmmm | 20:51 |
| sinzui | EdwinGrubbs, I think we should remove the account hack in setPreferredEmail(), but I need to verify how we are resting password | 20:51 |
| EdwinGrubbs | sinzui: well, I'll continue working on removing +claim for the time being. | 20:52 |
| sinzui | yes, I suspect setPreferredEmail() is a separate bug | 20:53 |
| sinzui | EdwinGrubbs, SSO reactivates the account itself. I think we can treat bug #248518 as a trivial deletion in a separate branch | 20:59 |
| mup | Bug #248518: setPreferredEmail activated accounts <registry> <tech-debt> <Launchpad Registry:Triaged> <https://launchpad.net/bugs/248518> | 20:59 |
| === EdwinGrubbs is now known as Edwin-afk | ||
| mwhudson | good morning | 21:19 |
| sinzui | hi mwhudson | 21:20 |
| * mwhudson tries to browse the code of the kernel import | 21:42 | |
| mwhudson | abentley, rockstar: https://code.staging.launchpad.net/~mwhudson/linux/trunk | 22:16 |
| maxb | trunk != linux-2.6.31.y.git | 22:37 |
| mwhudson | it's just the default in the form :) | 22:38 |
| mwhudson | weee adding all the revisions in the scanner for that kernel import took 90 minutes | 22:55 |
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!