| thumper | mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/code-review-comment-tweak/+merge/23522 | 05:33 |
|---|---|---|
| thumper | mwhudson: trivial | 05:33 |
| mwhudson | thumper: done | 05:36 |
| thumper | mwhudson: ta | 05:36 |
| danilos | adiroiban, I am resubmitting your branch for landing, hopefully it goes through this time | 07:44 |
| adiroiban | danilos: hi. ok :) | 07:44 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === henninge_ is now known as henninge | ||
| StevenK | adeuring: Hi! Could you look at https://code.edge.launchpad.net/~stevenk/launchpad/fixes-bug-451396/+merge/21706 ? | 10:14 |
| adeuring | StevenK: sure | 10:14 |
| === daniloff is now known as danilos | ||
| adeuring | streview sent | 10:53 |
| adeuring | StevenK: review sent | 10:53 |
| StevenK | adeuring: Thank you! | 11:16 |
| === stub1 is now known as stub | ||
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| gmb | adeuring, Can I get a code review for https://code.edge.launchpad.net/~gmb/launchpad/make-bugwatch-errors-less-obscure-bug-530113/+merge/23541 please? | 14:13 |
| gmb | rockstar, Are you available to give me a trivial UI review for https://code.edge.launchpad.net/~gmb/launchpad/make-bugwatch-errors-less-obscure-bug-530113/+merge/23541? | 14:14 |
| adeuring | gmb: sure | 14:19 |
| gmb | adeuring, Thanks | 14:19 |
| adeuring | gmb: rapproved | 14:24 |
| gmb | adeuring, Danke. | 14:25 |
| adeuring | gmb: welcome :) | 14:25 |
| sinzui | gmb: the tooltip looks good | 14:56 |
| gmb | sinzui, Thanks. | 14:57 |
| sinzui | gmb: I think I stepped on intellectronica or rockstar by just approving it. | 15:01 |
| intellectronica | and it hurts... | 15:01 |
| gmb | sinzui, Yeah, intellectronica said he'd review it, sorry. | 15:01 |
| intellectronica | but i would have given the exact same reply as you anyway, looks excellent :) | 15:01 |
| gmb | intellectronica, Thanks. | 15:02 |
| sinzui | intellectronica, this is your chance to prove I am incompetent. maybe the tooltip target is too small on your machine so you can never make it appear | 15:02 |
| gmb | Gah! I submitted it against db-devel, not devel. Oh well, old-fashioned ec2 test it is then. | 15:02 |
| gmb | intellectronica, sinzui: NO, IT'S FINE. | 15:02 |
| intellectronica | ha ha | 15:03 |
| sinzui | gmb: but lp does think you have a merge conflict | 15:03 |
| gmb | sinzui, That's because it's submitted against the wrong branch. | 15:03 |
| gmb | sinzui, The mp is for merging into db-devel, but I want it to land on devel. | 15:04 |
| sinzui | I suspected that | 15:04 |
| gmb | I'll check that it's not actually a problem, though. | 15:04 |
| === danilos is now known as daniloff | ||
| bigjools | adeuring: really trivial branch winging its way to you as soon as the email gets to LP :) | 15:21 |
| adeuring | bigjools: ok, I#ll take a trivial look ;) | 15:21 |
| bigjools | adeuring: danke :) | 15:22 |
| adeuring | bigjools: r=me | 15:28 |
| bigjools | adeuring: cheers | 15:29 |
| EdwinGrubbs | adeuring: hi, can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-554153-claim-profile-bug/+merge/23550 | 15:43 |
| adeuring | EdwinGrubbs: sure | 15:43 |
| noodles775 | Hi adeuring, will you have time for another one? https://code.edge.launchpad.net/~michael.nelson/launchpad/delegate-to-buildfarmjob/+merge/23553 | 15:59 |
| === noodles775 changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| adeuring | noodles775: I am a bit tired, but I'll try my best ;) | 15:59 |
| noodles775 | adeuring: no problem if you don't get to it... it'll get picked up on Monday. Thanks either way. | 16:00 |
| adeuring | EdwinGrubbs: w=me | 16:26 |
| EdwinGrubbs | thanks | 16:35 |
| === adeuring changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === deryck is now known as deryck[lunch] | ||
| === deryck[lunch] is now known as deryck | ||
| === gary_poster is now known as gary-lunch | ||
| === gary-lunch is now known as gary_poster | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!