[05:33] mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/code-review-comment-tweak/+merge/23522 [05:33] mwhudson: trivial [05:36] thumper: done [05:36] mwhudson: ta [07:44] adiroiban, I am resubmitting your branch for landing, hopefully it goes through this time [07:44] danilos: hi. ok :) === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === henninge_ is now known as henninge [10:14] adeuring: Hi! Could you look at https://code.edge.launchpad.net/~stevenk/launchpad/fixes-bug-451396/+merge/21706 ? [10:14] StevenK: sure === daniloff is now known as danilos [10:53] streview sent [10:53] StevenK: review sent [11:16] adeuring: Thank you! === stub1 is now known as stub === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell [14:13] adeuring, Can I get a code review for https://code.edge.launchpad.net/~gmb/launchpad/make-bugwatch-errors-less-obscure-bug-530113/+merge/23541 please? [14:14] rockstar, Are you available to give me a trivial UI review for https://code.edge.launchpad.net/~gmb/launchpad/make-bugwatch-errors-less-obscure-bug-530113/+merge/23541? [14:19] gmb: sure [14:19] adeuring, Thanks [14:24] gmb: rapproved [14:25] adeuring, Danke. [14:25] gmb: welcome :) [14:56] gmb: the tooltip looks good [14:57] sinzui, Thanks. [15:01] gmb: I think I stepped on intellectronica or rockstar by just approving it. [15:01] and it hurts... [15:01] sinzui, Yeah, intellectronica said he'd review it, sorry. [15:01] but i would have given the exact same reply as you anyway, looks excellent :) [15:02] intellectronica, Thanks. [15:02] intellectronica, this is your chance to prove I am incompetent. maybe the tooltip target is too small on your machine so you can never make it appear [15:02] Gah! I submitted it against db-devel, not devel. Oh well, old-fashioned ec2 test it is then. [15:02] intellectronica, sinzui: NO, IT'S FINE. [15:03] ha ha [15:03] gmb: but lp does think you have a merge conflict [15:03] sinzui, That's because it's submitted against the wrong branch. [15:04] sinzui, The mp is for merging into db-devel, but I want it to land on devel. [15:04] I suspected that [15:04] I'll check that it's not actually a problem, though. === danilos is now known as daniloff [15:21] adeuring: really trivial branch winging its way to you as soon as the email gets to LP :) [15:21] bigjools: ok, I#ll take a trivial look ;) [15:22] adeuring: danke :) [15:28] bigjools: r=me [15:29] adeuring: cheers [15:43] adeuring: hi, can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-554153-claim-profile-bug/+merge/23550 [15:43] EdwinGrubbs: sure [15:59] Hi adeuring, will you have time for another one? https://code.edge.launchpad.net/~michael.nelson/launchpad/delegate-to-buildfarmjob/+merge/23553 === noodles775 changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [15:59] noodles775: I am a bit tired, but I'll try my best ;) [16:00] adeuring: no problem if you don't get to it... it'll get picked up on Monday. Thanks either way. [16:26] EdwinGrubbs: w=me [16:35] thanks === adeuring changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === deryck is now known as deryck[lunch] === deryck[lunch] is now known as deryck === gary_poster is now known as gary-lunch === gary-lunch is now known as gary_poster