=== matsubara is now known as matsubara-afk
[02:21] <abentley> thumper, I can has review? https://code.edge.launchpad.net/~abentley/launchpad/append-distroseries/+merge/23728
[02:33] <wgrant> abentley: Appending just the distroseries name is very unusual.
[02:34] <wgrant> Was that was james_w suggested?
[02:34] <abentley> wgrant, it is.
[02:34] <wgrant> (normally something like ~series1 is used)
[02:35] <abentley> wgrant, okay, I may have gotten that bit wrong.
[02:38] <abentley> wgrant, thumper: changed and pushed.
[02:41] <wgrant> abentley: I'm not a fan of the s/distroseries/distroseries_name/, but from a packaging PoV that looks good. Thanks.
[02:42] <thumper> wgrant: please comment on the merge proposal :)
[02:43] <thumper> wgrant: in the future rather than just IRC
[02:43] <thumper> wgrant: otherwise we can miss it
[02:43] <abentley> wgrant, thanks for catching it.  I'd forgotten exactly what james_w suggested.
[02:43] <wgrant> thumper: True. Sorry.
[02:43] <thumper> wgrant: consider it practise for being a real reviewer :)
[02:52] <mwhudson> thumper: this is the real interdiff http://pastebin.ubuntu.com/418954/
[05:57] <abentley> thumper, I can has review? https://code.edge.launchpad.net/~abentley/launchpad/build-security/+merge/23741
[09:27] <noodles775> Hey henninge! Will you get a chance to lok at my branch today?
[09:27] <noodles775> No problem if not, just trying to clear our kanban lane :)
[09:28] <henninge> oh, it's Tuesday ...
[09:28] <henninge> noodles775: sure, at some point ... ;)
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || reviewing: - || queue: [noodles775,adiroiban(bug-564852),jpds] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[09:29] <noodles775> Great, thanks.
=== henninge_ is now known as henninge
[10:53] <gmb> henninge, Good morning. Mind if I add https://code.edge.launchpad.net/~gmb/launchpad/reschedule-button-qafix-bug-558415/+merge/23698 to your queue?
[10:53] <henninge> gmb: ah, yes, but I am working on a critical bug atm
[10:54] <gmb> henninge, Okay. There's no rush; bac's reviewing this afternoon isn't he?
[10:54] <henninge> gmb: should be, yes
[10:54] <gmb> henninge, Okay. I'll put it on the queue but I'm not worried if you or bac don't get to it for a while.
=== gmb changed the topic of #launchpad-reviews to:  On call: henninge || reviewing: - || queue: [noodles775, adiroiban(bug-564852), jpds, gmb(http://is.gd/bAr7Y)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== mrevell changed the topic of #launchpad-reviews to:  On call: henninge || reviewing: - || queue: [noodles775, adiroiban(bug-564852), jpds, gmb(http://is.gd/bAr7Y)] mrevell (http://is.gd/bAtGL) || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== mrevell is now known as mrevellunch
[13:27] <adiroiban> danilos: when you have some time, can you take a look at the initial commit and have a pre-implementation chat for bug 146178?
[13:27] <mup> Bug #146178: Add links to latest full and delta language pack exported <ui> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/146178>
=== salgado-afk is now known as salgado
=== sinzui changed the topic of #launchpad-reviews to:  On call: henninge || reviewing: - || queue: [noodles775, adiroiban(bug-564852), jpds, gmb(http://is.gd/bAr7Y), mrevell (http://is.gd/bAtGL), sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to:  On call: henninge, bac || reviewing: - || queue: [noodles775, adiroiban(bug-564852), jpds, gmb(http://is.gd/bAr7Y), mrevell (http://is.gd/bAtGL), sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[13:39]  * bac looks at the queue.  girds himself for a long day of reviewing.
[13:43]  * noodles775 feels for bac :/
[13:43] <bac> don't mind me...just whining a bit
=== bac changed the topic of #launchpad-reviews to:  On call: henninge, bac || reviewing: -,noodles || queue: [adiroiban(bug-564852), jpds, gmb(http://is.gd/bAr7Y), mrevell (http://is.gd/bAtGL), sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== mrevellunch is now known as mrevell
[14:32] <bac> noodles775: r=bac.  thanks.
=== bac changed the topic of #launchpad-reviews to:  On call: henninge, bac || reviewing: -,adiroiban(bug-564852) || queue: [jpds, gmb(http://is.gd/bAr7Y), mrevell (http://is.gd/bAtGL), sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:34] <noodles775> bac: Great, thanks.
[14:49] <danilos> adiroiban, I'm looking at it
[14:50] <adiroiban> danilos: I have created a preliminary MP for the branch ... if that helps
[14:59] <danilos> adiroiban, I've commented on the bug there, probably should have done it on MP as well :)
[15:00] <bac> danilos: are you doing the review?
[15:00] <adiroiban> danilos: ok. I will copy the commen. I have also commited a working implementation of IPerLanguagesWithStatistics https://code.edge.launchpad.net/~adiroiban/launchpad/512735/+merge/23759
[15:00] <danilos> bac, no, the preimp chat :)
[15:01] <danilos> adiroiban, that's the worst naming ever though :) I'll be happy to review that one
[15:01] <adiroiban> :)
[15:03] <jtv1> henninge, bac: can I put a small one on the queue?  https://code.launchpad.net/~jtv/launchpad/bug-567035/+merge/23742
[15:03] <adiroiban> danilos: for the language-packs links text, should we use UTC or user timezone?
=== henninge changed the topic of #launchpad-reviews to:  On call: bac || reviewing: adiroiban(bug-564852) || queue: [jpds, gmb(http://is.gd/bAr7Y), mrevell (http://is.gd/bAtGL), sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:03] <henninge> bac, jtv1: I am sorry, but I won't be able to take any reviews today.
[15:04] <jtv1> henninge: still on that critical bug?
[15:04] <henninge> yup
[15:04] <jtv1> and that looks like a pretty full queue.
[15:04] <jtv1> So maybe I should wait until tomorrow, when I'm OCR.  :)
[15:04] <bac> henninge: ok
=== jtv1 is now known as jtv
[15:04] <jtv> bac, need any help with that queue?
[15:05] <bac> jtv: i'm not going to say no
[15:05] <bac> jtv: but i have a long day ahead of me so it'll be ok
[15:06] <bac> adiroiban: so is your branch for bug 564852 read for review or are you still making changes?
[15:07] <jtv> bac: I'll see if I can steal a short one then.  :)
[15:07] <adiroiban> bac: is ready
[15:07] <bac> adiroiban: ok
[15:08] <adiroiban> bac: if a MP is not ready i'm setting its status to 'work in progress'
[15:08] <jtv> bac: I'm looking at the first one on the queue.
[15:08] <bac> adiroiban: right.  i was just concerned that it was ready for review but you and danilos seemed to be having an active discussion about the branch
[15:09] <bac> jtv: jdps?  if so, please remove it from the topic
[15:09] <adiroiban> bac: ah...my discussion with Danilo is about another branch
[15:09] <bac> adiroiban: ok.  thanks.
=== jtv changed the topic of #launchpad-reviews to: On call: bac || reviewing: adiroiban(bug-564852) || queue: [gmb(http://is.gd/bAr7Y), mrevell (http://is.gd/bAtGL), sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:11] <bac> adiroiban: +1 for using lp-send to create your MP.  much appreciated.
[15:12] <adiroiban> bac: I'm not using lp-send ... just the LP web ui. What are the advantages or using lp-send?
[15:12] <bac> adiroiban: it provides the skeleton you used in https://code.edge.launchpad.net/~adiroiban/launchpad/bug-564852/+merge/23612 and automatically includes the lint
[15:13] <bac> adiroiban: much easier than doing it by hand and ensures you don't just forget a section
[15:15] <adiroiban> bac: I see. Well I have a script that generates that output and copy it into the clipboard, but I will try to install lp-send and try to use it
[15:28] <bigjools> bac: hi, do you know Twisted?
[15:28] <bac> bigjools: i do not.
[15:29] <bigjools> bac: you're not going to like my branch then
[15:29] <bigjools> you can learn a bit if you want? :)
[15:29] <bac> bigjools: cool.  put it on the end of the queue...maybe i'll get to it, maybe i won't.  :)
[15:29] <bigjools> hah :)
[15:29] <bac> bigjools: i'd like to look at it.  if i have to punt i'm not shy
=== bigjools changed the topic of #launchpad-reviews to: On call: bac || reviewing: adiroiban(bug-564852) || queue: [gmb(http://is.gd/bAr7Y), mrevell (http://is.gd/bAtGL), sinzui, sinzui, bigjools] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:30] <bigjools> bac: it's a complicated change in the buildd-manager
[15:30] <bigjools> bac: but I'm happy to explain over a call if you want
[15:31] <bac> bigjools: either way.  if you'd rather get a fellow soyuzian to look at it now i won't be offended
[15:31] <bigjools> bac: it's not partiocularly Soyuzy apart from the build farm aspect, which is not that soyuzy any more :)
[15:31] <bigjools> bac: I'm happy to wait
[15:31] <bigjools> thanks
[15:32] <bac> np
[15:34] <jpds> jtv: it was salgado who suggested the sendHeader() trick..
[15:34] <jtv> jpds: the trick itself is fine, just don't rely on a specific offset in the array!
[15:35] <jtv> jpds: you could also use an "in" check, but that's fragile because of the whitespace.
[15:35] <jtv> And since this is key/value pairs anyway...
[15:47] <bac> adiroiban: in language-views.txt there is the claim that Language.translators is monkey patched but I cannot find where that happens
[15:48] <adiroiban> there should be someting like "del Language.tranlators"
[15:48] <adiroiban> line 92
[15:54] <bac> adiroiban: ok, so that deletes the method.  i expected to see it replaced.
[15:59] <bac`> adiroiban: nm, i see it now
[15:59] <adiroiban> bac`: it is replaced at line 153
[15:59] <adiroiban> it is a property and I was not able to patch the object
=== bac` is now known as BradCrittenden
[16:00] <adiroiban> as the property did not defined any "deleter"
=== BradCrittenden is now known as bac
[16:00] <bac> adiroiban: thanks
=== bac changed the topic of #launchpad-reviews to: On call: bac || reviewing: gmb(http://is.gd/bAr7Y) || queue: [mrevell (http://is.gd/bAtGL), sinzui, sinzui, bigjools] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[16:19] <bac> hi mrevell
[16:19] <mrevell> hi bac
[16:20] <bac> mrevell: i'm looking at your MP and notice two things before starting the review.  one you are linked to a bug that is fix released, which is odd.  and second you're targeted to db-devel, not devel.  is that intended?
[16:22] <mrevell> bac, The bug -- I'll update, I forgot it was still in that state. I thought the fix had been released but when I looked at the tour it appeared that it hadn't.
[16:22] <mrevell> bac, As for db-devel, that is not intentional. Thank you for pointing that out.
[16:22] <bac> mrevell: i was burned by that last week...
[16:23] <bac> yet another reason i'm continually pimping 'bzr lp-send'
[16:24] <mrevell> bac, I haven't used lp-send yet, so I'll give that whirl.
[16:31] <bac> gmb: did you intend to target your MP to db-devel?
[16:32] <gmb> bac, Yes.
[16:32] <bac> ok
[16:32] <gmb> bac, Or... Maybe not, actually
[16:32] <gmb> Lemme check.
[16:32] <bac> gmb: i don't see why...
[16:34] <gmb> bac, Ah, yes. It's because there's a DBItem, BugWatchActivityStatuses, which has one more item on db-devel than on devel.
[16:34] <bac> oh, ok
=== bac changed the topic of #launchpad-reviews to: On call: bac || reviewing:mrevell (http://is.gd/bAtGL) || queue: [sinzui, sinzui, bigjools] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[16:40] <bac> mrevell: did you intentionally omit mercurial from the list?
[16:40] <mrevell> bac, Yes, jelmer isn't happy for it to be mentioned publicly yet.
[16:41] <bac> ok
[16:41] <bac> shhh
[16:41] <mrevell> :)
[16:41] <mrevell> Well, let's say he doesn't want a song and dance yet.
[16:47] <bac> mrevell: is the tour to be written in en_US?
[16:48] <mrevell> bac, AFAIK the tour is written in en_GB.
[16:49] <bac> mrevell: alrighty.  i thought we'd decided the other for most things.  i don't care, just as long as it is consistent
[16:50] <mrevell> bac, The company styleguide requires en_GB these days, so over time I'll make sure everything I'm responsible for follows that. But I'm quite certain the tour was always en_GB.
[16:51] <bac> mrevell: oh, i didn't know about the styleguide specifying that.  goode to knouw.
[16:55] <mrevell> Yea verily
=== salgado is now known as salgado-lunch
[17:02] <sidnei> bac, if im allowed to jump the queue, there's a trivial one-liner here: https://code.edge.launchpad.net/~sidnei/lazr-js/use-browser-console/+merge/23778
[17:03] <bac> sidnei: done
[17:03] <sidnei> bac, thanks!
[17:05] <bac> mrevell: your review is done.  remember if you use 'ec2 land' it's going to go directly to db-devel, which you don't want
[17:05] <mrevell> Thanks bac. I'll address the issues you've raised and then use pqm-submit, following a successful ec2 test.
=== bac changed the topic of #launchpad-reviews to: On call: bac || reviewing lunch|| queue: [sinzui, sinzui, bigjools] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-lunch
=== salgado-lunch is now known as salgado
=== gary_poster is now known as gary-lunch
=== bac changed the topic of #launchpad-reviews to: On call: bac || reviewing sinzui|| queue: [sinzui, bigjools] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[18:38] <bac> hi sinzui
[18:38] <sinzui> hi bac
[18:38] <bac> sinzui:  i'm curious why you chose 1 year for the period to not suggest packaging again.  i would've thought six months, matching the ubuntu release period, would make more sense.
[18:38]  * sinzui is on a call
[18:39] <bac> o
[18:39] <bac> k
[18:39] <bac> no rush
[18:43] <intellectronica> bac: can i add a branch to the queue?
[18:43] <bac> sure intellectronica
[18:43] <intellectronica> bac: great, thanks!
=== intellectronica changed the topic of #launchpad-reviews to: On call: bac || reviewing sinzui|| queue: [sinzui, bigjools, intellectronica] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: On call: bac || reviewing sinzui|| queue: [bigjools, intellectronica] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[19:02] <jml> could I please have a review for https://code.edge.launchpad.net/~jml/launchpad/better-subunit-attachment/+merge/23786
[19:03] <jml> bigjools, are you in the queue for https://code.edge.launchpad.net/~julian-edwards/launchpad/builder-reset-fail-bug-563353 ?
[19:03] <bigjools> jml: yes but I don't mind if you insert
[19:03] <jml> bigjools, actually, I was just going to review your branch if it's the one we were talking about earlier
[19:04] <jml> (and if LP ever loads the damn thing)
[19:04] <bigjools> jml: oh right!
[19:04] <bigjools> well, thanks :)
=== gary-lunch is now known as gary_poster
[19:17] <sinzui> bac: It takes more than 6 months for Ubuntu to diverge. Lucid +1 has the same packages as Lucid.
[19:18] <sinzui> bac: a year is a better time to ask again. I also think that the next time we ask, we should explain how the project can get packages in Ubuntu
[19:18] <bac> does lucid + 2 == lucid + 1 == lucid ?
[19:19] <sinzui> s+2 switches out main packages. s+3 adds new packages from the universe. beta (4-6) just add dependencies
[19:35] <jml> bigjools, done
[19:35] <bigjools> jml: cheers
=== jml changed the topic of #launchpad-reviews to: On call: bac || reviewing sinzui|| queue: [intellectronica, jml] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[19:36] <jml> and with that, I'm off.
[19:39] <bigjools> will work on it in the morning, thanks
=== fjlacoste is now known as flacoste
=== matsubara-lunch is now known as matsubara
=== bac changed the topic of #launchpad-reviews to: On call: bac || reviewing intellectronica || queue: [jml] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[20:31] <bac> intellectronica:  r=bac
[20:31] <intellectronica> bac: thanks!
[20:32] <bac> intellectronica:  i do hope your new algorithm is doing what you intend.
=== bac changed the topic of #launchpad-reviews to: On call: bac || reviewing jml || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[20:33] <intellectronica> bac: yes, i hope too that this last batch of improvements will make heat more useful to more projects
[20:34] <bac> intellectronica:  previously you saw very little/almost no depreciation of the heat values?
[20:34] <bac> that's why it was not useful?
[20:35] <intellectronica> bac: more importantly, currently heat is not sensitive enough to activity. these new changes will make it respond to activity and inactivity in a much greater granularity, so new changes to a bug, or the lack of them, will reflect quickly in the bug's heat value
[20:36] <intellectronica> bac: our hope is that this will make heat more useful that now have a list of untouched but hot bugs at the top of the list
[20:37] <bac> intellectronica:  it'll be a nice feature when the kinks are worked out.  this should get you much closer.
[20:37] <intellectronica> bac: that's mostly a case of reality vs. ideology. intuitively, projects should work on their hot bugs and get them closed, but some don't.
[20:37] <intellectronica> indeed
=== bac changed the topic of #launchpad-reviews to: On call: bac || reviewing salgado|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[21:36] <EdwinGrubbs> bac: can you review this branch for me? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-553384-deactivated-project-oops/+merge/23794
[21:41] <bac> EdwinGrubbs:  sure
=== bac changed the topic of #launchpad-reviews to: On call: bac || reviewing edwin|| queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[21:49] <sinzui> yeah
[22:19] <thumper> morning
[22:20] <thumper> EdwinGrubbs: are you going to UDS
[22:21] <EdwinGrubbs> thumper: bac was going for the Registry
[22:21] <thumper> EdwinGrubbs: was, or is?
[22:21] <EdwinGrubbs> thumper: is
[22:21] <sinzui> is
[22:22] <sinzui> bac: is pretty centered. He lives in the here and now. He is
[22:22] <sinzui> Though his nic implies he lives in the past, back never was, he just is
[22:22] <thumper> heh
[22:22] <sinzui> ah evo, how I hate you
=== salgado is now known as salgado-afk
[22:43] <bac> yes i is
[22:55] <abentley> mwhudson, when you need a break, could you review this? https://code.edge.launchpad.net/~abentley/launchpad/no-builds-recipe/+merge/23744
[22:57] <mwhudson> abentley: sure
=== matsubara is now known as matsubara-afk
[23:14] <bac> EdwinGrubbs:  i almost finished your branch but not quite.  i'll try to finish after dinner.
[23:15] <EdwinGrubbs> ok, thanks