[09:08] Hi === salgado-afk is now known as salgado === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell [15:01] #startmeeting [15:01] Meeting started at 09:01. The chair is bac. [15:01] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:01] hi everyone and welcome to the reviewers meeting [15:01] who is here today? [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:02] yay, registry is all here [15:02] foundations is a close second with bugs showing. [15:02] danilos: ping [15:02] me [15:02] bigjools: ping [15:02] me [15:02] me [15:03] me [15:03] jelmer: ping [15:03] hi BjornT! [15:03] me [15:03] me [15:03] me [15:03] me [15:04] bugs in da house [15:05] foundations is here too (leonardr didn't "me" but is around and is kinda busy right now anyway) [15:05] me [15:05] thanks gary_poster [15:05] [topic] agenda [15:05] New Topic: agenda [15:05] mr [15:05] me even [15:05] * Roll call [15:05] * Agenda [15:05] * Outstanding actions [15:05] * Mentoring update [15:05] * New topics [15:05] * Reduction of negation preferred over "common case first" in if statements? [henninge, jtv] [15:05] * Peanut gallery [15:06] me [15:06] google calendar blows for timezone management [15:06] bigjools and everyone else: did you know you can have it show two time zones? it makes things much easier [15:06] bigjools, timezone management? where's that in google calendar? [15:06] i show my home zone and UTC and am sure to schedule everything using UTC [15:06] danilos: so that's how they enable and disable DST? [15:06] bac, that must be new [15:07] danilos: within a month or so, i think [15:07] deryck has tried it and found it to work too [15:07] [topic] * Outstanding actions [15:07] New Topic: * Outstanding actions [15:07] [topic] * Outstanding actions [15:07] New Topic: * Outstanding actions [15:07] doh [15:07] yup, two tz with UTC default rocks in gcal. [15:08] [topic] bac to define new doctest policy regarding what is "testable documentation". [15:08] New Topic: bac to define new doctest policy regarding what is "testable documentation". [15:08] i made no progress on this. sorry. roll it to next week. [15:08] [topic] bac to get input on proposed community reviewer and committer policy and announce it on the list. [15:08] New Topic: bac to get input on proposed community reviewer and committer policy and announce it on the list. [15:08] it's DST that blows [15:09] i *did* do this and got some good feedback. i was waiting to see if more came in but since it didn't i'll formalize my proposal and send to the public list [15:09] [topic] henninge to update the style guide regarding multi-line parameters in function defns and calls. [15:09] New Topic: henninge to update the style guide regarding multi-line parameters in function defns and calls. [15:09] bac: roll it, please [15:09] henninge: okey doke [15:10] 0.5 / 3.0...not so good [15:10] a new topic today that was leftover from last week: [15:10] wiki was not working right after the last meeting [15:10] [topic] Reduction of negation preferred over "common case first" in if statements? [henninge, jtv] [15:10] New Topic: Reduction of negation preferred over "common case first" in if statements? [henninge, jtv] [15:10] Yes, another little thing [15:10] henninge, jtv: take it away [15:10] ok [15:10] I just come up with these because they come up in reviews [15:11] As long as I can remember, we've had a rule not to do "if not foo: ... else: ..." [15:11] and I just like to know we agree and then put it down in writing. [15:11] sorry, jtv [15:11] no worries, go ahead [15:11] http://paste.ubuntu.com/419873/ [15:11] LINK received: http://paste.ubuntu.com/419873/ [15:11] jtv: I don't remember that [15:11] So, my question is: do we prefer a style? Should we enforce one? [15:12] henninge: no, we shouldn't have a policy on this [15:12] bigjools: afaik this is 2007 or older, and not currently documented [15:12] intellectronica: +1 [15:12] * henninge thinks "not documented -> not reviewable" .... [15:12] That would be my suggestion. [15:13] there's useful policies and then there's policies for the sake of policy [15:13] guess where I think this one falls? :) [15:13] cool, if no-one objects, I am done. [15:13] I'm fine either way, as long as we know where we stand. [15:13] jtv, barry would say style 1 can cause confusion and should be avoided [15:13] i think if both cases can be considered equally likely then testing for the affirmative makes more sense [15:14] bigjools: +1, but you should have written it "there's policies for the sake of policy and then there's useful policies". [15:14] lmao [15:14] common case first? [15:14] * bigjools runs [15:14] :-) [15:15] jtv: my understanding is that we stand nowhere with this - and nobody cares. [15:15] ;-) [15:15] henninge: seems so. [15:15] henninge, good synopsis :) [15:15] I'd vote for "common case not last"... [15:15] lacking a policy i'd suggest it is situational and up to the reviewer's discretion about readability [15:16] My personal rule for coding guidelines is "are we willing to make the cleanup effort?" If not, it's probably not worth adding a rule for either. [15:16] But this one was there before I was a reviewer. :) [15:17] bac: I'll put a note in the style guide to think about what you are doing and to have readability in mind. [15:17] although, that is a pretty general advice ... [15:17] ;) [15:17] henninge: yes, very general [15:18] so i think we agree this is really a non-issue and everyone will DTRT [15:18] cool [15:18] bac: move on! ;) [15:18] shall we move on? [15:18] In fact we had a discussion about this once and the conclusion there was: review is not to find mistakes, it's to promote legibility and such. [15:18] [topic] peanut gallery [15:18] New Topic: peanut gallery [15:18] jtv! [15:18] any other burning issues today? [15:18] bigjools? [15:19] jtv: I would say the exact reverse [15:19] bigjools: where were you when I said the exact reverse and found everyone against me? ;-) [15:19] but anyway, don't wanna start an argument right no [15:19] w [15:19] nothing, then? [15:19] bac: guess not [15:19] ok, let's end early and get to real work. [15:19] thanks for coming guys [15:20] #endmeeting [15:20] Meeting finished at 09:20. [15:20] thanks bac [15:20] thanks bac [15:24] bac: thanks for the heads up === jelmer is now known as ctrlsoft === salgado is now known as salgado-lunch === gary_poster is now known as gary-lunch === leonardr is now known as leonardr-lunch === salgado-lunch is now known as salgado === gary-lunch is now known as gary_poster === leonardr-lunch is now known as leonardr === salgado is now known as salgado-afk