[04:03] <mwhudson> rockstar: https://code.edge.launchpad.net/~mwhudson/launchpad/fix-ec2-harder-dammit/+merge/23897
[05:43] <thumper> rockstar: https://code.edge.launchpad.net/~thumper/launchpad/yet-more-api-exports/+merge/23905
[09:25] <noodles775> Hi ctrlsoft :)
[09:25] <jelmer> moin noodles :-)
[09:29] <noodles775> intellectronica: Hi! are you after more UI reviews? If not, I'll do it now, just let me know what you prefer (for https://code.edge.launchpad.net/~adiroiban/launchpad/bug-146178/+merge/23760)
[09:29] <noodles775> wgrant: hi! do you want me to land this one as is? https://code.edge.launchpad.net/~wgrant/launchpad/emailauthentication.txt-2.6-fix/+merge/23449
[09:36] <wgrant> noodles775: Yeah, I'm a bit busy until Wednesday, so it'd probably be a good idea.
[09:36] <wgrant> I'll track down the real bug then.
[09:37] <noodles775> wgrant: ok, will do.
[09:37] <wgrant> Thanks.
[10:04] <henninge> noodles775, jelmer: I have a CP-candidate that could use some high-priority treatment. Can either of you take that?
[10:07] <jelmer> henninge: I'll have a look
[10:07] <jelmer> henninge: where's the MP?
[10:07] <henninge> https://code.edge.launchpad.net/~henninge/launchpad/bug-565294-nplurals/+merge/23861
[10:07] <henninge> jelmer: thanks
[10:07] <henninge> jelmer: it looks large but a lot of is was me removing lint.
[10:08] <henninge> I probably should not have done that in this branch ...
[10:09] <jelmer> henninge: it looks like the lint changes are mostly removing assignments?
[10:09] <henninge> jelmer: yes, unused variables
[10:31] <jelmer> henninge: is it correct that test_header_pluralform_western uses 'ja'?
[10:31] <jelmer> (which is Japanese I guess?)
[10:32] <henninge> jelmer: yes, it is about the case were the western standard formula is found in the file for a language were that should not be.
[10:32] <henninge> and a language that has less plural forms than 2 - which is 1 ...
[10:33] <jelmer> noodles775: thanks
[10:33] <noodles775> np, just updating what I'm reviewing currently :)
[10:34] <henninge> jelmer: the actual logic behind that is based on Danilo and me looking at the current data in the database.
[10:34] <henninge> jelmer: and we found some po files for asian languges that report western plural expressions.
[10:35] <henninge> in many templates for POFile headers, the western style is used as the default and often translators just don't change that before importing the file to Launchpad.
[10:35] <jelmer> henninge: ah, ok - thanks
[12:20] <StevenK> adeuring: Hi! Do you have a moment to look at https://code.edge.launchpad.net/~stevenk/launchpad/fixes-bug-451396/+merge/21706 again?
[12:20] <adeuring> StevenK: sure
[12:20] <StevenK> adeuring: Ignore the 'import urllib', please, I'm just pushing the branch that gets rid of that
[12:20] <adeuring> StevenK: ok ;)
[12:38] <intellectronica> noodles775, jelmer: can one of you review a small branch for me?
[12:39] <noodles775> Suer!
[12:39] <jelmer> intellectronica: Sure, if you give me 15m :-)
[12:39] <intellectronica> jelmer: great, thanks. just creating an MP.
[12:54] <intellectronica> jelmer: https://code.edge.launchpad.net/~intellectronica/launchpad/bug-heat-days-active/+merge/23920
[12:54] <jelmer> intellectronica: k
[12:54] <intellectronica> thankyou
[12:57] <noodles775> intellectronica: not sure if you saw my message before, but let me know if you are after UI reviews, otherwise I'll just do Adi's UI review now.
[12:57] <intellectronica> noodles775: i must have missed your message. i'm happy to do a ui review. which mp?
[12:59] <noodles775> intellectronica: I just wasn't sure if you were trying to collect UI reviews atm. (as a mentat), otherwise I'm happy to do it... it's this one: https://code.edge.launchpad.net/~adiroiban/launchpad/bug-146178/+merge/23760
[13:03] <intellectronica> noodles775: do you know if adi will be back today for an interactive review, or shall i just reply in the mp?
[13:04] <noodles775> intellectronica: I haven't heard back from him today after doing two code reviews, I'd do it via the mp for now.
[13:05] <intellectronica> oright
[13:05] <noodles775> jelmer: have you started intellectronica's? If not, can I swap you and you can review mine? :)
[13:06] <jelmer> noodles775: I haven't started on his yet
[13:06] <jelmer> noodles775: So swapping would be fine :-)
[13:06] <noodles775> Great, although I guess I'll need to ask someone else to do the second review on mine :)
[13:08] <StevenK> adeuring: No news is good news? :-P
[13:09] <adeuring> StevenK: nah, things look fine :)
[13:09] <intellectronica> jelmer, noodles775: whoever is reviewing, please wait a sec, i just realised the diff is too much, because it contains some changes from a previous branch i thought had already been merged.
[13:10] <noodles775> intellectronica: ok, np.
[13:10] <adeuring> StevenK: I have just one remaining nitpick: could you remove the trailing space in the line "Leaving the PGP signature on a package uploaded " ?
[13:10] <adeuring> we try to avoid them so that we don't get sprurious diff lines when somebody adds/removes trailing spaces.
[13:10] <intellectronica> can i add a prequisite branch to the mp after the fact, or do i have to recreate it?
[13:11] <StevenK> adeuring: Okay, done.
[13:11] <noodles775> intellectronica: I can't see any way to do so without recreating either.
[13:11] <bigjools> nice branch for you guys :)
[13:12] <adeuring> StevenK: cool. r=me. I assume I should run your branch  through ec2, or can you do that?
[13:12] <jelmer> noodles775: so I guess I should get somebody else to review my review of your code?
[13:12] <StevenK> adeuring: I can do that. Can you fiddle the MP?
[13:13] <noodles775> jelmer: yeah, shouldn't be a problem though. But maybe grab bigjools' for the moment, as at least we can do that one together?
[13:13] <adeuring> StevenK: done
[13:14] <intellectronica> noodles775: oright, the new mp is https://code.edge.launchpad.net/~intellectronica/launchpad/bug-heat-days-active/+merge/23921 .   sorry for the inconvenience.
[13:14] <noodles775> np.
[13:15] <StevenK> adeuring: Thanks! I'm throwing it through EC2 now.
[13:17] <noodles775> intellectronica: I can't see that days_since_last_activity is being used for anything?
[13:18] <noodles775> Did you mean to do (max_heat * 0.25 / (days_since_created - days_since_last_activity)) or something similar, looking at the comment?
[13:19] <noodles775> Ah, or looking at the related bug title, I'm guessing it should be s/dasy_since_created/days_since_last_activity on line 21 on the MP diff?
[13:20] <henninge> jelmer: thanks for the review, I agree with you nitpicks ;)
[13:20] <jelmer> henninge: sorry it took so long, I haven't really looked at the translations code before :-)
[13:21] <henninge> jelmer: that's ok. Ask about whatever is unclear.
[13:21] <henninge> actually, I will go to lunch now ...
[13:21] <henninge> ;)
[13:21] <intellectronica> noodles775: no, i think that's a cut-n-paste error.
[13:21] <henninge> jelmer: will you pass it on to noodles775 for mentoring?
[13:21] <jelmer> henninge: Yeah, I've just requested a review from him as well.
[13:22] <henninge> jelmer: cool, thanks
[13:22] <danilos> henninge, jelmer: it's very important to get this CPed before 2200 UTC today
[13:22]  * noodles775 switches to it.
[13:23] <danilos> noodles775, thanks
[13:27] <noodles775> intellectronica: so should it be divided by the number of days *since* the bugs last activity (as stated in the bug title), or divided by the difference between the days since the bug was created and it's last activity (as the comment seems to suggest?)
[13:28] <intellectronica> noodles775: it should be divided by the days since the bug's creation
[13:28] <noodles775> intellectronica: so the bug 567439 title is wrong then, ok.
[13:28] <mup> Bug #567439: Add MAX_HEAT / 4 / days since last activity to bug heat <story-bug-heat> <Launchpad Bugs:In Progress by intellectronica> <https://launchpad.net/bugs/567439>
[13:29] <intellectronica> noodles775: oh, right, it is. there's another bug for a calculation based on time since last activity, i must have confused them.
[14:00] <noodles775> henninge: why not s/language_forms/number_plural_forms on line 57 and do away with the extra variable? (line 73 sets number_plural_forms to the same value?)
[14:01] <noodles775> Ah, right, as the language.plural forms can be overwritten with None... nm.