| kees | ScottK: I'm happy with the vlc 1.0.6 upload from a source and patching delta perspective. vlc tends to be pretty conservative normally. | 00:02 |
|---|---|---|
| ScottK | kees: Thanks. | 00:02 |
| kees | ScottK: so if jdong says it's good, I say ship it. | 00:02 |
| ScottK | OK. I tend to agree. | 00:03 |
| slangasek | langpacks are out of the queue now | 02:20 |
| * ScottK is back. | 02:41 | |
| stgraber | can someone push edubuntu-artwork through the queue so it's ready for our next rebuild (once the langpacks have finished updating I'm guessing) ? | 02:50 |
| ScottK | stgraber: lang packs are done. Let me have a look | 02:56 |
| ScottK | stgraber: Accepted. | 02:59 |
| ScottK | slangasek: The LP U/I refuses to accept vlc, so I'll leave that to you. | 03:00 |
| stgraber | ScottK: thanks | 03:08 |
| ScottK | gdmap is distinctly odd. It looks like it got autoreconfed or something and a bunch of stuff went missing. | 03:13 |
| ScottK | If someone sees seb128 they might ask him to have another look at it. | 03:13 |
| hyperair | ScottK: the code in banshee-extension-appindicator was originally duplicated from banshee's notificationarea extension. the code has received well enough testing. there will not be a regression. | 04:20 |
| ScottK | hyperair: I realize there won't be a regression for notify-osd users. | 04:21 |
| hyperair | ScottK: not for notification-daemon either. | 04:21 |
| hyperair | ScottK: or any other notification daemon that suppots the notifications standard properly | 04:21 |
| hyperair | like i said, it has been well tested | 04:21 |
| hyperair | by Ubuntu users, and by non-Ubuntu users. | 04:21 |
| hyperair | the fragment of the code that was removed by the patch was removed many banshee releases back. qense just added it because he thought it might be useful | 04:22 |
| hyperair | it was never supposed to have been there in the first place. | 04:22 |
| ScottK | Except currently the notification updates at start of stream, on update, and end of stream. If I read the patch right, the start and end update are removed. | 04:22 |
| ScottK | OK, well that's a totally different rationale than is in the bug. | 04:22 |
| ScottK | The bug describes working around a notify-osd limitation. | 04:23 |
| hyperair | sorry, i guess the bug was not worded properly | 04:24 |
| hyperair | the end-of-stream notification would time out anyway | 04:24 |
| ScottK | True, so I guess it's really just the start of stream notification that is affected. | 04:25 |
| hyperair | yes | 04:25 |
| ScottK | So with the patch there is no notification until some update happens instead of there being one at the start of the stream, right? | 04:27 |
| ScottK | That doesn't make any sense to me. | 04:27 |
| hyperair | ScottK: what? | 04:29 |
| ScottK | I may be reading that patch wrong, but that's what it looked like. | 04:30 |
| hyperair | there's a if (current_nf == null) somewhere | 04:30 |
| hyperair | it starts off as null | 04:30 |
| hyperair | when the first notification is fired, a Notification object will be created | 04:31 |
| hyperair | and displayed | 04:31 |
| ScottK | In case PlayerEvent.StartOfStream: it removes current_track = ServiceManager.PlayerEngine.CurrentTrack; and then ShowTrackNotification (); | 04:31 |
| hyperair | i think there is code repetition | 04:31 |
| hyperair | the code was already in ShowTrackNotification() | 04:32 |
| ScottK | So that's just redundant? | 04:32 |
| ScottK | That bit was the core of my concern. | 04:32 |
| hyperair | ScottK: ah it's a switch statement, so it just coincides with the next one. | 04:33 |
| hyperair | StartOfStream and TrackInfoUpdated | 04:33 |
| ScottK | OK. | 04:33 |
| ScottK | Good enough then. | 04:33 |
| hyperair | yep | 04:33 |
| ScottK | Accepted. | 04:34 |
| ScottK | Sorry for the confusion. | 04:34 |
| hyperair | np | 04:34 |
| hyperair | and thanks =) | 04:34 |
| ScottK | OK. That's the end of the current batch I'm comfortable accepting. | 04:40 |
| === ubott2 is now known as ubottu | ||
| ScottK | flite is main and fixes FTBFS, so I'd appreciate it if someone would review. Diff is trivial. | 14:13 |
| iulian | ScottK: Am I qualified to review it? | 15:18 |
| ScottK | iulian: I certainly hope so. | 15:19 |
| ScottK | (it's adding a missing build-depends) | 15:19 |
| iulian | ... on ed. | 15:20 |
| iulian | It looks good to me. | 15:20 |
| ScottK | iulian: OK. So you'd like for me to accept it on your behalf? | 15:25 |
| iulian | ScottK: Yes, please go ahead. | 15:26 |
| ScottK | iulian: Done. Thanks. | 15:27 |
| iulian | ScottK: If there is anything else I can do, please let me know. | 15:30 |
| ScottK | iulian: OK. | 15:30 |
| ScottK | iulian: If there's anything in the queue you're comfortable signing off on, let me know and we can discuss it. For Main the RM wants to limit fixes to ones that fix FTBFS or don't make good SRU candidates because you really want them on the installation media, low risk/obvoius fixes. | 15:32 |
| ScottK | For Universe we're more open about any bug fixes. | 15:32 |
| iulian | ScottK: Alrighty. | 15:36 |
| ScottK | iulian: ^^^ could you perhaps review these? | 15:41 |
| iulian | ScottK: Sure. | 16:03 |
| ScottK | iulian: Great. I can let them in for you once you've reviewed. | 16:04 |
| iulian | ScottK: gpsk31, gmerlin, gabedit, gcin and emerald look good. | 16:15 |
| ScottK | OK | 16:16 |
| * iulian is reviewing gamgi now. | 16:16 | |
| iulian | It looks like geser is pretty busy. :) | 16:17 |
| ScottK | Yep | 16:18 |
| ScottK | iulian: I'd appreciate a review for qd when it appears. Since it's my upload, I can't be the reviewer. | 16:20 |
| iulian | ScottK: OK. | 16:22 |
| ScottK | Thanks. | 16:23 |
| iulian | ScottK: gamgi, gentoo and gnote look good too. | 16:23 |
| ScottK | iulian: Accepted. | 16:24 |
| ScottK | iulian: There are two gdmap uploads in queue. Tell me if you want geser's or seb128's. | 16:25 |
| iulian | ScottK: Hmm, gdmap appears twice in the queue with different diff.gz | 16:25 |
| iulian | Oh. :) | 16:25 |
| ScottK | I looked at seb128's yesterday and it had a bunch of configure stuff in the diff I suspect wasn't wanted. | 16:25 |
| ScottK | So have a look and let me know what you think. | 16:26 |
| iulian | OK. | 16:26 |
| iulian | ScottK: Indeed. seb128's patch looks ugly. | 16:34 |
| iulian | I'd go with geser's patch. | 16:34 |
| * iulian looks at qd. | 16:34 | |
| ScottK | OK. | 16:35 |
| ScottK | Done | 16:35 |
| iulian | ScottK: I have no idea why 'uscan --force-downloads' shows up in the diff. | 16:40 |
| iulian | Anyway, please accept it. | 16:40 |
| ScottK | iulian: Becuase I added a missing newline. | 16:40 |
| ScottK | OK | 16:40 |
| ScottK | Done | 16:41 |
| iulian | Ah, right. | 16:42 |
| ScottK | iulian: I'd appreciate a review on foundry when it hits. | 17:48 |
| ScottK | (just uploaded) | 17:48 |
| * iulian gets the source. | 17:52 | |
| iulian | ScottK: From where have you cherry picked the fix? | 17:55 |
| ScottK | iulian: The debian package in Testing/Unstable. | 17:55 |
| ScottK | They've got a new upstream version, so I didn't want to pull that in. | 17:55 |
| iulian | ScottK: OK, please accept it. | 17:58 |
| ScottK | iulian: Done. Thanks. | 17:59 |
| iulian | No problem. | 17:59 |
| ScottK | I'm heading out for a while. If stuff comes in and you review it, just say so here and I'll process it when I get back. | 18:00 |
| iulian | ScottK: OK. | 18:03 |
| iulian | ScottK: Go ahead and accept python-django-djblets. | 20:52 |
| * iulian has just reviewed it. | 20:52 | |
| ScottK | iulian: Thanks. | 21:10 |
| * iulian goes to bed. | 21:16 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!