/srv/irclogs.ubuntu.com/2010/04/24/#ubuntu-reviews.txt

nigelbabuour crazy review queue is up to 143 bugs00:55
nigelbabuand I was worried about running out of bugs for patch day00:55
persiaWe'll never run out: we might catch up, but we can trust other folks to always give us more.00:57
nhandlernigelbabu: I am interested in seeing what happens after the maverick repos open up. We will get a lot of uploads as well as a lot of submitted patches02:14
nigelbabunhandler: yes, it might be *very* interesting13:11
persiaI think the lucid release is likely more a factor than maverick open, in terms of patch submission.13:11
nigelbabuyes, but maverick being open gets us the change to integrate in a lot of pachtes13:13
nigelbabu*patches13:13
nigelbabubtw, I'm trying to get a review page similar to the sponsorship overview13:14
persiaHow do you mean "trying"?13:14
persiaDo you just need hosting?13:14
persiaOr are you still fiddling with code?13:15
nigelbabustarting to fiddle with code13:15
nigelbabumy people.ubuntu stuff sould be okay for hosting13:15
persiaOK.  Hosting is fairly easy, and I know several ways to do that :)13:16
persiapeople.ubuntu.com can't run code: only host static stuff.13:16
nigelbabuor I can convince brian to put it up13:16
nigelbabuI thought the python gave out an html page13:17
persiaIt does, but you want to run the python every couple minutes.13:17
persiaPersonally, I think the sponsorship report has less functionality than custom LP lists.13:18
nigelbabuoh yeah.  well, let me get there first :)13:18
nigelbabuwell, it does keep out multiple copies of smae bug13:18
persiaThe main reason I support it is that there are multiple groups of developers who need different sponsors lists, and I agree that those submitting sponsor requests shouldn't have to know who to subscribe.13:18
persiaI don't think we need that for reviewers.13:18
nigelbabuWhy I'm looking to an overview page is to avoid the complex queries and just point a page to show what needs to be reviewed.13:20
persiaHow does it differ from the queries?13:20
nigelbabuIts similar for newer folks13:20
persiaIt's trivial to hide static queries behind nice pretty links.13:20
nigelbabu/similar/simpler13:20
persiaHow?13:20
nigelbabuI wanted a way to keep track of patch-fowarded-upstream where the upstream bug is closed13:21
nigelbabuand a coupla other use cases13:21
persiaAh, so the report would actually categorize stuff, etc.13:21
nigelbabuyes13:22
persiaWhereas with LP all we can do is produce lists, but not an overview.13:22
nigelbabuhence the *starting* to fiddle with code13:22
persiaOK.  Please focus on making it a nice report/set of reports that tells us what is where, rather than on making it a landing page for reviewers to work from.13:22
* persia believes any non-realtime report is inherently broken as a worklist13:23
nigelbabuIn that case can you help me write down goals?13:23
nigelbabuIts more of a summary to look at13:23
* persia should learn to be less expressive in the hopes of one day establishing a manageable activity list13:24
nigelbabuhehe :)13:24
persiaInitial thoughts would be a summary overview of how many bugs are in which (descriptive) state based on analysis of tags (which is more than just raw tag count, which we can get easily from LP).13:28
persiaIt would probably be interesting to produce a copy of this daily so we could later compare:analyse.  Maybe have the script generate a date-marked (e.g. filename) machine-readable set of data, and have another script that makes that pretty.13:29
persiaI believe most of the worklists *should* be able to be hidden behind URLs: I'm happy to toss that on the front page of qa.ubuntuwire.com instead of the current patch links, and they could also be put on the report.13:30
persiaIf there exists a workqueue that can't be generated with an LP URL (like "bugs submitted upstream where the upstream task is closed"), then maybe generate worklists there (although I think this needs to update frequently).13:31
nigelbabuSo, something in the likes of a list of bugs with each status.13:32
persiaNote that in the case of patches-submitted-elsewhere-and-relevant-bugs-closed we need to differentiate between closures that imply patch acceptance and closures that imply patch rejection.  If we find that the algorithm manages to differentiate these successfully with no false positives, we can probably drop the workqueue lists, and instead have the script just mark for acceptance or rejection.13:33
persiaI don't think the lists of bugs with each status is useful *except* if we define a workqueue that can't be searched in LP.13:33
persiaOr rather, can't be defined with a URL.13:33
persia(so it requires API to develop it).13:34
persiaThat said, I think the right way to determine which workqueues to generate should be to try to figure out a set of bugs that has a known correct action (e.g. patch-submitted-upstream -> patch-accepted-upstream).13:34
nigelbabui.e. a point where we might have to work on it.13:34
persiaAnd then use the workqueues as tools to improve the algorithm with an eye towards automation.13:35
nigelbabu+113:35
persiaNote that this is *very* different than how the sponsors report works, although the sponsors report code may be a useful example to base some of the analysis upon.13:35
nigelbabuits just base code so that I dont have to do the initial ground work13:36
nigelbabuhttp://pad.ubuntu-uk.org/7a7QjBIyuq13:38
nigelbabuI'm working on a rough cut of what needs to be done13:38
persiaMakes sense.13:43
persiaI'd probably try to focus on patch states, rather than which tags happen to be present.13:43
persiaSo "How many bugs are currently waiting for upstream comment?" is an interesting metric.13:44
nigelbabuah, that way13:44
persiaAnd fot athat, I'd want to count patch-submitted-upstream AND NOT patch-accepted-upstream or patch-rejected-upstream.  The docs say that we're supposed to replace the tags, but I'm not confident everyone follows docs well.13:44
nigelbabuSo, we don't use the tags at all in the reports.13:45
persiaI don't think it's worthwhile to expose the actual tags.13:51
nigelbabuI agree13:51
persiaThat just leads to rough human estimates of interesting values by comparing the numbers.13:51
persiaIf we're doing computational analysis, we can provide more interesting interpretation13:51
nigelbabuNow, I remember why I hated hacking on LP API13:56
nigelbabuPoor documentation.13:57
persianigelbabu: On (a)(ii): the analysis should be done for each bug, rather than doing arithmetic on the counts (you may already know this, but it wasn't clear to me from etherpad)14:16
persianigelbabu: I think it's also interesting to look at the total number of bugs that would be in the review queue if there wasn't a date restriction (so apply the same filters (excepting the date filter) as the script)14:17
nigelbabupersia: I did know about (a)(ii)14:18
nigelbabuand total number is already ready :)14:18
nigelbabuI'm planning to take numbers using brian's script from the graphs14:18
persiaDo we have total numbers with the filters (sponsors, kernel, etc.)?14:19
nigelbabuah14:20
persiaMy rough estimate is that we'd get down to ~1500 with the filter, but that's a complete guess.14:21
nigelbabufor (a)(ii), you wanted patch-forwarded-upstream+patch-forwarded-debian+-patch-accepted-upstream+-patch-accepted-debian+-patch-rejected-upstream+-patch-rejected-debian14:22
nigelbabuwell, thats from modifying the link's query14:22
persiaWell, kinda.14:24
persiaI just suggested doing real analysis.14:25
nigelbabuOnly, I get no hits with that one :x14:25
persiaIf you do that check for each bug iteratively (rather than doing arithmetic later), you should get the number of bugs waiting for upsteam feedback.14:25
persiaOTher interesting numbers would be a count of how many patches have been accepted usptream.14:27
persiaOr a count of how many patches have been applied upstream that still have open Ubuntu bugs.14:28
persia(indicating how far we're behind on integration)14:28
persiaI'm sure there are others, but once you have a few, I suspect you'll get requests for more.14:28
nigelbabuThats the plan so far :)14:30
nigelbabufor the places we have work to do, I'll just make a table or link to a query14:30
persiaPlease don't.14:33
persiaInstead, for the candidates for automation, generate a table so we can review that the automation is safe to enable.14:34
persiaFor the worklists, try to construct URLs for realtime LP queries.14:34
* persia reads ago.14:34
persias/ago/again/14:34
nigelbabuIsn't that what I just said?14:34
persiaRight.  Please *DO* :)  Just differentiate in the way I describe :)14:35
nigelbabuyup,sure :)14:35
nigelbabuOnly this can only happen in stages.14:35
nigelbabuI'll first work on getting the numbers out14:35
persiaSounds like a plan :)  Let me know if you need hosting (either realtime, or cronjob).14:39
nigelbabuokay :)14:39
nigelbabuIs it normal that I end up doing support stuff for the team than actual patch review?14:40
persiaIn all the teams where I have accepted a leadership or administrative role, I've found that I have greatly reduced time to spend doing the actual work of the team.14:42
nigelbabuWell, so that explains that.14:42
persiaWhen I'm not spending time thinking about how to improve how the team works, I'm spending time supporting other folks on the team with their goals.14:42
nigelbabuSo far similar to what I've been doing.14:44
persiaYep.  You're the team leader for this team :)14:49
nigelbabuI *hate* LP API!14:51
nigelbabu(and it seems to hate me equally)14:51
nigelbabulooks like I neeed help figuring out how LP API deals with tag combinations14:53
persia#launchpad :)14:55
nigelbabuweekend14:56
nigelbabuNote to self: Trial and error /works/14:57
persiaWell, and bad time of day for the couple folks that tend to be around on weekends.14:57
nigelbabuI figured it out.  API documentation is just bad.14:57
nigelbabuinstead of whitespace I needed a =14:57
nigelbabu+ rather14:58
nigelbabupatch-forwarded-upstream shows 3 bugs with patches and patch-forwarded-upstream+patch-forwarded-debian shows 014:59
nigelbabuwonder why14:59
persiapaste code?14:59
nigelbabuhttp://paste.ubuntu.com/421691/15:00
nigelbabuI've worked on the code than brian uses for generating graphs15:00
persiaActually, based on our workflow, I would expect that the number of bugs with that combination would be 0.15:03
persiaWe haven't gone back to the patch-forwarded-upstream bugs and decided upstream was far too slow, and done forwarding to Debian yet.15:03
nigelbabuah, I have to try something with two tags to see if that works15:04
nigelbabuEven with Any combination/15:06
nigelbabuok, thiss is totally cuckoo!  Whats works on LP site doesn't work via API15:12
persiaThat doesn't suprise me.15:13
persiaAn increasing amount of the web interface is being refactored to use the API, but it's not complete in any way.15:13
nigelbabuI'm not sure if tag combinations work via API.15:14
persiaAnd there's extra oddities: like the behaviour of things being different if you use/don't use the Javascript interface.15:14
nigelbabuI tried using whitespace to separate two tags and also +, still returns 015:14
persiaYou could grab all the bugs that have some specific tag, and then select a subset (using Python's set interface) where they also have (or don't have) some other tag.15:15
nigelbabugrabbing bug by bug is very inefficient.  It takes a loong time.15:15
persiaThat said, I can barely patch typo bugs in Python, so I can't really help you do that :)15:16
persiaNo, grab a set of bugs that have tag A.15:16
persiaStick them in a set.15:16
persiaThen create a subset from that set, based on properties of the bugs (not requerying LP).15:16
nigelbabuAh, that *might* work15:17
nigelbabuI need food first.15:17
persiaDepends on whether you have local access to the bug properties.  I don't know the data structures.15:17
persiaBut that algorithm should get you the right set.15:17
nigelbabusubsetting might involve querying LP again15:18
vishnigelbabu: did the cheese apport hook land for karmic as well?15:29
nigelbabuvish: no.  need sru for that.15:33
vishnigelbabu: hmm , a lot of the bugs are from karmic users.. would it get an sru?15:34
nigelbabuvish: can ask someone from ~ubuntu-sru?15:34
vishrighto..15:34

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!