| thumper | hello mister reviewer: https://code.edge.launchpad.net/~thumper/launchpad/really-send-reviewer-email-to-teams/+merge/24094 | 03:07 |
|---|---|---|
| thumper | mwhudson: a simple branch that actually sends code review email to team reviewers | 03:07 |
| mwhudson | thumper: looking | 03:33 |
| thumper | mwhudson: good news | 03:33 |
| mwhudson | thumper: oh? | 03:34 |
| thumper | just QAed my scanner change | 03:34 |
| thumper | and it records the merged revno | 03:34 |
| thumper | \o/ | 03:34 |
| mwhudson | thumper: \o/ | 03:34 |
| thumper | for merged proposals | 03:34 |
| thumper | hows the branch you are preparing for me going? | 03:34 |
| mwhudson | thumper: i think i just need to push it up and propose them | 03:34 |
| mwhudson | thumper: there's three pipes left :) | 03:35 |
| mwhudson | two are small though | 03:35 |
| thumper | ok | 03:35 |
| thumper | I'm spending time looking into the core publication mechanism | 03:35 |
| thumper | I'm trying to make testing breadcrumbs easier | 03:35 |
| thumper | gary thinks it is too hard to do | 03:35 |
| thumper | but I don't take no for an answer | 03:35 |
| thumper | I just haven't found the right place to hook in | 03:36 |
| thumper | ha | 03:54 |
| thumper | I think I found it | 03:54 |
| thumper | nope, not yet | 04:16 |
| thumper | ah, now I've found it | 04:30 |
| thumper | now to disect | 04:30 |
| thumper | or should I say, later to disect | 04:30 |
| thumper | mwhudson: thanks for the review | 04:31 |
| * thumper afk for a bit | 04:31 | |
| thumper | mwhudson: I'm going to attempt to use a gym without killing myself or pulling any muscles | 04:47 |
| thumper | mwhudson: I'll get to your branches later this afternoon/tonight | 04:48 |
| mwhudson | thumper: good luck with that | 04:48 |
| mwhudson | thumper: sounds fine | 04:48 |
| thumper | mwhudson: I'll make sure they're all reviewed for tomorrow morning | 04:48 |
| mwhudson | thumper: awesome | 04:48 |
| thumper | mwhudson: will this make everything go? all tests pass? | 04:48 |
| mwhudson | thumper: all tests passed on friday night, i guess changes in db-devel may have broken something | 04:49 |
| mwhudson | but i doubt it | 04:49 |
| thumper | hopefully not | 04:49 |
| thumper | I found the code I need to tackle for the breadcrumb work | 04:49 |
| thumper | I should have read salgado's comment as he mentions it in the code :) | 04:49 |
| === noodles775 changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [adiroiban(UI bug-146178), noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | intellectronica: Hi! Will you be around today for reviews? Otherwise I'll try to organise a swap :) | 09:53 |
| === intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: - || queue: [adiroiban(UI bug-146178), noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === mrevell is now known as mrevell-lunch | ||
| === intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: noodles775 || queue: [adiroiban(UI bug-146178)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === mrevell-lunch is now known as mrevell | ||
| intellectronica | noodles775: i think that the description of a boolean should take the form of a question, so instead of "Whether the build should be treated as private." I'd do "Should the build be treated as private?" | 13:35 |
| noodles775 | intellectronica: ok. | 13:36 |
| intellectronica | noodles775: what do you think? i don't care deeply about this, just wanted to mention. | 13:36 |
| noodles775 | intellectronica: Although I personally prefer the first option, I'm not fussed either way, so would just go with whatever the defacto standard is. | 13:37 |
| intellectronica | noodles775: on line 395 of the diff there's a trailing , which i think you can remove | 13:37 |
| noodles775 | Aha. | 13:37 |
| intellectronica | noodles775: if you prefer the first option keep it | 13:37 |
| intellectronica | noodles775: r=me | 13:49 |
| === intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: - || queue: [adiroiban(UI bug-146178)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | intellectronica: thanks. | 13:50 |
| bac | intellectronica: can i add a very small one to your queue? https://code.edge.launchpad.net/~bac/launchpad/bug-524778-2/+merge/24060 | 14:21 |
| intellectronica | bac: if it's very small i'll do it right now | 14:21 |
| bac | intellectronica: itty bitty | 14:21 |
| intellectronica | bac: r=me | 14:22 |
| bac | thanks tom | 14:22 |
| === barry` is now known as barry_ | ||
| === barry_ is now known as barry | ||
| === intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === abentley changed the topic of #launchpad-reviews to: On call: intellectronica, abentley || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gary_poster | hi. Could I get a review for https://code.edge.launchpad.net/~gary/launchpad/bug562828/+merge/24044 ? | 15:38 |
| abentley | gary_poster, sure. | 15:41 |
| gary_poster | Thank you abentley | 15:42 |
| === abentley changed the topic of #launchpad-reviews to: On call: intellectronica, abentley || reviewing: -, gary || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | gary_poster, It seems like this solution would be problematic if the librarian could ever contain symlinks. That's unlikely, right? | 15:47 |
| gary_poster | abentley: you mean, if its purpose were to (occasionally) store symlinks, rather than it being merely organized with symlinks? | 15:48 |
| abentley | gary_poster, right. | 15:48 |
| gary_poster | Yeah, that's unlikely. I'll be happy to get a more confident answer from flacoste. | 15:49 |
| abentley | gary_poster, when I first read "tree", I thought you were talking about the launchpad source tree, which does have symlinks, and thought we were storing the contents of the source tree in the librarian. | 15:49 |
| flacoste | gary_poster, abentley: the librarian doesn't create or manage symlinks | 15:50 |
| flacoste | gary_poster, abentley: now if an admin does that... | 15:50 |
| flacoste | don't :-) | 15:50 |
| gary_poster | :-) | 15:50 |
| abentley | gary_poster, approved. | 15:51 |
| gary_poster | thank you abentley | 15:51 |
| === abentley changed the topic of #launchpad-reviews to: On call: intellectronica, abentley || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === stub1 is now known as stub | ||
| mrevell | intellectronica, Do you have time to review my branch at https://code.edge.launchpad.net/~matthew.revell/launchpad/bug-heat-help-bug-544799/+merge/24016 | 16:49 |
| intellectronica | mrevell: sure | 16:50 |
| intellectronica | mrevell: r=me. don't forget that the actual heat changes are in db-devel, so you might want to delay landing this branch until the end of the cycle | 16:55 |
| intellectronica | mrevell: or even better, make it a db-devel branch (which will require you to only merge in the relevant changes and not all the revisions from devel preceding it). | 16:56 |
| mrevell | intellectronica, So, do I just land it on db-devel or do I need to re-branch from db-devel? | 16:58 |
| mrevell | Thanks for the r=intellectronica, btw :) | 16:58 |
| === adiroiban changed the topic of #launchpad-reviews to: On call: intellectronica, abentley || reviewing: -, - || queue: [adiroiban(code bug-146178)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| intellectronica | mrevell: you need to re-branch from db-devel and then merge into your new branch only the changes relevant to this bug from the existing branch | 16:58 |
| mrevell | thanks intellectronica | 16:59 |
| bac | intellectronica, abentley: i have another insanely easy branch: https://code.launchpad.net/~bac/launchpad/bug-568659/+merge/24131 | 17:00 |
| intellectronica | bac: i'll take it | 17:00 |
| bac | intellectronica: pace yourself! :) | 17:01 |
| === matsubara is now known as matsubara-lunch | ||
| intellectronica | bac: r=me | 17:01 |
| === salgado is now known as salgado-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === intellectronica changed the topic of #launchpad-reviews to: On call: abentley || reviewing: - || queue: [adiroiban(code bug-146178)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === gary_poster is now known as gary-lunch | ||
| === deryck[lunch] is now known as deryck | ||
| === salgado-lunch is now known as salgado | ||
| === matsubara-lunch is now known as matsubara | ||
| === gary-lunch is now known as gary_poster | ||
| === matsubara is now known as matsubara-afk | ||
| === abentley changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === sinzui changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara-afk is now known as matsubara | ||
| === salgado is now known as salgado-afk | ||
| === adiroiban changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [sinzui, adiroiban(code,bug-146178),adiroiban(code,bug-525992)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!