[07:21] good morning [07:38] nigelbabu: I'll blog about patch day lite now - I hope we can invite a couple more people :) === yofel_ is now known as yofel [13:00] nigelbabu: how's the review day coming on? [13:46] nigelbabu: what would I do with a bug like https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/548851? [13:47] Malone bug 548851 in rhythmbox "IM Status plugin does not reset status message on end playback." [Low,Fix committed] [13:47] the patch is fixed upstream [13:47] but won't go into lucid because it's frozen and stuff [13:48] sorry, was stuck at work. Just got back. [13:48] dholbach: ^ [13:49] for that we could mark it fix committed and milestone for late I suppose :/ [13:49] I dunno of anything else we could do [13:50] nigelbabu: the problem is: it'll stay on the patch list forever [13:50] or at least until somebody decides to integrate it [13:50] generally I keep track of those bugs when I run into them upload them or ping someone who cares about the package [13:52] yeah, but it means that it will stay on the "TODO list" for others [13:52] do we upload a debdiff and subscribe sponsors in that case? [13:52] or I could mark it as patch-accepted-upstream [13:52] that'd be sensible [13:52] wait, isn't that done? [13:53] nope [13:53] * dholbach does that [13:55] nigelbabu: and we should probably link to information about how to test and review a patch :) [13:56] dholbach: I shuold probably write it. [13:57] I'm sure there's a bunch of stuff on the wiki that could help explain things [13:57] I'll hunt and add those stuff tomorrow. [13:57] great [13:58] * dholbach checks a couple more bug reports to get a feel for the process [13:59] dholbach: any idea why the patch review mailing list doesn't contain any action done on the bug report? [13:59] only the patch tag being added comes up [13:59] if everything was coming on the M/L I could keep track of who's helping out [14:00] I have no idea [14:01] maybe bdmurray knows [14:01] hm, I'll ask him later today :) [14:03] maybe we should also add a link to the bugs that are patch-accepted-* with some explanation how to get stuff accepted in the distro [14:03] nigelbabu: what do you think? [14:03] like a standard reply. Makes sense. [14:03] nigelbabu: so we have a couple of different working lists [14:03] nigelbabu: oh, I meant on the wiki [14:03] But I was also thinking adding that as a report to the overview I was making [14:04] so people who want to have a headstart with development can gelp :) [14:04] help rather [14:04] I guess it makes sense to give it more exposure in different ways [14:04] I'll add something to the wiki about the patch-accepted-* bugs [14:07] dholbach: I had a look at the motu wiki and how it started off, it looks hopeful how small they started :) [14:12] Ciemon: thanks for the edit. :) [14:12] I was supposed to add that quite a long time back and forgot [14:16] :) [14:16] next time you ask for people to check things I'll read rather than skim [14:16] mind you, the more I do this the more I find I need to do more! [14:16] haha [14:17] Ciemon: how are you finding the workflow? [14:17] i.e. from the perspective of someone who's seeing it for the first time.. [14:17] Seems to be fine.. my stumbling block is over feeding upstream, it's something I've not done, and tbh, not looked into [14:18] I must this week [14:18] As I have a couple of bugs line up for Maverick that need it [14:19] ah, you can always ask the #ubuntu-bugs folks for help if you get stuck there [14:19] thanks [14:19] nigelbabu: https://wiki.ubuntu.com/ReviewersTeam/GettingInvolved?action=diff&rev2=16&rev1=15 [14:19] dont get scared at the number of replies. Too many helpful folks there :) [14:20] This is an interesting line: " If the change is significant enough to be fixed in Ubuntu, get the patch uploaded" [14:20] dholbach: ROCK!! [14:21] Ciemon: look at ^ see if clears your worries? [14:22] it does to a point, but I think that you/Daniel may need to define "important bug" [14:23] without a definition, all bugs are important [14:24] I think the https://wiki.ubuntu.com/Bugs/Importance high and critical fall under important [14:26] Do we have any documention about testing patches? [14:26] I dont find any [14:26] Bugs/Importance is a good idea [14:27] and the classification in StableReleaseUpdates probably too [14:27] I'll add to wiki [14:27] but it's left to individual interpretation as to importance [14:27] So.. I'm not part of UbuntuBugControl.. and I can't change importance [14:28] but I can review [14:28] so, you probably need to use the levels to indicate which bugs are at the level required to go to Ubuntu without upstream acknowledgement [14:28] you just pop by in #ubuntu-bugs and caks someone to set it for you :) [14:28] ask rather [14:29] thats the problem. We're not sure. It varies [14:29] :D [14:29] some patches are important, but we'd rather have upstream comment on it at least [14:30] I'd suggest that Critical, High and Medium need to go into Ubuntu straight away [14:30] the others "could" wait [14:31] anyway.. I'm waaay out of my league here [14:31] some times, upstream makes some comment about it. [14:31] I'm hesitant to therefore accept the Medium ones in immediately [14:31] and keeping you from work [14:31] My work is this today. [14:31] Getfeedback about the review guide. [14:32] ok, well, just need to do a bit of work and I'll be back [14:36] Ciemon: there's no way all the Medium bugs can go into Ubuntu straight-away [14:37] Ciemon: there's freeze times, stable release updates need extensive testing [14:37] have a look how many bugs are "medium" [14:38] and even if patches looks it obviously fixes the issue, it might still break other stuff [14:41] Ciemon: bug 548851 is an example for that [14:41] Malone bug 548851 in rhythmbox "IM Status plugin does not reset status message on end playback." [Low,Fix committed] https://launchpad.net/bugs/548851 [14:41] oh sorry, that's "Low" already :) [14:43] it'd be nice to get as many fixes in as possible, but because of release schedule decisions we need to draw a line [14:44] otherwise you'd keep spinning new images and people would need to test them, you'd delay the release, etc. [14:44] and you'd probably always keep working on the same release [14:44] and as nigelbabu said: it's good to get the ACK of upstream [14:45] because if upstream (who are usually more experienced - it's code they wrote) decide to go with a different solution it might mean that we need to maintain the side-effects of our solution for 18 months to 5 years (depending on what kind of release it is) [14:48] dholbach: thanks for helping my understanding. The reason I went for Medium and above is, from Medium: "A bug that has a moderate impact on a core application." [14:48] whereas Low "can be easily worked around" [14:48] Ciemon: yeah, from that viewpoint it definitely makes sense [14:49] As I've only being doing this for 3 weeks I only have these docs to go from, rather than experience, which could be a good thing :) [14:50] Ciemon: I guess Medium is used in a lot of cases where it probably shouldn't :) [14:50] ahhhh! Now we come to it. [14:50] :-) [14:50] :) [14:50] nigelbabu: what do you think about making GettingInvolved more of a "you might want to check these pages out" and "this is what we do" page? [14:51] nigelbabu: the page is growing and growing (which is good) and contains like all the process documents :) [14:51] and todo lists [14:51] and making the review guide separate? [14:52] it was an idea I just had, right now I'm adding more stuff to it :) [14:52] I had that idea long back, but I didn't want to break everyone linking to it. [14:53] it's a great page [14:53] Either we can work on a new page and then put it there. [14:53] Or we can do it after patch day [14:53] yeah, maybe let's just keep it on the radar until later on [14:54] I'll make a separate page in a sandbox and we can may be flip at some point [14:56] just added a link to all the bugs with patches that were accepted in debian or upstream else already [14:57] might be a nice working list for either SRUs or maverick [14:57] a query right? [14:58] yep [14:58] https://wiki.ubuntu.com/ReviewersTeam/KnowledgeBase#Tag%20Query [14:58] but we could make it part of getting started [14:58] like how you could package stuff [14:59] I added it to the "Inclusion in Ubuntu" paragraph [15:00] :) === xnox is now known as xnox_away [15:11] dholbach: may be, just may be, we can turn our landing page to different types of ways folks can help reviews team [15:11] nigelbabu: yeah, why not [15:12] (a) triage patches, (b) pacakges stuff [15:12] so we can have new or prospective MOTU to review team to package stuff [15:15] is there a page showing a clearly mapped path for newbie to motu? [15:16] not yet, but important ingredients are all linked from https://wiki.ubuntu.com/MOTU/GettingStarted [15:16] fine, just thought I'd ask :) [15:18] what makes it hopefully a bit "easier" is striving for doing stuff in Ubuntu and making the world a better place for millions of users and learning something new, you enjoy [15:19] so joining a team or getting a badge in launchpad it not the central interest :) [15:22] Its like karma, after the first excitement [15:22] it wras off [15:23] then all you think off is getting things fixed and not badges or how much karma you get for it [15:24] Ciemon: closest i can think is https://wiki.ubuntu.com/UbuntuDevelopers?action=AttachFile&do=view&target=ubuntu-developers6.png [15:37] thanks maco [15:38] we're going to talk about all of this on the podcast tonight (ubuntu uk) [15:38] that chart leaves out per package uploaders thoug [15:38] and the new stuff with packagesets [15:39] because now you can be a kubuntu-dev and have access to all the kde packages but not be a core dev [15:48] nigelbabu: how did you change the topic here? [/me forgot] [16:00] vish: use /topic "some text" [16:01] Ciemon: that doesnt work in all channels , and not here though [16:03] vish: it does, but you need to be a channel op to make changes. [16:11] Ciemon: yup , but i dont think nigelbabu was the op here.. hence was wondering how :) [16:20] vish: /msg chanserv help [16:20] there is an option there [16:21] maco: package sets would be just a stand-alone item === vish is now known as Vish === Vish is now known as vish === vish is now known as Vish [16:40] Vish: what are you doing? [16:41] baaah! :s [16:41] Vish: part all channels and do it please. [16:42] nigelbabu: what? [16:42] how do i fix the nm problem ? [16:43] Vish: before you /nick, part all channels [16:43] nigelbabu: heh , tel that to nm , so that it doesnt disconnect me :s [16:43] lol [16:44] oh great! i cant use a system for more than 24hrs , before stuff starts to go bonkers..! :/ [16:46] haha [18:52] nigelbabu: You might also want to keep track of as it will probably affect this team a lot. === xnox_away is now known as xnox