| thumper | gary_poster: ping | 00:07 |
|---|---|---|
| jelmer | gary_poster: hi | 00:08 |
| thumper | anyone know where the request.publication is set? | 00:13 |
| poolie | hi jelmer, thumper | 00:14 |
| thumper | hi poolie | 00:14 |
| thumper | poolie: I have an interesting bug for you | 00:15 |
| thumper | poolie: if I can find | 00:15 |
| thumper | it | 00:15 |
| thumper | bug 568740 | 00:16 |
| mup | Bug #568740: lp:ubuntu/sun-java6 isn't pulled, apparently due to MemoryError <branch-puller> <Bazaar:New> <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/568740> | 00:16 |
| poolie | ok | 00:20 |
| poolie | so can you give us any more information about it? | 00:20 |
| poolie | or do you think pulling it directly should reproduce it? | 00:20 |
| poolie | i've been meaning to do something about giving better debug info for MemoryError | 00:20 |
| poolie | so i might try it in that context | 00:20 |
| poolie | is this one important or just interesting? | 00:20 |
| thumper | well, I don't know where it is failing apart from MemoryError | 00:33 |
| thumper | it is important for someone | 00:34 |
| mars | thumper, the request.publication stuff is a function of an IRequestPublicationFactory instance. We have a few in c.l.webapp.servers | 00:37 |
| thumper | mars: thanks, I'm going through the doc test for publication right now | 00:37 |
| mars | thumper, the factory produced request/publication pairs, which the Zope machinery puts together, then gives to zope.publisher.publish() | 00:37 |
| * thumper nods | 00:39 | |
| === matsubara is now known as matsubara-afk | ||
| cody-somerville | Hey | 01:04 |
| cody-somerville | I'm making a field read only and setting up a mutator for it. This causes tests to break because the field is used in forms. How do I get around this? | 01:04 |
| cody-somerville | Ah, I see branch's privacy field is an example. | 01:09 |
| thumper | mwhudson: what have we broken? http://launchpadlibrarian.net/45588750/maxb-django-trunk-bzr-svn.log | 02:14 |
| mwhudson | thumper: huh | 02:16 |
| thumper | mwhudson: it is a branch | 02:16 |
| thumper | mwhudson: for svn | 02:16 |
| thumper | mwhudson: so I'm wondering if we have broken something else | 02:16 |
| mwhudson | bzr log -l 2 svn+http://code.djangoproject.com/svn/django/trunk seems to be doing something | 02:16 |
| mwhudson | thumper: however, bzr log -l 2 http://code.djangoproject.com/svn/django/trunk does not work | 02:24 |
| mwhudson | thumper: at this point i suggest the usual course of action | 02:24 |
| mwhudson | thumper: which is asking jelmer | 02:24 |
| thumper | mwhudson: bug jelmer? | 02:24 |
| mwhudson | perhaps the code import system could prepend svn+ to http urls for svn imports | 02:25 |
| nigelbabu | I'd like to work on fixing bug 569447 | 02:46 |
| mup | Bug #569447: Documentation for searchTask tag is wrong <api> <trivial> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/569447> | 02:46 |
| nigelbabu | Is it something easy to do? | 02:47 |
| mwhudson | nigelbabu: should be | 02:48 |
| mwhudson | nigelbabu: the documentation for the api doc comes from the docstring in the interface | 02:48 |
| nigelbabu | mwhudson: I read the docs and it said I should first discusss about it and then start | 02:49 |
| nigelbabu | if it comes from the interface there is a problem. | 02:49 |
| nigelbabu | the documention is corrent for the interface and wrong for the api | 02:49 |
| mwhudson | nigelbabu: why? | 02:49 |
| mwhudson | ah | 02:50 |
| mwhudson | i wonder if there's a way of overriding/changing the doc for the api... | 02:50 |
| mars | mwhudson, nigelbabu, grep-find? | 02:50 |
| mars | since you already know the string you are looking for... | 02:51 |
| nigelbabu | its not about finding. | 02:51 |
| nigelbabu | mwhudson: can poke me when you find a way out? I'm ready to work on it if it needs fixing :) | 02:53 |
| mwhudson | nigelbabu: i'm not sure that you can override the string used in the api doc | 02:57 |
| mwhudson | nigelbabu: so maybe a bug on lazr.restful asking for that is the way to go | 02:58 |
| nigelbabu | ah, ok :) | 02:58 |
| thumper | mwhudson: how come the postmortem debugger isn't giving me any content for listings? | 03:00 |
| nigelbabu | what should I say? "There should be a way to override the interface strings for API docs"? | 03:00 |
| thumper | mwhudson: I just get [EOF] | 03:00 |
| mwhudson | thumper: um, the path in the pyc files might be wrong? | 03:01 |
| thumper | :( | 03:01 |
| thumper | doesn't seem to be | 03:01 |
| === lifeless_ is now known as lifeless | ||
| mwhudson | someone has requested a mercurial import of netbeans | 06:13 |
| mwhudson | good luck with that | 06:13 |
| === jamesh_ is now known as jamesh | ||
| noodles775 | G'day all. | 07:21 |
| spm | yo | 07:25 |
| mwhudson | must be time for dinner | 07:28 |
| mrevell | Morning. | 08:53 |
| === almaisan-away is now known as al-maisan | ||
| wgrant | Is it just me, or have the JS status/importance widgets lost their custom colouring recently? | 09:12 |
| mwhudson | baaah | 09:21 |
| mwhudson | exactly one failure on no-hosted-area | 09:21 |
| jml | mwhudson: :) | 09:41 |
| mwhudson | fortunately it's rather trivial | 09:42 |
| mwhudson | jml: good morning | 09:44 |
| jml | mwhudson: hi | 09:54 |
| * mwhudson fires up the ec2 land of doom | 10:14 | |
| mwhudson | " 96 files changed, 2640 insertions(+), 2916 deletions(-)" | 10:14 |
| jml | mwhudson: that's a big change | 10:25 |
| jml | mwhudson: are much of those insertions added documentation? | 10:25 |
| bigjools | thumper: still around? | 10:31 |
| jml | I'm off out of the house for a bit. Expect to be online shortly. | 10:35 |
| jml | bigjools: let's talk today | 10:36 |
| bigjools | jml: grab me when you can | 10:37 |
| jml | bigjools: ok. thanks. | 10:37 |
| jml | wgrant: you've probably already figured it out by now, but sinzui's recent CSS refactoring broke them. Looks like there's a fix up already. | 10:38 |
| wgrant | jml: Yeah, I thought that would have to be it. | 10:41 |
| thumper | bigjools: no | 10:50 |
| bigjools | thumper: ok, then I can't tell you about the new PPA for bzr-builder | 10:50 |
| thumper | bigjools: email still works :) | 10:51 |
| bigjools | thumper: when kmail is not crashing, yes :) | 10:51 |
| deryck | Morning, all. | 11:00 |
| mwhudson | jml: no | 11:06 |
| gary_poster | thumper jelmer pong | 11:50 |
| bigjools | ah gary_poster, just the man I need to talk to | 11:51 |
| gary_poster | what's up bigjools | 11:51 |
| bigjools | gary_poster: I might have been a bit naieve in expecting a webservice method to work when returning a collection of ITextLine | 11:52 |
| bigjools | there's no adapter to do that by the looks of it | 11:52 |
| bigjools | is there any easy solution to returning a list of strings? | 11:52 |
| gary_poster | bigjools: sadly, I'm not sure. Leonard will probably be on soon and I'll ask him to seek you out. | 11:53 |
| bigjools | gary_poster: ok thanks | 11:53 |
| wgrant | Do you actually need to do returns_collection_of there? | 11:54 |
| wgrant | If you omit it, lazr.restfulclient will just treat it as JSON, so they will come out as strings. | 11:54 |
| wgrant | (we already do a similar thing for dicts in a few places) | 11:54 |
| bigjools | wgrant: ah, got an example? | 11:56 |
| maxb | Are there no CHR people this week? | 12:00 |
| wgrant | bigjools: There are methods like Branch.composePublicURL and BugNomination.canApprove that return single objects without declaring their types (since they are basic JSON types). | 12:00 |
| wgrant | I'm not sure of any that return lists. | 12:00 |
| wgrant | It does just work, but I'm not sure how legal it is. | 12:01 |
| bigjools | yeah it's the list aspect that is problematic | 12:01 |
| wgrant | If you don't tell it otherwise it will just decode the JSON and be done with it. | 12:01 |
| * bigjools tries and sees what happens | 12:02 | |
| wgrant | Technically it's fine. | 12:03 |
| wgrant | Whether it will make a Leonard appear and attack you, I do not know. | 12:03 |
| bigjools | a Leonard can change its spots | 12:03 |
| bigjools | wgrant: BTW did you check out the sizes of those log files ? | 12:04 |
| wgrant | bigjools: Yes. | 12:04 |
| wgrant | I am scared. | 12:04 |
| bigjools | yes thought so :) | 12:04 |
| bigjools | has anyone done a webservice test using lplib yet? | 12:05 |
| wgrant | People have tried. | 12:05 |
| wgrant | Bugs have been filed. | 12:05 |
| wgrant | I think some of them might have been fixed. | 12:05 |
| wgrant | eg. Bug 569189 | 12:06 |
| mup | Bug #569189: Authenticated users in launchpadlib tests have no permissions <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/569189> | 12:06 |
| wgrant | Bug 569101 | 12:06 |
| mup | Bug #569101: Protocol Error when calling some launchpadlib methods within the test environment <qa-untestable> <Launchpad Foundations:Fix Committed by bac> <https://launchpad.net/bugs/569101> | 12:06 |
| wgrant | So it probably works a bit. | 12:06 |
| bigjools | let's see | 12:06 |
| === mrevell is now known as mrevell-lunch | ||
| bigjools | wgrant: win! | 12:42 |
| wgrant | bigjools: You have a string collection exported and tested with launchpadlib in the test suite? | 12:43 |
| bigjools | yarp | 12:43 |
| wgrant | Win indeed! | 12:43 |
| bigjools | so now I can land this branch that exports your p3a URLs | 12:43 |
| wgrant | I bet that doesn't respect the OAuth token's privacy setting, though. | 12:45 |
| bigjools | it does | 12:52 |
| bigjools | the new method is on IPerson and it'll throw a 401 unless you've got lp.edit | 12:53 |
| wgrant | But if I tell Launchpad that my token shouldn't be able to access private data, will it let me? | 12:54 |
| * bigjools re-reads and sees you were talking about OAuth tokens | 12:54 | |
| wgrant | Ah. | 12:54 |
| bigjools | not sure it does respect it, you're right, I'm using WRITE_PUBLIC | 12:55 |
| === salgado-afk is now known as salgado | ||
| leonardr | bac, refresh my memory | 13:20 |
| leonardr | you were having some problems with the launchpadlib tests in launchpad | 13:21 |
| leonardr | i gave you a little one-line-or-so fix, which you applied and it worked | 13:21 |
| leonardr | is that right?. | 13:21 |
| leonardr | have you landed that? | 13:21 |
| leonardr | bigjools, gary told me of your woe | 13:22 |
| leonardr | an ICollection is only for IEntry objects that have their own urls. you should be able to return an IList of ITextLine | 13:22 |
| === mrevell-lunch is now known as mrevell | ||
| Ursinha | bigjools, hello :) | 13:32 |
| Ursinha | bigjools, I pinged you yesterday, but have no idea if you answered because my internet was worse than crap | 13:32 |
| bigjools | Ursinha: hi | 13:45 |
| bigjools | leonardr: yeah I'm just returning the list and it seems to work well, thanks | 13:45 |
| jml | allenap, is that test process still going? | 13:50 |
| jml | allenap, if so, could you please attach a strace to it and see what it's doing? | 13:51 |
| allenap | jml: Sorry, I killed it. It was in a tight select() loop though; I did an strace before I killed it. | 13:52 |
| jml | allenap, ok. thanks. | 13:52 |
| allenap | jml: select(0, NULL, NULL, NULL, {0, 10000}) = 0 (Timeout) | 13:52 |
| * jml raises an eyebrow | 13:53 | |
| bac | leonardr: yes, i landed the patch that involved uppercasing of the request method | 14:00 |
| bac | leonardr: i also discovered this bug: https://bugs.edge.launchpad.net/launchpad-foundations/+bug/569189 | 14:07 |
| mup | Bug #569189: Authenticated users in launchpadlib tests have no permissions <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/569189> | 14:07 |
| allenap | jml: Fwiw, it's in lp:~allenap/launchpad/early-batching-bulk-updates-bug-509223 when run with the test command in the email. If I run with "bin/test -vvc lp.bugs.scripts.checkwatches" it does not hang. This might have something to do with when zope.testing spawns a sub-process when the layer doesn't tear down. | 14:11 |
| leonardr | james_w, i just released a lazr.restfulclient that fixes bug 568301 | 14:29 |
| mup | Bug #568301: Invoke a named operation on a collection, and the collection is fetched. <performance> <lazr.restfulclient:In Progress> <https://launchpad.net/bugs/568301> | 14:29 |
| leonardr | want to give it a try and see how the performance improves? | 14:29 |
| james_w | thanks | 14:29 |
| james_w | I'll try later | 14:29 |
| leonardr | sure | 14:30 |
| leonardr | james_w: when you have time to test things i changed, also take a look at bug 561521 | 14:43 |
| mup | Bug #561521: Success of PATCH request dependent on dict iteration order <Launchpad Foundations:Fix Committed> <lazr.restful:Fix Released> <https://launchpad.net/bugs/561521> | 14:43 |
| wgrant | deryck: Hi. Are you aware of some horrifyling slow BugJob-related queries caused by status changes? | 14:47 |
| wgrant | They are making some Soyuz things time out. | 14:47 |
| deryck | wgrant, I have just started to become aware of some BugJob-related timeouts. Didn't realize we had some with status changes, though. | 14:52 |
| Ursinha | bigjools, so, ping me when you're not busy, re. my bot and your bugs :) | 14:52 |
| wgrant | deryck: Accepting queue entries can close bugs, and they've recently started timing out with several hundred milliseconds of BugJob query per bug. | 14:53 |
| deryck | wgrant, ah, that makes sense. Anything that qualifies for a bug change will touch that code. gmb, see wgrant's comments. ^^ | 14:55 |
| * gmb looks | 14:55 | |
| deryck | gmb, so we need to look at ways of speeding this up. it's causing timeouts when filing bugs on ubuntu, too. | 14:55 |
| gmb | wgrant, deryck: Ah, so at a guess this is happening when we're looking at BugJob to see if there's already a CalculateBugHeatJob for that bug, right? | 14:56 |
| wgrant | gmb: So I'm told, although I obviously can't see the full picture. OOPS-1575B227 is an example. | 14:56 |
| maxb | allenap: If you've still got that hung test run around, could you check whether there actually is a related subprocess hanging around? Otherwise, I'm not sure why it would still be blocked. You could try a 'lsof -p thatpid' to see if there's anything interesting there | 14:56 |
| * gmb looks | 14:57 | |
| * deryck looks at OOPS, too | 14:57 | |
| deryck | Yeah, this is the same as ubuntu filebug timeouts. and yes, as gmb notes, it's the select. | 14:59 |
| deryck | gmb, See bug 539382, too. | 14:59 |
| wgrant | The query doesn't look like it has to be terrible. | 15:00 |
| wgrant | Unless the indices are. | 15:00 |
| gmb | wgrant, Yeah, I wonder if we're missing an index somewhere. | 15:01 |
| * gmb looks | 15:01 | |
| gmb | wgrant, deryck, I wonder if there should be indices on Job.lease_expires and .scheduled start, since that's what's getting hit in the subquery. | 15:03 |
| wgrant | My DB says seq scans on Job and BugJob. | 15:03 |
| gmb | ?! | 15:03 |
| wgrant | That would do it. | 15:03 |
| gmb | So we need indices on both tables then. | 15:03 |
| deryck | yup | 15:04 |
| deryck | simple to fix then. :-) | 15:04 |
| gmb | Indeed. | 15:04 |
| wgrant | ... | 15:04 |
| * wgrant looks at BugJob's indices. | 15:04 | |
| gmb | (Well, simple to *say* anyway) | 15:04 |
| wgrant | Or lack thereof. | 15:04 |
| deryck | gmb, do you think you could find some time today to cowboy a patch to staging to confirm, and if so, get a branch for that? | 15:04 |
| gmb | deryck, Sure, I'll add a card for it. Should get me away from this endlessly frustrating refactoring, too. | 15:05 |
| deryck | gmb, thanks! Sorry to sideline you with it, but it is becoming more and more of a problem. You can use bug 539382 to track it, I think. | 15:05 |
| deryck | wgrant, thanks for pinging me about this. | 15:05 |
| gmb | deryck, cool | 15:06 |
| wgrant | deryck: Thank you for swiftly investigating. | 15:06 |
| deryck | np | 15:07 |
| bigjools | Ursinha: HELLEAU | 15:09 |
| maxb | Hi, are there no CHR people this week? | 15:11 |
| jtv | Puzzle for the day. Why would Store.of(x) return None, given that x is not None and was retrieved from the database, other than that x has been deleted somehow? | 15:15 |
| wgrant | jtv: Because you are a BranchJobDerived, not a real BranchJob. | 15:16 |
| jtv | wgrant: brilliant! | 15:17 |
| jtv | wgrant: for the bonus round, why would BuildQueue, which has no clue WTF I am or am not besides the fact that I implement a particular interface, want to destroy me? | 15:17 |
| * bigjools removes the third massive bee from the office today | 15:18 | |
| jtv | Actually, BranchJobDerived delegates to BranchJob, so I'd guess that would include destroySelf. | 15:18 |
| wgrant | jtv: It tries to the destroy the BuildQueue, the Job and the link between the Job and the real object. | 15:18 |
| jml | jtv: humanity has a long history of destroying things based on perceived type | 15:18 |
| wgrant | jtv: But this doesn't use destroySelf. | 15:18 |
| jtv | jml: yes! I thought we were finally getting good at it. | 15:18 |
| wgrant | jtv: And bigjools vetoed my change to use it. | 15:18 |
| wgrant | In favour of noodles' big refactoring. | 15:19 |
| jtv | arrrr | 15:19 |
| jtv | Hear that faint drone? That's Baby Jesus crying. | 15:20 |
| noodles775 | wgrant: the big refactoring is based on your ideas too :) | 15:20 |
| jtv | noodles775: that's as may be, but right now, BuildQueue does The Wrong Thing™ with my object and what recourse do I have? | 15:20 |
| wgrant | https://code.edge.launchpad.net/~wgrant/launchpad/bug-549340-fix-buildqueue-destruction was mine, FWIW. | 15:21 |
| * noodles775 looks at the branch and jtv's issue. | 15:23 | |
| bigjools | jtv's branch is not a storm object is it? | 15:24 |
| bigjools | s/branch/object/ | 15:24 |
| wgrant | bigjools: Right. | 15:24 |
| wgrant | It delegates to one. | 15:25 |
| jtv | bigjools: if you want to argue over whether there should be a separate TranslationTemplatesBuildJob table, go argue with jml who insisted that I use BranchJob instead. :) | 15:25 |
| jml | jtv: citation needed | 15:25 |
| bigjools | lol | 15:25 |
| jtv | Why not define a method in IBuildFarmJob for "this build is done, do whatever you want for historical purposes, or delete yourself, I don't care which"? | 15:25 |
| wgrant | The Code team in general wants us to use Jobs. | 15:26 |
| bigjools | yeah and that unfortunately hurt us in the buildfarm :( | 15:26 |
| wgrant | Well, there was discussion last week that they were unhappy with the new design, since it doesn't involve Jobs. | 15:27 |
| jtv | What, we're selling out to Apple? | 15:27 |
| * wgrant throws some iPhone shards at jtv. | 15:27 | |
| jtv | Oh, `Job`s. Sorry. | 15:27 |
| noodles775 | I'm not removing the jobs at the moment, and I think once the refactoring is finished we'll be in a much better position to see if we want to either (1) talk about removing the links to Job or (2) turn BuildFarmJob into a services Job with the correct job-type. | 15:28 |
| wgrant | I think the new model could pretty trivially be altered to integrate well with Job, without the mess that is the current situation. | 15:29 |
| noodles775 | I agree. | 15:29 |
| jtv | Actually, removing a BranchJob will also destroy the Job. | 15:29 |
| jtv | Anyway. I do need an interim measure, and fast. How about this idea of delegating "go destroy yourself or something" to the IBuildFarmJob? | 15:30 |
| bigjools | the only reason to use Job is if we intend to use the Job runner | 15:31 |
| bigjools | that will never ever happen | 15:31 |
| wgrant | Code disagrees. | 15:31 |
| wgrant | Feel free to argue with them :) | 15:31 |
| bigjools | they would :) | 15:31 |
| bigjools | I'm not arguing, I'm stating a fact. | 15:32 |
| wgrant | jtv: So you're actually thinking of deploying these jobs in 10.04? | 15:32 |
| jtv | wgrant: or be damned near ready to. | 15:33 |
| wgrant | Excellent. | 15:33 |
| jtv | At the very least I want to be able to move on to the next failure, it's been long enough! | 15:33 |
| bigjools | heh | 15:33 |
| wgrant | Well, they worked perfectly for me a little over a month ago. I'm not I had any fixes that remain unmerged, apart from this one. | 15:34 |
| wgrant | So barring the inevitable massive production issues, it probably just about works. | 15:35 |
| jtv | Nice quote, that. | 15:35 |
| noodles775 | jtv: so that would be wgrant's branch above right? (IBuildFarmJob.destroySelf()) | 15:36 |
| jtv | noodles775: no, bigjools had one strong argument against that—it's SQLObject. My own would be: it's the IBuildFarmJob's own damn business what it wants to do after it retires. It doesn't _have_ to die right there. | 15:36 |
| jtv | Just call it something different and presto. :) | 15:36 |
| noodles775 | Right. | 15:37 |
| bigjools | jtv: I think you're simplifying it too much. We have a BuildQueue, which has generic info, and an associated IBuildFarmJob which has specific info. BuildQueue records are destroyed when done with, which means the IBuildFarmJob must be too. If you want persistence you need a separate table. | 15:38 |
| bigjools | which I'm pretty sure is what I said ages ago :) | 15:39 |
| jtv | bigjools: why does it mean IBuildFarmJob must be destroyed? All you need is for it to stop referring to the Job. | 15:39 |
| * wgrant would really like to delay any persistence changes until after The Refactoring. | 15:40 | |
| bigjools | jtv: because that's how it's designed to work, changing it now would be very invasive | 15:40 |
| wgrant | Particularly since it makes the transition much easier if we only have one type of job to migrate... | 15:40 |
| jtv | bigjools: I can see how the design always assumed it, but where does it actually rely on it? | 15:41 |
| bigjools | jtv, think of it as the difference between data about the job, and data about the build itself | 15:41 |
| jtv | Yes, I'm thinking of it... go on! | 15:42 |
| mrevell | noodles775, Hey, got five minutes? | 15:44 |
| noodles775 | mrevell: sure. | 15:44 |
| bigjools | jtv: so it was designed like that so that we could throw away data that was of no use once the job was done. Deletion is something that doesn't happen enough in LP! | 15:45 |
| noodles775 | jtv, bigjools: jfyi, after the refactoring IBuildFarmJob *won't* be destroyed, but all the other queue-related items will be (as they are now - I'm not touching their behavior). That is, BuildPackageJob delegates to IBuildFarmJob... the BuildPackageJob (and related job) will die, but not the BuildFarmJob. | 15:46 |
| jtv | bigjools: but you don't know what the data _is_. The IBuildFarmJob is not data; it's something abstract that helps you define how to do the job, not a database record. | 15:46 |
| wgrant | jtv: That's about to change. | 15:46 |
| noodles775 | It will be, but that doesn't help you now. | 15:46 |
| wgrant | noodles775: So BuildQueue/Job are staying as they are for now, just all the stuff on top of them is being fixed? | 15:47 |
| bigjools | jtv: I didn't mean IBuildFarmJob as such, but the derived tables, but as they say it's going to change | 15:47 |
| noodles775 | wgrant: yes, I'm not touching the BuildQueue, just ensuring it still works as it does now. I'm just generalising so that all *Build models have common info in the same place. | 15:48 |
| jtv | bigjools: that's fine with me, but as an implementer of IBuildFarmJob, I still say it's my own business how I take care of this. | 15:48 |
| noodles775 | (basically your diagram minus the queue related attributes) | 15:48 |
| bigjools | jtv: I completely disagree :) | 15:48 |
| jtv | Well, then fix BuildQueue to do it in a way that works for non-ORM classes! | 15:48 |
| bigjools | making the build-manager work for different job types was fucking hard | 15:49 |
| bigjools | the direction we took solved a lot of problems while not breaking too much of the existing functionality | 15:49 |
| jtv | kudos for that, and I'm not married to the "the IBuildFarmJob doesn't have to die" idea. Can we at least delegate the deletion somehow? | 15:50 |
| bigjools | you're going to need a separate table that has persistent data on it, for the builder history page | 15:52 |
| bigjools | anyway chat to noodles775, he might be able to help more than me since he's deep in that code at the moment :) | 15:53 |
| jtv | We've got a ticket open for persistent history. My very immediate concern is this failure that puts the builder into a very bad state. | 15:54 |
| === matsubara is now known as matsubara-lunch | ||
| noodles775 | jtv: I think delegating the deletion would be fine... happy to chat about it, or review an MP :) | 15:56 |
| cody-somerville | Can I get some help with my branch? lp:~cody-somerville/launchpad/bug-444266/ | 15:56 |
| jtv | noodles775: great, thanks. Call it cleanUp() or something, put the Store.of(self).remove() in the default implementation, and override it in TranslationTemplatesBuildJob? | 15:57 |
| noodles775 | jtv: sounds good. | 15:57 |
| jtv | noodles775: ok, I can have that waiting for you tomorrow morning. | 15:57 |
| jtv | assert jtv.eod < time.now() | 15:58 |
| cody-somerville | I created a IHasBugSupervisorEditSchema class to provide an editable field for bug_supervisor in IHasBugSupervisorEditView since bug_supervisor is defined as readoly in the IHasBugSupervisor interface. | 15:58 |
| jtv | noodles775: thanks again. | 15:58 |
| bigjools | jtv, noodles775: can we determine if the object is Storm or SQLObject and DTRT? | 15:58 |
| noodles775 | cody-somerville: the On Call Reviewer (on #launchpad-reviews) is usually around for that kind of think if no-one here takes you up :) | 15:58 |
| jtv | bigjools: this one isn't either | 15:58 |
| bigjools | ?! | 15:58 |
| jtv | but afaic the default implementation could try | 15:58 |
| bigjools | /o\ | 15:58 |
| * bigjools -> OTP | 15:59 | |
| flacoste | can you believe it's snowing over here! | 15:59 |
| jml | yes | 16:00 |
| jml | you live in an arctic wasteland | 16:00 |
| noodles775 | bigjools: you can (I've had to create the following property on IBuildFarmJob as an intermediate measure: http://pastebin.ubuntu.com/423413/) | 16:00 |
| jtv | jml clearly fancies those, or he wouldn't have moved so much closer to them | 16:00 |
| cody-somerville | flacoste, Don't say that. That means its only a matter of time before it starts snowing here :P | 16:01 |
| bigjools | it's hot here | 16:01 |
| jml | jtv, no, I just _really_ like grey. | 16:01 |
| jtv | "the night sky over the planet Krikkit is the least interesting sight in the Universe." | 16:01 |
| jtv | bigjools: hot here too. Still otp? | 16:03 |
| jtv | Wow, it's getting so difficult to pick out a T-shirt to wear now that they have mobs in all colours. | 16:04 |
| jtv | I loved the green ones. Waving identical little flags with fixed, almost hopeful little smiles... Very Pyongyang. | 16:05 |
| gmb | deryck, wgrant: So, adding indices doesn't seem to solve the seqscan problem with bug 539382. | 16:19 |
| gmb | (I haven't added indices for *everything* yet, maybe that'll work) | 16:19 |
| gmb | However, it may be simpler to have CalculateBugHeatJob.create() just create a new job regardless and then have the garbo process make sure that only one update gets run for that bug. | 16:20 |
| deryck | gmb, are you trying this locally? My experience is that local indexes may not get used when they will on staging. Unless you're working with a bit of BugJob data locally. | 16:21 |
| gmb | deryck, Ah, good point. I didn't realise that indices might not get used when data volume is low. I'll try and scare up a LOSA. | 16:21 |
| deryck | gmb, though you're right that ultimately it might be still be better to push the work to CalculateBugHeatJob. But indexes will help regardless of that. | 16:23 |
| jtv | In fact you'll get _completely_ different plans on realistic data than you will at home. | 16:26 |
| * jtv is out. | 16:27 | |
| === deryck is now known as deryck[lunch] | ||
| === flacoste is now known as flacoste_lunch | ||
| === flacoste_lunch is now known as flacoste | ||
| === salgado is now known as salgado-lunch | ||
| gmb | deryck[lunch], wgrant: So, indices FTW. Will put a DB patch together. | 17:27 |
| === gary_poster is now known as gary-lunch | ||
| === deryck[lunch] is now known as deryck | ||
| deryck | gmb, good news, thanks | 17:45 |
| mrevell | Night all | 18:16 |
| === salgado-lunch is now known as salgado | ||
| === gary-lunch is now known as gary-poster | ||
| === al-maisan is now known as almaisan-away | ||
| === gary-poster is now known as gary_poster | ||
| leonardr | gary or barry, any suggestions on how to mock up a test for time.sleep? i have a semi-vague idea but it seems like something you'd know well | 19:38 |
| gary_poster | leonardr: I've simply used the Grand Hack monkeypatch approach myself. If I control the pertinent module(s) I sometimes use a "from time import sleep" within it so that I can just locally mokeypatch sleep in the module. It's possible that mocker would give you an alternate approach, but then you are adding a dependency | 19:41 |
| leonardr | gary, what you're saying is similar to what i was thinking, but i'm not sure what you mean by 'the module'. do you have time to work this out in person? | 19:42 |
| gary_poster | sure | 19:42 |
| salgado | leonardr, maybe this could be of help: http://labix.org/mocker | 19:42 |
| salgado | Trivial mocking of any external module (e.g. time.time()) via proxy replacement. | 19:42 |
| gary_poster | that was my second suggestion above, yeah. But it's adding a dependency. If you need it (because you don't control the module that uses sleep) it might be a particularly good choice | 19:43 |
| leonardr | gary: it also might be a good choice since lazr.restfulclient already splits out test dependencies from regular dependencies | 19:43 |
| gary_poster | true | 19:43 |
| leonardr | gary: also, i now understand what you said originally. i'll try that | 19:44 |
| gary_poster | cool | 19:44 |
| === lifeless_ is now known as lifeless | ||
| mwhudson | The size of the diff (9540 lines) is larger than your specified limit of 1000 lines | 22:07 |
| mwhudson | woop! | 22:07 |
| mars | mwhudson, lol | 22:14 |
| === salgado is now known as salgado-afk | ||
| === ]reed[ is now known as [reed] | ||
| wgrant | mars: Hi. Do you know why we still have PlotKit and slimmer in the three? | 22:24 |
| wgrant | AFAICT they have been unused since 3.0 or earlier. | 22:24 |
| wgrant | s/three/tree/ | 22:24 |
| === matsubara is now known as matsubara-afk | ||
| mars | wgrant, sorry, I do not know. I would have to hunt for leftover traces of them in the source. sinzui would know better than I if they are still used. | 22:28 |
| wgrant | mars: I've grepped, there's nothing. | 22:29 |
| sinzui | wgrant, I wanted to remove plotkit a few months ago. I cannot remember what stopped me | 22:29 |
| sinzui | wgrant, I give you an rs=sinzui to remove them. I am certain no tests will break because they predate js tests. | 22:30 |
| wgrant | haha. | 22:30 |
| * sinzui thinks a few bug reports after the fact will spur engineers to get rid of cruft | 22:31 | |
| wgrant | I have a few other deletions of unused code, but the branch hit 10000 lines (all deletions) so I might split it. | 22:31 |
| sinzui | wgrant, I can look at it. I love reviewing deletes | 22:32 |
| wgrant | sinzui: https://code.edge.launchpad.net/~wgrant/launchpad/remove-obsolete-js-stuff/+merge/24264, if you have a moment. | 22:49 |
| * sinzui looks | 22:49 | |
| sinzui | wgrant r=me | 22:52 |
| sinzui | wgrant, Do you want me to land this now? | 22:52 |
| wgrant | sinzui: Yes please. | 22:52 |
| wgrant | sinzui: Oops, forgot to delete another copy of PlotKit. | 22:59 |
| sinzui | okay | 22:59 |
| sinzui | I was just looking for an old plotkit bug so I had not pressed enter yet | 23:00 |
| wgrant | Ah. Pushed, and already mirrored. | 23:01 |
| sinzui | bomb away | 23:02 |
| wgrant | sinzui: Were you thinking of your attempt to remove MochiKit, which PlotKit needed? | 23:04 |
| sinzui | yes I was | 23:04 |
| sinzui | there is still some complicated script using mochikit | 23:05 |
| thumper | mwhudson: talking with flacoste solved my problem for yesterday | 23:25 |
| thumper | mwhudson: a 2005 XXX comment | 23:25 |
| thumper | :) | 23:26 |
| mwhudson | thumper: woot | 23:26 |
| thumper | mwhudson: can I move a pipe in a pipeline? | 23:31 |
| thumper | mwhudson: I forgot to add --before to my add-pipe command | 23:31 |
| mwhudson | thumper: not directly afaik, but you can just remove it and add it again? | 23:32 |
| thumper | nm | 23:32 |
| thumper | yeah, that's what I did | 23:32 |
| wgrant | sinzui: I'm confused -- what is left to do for bug #44052? | 23:34 |
| mup | Bug #44052: Auto-suggest affected project based on affected package <bridging-the-gap> <package-link> <Launchpad Registry:Triaged> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/44052> | 23:34 |
| wgrant | It has done so for years. | 23:35 |
| mwhudson | any bugs developers here? | 23:35 |
| mwhudson | some bugwatch failures in db-devel | 23:36 |
| mwhudson | looks like http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10789 conflicts with a database patch in db-devel | 23:37 |
| thumper | flacoste: I've got the removal of the CustomMachine running through ec2 | 23:55 |
| thumper | flacoste: with that done, my test_traverse works in the harness now | 23:55 |
| thumper | sinzui: around? | 23:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!