[11:35] <noodles775> henninge: another one for you if/when you've time :)
[11:36] <henninge> noodles775: um, there is quite a queue and I am not ready yet ...
[11:36] <henninge> noodles775: you can append it and I will see if I can get to it.
[11:36] <henninge> I need to finish some urgent QA first, sorry.
[11:37] <noodles775> henninge: yeah, no worries, I've already got in on the queue for whoever gets there first. Good luck with the QA!
[12:01] <henninge> another staging restore .... might as well do reviews  ;)
[12:09] <henninge> sinzui's queue entry seems to have been stale.
[14:18] <bac> morning henninge.  how's it going?
[14:19] <henninge> bac: Hi! Good, thanks.
[14:20] <henninge> bac: but I won't have a great OCR throughput today ....
[14:21] <bac> henninge: that's ok
[15:41] <BjornT> abentley_: ping
[15:41] <abentley> BjornT, pong.
[15:42] <BjornT> abentley: about dailybuilds-archive. do i understand correctly, if i think that the archive column will be used only for daily builds?
[15:44] <abentley_> BjornT, correct.  When we do a daily build, we will use SourcePackageRecipe.archive as value for SourcePackageRecipeBuild.archive
[15:45] <BjornT> abentley_: how about naming it daily_build_archive to make that clear?
[15:46] <abentley_> BjornT, we might also like to use it as the default when doing a manual build.
[15:49] <abentley> BjornT, but if it gets it though review faster, I can change the name.
[15:52] <BjornT> abentley: well, it's mostly that i'd like us to have an idea of what things will be used for. the name should make this clear, so that it's easier to understand from reading the code.
[15:58] <cody-somerville> Hi :)
[15:58] <cody-somerville> Can I get some help with my branch? lp:~cody-somerville/launchpad/bug-444266/
[15:59] <cody-somerville> I created a IHasBugSupervisorEditSchema class to provide an editable field for bug_supervisor in IHasBugSupervisorEditView since bug_supervisor is defined as readoly in the IHasBugSupervisor interface.
[15:59] <BjornT> abentley: if you're ok with naming it daily_build_archive, that's ok, though. that shows a clear use, and if you find different use cases, it will be more obvious that you should rename it.
[15:59] <cody-somerville> Similar to what BranchEditSchema does to make the private field editable.
[15:59] <cody-somerville> However, I get TypeError: ('Could not adapt', <Distribution 'Ubuntu' (ubuntu)>, <InterfaceClass lp.bugs.browser.bugsupervisor.BugSupervisorEditSchema>)
[16:00] <cody-somerville> and TypeError: ('Could not adapt', <Product at 0xf7dad50>, <InterfaceClass lp.bugs.browser.bugsupervisor.BugSupervisorEditSchema>)
[16:03] <cody-somerville> :)
[16:07] <henninge> noodles775, danilo_: Can you please have a look at the first paragraph of my review for Adi and comment *if you object*? Thanks. ;) https://code.edge.launchpad.net/~adiroiban/launchpad/bug-525992/+merge/23285
[16:09] <henninge> bac: I am done. ;)
[16:09] <bac> have a good evening henninge
[16:09] <henninge> thanks
[16:11] <noodles775> henninge: I think your suggestion is a good one (stating the mode without "Enter")..
[16:11] <henninge> noodles775: ok, thanks ;)
[16:12] <henninge> noodles775: I was just thinking it could even be "You are in ... mode"
[16:17] <danilo_> henninge, I concur :)
[16:18] <henninge> cool
[16:49] <cody-somerville> I'm confused.
[16:49] <cody-somerville> Who is reviewing? bac or noodles775?
[16:50] <bac> on call: bac
[16:50] <bac> what is bac doing?
[16:50] <bac> reviewing: noodles
[16:50] <bac> clearer cody-somerville?  :)
[16:50] <cody-somerville> bac is reviewing noodles?
[16:50] <bac> indeed
[16:51] <cody-somerville> noodles775, thats not clear at all :P
[16:51] <bac> do you need a review cody-somerville?
[16:51] <cody-somerville> err..
[16:51] <cody-somerville> (sorry, auto complete)
[16:51] <cody-somerville> bac, Yes please :)
[16:51] <cody-somerville>  I created a IHasBugSupervisorEditSchema class to provide an editable field for bug_supervisor in IHasBugSupervisorEditView since bug_supervisor is defined as readoly in the IHasBugSupervisor interface.
[16:51] <cody-somerville> Similar to what BranchEditSchema does to make the private field editable.
[16:51] <cody-somerville> However, I get TypeError: ('Could not adapt', <Distribution 'Ubuntu' (ubuntu)>, <InterfaceClass lp.bugs.browser.bugsupervisor.BugSupervisorEditSchema>)
[16:51] <bac> cody-somerville: tbh you're the first person to say it has confused them in the 2 years we've used this format.
[16:51] <cody-somerville> and TypeError: ('Could not adapt', <Product at 0xf7dad50>, <InterfaceClass lp.bugs.browser.bugsupervisor.BugSupervisorEditSchema>)
[16:52] <cody-somerville> lp:~cody-somerville/launchpad/bug-444266/
[16:52] <cody-somerville> bac, Maybe it would be more clear if it listed a branch instead of a person
[16:52] <cody-somerville> bac, But to me the current topic suggests that noodles775 is reviewing and you're 'on call' to help if needed.
[16:52] <bac> cody-somerville: things to be reviewed show up at https://code.edge.launchpad.net/launchpad/+activereviews
[16:53] <bac> so if noodles only has one branch ready to be reviewed there is no ambiguuity
[16:53] <bac> cody-somerville: have you created a merge proposal?
[16:54] <cody-somerville> bac, No. My branch doesn't work so I didn't create one.
[16:54] <bac> ah, ok
[16:55]  * bac looks at branch
[16:57] <bac> hi noodles775
[17:09] <bac> cody-somerville: how do i reproduce those errors?
[17:09] <cody-somerville> ./bin/test -vvvc -tbug-release-management
[17:28] <noodles775> Hi bac
[17:37] <bac> cody-somerville: you need an adapters property on the view.  look at how it was done for BranchEditSchema
[18:14] <cody-somerville> bac, okay, I must have missed that
[18:14] <cody-somerville> bac, I'll take another look
[19:36] <bac> noodles775: ping
[20:21] <noodles775> hi bac
[20:21] <bac> hi noodles775.  bad timing -- i thought you'd gone so i just marked your MP 'abstain'
[20:33] <leonardr> bac, can i add https://code.edge.launchpad.net/~leonardr/lazr.restfulclient/retry_on_502/+merge/24252 to the queue?
[20:47] <bac> leonardr: yes
[20:47] <leonardr> cool
[20:55] <bac> leonardr: inexplicably your MP is private again.
[20:55] <leonardr> bac: fixing
[20:58] <leonardr> bac: i don't see any 'public' flag for mps. is it possible you don't belong to lazr-developers??
[20:58] <leonardr> i've asked you specifically for a review
[20:58] <leonardr> so you should be able to see it now
[20:59] <bac> actually i could see it before but noticed it was private
[20:59] <bac> now i cannot see it at all
[21:00] <leonardr> aaaargh
[21:00] <leonardr> if only i knew how to use this launchpad thing
[21:00] <bac> and i am in ~lazr-developers as are all of ~launchpad
[21:01] <leonardr> brad: ah, the _branch_ is private
[21:01] <bac> odd, the MP moved URLs when you changed it.  it now lives at https://code.edge.launchpad.net/~leonardr/lazr.restfulclient/retry_on_502/+merge/24257
[21:01] <leonardr> bac: try again, i made itp ublic
[21:01] <bac> how'd you do that?
[21:18] <bac> leonardr: what is the purpose of the BrokenApplication class in your test?
[21:19] <leonardr> bac: i think that might not be necessary anymore
[21:20] <bac> leonardr: me too
[21:20] <leonardr> yeah, i tried to do it as a class and decided it was easier as a function
[21:33] <cody-somerville> bac, woot. ty.
[21:33] <bac> np
[21:35] <cody-somerville> bac, Now, where would you recommend I add tests to set security contact and bug supervisor via API?
[21:36] <bac> cody-somerville: we cannot yet do automated tests using launchpadlib but will be able to very soon now
[21:36] <bac> until then, we use the web service directly, without the lplib wrapper
[21:36] <bac> cody-somerville: look in lp/bugs/stories/webservices
[21:37] <cody-somerville> bac, right right
[21:37] <cody-somerville> bac, but there is no doctest in there yet for this sort of thing
[21:37] <cody-somerville> bac, I'm looking for a good name to use for new doctest
[21:40] <bac> cody-somerville: i'm not familar with how the bug tests are organized right now. if they don't fit in one of the existing tests then just use your best judgment
[23:23] <adiroiban> bac: hi. I have create a new MP for bug 146178 and this one is targeted to devel (not db-deve). https://code.edge.launchpad.net/~adiroiban/launchpad/bug-146178/+merge/24265
[23:23] <mup> Bug #146178: Add links to latest full and delta language pack exported <ui> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/146178>
[23:24] <adiroiban> Should I get a new UI review?