[09:21] Hi! [09:21] OOPS [10:12] mrevell is turning into a webapp [10:13] haha === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === salgado is now known as salgado-afk === salgado-afk is now known as salgado [15:00] me [15:00] #startmeeting [15:00] Meeting started at 09:00. The chair is bac. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:00] who besides graham is here? [15:00] me [15:00] moi [15:01] and welcome to the reviewers meeting [15:01] me [15:01] bigjools, danilos: ping [15:01] o/ [15:01] koo [15:02] me [15:02] if EdwinGrubbs were here the registry team would be complete [15:03] me [15:03] me [15:03] noodles775: where's your mentat? [15:04] coming :) [15:04] me [15:04] me [15:04] me [15:04] me [15:05] bac, Gary and Leonard send their apologies [15:05] mars: thanks. did gary get hung up taking leonard to the train station? [15:05] let's get started. rounding up everyone might take longer than the meeting. [15:06] bac, he had an appointment after to go to [15:06] [topic] agenda [15:06] New Topic: agenda [15:06] * Roll call [15:06] * Agenda [15:06] * Outstanding actions [15:06] * Mentoring update [15:06] * New topics [15:06] * Reduction of negation preferred over "common case first" in if statements? [henninge, jtv] [15:06] * Peanut gallery [15:06] [topic] outstanding actions [15:06] New Topic: outstanding actions [15:06] [topic] * bac to define new doctest policy regarding what is "testable documentation". [15:06] New Topic: * bac to define new doctest policy regarding what is "testable documentation". [15:07] i must roll this to next week. [15:07] [topic] * henninge to update the style guide regarding multi-line parameters in function defns and calls. [15:07] New Topic: * henninge to update the style guide regarding multi-line parameters in function defns and calls. [15:07] bac: done ;) [15:07] henninge: any progress? [15:07] yay [15:07] [topic] * bac to write community reviewer and contributor policy and announce it on the list. [15:07] New Topic: * bac to write community reviewer and contributor policy and announce it on the list. [15:08] i've started this email but haven't finished. hope to send it off today or tomorrow. [15:08] * bac 0 for 2 [15:08] me [15:08] [topic] * henninge to update style guide regarding readability and 'if not condition' tests. [15:08] New Topic: * henninge to update style guide regarding readability and 'if not condition' tests. [15:08] bac: that's old, we discussed it last week. [15:08] I mentioned in the style guide, too. [15:08] henninge: we discussed it but you said you'd write it up [15:08] bac: I did ;-) [15:09] ok, great. thanks henninge. you're a model of german efficiency. [15:09] oh, that's still action items ... [15:09] I wish ... [15:09] so we have no other new items to discuss [15:09] [topic] peanut gallery [15:09] New Topic: peanut gallery [15:09] anyone have a new issue to raise today? [15:10] hey i forgot to ask how the mentoring is going. noodles and jelmer? [15:11] from my pov, jelmer is doing great... just learning the process really... how do you feel jelmer ? [15:11] noodles775: ? [15:11] I think it's going well too. [15:11] jelmer: have you been kept busy reviewing? [15:11] bac: Not really, I've mostly actually reviewed other Soyuz branches so far. [15:12] and one from Translations! ;) [15:12] jelmer: your day is thursday, right? [15:12] bac: Yep, but I've been on leave two thursdays in the last month or so. [15:13] right. we'll try to get you some non-soyuz branches. [15:13] so, any other issues? [15:13] There's still quite some things that noodles775 catches that I didn't spot, but I'm sure that'll get better over time. [15:13] let's end early then. [15:13] #endmeeting [15:13] Meeting finished at 09:13. [15:13] thanks [15:13] thanks bac [15:13] thanks bac [15:14] Cheers bac [15:14] thanks bac [15:14] * bac tries to remember the asiapac meeting this week... [15:14] thanks bac [15:15] thanks bac === salgado is now known as salgado-afk === salgado-afk is now known as salgado-lunch === salgado-lunch is now known as salgado === salgado is now known as salgado-lunch === EdwinGrubbs is now known as Edwin-lunch === salgado-lunch is now known as salgado === Edwin-lunch is now known as EdwinGrubbs === salgado is now known as salgado-afk [23:04] bac: when is the reviewer meeting? [23:05] thumper: well, it should've been 30 minutes ago...if i hadn't gotten caught up in something else [23:05] thumper: how is now? [23:05] fine for me [23:05] damn i can't believe i've spaced out three weeks in a row [23:05] mwhudson, rockstar? [23:05] wgrant: ? [23:05] * rockstar looks up [23:05] reviewer meeting time [23:06] hello [23:06] #startmeeting [23:06] me [23:06] Meeting started at 17:06. The chair is bac. [23:06] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [23:12] UI reviews do have a reputation for being a PITA, usually because they are done too late in the review process. [23:12] But that shouldn't excuse us from not doing UI reviews. [23:12] agreed [23:12] Or even doing ui=rs [23:12] rockstar: i'll admit we've gotten a little lax. i did a review for mrevell yesterday and could've insisted on a UI review but didn't. (it *was* pretty simple) [23:12] (which I used recently with thumper, and felt okay about it since it's not available UI anywhere but dev) [23:13] bac, there's no reason why he couldn't have done ui=rs then. [23:13] rockstar: are y'all still doing ui reviewers meetings? [23:13] rockstar: ec2 land definitely doesn't support that... [23:13] bac, well, we just had our last call for now. Our group is taking things to the launchpad-dev list now. [23:14] (for transparency as well) [23:14] bac: with lp-land you can edit the string :) [23:14] bac, if the tools don't work, we should fix them. [23:14] thumper: true. rockstar: agreed [23:15] i think the larger issue is getting a UI review if you really need one. [23:15] Yeah, reviewers should either say "put my name down as ui reviewer" or "go get a ui review" [23:15] perhaps just a gentle reminder will work. [23:15] bac, ack. [23:15] * rockstar was poet and didn't realize it. [23:15] rockstar: would you like to send out such an email or do you want me too? [23:16] bac, I'd be happy to. [23:16] nice, thanks [23:16] [action] rockstar to kick some butt re: ui reviews [23:16] ACTION received: rockstar to kick some butt re: ui reviews [23:17] y'all have anything else to chat about? [23:17] yep [23:17] just landed in r10800 of devel we have two new testing bits [23:17] test_traverse in lp.testing.publication [23:17] which given an url, will return a tuple of (object, view, request) [23:17] it hooks into the zope publication method [23:18] to do exactly what normal browser traversal would do [23:18] this is then used in the update BaseBreadcrumbTestCase [23:18] so you can get breadcrumbs for an object [23:18] neat [23:18] without having to fake the traversed objects [23:18] also I'd like an action point to remind people [23:18] not to put new code in canonical.launchpad [23:19] I moved the test case to lp.testing.breadcrumbs [23:19] from canonical.launchpad.webapp.tests [23:19] Yay thumper [23:19] thumper you'll be happy i followed rockstar's example today and moved the registry javascript out of there [23:19] \o/ [23:19] i think we're the only two apps to do so [23:20] it's a start [23:20] bac, awesome. [23:20] my change to the breadcrumb tests required quite a lot of fixing [23:20] yeah, it's hard to believe the big migration was last march and we still have so much cruft [23:20] bac, did you have any problems with that? [23:20] as I had to fix all the existing test_breadcrumbs [23:20] rockstar: no, just hunting down all of the relative paths to change [23:20] even found one real bug [23:21] that was not being tested as it should have been [23:21] thumper i did too. [23:21] I wish we had a unittest school to help people learn how to write better unittests [23:21] thumper: perhaps you can lead us at the epic [23:21] hah [23:21] I'd defer to mwhudson or jml [23:22] I've learnt a huge amount from them [23:22] seriously it would be a good topic [23:22] it would [23:22] we should do something like that [23:22] if only jml weren't so shy about public speaking [23:22] hahaha [23:22] anything else? [23:22] I don't think so [23:23] i'd like to apologize for missing the meeting lately. last week i got super frustrated and left to go biking, completely forgetting about this meeting [23:23] i'll try not to do it again [23:23] please ping me if you remember [23:23] i guess i won't be attendng after this one [23:24] mwhudson: you're always welcome to drop by... [23:24] mwhudson: hope the new assignment is fun [23:25] bac: so do i! [23:25] rockstar and thumper thanks for bringing up those points. i'll take them back for discussion in the bigger group. [23:25] mwhudson: I guess it depends on how much LP work you acdtually do [23:25] i need to run. ttyl. [23:25] yeah [23:25] #endmeeting [23:25] Meeting finished at 17:25. [23:25] bac: bye for now [23:25] thanks bac