| cody-somerville | bac, https://code.edge.launchpad.net/~cody-somerville/launchpad/bug-444266/+merge/24273 | 00:47 |
|---|---|---|
| mwhudson | thumper: https://code.edge.launchpad.net/~mwhudson/launchpad/unregister-bzr-git/+merge/24279 ? | 03:10 |
| mwhudson | thumper: um, please insert "can you review" in there | 03:10 |
| thumper | :) | 03:12 |
| thumper | done | 03:17 |
| === wgrant changed the topic of #launchpad-reviews to: On call: bac || reviewing: - || queue: [bigjools,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === wgrant changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [bigjools,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| mwhudson | thumper: another one? https://code.edge.launchpad.net/~mwhudson/launchpad/code-import-workers-copy-too-much/+merge/24282 | 04:31 |
| thumper | mwhudson: I'm almost done with breadcrumbs | 05:25 |
| thumper | mwhudson: want to review | 05:25 |
| thumper | ? | 05:25 |
| mwhudson | thumper: ok | 05:26 |
| thumper | mwhudson: why does reading other teams code make me want to cry? | 05:29 |
| mwhudson | thumper: i don't knpw | 05:29 |
| thumper | distroseries.hide_all_translations = BoolCol... | 05:29 |
| mwhudson | !! | 05:30 |
| mwhudson | thumper: hang on, why is that so bad? | 05:31 |
| mwhudson | apart from being sqlobject-y | 05:32 |
| thumper | they weren't setting it to False in their tests | 05:32 |
| mwhudson | oh | 05:32 |
| thumper | just awaiting diff | 05:38 |
| thumper | https://code.edge.launchpad.net/~thumper/launchpad/code-import-machine-breadcrumb/+merge/24286 | 05:38 |
| thumper | mwhudson: the generated diff is missing the last commit | 05:39 |
| thumper | mwhudson: which deletes an obsolete method | 05:39 |
| mwhudson | thumper: i was grabbing the branch to look at in meld anyway | 05:39 |
| thumper | mwhudson: ok | 05:39 |
| thumper | the branch has been pushed | 05:40 |
| thumper | I have my guitar lesson soon, so I'm afk | 05:40 |
| mwhudson | ok | 05:41 |
| thumper | stub: review poke for abentley | 05:46 |
| stub | k | 05:51 |
| === noodles775 changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [bigjools,wgrant,noodles] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | stub, Thanks for the review; I've replied and updated the patch. | 09:58 |
| stub | k | 09:59 |
| stub | gmb: have you pushed? | 10:31 |
| gmb | stub, Hahahaaha. Durr. | 10:31 |
| gmb | stub, Have pushed now. | 10:32 |
| gmb | This may be a sign that I have too much blood in my caffeine system. | 10:32 |
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || reviewing: - || queue: [bigjools,wgrant,noodles] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jtv | noodles775: ready for review at last... would you mind? | 12:01 |
| jtv | https://code.edge.launchpad.net/~jtv/launchpad/bug-569108/+merge/24297 | 12:01 |
| noodles775 | jtv: not at all, can we swap? | 12:01 |
| noodles775 | (I'd appretiate your thoughts on the refactoring branch I've got. It's a bit confusing as its one in a pipeline). | 12:02 |
| jtv | noodles775: sure... I think I'll relocate away from this road my embassy told me to stay away from, and I can read your branch on the way | 12:02 |
| noodles775 | jtv: thanks. It doesn't need to be today (given the time etc.) | 12:02 |
| jtv | noodles775: actually I was _supposed_ to OCR today, so might as well make a decent effort | 12:03 |
| noodles775 | :) | 12:03 |
| jtv | (Actually it's a bit insane for my embassy to warn me away from this road; it goes all the way to the next city, and the battle happened miles away & hours ago) | 12:05 |
| noodles775 | sheesh | 12:05 |
| jtv | They keep doing that: "Bombs went off in X and Y sometime before your family halfway around the world asked you about them. We recommend that you stay away from bombs." | 12:08 |
| jtv | There's just no keeping up with the electronic grapevine. :) | 12:08 |
| noodles775 | heh | 12:08 |
| jtv | Speaking of grapevine: word is only one dead, soldier, friendly fire. | 12:11 |
| jtv | Confusion because of the rain. Maybe they got a little trigger-happy with those flashy new Israeli assault rifles I saw them with... bullpup, so easy to point the wrong way. | 12:11 |
| jtv | And in other news: my girlfriend managed to get out of there. :-) | 12:12 |
| noodles775 | Some good news then! | 12:12 |
| === mrevell is now known as mrevell-lunch | ||
| === matsubara-afk is now known as matsubara | ||
| jml | hello | 13:02 |
| jml | https://code.edge.launchpad.net/~jml/launchpad/more-tests-for-ec2/+merge/24309 -- easy peasy review | 13:03 |
| === jml changed the topic of #launchpad-reviews to: On call: allenap || reviewing: - || queue: [bigjools,wgrant,noodles,jml] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === mrevell-lunch is now known as mrevell | ||
| === salgado is now known as salgado-afk | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || reviewing: bigjools || queue: [bigjools,wgrant,noodles,jml] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || reviewing: wgrant || queue: [wgrant,noodles,jml] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || reviewing: noodles || queue: [jml] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | BjornT, I made the name change you requested to the database patch. If that's sufficient, could you mark it approved, please? | 14:17 |
| BjornT | abentley: yes of course, it was already conditionally approved, even though it wasn't marked approved | 14:18 |
| abentley | BjornT, Ah. I thought so, but I wanted to make sure. | 14:18 |
| allenap | noodles775: I'm looking at 567922-binarypackagebuild-packagebuild-2. Is it worth getting this reviewed by someone who knows this area? I'm happy to continue, but I'm probably not going to be able to give you more than a syntax and style check. | 14:28 |
| noodles775 | allenap: yeah, I chatted with jtv earlier and he said he'd be happy to take a look, so feel free to leave it with him. | 14:28 |
| allenap | noodles775: Okay, cool. | 14:29 |
| === allenap changed the topic of #launchpad-reviews to: On call: allenap || reviewing: jml || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === noodles775 changed the topic of #launchpad-reviews to: On call: allenap || reviewing: jml || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado-afk is now known as salgado | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: allenap, Edwin || reviewing: jml || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === allenap changed the topic of #launchpad-reviews to: On call: allenap, Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === deryck is now known as deryck[lunch] | ||
| cody-somerville | allenap, Would you be willing to review https://code.edge.launchpad.net/~cody-somerville/launchpad/bug-444266/+merge/24273 ? | 16:30 |
| allenap | cody-somerville: Yeah, sure :) | 16:30 |
| === allenap changed the topic of #launchpad-reviews to: On call: allenap, Edwin || reviewing: cody-somerville, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | rockstar, could you please review https://code.launchpad.net/~abentley/launchpad/fix-build-time-display/+merge/24263 ? | 16:36 |
| rockstar | abentley, on it | 16:37 |
| abentley | rockstar, thanks. | 16:37 |
| adiroiban | danilos: hi, whan you have time, can you take a quick look over the changes from the branch attached to bug 548375 | 16:46 |
| mup | Bug #548375: Rosetta import empty strings (e.g. "") from .po files <rosetta-imports> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/548375> | 16:46 |
| === salgado is now known as salgado-afk | ||
| === salgado-afk is now known as salgado-lunch | ||
| rockstar | abentley, I'm not sure TestSourcePackageRecipeBuildView should inherit from BrowserTestCase - TestCaseWithFactory is probably fine. | 16:55 |
| rockstar | I say this because it doesn't actually use a browser, but just instantiates a raw view. | 16:55 |
| abentley | rockstar, Okay. | 16:56 |
| rockstar | abentley, r=me | 16:57 |
| === salgado-lunch is now known as salgado | ||
| danilos | heh, a thought occurred to me: shall we consider moving x-es for closing pop-ups in LP to the left side? :) | 17:02 |
| rockstar | danilos, I wondered that while working on the overlay yesterday. :) | 17:05 |
| === deryck[lunch] is now known as deryck[afk] | ||
| === salgado is now known as salgado-lunch | ||
| maxb | eww | 17:20 |
| maxb | No, leave the Xes in the right place :-) | 17:21 |
| maxb | pun intentional | 17:21 |
| === EdwinGrubbs is now known as Edwin-lunch | ||
| danilos | rockstar, abentley: hi, do you guys know if it'd be safe to upgrade bzr-git to the latest lp:~launchpad-pqm/bzr-git/devel revision? If so, can you give me an ok on https://code.edge.launchpad.net/~danilo/launchpad/bug-570728/+merge/24340? | 17:56 |
| rockstar | danilos, I saw that bug you commented on. | 17:56 |
| danilos | rockstar, cool, can you let me know if it's ok to merge the change? | 17:57 |
| rockstar | danilos, do you know if this will actually fix your issue? I don't see jelmer confirm that in the bug. | 18:02 |
| danilos | rockstar, I don't know how to check but jelmer did say on IRC that this is a fix for that bug | 18:02 |
| rockstar | danilos, okay. | 18:03 |
| danilos | rockstar, well, that "he committed a fix on bzr-git tree" | 18:03 |
| danilos | jelmer, is there a way I can check latest bzr-git fixes it for the branch from the bug 570728? | 18:03 |
| mup | Bug #570728: Importing git repo from http://git.participatoryculture.org/miro/ fails <Bazaar Git Plugin:Fix Released by jelmer> <Launchpad Bazaar Integration:In Progress by danilo> <https://launchpad.net/bugs/570728> | 18:03 |
| rockstar | danilos, r=me | 18:04 |
| === allenap changed the topic of #launchpad-reviews to: On call: Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| danilos | rockstar, thanks | 18:04 |
| === matsubara is now known as matsubara-lunch | ||
| danilos | rockstar, just one more question before I head home: is it possible to QA this on staging later? (i.e. are there imports happening on staging, or is it just a simple script run once I set it up in the UI) | 18:10 |
| rockstar | danilos, yes, it can be QA'd on staging. I remember last time I needed to do it, it took some LOSA help, but that was a while ago. | 18:14 |
| danilos | rockstar, cool, thanks | 18:14 |
| === salgado-lunch is now known as salgado | ||
| jelmer | danilos: sorry, was off to the shops. are you still there? | 19:01 |
| danilos | jelmer, yeah, otp though | 19:02 |
| === matsubara-lunch is now known as matsubara | ||
| jelmer | danilos: other than QA'ing you can use bzr-git locally to test if it works | 19:02 |
| danilos | jelmer, how to best test it? | 19:07 |
| danilos | jelmer, (i.e. I see bzr-receive-pack and bzr-upload-pack and have no idea what to do with them) | 19:09 |
| jelmer | danilos: bzr branch lp:~launchpad-pqm/bzr-git/devel ~/.bazaar/plugins/git; bzr branch http://git.participatoryculture.org/miro/ miro | 19:11 |
| danilos | jelmer, ah :) | 19:11 |
| jelmer | danilos: assuming you have the right version of dulwich installed | 19:11 |
| === Edwin-lunch is now known as EdwinGrubbs | ||
| bac | hi EdwinGrubbs, could you review https://code.edge.launchpad.net/~bac/launchpad/bug-561586/+merge/24355 | 19:59 |
| EdwinGrubbs | bac: The bug doesn't mention this, but at some point "lp." needs to be prepended to the argument to YUI.add() and Y.namespace(). Of course, that is a lot more work, because you have to change all the imports. If you don't want to do that now, we should make sure there is a bug about that. | 20:04 |
| bac | EdwinGrubbs: it seems like not that much work. i'll do it now and add a note to the current bug | 20:05 |
| EdwinGrubbs | bac: I don't have any other comments about your current diff. | 20:06 |
| bac | thanks EdwinGrubbs. i'll get back to you shortly with the incremental | 20:07 |
| bac | EdwinGrubbs: i've made the namespace changes to https://code.edge.launchpad.net/~bac/launchpad/bug-561586/+merge/24355 and included an incremental diff | 20:57 |
| bac | EdwinGrubbs: could you review it please? | 20:57 |
| EdwinGrubbs | sure | 20:57 |
| bac | hi sinzui | 21:16 |
| bac | sinzui: you reviewed and approved the ui for adi for this MP https://code.edge.launchpad.net/~adiroiban/launchpad/bug-146178/+merge/23760 | 21:17 |
| bac | sinzui: i pointed out to him it was incorrectly targeted to db-devel so he resubmitted to https://code.edge.launchpad.net/~adiroiban/launchpad/bug-146178/+merge/24265 | 21:17 |
| bac | sinzui: could you mark the latter one UI approved? | 21:17 |
| EdwinGrubbs | bac: r=me | 21:18 |
| bac | thanks EdwinGrubbs | 21:18 |
| sinzui | done | 21:19 |
| === deryck[afk] is now known as deryck | ||
| === salgado is now known as salgado-afk | ||
| flacoste | EdwinGrubbs: care to review https://code.edge.launchpad.net/~flacoste/launchpad/cleanup/+merge/24367 | 22:29 |
| flacoste | or anyone else | 22:29 |
| flacoste | it's a pure-removal branch | 22:29 |
| EdwinGrubbs | flacoste: sure | 22:29 |
| EdwinGrubbs | flacoste: r=me | 22:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!