=== matsubara is now known as matsubara-afk
=== mrevell is now known as mrevell-lunch
=== salgado-afk is now known as salgado
=== matsubara-afk is now known as matsubara
=== bac changed the topic of #launchpad-reviews to: **Paste your diffs for review due to scanning 18k mavrick branches ** On call: bac || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[13:32] <bac> henninge: you reviewing today, nominal as it is?
[13:33] <henninge> bac: oops, forgot ;)
[13:33] <bac> henninge: i suspect its a quiet day
[13:33] <bac> interrupted by panic
[13:33] <henninge> ;-)
=== henninge changed the topic of #launchpad-reviews to: **Paste your diffs for review due to scanning 18k mavrick branches ** On call: bac, henninge || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:13] <matsubara> bac, hi, available for a review?
[14:13] <bac> matsubara: yes, of course
[14:13] <matsubara> bac, https://code.edge.launchpad.net/~matsubara/launchpad/bug-553361-no-referrer/+merge/24506
[14:19] <bac> matsubara: r=bac, with one tiny fix
[14:22] <matsubara> thanks bac
[14:42] <leonardr> bac, henninge: i have a wadllib branch (based on james_w code) that didn't get reviewed yesterday. can you take it? https://code.edge.launchpad.net/~leonardr/wadllib/fix-bind-to-anon-collection/+merge/24613
[14:43] <henninge> bac: can you take that please? I am in the middle of something else.
[14:43]  * henninge guesses that bac is in the middle of something, too ... ;)
[14:43] <leonardr> there's no huge rush, but i would like to get it reviewed today
[14:45] <henninge> leonardr: I will give it a try later ;)
[14:53] <noodles775> abentley: hi! I've sent two incrementals to the branch you reviewed for me yesterday... but understand if you don't have time atm :)
[14:53] <abentley> noodles775, I'm having a look at one of them right now.
[14:54] <bac> henninge, leonardr: sorry i was on our stand up call.  leonardr i can review your branch now.
[14:54] <leonardr> bac, thanks
[14:54] <noodles775> abentley: great, thanks! Just note: I realised with the second one that I don't need the Mixin that I created on the first.
[14:54] <abentley> noodles775, ah, okay.
=== Ursinha is now known as Ursinha-lunch
=== salgado is now known as salgado-lunch
=== leonardr is now known as leonardr-afk
[16:51] <noodles775> Hi bac, I've got one here if you've time, but I won't be around to do the review interactively: https://code.edge.launchpad.net/~michael.nelson/launchpad/567922-binarypackagebuild-new-table-2/+merge/24688
[16:51] <bac> noodles775: ok
=== bac changed the topic of #launchpad-reviews to: **Paste your diffs for review due to scanning 18k mavrick branches ** On call: bac, henninge || reviewing: leonardr || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[16:52] <noodles775> thanks bac  (or henninge) :)
[16:55] <bac> leonardr-afk: done
=== bac changed the topic of #launchpad-reviews to: **Paste your diffs for review due to scanning 18k mavrick branches ** On call: bac, henninge || reviewing: - || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-lunch
=== henninge is now known as henninge-afk
=== salgado-lunch is now known as salgado
=== Ursinha-lunch is now known as Ursinha
=== leonardr-afk is now known as leonardr
=== matsubara-lunch is now known as matsubara
=== bac changed the topic of #launchpad-reviews to: **Paste your diffs for review due to scanning 18k mavrick branches ** On call: bac, henninge || reviewing: noodles || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: **Paste your diffs for review due to scanning 18k mavrick branches ** On call: bac || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== Ursinha is now known as Jorjao
=== Jorjao is now known as Ursinha
=== matsubara is now known as matsubara-afk
=== salgado is now known as salgado-afk
=== salgado is now known as salgado-afk