[02:22] persia: ok, so tomorrow is patch day,who does the starting delights? :) [02:33] err, today rather [03:04] bdrung: just reminding you that patch day starts today :) [03:08] nhandler: ^ [03:08] who else to remind now [03:08] Thanks nigelbabu [03:08] Where is the schedule? [03:09] https://wiki.ubuntu.com/PatchDay [03:09] thanks [03:40] nigelbabu: One thing we might want to do is poke the next reviewer when it gets close to their turn [03:49] good to see all the slots filled now [07:24] good morning [11:05] Patch Day! Patch Day! Patch Day! [11:05] So, this is the beginning of patch day. The 5th of May is slowly winding itself over the globe. [11:06] Who all's here? [11:06] * vish never seen persia so excited ;) [11:07] hey vish. [11:07] hi.. [11:09] hey persia [11:10] Hey BlackZ. [11:10] So, 330 outstanding patches seeking quick review: https://bugs.launchpad.net/~ubuntu-reviewers/+subscribedbugs [11:10] Let's get that down to 0 by the end of today. We've almost 50 hours, so if we can do better than one patch every 10 minutes, we win!. [11:16] hi all [11:16] Hey slytherin, popey. Welcome! [11:16] :-) [11:16] o/ [11:16] So the list of patches we're trying to clear today is https://bugs.launchpad.net/~ubuntu-reviewers/+subscribedbugs [11:17] https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide is a guide to how we review the patches. [11:17] There's other informative links in the /topic if you're curious :) [11:18] hey ppl - I've never done patch review before but I'm willing to give it a shot :) is there anything I can help with? [11:18] kermiac: Absolutely. We've a little over 300 patches we're targeting today. [11:19] https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide is the procedure we're using: just grab any bug to which ~ubuntu-reviewers is subscribed, and have at it. [11:19] yay , knocked one out.. [11:19] ok, I'll have a look. Thanks persia :) [11:20] Hurrah vish! [11:21] persia: hmm , Bug #111939 , has the debdiff , earlier sponsors [ bdrung ] mentioned there was no debdiff , but now we have one , we can unsubscribe the reviewers and subscribe the sponsors right? also nigelbabu has spoken about this bug to didrocks [11:21] Malone bug 111939 in metacity "Not possible to alt-tab during a drag-and-drop operation" [Unknown,Confirmed] https://launchpad.net/bugs/111939 [11:22] vish: Needs a maverick patch at this point, as well. [11:22] ah.. ok [11:24] vish: If yo'd like, you can probably easily convert nigelbabu's lucid-proposed debdiff to maverick, and then drop it from our queue. Looks like it's already upstream, so would probably benefit from some tags. [11:24] hm, what needs to be done on bug 154349? correct the tags? [11:24] Malone bug 154349 in synaptic "synaptic won't remember certain preferences" [Undecided,Confirmed] https://launchpad.net/bugs/154349 [11:25] yofel: Looks like it's tags only there, yeah. [11:25] yofel: Might be able to just drop from the queue, depending on the upstream status of the patches. [11:26] mvo merged it into lucid but not trunk yet (as said on https://code.edge.launchpad.net/~oliver-joos/synaptic/lp154349/+merge/23250) [11:26] would that be accepted or sent? [11:27] I think just patch-forward-upstream: needs to have been merged to be patch-accepted-upstream [11:27] ok [11:28] remove the patch tag or leave it? [11:29] vish: yes (subscribing ubuntu-sponsors) [11:29] leave it. Otherwise it just gets added again and the team resubscribed. [11:29] ok [11:29] persia: hmm , i think nigelbabu already has the debdiff for that too.. [11:29] nigelbabu: do the review team recommend DEP-3? [11:30] * persia didn't see if, but if it's there, yeah, bdrung is right. [11:30] ah yay.. bdmurray just replied ;) [11:30] oopd bdrung ^ [11:30] bdrung: We don't really care: we focus on getting patches to upstream, mostly. [11:31] bdrung: https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide#Workflow [11:31] persia: getting patches upstream does not conflict with using DEP-3 header. [11:31] persia: tagged, the workflow says to unsubscribe the reviewers team now, can you do that? [11:32] bdrung: Right, but we don't insist on it: we assume that it's best to pass the patch around with appropriate attribution, regardless of the format. DEP-3 is more important in the context of getting a patch applied as a distro-patch than in the context of ensuring communication with usptream is happening. [11:32] yofel: Sure. 154349, right? [11:32] yes [11:32] yofel: Done. [11:32] thanks :D [11:32] next one... [11:32] Damascene: Are you finding everything you need? [11:33] persia: yes. IMO a reference or recommendation for DEP-3 in the reviewguide would be nice. [11:34] persia, I found out that I'm not a member of bugsquad nor understand how to make .deb files [11:34] * yofel didn't know about DEP-3, will read it later [11:34] bdrung: Do you really think it's relevant for patches that aren't being applied at a distro-level? [11:35] persia: i think it's useful. You have the link to launchpad in the patch. [11:36] OK. You do know that we don't expect patch authors to read the reviewers guide, right? [11:37] persia: yes. the member of the review team could add the header (at least when he/she creates a debdiff) [11:37] But generally we *don't* create debdiffs. [11:37] We mostly just forward the patches upstream. [11:39] (the exception being patches to distro-patches or packaging, but those don't generally get DEP-3 anyway) [11:40] persia: so where the patch comes from upstream via the debian maintainer, and it's only SRU material (mysql), does the review team need to be subscribed? [11:40] ajmitch: In cases like that it's be nice of us to debdiffise it and push to sponsors, but not, that doesn't need us to do anything. [11:41] s/not/no/ [11:41] well it's being handled by a server team member [11:41] * ajmitch isn't in the team, so can't unsub [11:41] In that case, we don't need to care about it at all: just add the tags (patch-accepted-upstream, etc.) and move on. [11:41] bug 343870 if you want to take it off the list [11:41] Malone bug 343870 in mysql-dfsg-5.1 "php-cli segmentation fault with mysql extension" [Medium,Confirmed] https://launchpad.net/bugs/343870 [11:42] Sure. [11:42] Done. [11:43] * dholbach adds ajmitch [11:43] dholbach: Thanks! [11:44] blogged about it too http://daniel.holba.ch/blog/?p=678 [11:44] dholbach: ta [11:45] hey duanedesign! [11:45] how would one handle bug 251335? part of the patch was accepted, part of it needs work, the bug is tagged as patch-needswork already [11:45] Malone bug 251335 in synaptic "Synaptic searches on UI thread" [Medium,Confirmed] https://launchpad.net/bugs/251335 [11:47] yofel: I'd probably call that "patch-forwarded-upstream" and "patch-needswork". [11:48] yofel: Shall I unsub the team for that one? [11:48] I think yes (at least that's what I believe after reading the review guide) [11:49] Done. [12:00] So we've finished the first hour of patch day, and are already 6% complete. At this rate, we'll be done in 16 hours! [12:01] persia: the 312 that's showing is a bit high, too [12:02] as multiple bug tasks on the same bug show up in the list [12:02] ajmitch: Sure, but since I started with the 330 number (also a bit high), I figure it's only fair to compare against that. [12:03] * persia tries to convince LP to provide a more correct number [12:03] * ajmitch tries to decide what to do about this bug [12:03] Which bug? [12:04] bug 551901, it's sort-of-but-not-quite upstreamed [12:04] Malone bug 551901 in krb5 "likewise-open fails to join Windows 2000 SP4 domain" [Medium,Confirmed] https://launchpad.net/bugs/551901 [12:04] again, being handled by the server team people :) [12:04] * ajmitch is going for familiar territory in the list [12:05] Probably the same: needs tagging, and unsubscription. Bugs well-in-hand tend to just need gentle poking. [12:05] ok [12:06] I think I'll get back to this tomorrow, a little late for me to think straight this evening [12:07] Thanks! Have a good night. [12:07] https://bugs.launchpad.net/ubuntu/+bugs?field.subscriber=ubuntu-reviewers seems to be the URL for the lower-number (but I don't have the count from the start of Patch Day). 201 now. [12:08] Anyone looking for instructions, or buglists? [12:08] nigelbabu: Are you about? [12:11] persia: can you unsubscribe the team from bug 33288? nigelbabu seems to have forgot about it (and should one re-ad the patch tag for those bugs?) [12:11] Malone bug 33288 in poppler "Evince doesn't handle columns properly" [Unknown,Confirmed] https://launchpad.net/bugs/33288 [12:11] yofel: I don't see the point of re-adding the patch tag, personally. [12:12] ah wait, there's no patch on it anymore right [12:12] dholbach: Could you add yofel to the team? He seems to have a good handle on the process :) [12:12] yofel: is your launchpad id yofel too? [12:12] yep [12:13] super [12:13] Thanks. [12:13] done [12:15] thanks :D [12:26] * persia pokes nigelbabu again [12:27] Hey hyperair! [12:27] hey persia =) [12:29] hyperair: Would you be up for starting a bit early? nigelbabu doesn't seem to be about. We're down to 200 according to https://bugs.launchpad.net/ubuntu/+bugs?field.subscriber=ubuntu-reviewers and 309 acording to https://bugs.launchpad.net/~ubuntu-reviewers/+subscribedbugs (from 201 at 11:00 and 330 at 10:00) [12:29] heh? it's already review day? [12:30] =O [12:31] i need to be running at 9pm, though, it seems. [12:31] that'd be in 1.5h [12:31] * hyperair goes to grab some dinner first [12:32] Of course, and you're listed as next on https://wiki.ubuntu.com/PatchDay :) [12:32] Of course, and you're listed as next on https://wiki.ubuntu.com/PatchDay :) [12:32] i swear i thought that was 24h from now. [12:32] The 5th of May is creeping around the globe :) [12:32] oh looks like i put my name in for today as well! [12:32] =O [12:33] okay i'll go look at things [12:33] Looks like you're also scheduled for 24h from now. [12:33] yes, i am [12:33] * hyperair kicks java [12:33] uh what do i do if launchpad decides to hate me today? [12:34] it's been hating me a lot recently [12:34] Ask for help? Lots of folks are active and doing stuff, so if you can't get somewhere, I'm sure someone else can. [12:35] Main thing you need to do during your shift is make sure people know about https://bugs.launchpad.net/ubuntu/+bugs?field.subscriber=ubuntu-reviewers and https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide and answer any questions that come up. [12:36] also, maybe good to post statistics at the top of each hour, and make sure you coordinate with the next person on the schedule when the time comes. [12:39] okay [12:39] Thanks for starting early! [12:49] persia: is there an easy way to filter only bugs affecting packages *i* can upload to? [13:00] I'm here, sorry to be late [13:01] \o/ [13:01] hyperair: you're on now? [13:03] hi nigelbabu [13:03] hey yof [13:03] nigelbabu: no, you're on. [13:04] hyperair: ok. the wiki shows you, since you covered for me, gladly [13:04] can someone double check bug 202009? IMO that's not a patch, but a scritpt that somehow workarounds the issue changing the default and user settings while at it [13:04] Malone bug 202009 in grub "update-grub not updating menu.lst" [Medium,Confirmed] https://launchpad.net/bugs/202009 [13:04] heya yofel (didn't tab earlier) [13:05] hyperair: Not that I know. [13:05] persia: =( [13:08] when do the patch-day start? [13:08] r0tes_pf3rd: we've started already [13:09] oh, cool [13:09] how can i help? [13:10] r0tes_pf3rd: You can help by reviewing patches. I'll point you the documentation so you can start off [13:10] https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide [13:10] 182 untouched bugs to go, so there's still plenty out there :) [13:11] ok, i will look on the page [13:11] yofel: I think we have something similar to that grub bug already [13:11] i.e. a fix is already in I think [13:12] from karmic on I remember only 1 kernel being displayed on boot [13:14] hey jono [13:15] hyperair: you cool for next hour? [13:15] nigelbabu: well, I do remember the discussions about menu.lst not updating in karmic, but I'll leave the bug handling to someone that knows a bit more about grub, do you agree though that that's not a patch? [13:15] nigelbabu: unfortunately not. got a meeting at 9pm (45min from now) [13:15] hyperair: wait, so you're taking care of this hour or you want me to? [13:16] yofel: agreed there, its a new script [13:16] nigelbabu: er. up to you, which do you prefer? [13:17] hey BlackZ [13:17] hyperair: I did around 20 minutes to prepare a presention for UOW, either now or next hour [13:17] s/did/need [13:17] alright, go do it, i'll handle this hour =) [13:17] hyperair: thank you, poke if you need something, I should be around :) [13:17] nigelbabu: sure. [13:18] * hyperair regrets not remembering set theory and curses java's weird transformation API [13:36] anyone think its worth it to update review lead on topic? [13:41] dholbach: about? [13:57] * persia thinks it's not worth updating the /topic for every change, as it's likely to be more flexible than scheduled. [13:59] yeah, hence I didn't d it [13:59] do it [14:00] hyperair: ok, taking over :) [14:00] Folks, 180 bugs unreviewed in the queue. [14:00] I'll be the review lead for the next few hours [14:04] bdrung: I've been lazy to follow dep-3 on that metacity bug since I wanted someone to first test [14:12] persia: do we want to advertise in -bugs and -motu every 6 hours or so? [14:12] hello fschrat [14:12] I'd say 4, but sure. [14:12] persia: hm 4 is fine too :) [14:13] malev: hey, nice to see you here, Patch day is today! [14:15] * hyperair grumbles [14:15] hello everyone [14:15] i spent all my time trying to test that chkrootkit patch [14:15] turns out chkrootkit hung trying to read /proc/kmsg [14:15] hi nigelbabu ! I'll start in a few minutes [14:15] hyperair: awesome [14:15] fschrat: hey, welcome [14:16] malev: great :) [14:34] persia: can take a look at http://launchpadlibrarian.net/40823731/vncExtInit.cc.patch ? [14:34] isn't the patch file formatted wronly ? [14:39] No, just differently. We're used to looking at the output of `diff -u ...`: that's the output of `diff ...` [14:42] oh, ah [14:42] looks like I need to test tht bug [14:51] what would be the call on bug 424927? leave it for jfo? [14:51] Malone bug 424927 in linux "include CK patch set (BFS)" [Wishlist,Confirmed] https://launchpad.net/bugs/424927 [14:53] nigelbabu: yes [14:53] Indeed. It's in one of the blacklisted packages, but left over from before the blacklist was in place. [14:54] oh, then I have some cleaning to do [14:56] dholbach: you'll be around for my session right, just in case I cna't handle questions [14:57] nigelbabu: around that time I was planning to meet somebody for dinner :-/ [14:57] nigelbabu: what about bdmurray and james_w and bryce? [14:58] dholbach: I'll talk to james [14:58] better ping all of them :) [14:58] yeah, good idea [14:59] bdmurray, james_w: My UOW session on patch review is at 1700, if you folks can be around to help with questions, would be great :) [15:00] nigelbabu: I have an idea for when the patch day is over: we could start making a list of bugs that were solved where the patch reviewers put some time into fixing them and we blog "the story of these patches" later on [15:00] (a bit like https://wiki.ubuntu.com/BugSquad/Diaries) [15:01] dholbach: I'm +1, I actually want to ask brian for a tar of all the mails in moderate on the patch review m/l during patch day [15:02] moderation queue [15:02] dat way we can know who did what [15:06] Status update: 172 unreviewed bugs [15:08] heya arand :) [15:09] nigelbabu: Hello, hmm, I'm likely not going to be of much help, but I though I might listen and learn, it that is ok? [15:09] arand: sure :) [15:23] ok, good news [15:24] we have gone below 170 mark [15:24] 167 unreviewed bugs [15:28] hello there dyfet [15:29] would you like to help with patch review? [15:30] I would be happy to try [15:30] dyfet: great! you can go through https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide [15:30] please ask if you have any qiestions [15:31] there is always a review lead here till the end of patch day [15:45] heya qense [15:46] we're down to 160 unreviewed bugs folks :) [15:46] hi nigelbabu! [15:46] qense: patch day today! [15:46] My congratulations to the review team! [15:46] aha! [15:48] qense: another 40 hours or so to go [15:48] meh, what's the policy if someone adds an upstream patch to a bug? [15:48] Huh? How long is your definition of a day? [15:49] yofel: if its integrated upstream, add patch-accepted-upstream [15:49] ok [15:49] qense: a day in all time zones, 49 hours [15:50] Good idea :P [15:50] So for my timezone the day's actually tomorrow! [15:50] qense: haha [15:52] for me too, but who cares :P [15:52] qense: see, you should be inspired by yofel :D [15:52] I'm already working very hard on Mergimus! [15:53] Even though it's not Write an App-day! [15:53] qense: lol [15:55] starcraftman: /ws 29 [15:55] grrr [16:04] anyone choose a patch as they want or there is a sort of order or something like that? [16:05] malev: have you seen the query link on review guide [16:05] just take a pick from that query [16:05] it should show you all unreviewed patches [16:05] this is the query: All open bugs with patches attached: https://launchpad.net/ubuntu/+bugs?field.searchtext=&orderby=-importance&search=Search&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field.s [16:05] ubscriber=&field.component-empty-marker=1&field.tag=&field.tags_combinator=ANY&field.status_upstream-empty-marker=1&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_no_package.used=&field.has_patch.used=&field.has_patch=on&field.has_branches.used=&field.has_no_branches.used=&field.has_no_branches=on ? [16:06] sorry, it's a big query [16:06] I'm here: https://wiki.ubuntu.com/ReviewersTeam/KnowledgeBase [16:06] and I take the query from there [16:07] not that one, let me find it [16:07] malev: click on query here https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide#Workflow [16:09] malev: to start off you can go with bug 569469 [16:09] Malone bug 569469 in update-manager "[lucid] program crashes when string "%s ago" is displayed" [Medium,Fix committed] https://launchpad.net/bugs/569469 [16:09] it seems easy enough [16:10] nigelbabu, oks! going there [16:13] malev: so, what do you make of the situation there [16:13] I'm trying to reproduce the bug [16:14] oh there is nothing to reproduce, it's only bad english :D [16:14] gonna check the patch [16:17] nigelbabu, which branch should I download to chech the patch? [16:18] malev: I'm just checking tht up [16:18] malev: https://launchpad.net/update-manager [16:19] yes, but, if you go to branches, there are a lot! which onw [16:19] the development? [16:19] or the lucid? [16:19] https://code.launchpad.net/ubuntu/+source/update-manager [16:20] if you notice the bug, mvo talks about trunk [16:21] so you should check the trunk brach [16:21] cool [16:23] nigelbabu, you are giving a talk in a few minutes? [16:23] malev: the 3rd session today [16:27] malev: if you didn't find the commit yet, its commit 1807 [16:27] nigelbabu, I'm downloading the branch. It0's REALLY solw [16:28] yes, because of maverick stuff [16:31] malev: when hunting for commits, its easier on the web interface [16:31] nigelbabu, might be, but, how can I test the patch if I don't use it? [16:32] string changes are kinda easy to predict looking at the code :) [16:34] bdrung: poke [16:37] anyone got a minute to look at bug 491940? would that be accepted or needswork o.O? LTSP seems to be happy with the patch, Chris not [16:37] Malone bug 491940 in ltsp "Patch for LTSP clients to properly reboot/shutdown" [Undecided,Confirmed] https://launchpad.net/bugs/491940 [16:38] and are we seriously supposed to get subscribed just to package a patch? (not that I mind, I'm just not sure there) [16:40] yofel: yes, thats part of we do [16:41] packaging patches [16:41] lauchpad is down? [16:41] good [16:42] yofel: talk to chris and hear his take on it (especially after lxde accepted a similar patch) [16:42] malev: checking [16:42] malev: nope [16:42] don't now is working [16:45] nigelbabu, I donwload the trunk and it's on commit 1817 ten more than what the web site says... [16:46] * nigelbabu stabs loggerhead [16:49] malev: what is 1807 about? [16:49] I'm with the patch of update-manager. I can't aply the patch. don't know why [16:49] 1 out of 1 hunk FAILED -- saving rejects to file Desktop/UpdateManager1.py.rej [16:49] bzr: ERROR: Patch application failed [16:50] I think I'm using a different branch [16:52] malev: you can't apply because the code changed [16:52] mvo applied another change to fix the same issue [16:53] and second thing, look at the path you're trying to patch, it doesn't exsit [16:53] that is what I was looking now! [16:53] well, I'm going to try to create another patch with a good path :D [16:53] I start enjoying this :D [16:53] malev: you dont need to, it would still fail [16:54] because like I said, mvo already fixed it :) [16:54] ooo too bad [16:54] then I'll close the bug :( [16:54] no no [16:54] just change tag to patch-rejected [16:55] say in comments that another fix for this has been commited already [16:55] because.. it's all ready fixed [16:55] oks [16:55] thanks [16:55] getting a feel for the process now? [16:55] haha [16:55] I think [17:03] there are some bug reports with doesn't has a patch attached but has the patch tag. should I delete the tag? [17:03] bug number? [17:05] sometimes a patch is just pasted into a comment, check for those too, or the patch is upstream and only a link to the commit is given [17:08] Status update: 155 bugs to be reviewed === yofel_ is now known as yofel [17:12] Hey I am in a BR that: It has a bug, but there is newer verstions in which it is fixed. so the OR recomend us to apply the patch or to update the version provided. what do you whink? [17:12] https://bugs.launchpad.net/ubuntu/+source/python-scipy/+bug/538774 [17:12] Malone bug 538774 in python-scipy "scipy.io.loadmat() excessively slow (regression)" [Undecided,Fix committed] [17:19] malev: there is not talk of an upstream commit, ask OP for a link to upstream commit to confirm its fixed [17:20] nigelbabu, ok [17:52] cyphermox: all yours in 10 minutes [17:53] and be ready to handle a huge influx after the UOW session [18:04] yup [18:37] hi! [19:12] status update, 154 unreviewed bugs [20:51] nigelbabu: pong [21:17] hi [21:18] I'm customizing a Ubuntu distro for distance learning, and the main point is to apply online tests. I would like to know if there is someone involved to version control in Ubuntu, mainly related to "what/how it happens" when canonical upgrade a ubuntu version like from 9.10 to 10.04. I would like to upgrade my distro and keep an easy control of everything modified. [22:59] well, I have to get going, sorry I can't stick around longer [23:12] morning all :) [23:16] cyphermox: Sorry about that. [23:17] Good morning ajmitch [23:18] how's the patch day going? [23:18] I see you're booked in for an extra-long session now [23:20] Depends on how one counts. Down to 277/175 bugs left to track 12 hours in. [23:21] Yeah, seems like nobody else was up for being the named contact during these hours :) [23:24] sorry, it sort of falls in my work hours as well :) [23:25] Understood. Mine too, but I don't mind answering some questions on IRC (and expect the number of folk around to be light for most of it) [23:27] yes, thanks for stepping up todo it [23:28] nigelbabu has a handy way of helping people up the steps :) [23:33] OOh. only 152 bugs by another count. I defintely need to use the right queries, I think. [23:33] which count are you using now? [23:34] 152 is the number from the query at https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide#Workflow [23:35] ok, so that doesn't show the tasks fixed in ubuntu but still pending in debian, which is probably what we want [23:36] It also doesn't show a lot of the bugs that have already been properly tagged and forwarded, etc. [23:37] I should clear up that krb5 one that I asked you about last night [23:38] and apt-xapian-index, I can ask upstream about that directly [23:39] it's useful to have a few active developers in the NZ loco channel [23:39] quite a few of us are DDs in there [23:40] Indeed. [23:47] I have to run off for a bit: I'll definitely answer any unanswered questions when I return. Apologies for anyone who gets stuck in the meantime. [23:48] * ajmitch will be around, sort of [23:48] Thanks :)