[14:02] <wgrant> noodles775: Thanks.
[14:02] <noodles775> Always a pleasure wgrant :)
[16:41] <abentley> rockstar, thanks!
[16:41] <rockstar> abentley, no problem sir.
[17:01] <mars> rockstar, ping, have room for a quick review?  a dozen new lines of code, some refactoring of the windmill test layer setup: https://code.edge.launchpad.net/~mars/launchpad/turn-on-windmill-debug-logging/+merge/24839
[17:01] <rockstar> mars, please add yourself to the queue.
[17:02] <mars> !take_ticket
[17:02] <mars> ;)
[17:03] <rockstar> mars, every time I'm on call reviewer, I always think that we need a bot to handle the queue...  I just never actually get around to making one.
[17:03] <mars> likewise
[17:21] <mars> rockstar, I'm off to lunch, back in an hour and a bit.
[17:36] <rockstar> abentley, the UI looks good for the SPRB.  Is there a way I can walk through actually building a source package recipe, or do I just have to mess with the database?
[17:36] <abentley> rockstar, you just have to mess with the db.
[17:37] <rockstar> abentley, okay.
[17:37] <rockstar> abentley, So I guess that means that I won't have a build log I can access from +files then?
[17:38] <abentley> rockstar, I just create an LFA manually.
[18:07] <rockstar> abentley, your indentation on lines 428-431 of the diff is wonky.
[18:53] <rockstar> mars, does reset_logging undo all of this logger buggery you're doing here?
[18:59] <mars> rockstar, it does
[19:00] <mars> rockstar, BaseLayer calls it as well, but I did this because it is more visible and explicit
[19:00] <rockstar> mars, what does safe_hasattr do?
[19:01] <mars> rockstar, doesn't eat exceptions.  Builtin hasattr does (fun fun!)
[19:02] <rockstar> mars, why not just use getattr?
[19:02] <mars> rockstar, what line?
[19:02] <mars> 96
[19:03] <rockstar> mars, yes.
[19:04] <mars> rockstar, it might be because hasattr will tell you that an attribute exists.  getattr may return None, but you can't tell if that is the attribute's value, or the default argument.
[19:04] <mars> or the default argument to getattr()
[19:06] <rockstar> mars, okay.  As long as you feel you're using the right call here, I'm happy with that.
[19:06] <bac> rockstar: can i add one to your queue?
[19:06] <rockstar> bac, absolutely.
[19:06] <bac> https://code.edge.launchpad.net/~bac/launchpad/bug-574493/+merge/24853
[19:08] <mars> rockstar, not my code, so it should work :)
[19:09] <mars> rockstar, that is one of the code blocks I extracted into its own method
[19:09] <mars> personal choice: I dislike 300 and 400 line method definitions, even if they are linear.
[19:10] <mars> if there are comments that say "# now we do this" followed by "# then we do that", then it is pretty good sign that you can extract a method
[19:11] <mars> but, like I said, that's personal preference
[19:12] <rockstar> mars, I think you've made the code clearer by breaking it up.
[19:12] <mars> cool, thanks :)
[19:16] <rockstar> mars, I'd like to do your review and then move on to bac's, but launchpad is apparently down right now.
[19:17] <mars> :(
[19:29] <mars> rockstar, page is back up.  Do I have r=rockstar?
[19:29] <rockstar> mars, indeed you did as of a few minutes ago.
[19:30] <mars> rockstar, cool, thank you
[19:31] <rockstar> bac, is this a private branch?
[19:31] <bac> rockstar: it is
[19:32] <abentley> rockstar, could you please review https://code.edge.launchpad.net/~abentley/launchpad/no-default-powerpc/+merge/24855 ?
[19:32] <rockstar> abentley, sure.
[19:47] <rockstar> abentley, I'm going to eat lunch, then I'll get to your branch immediately following.
[19:48] <abentley> rockstar, sure, no rush.  Thanks for your other review.
[20:01] <mars> rockstar, dumb question: ec2 land does run the test suite before submitting to PQM, right?
[20:03] <mars> bac, ^ ?
[20:03] <bac> yes
[20:03] <mars> bac, ok, thanks.  Updating the docs: if you can believe it, no one actually bothered to mention that fact, anywhere.
[20:04] <bac> really?  since it evolved out of 'ec2 test' i guess it was just assumed
[20:05] <mars> 'ec2 help land' doesn't mention it.  I just updated LandingChanges so it does say that.
[20:57] <abentley> mars, however, if you want to land without testing, "bzr lp-land" from the bzr-pqm plugin will do that for you.
[20:58] <mars> abentley, yep, thanks.  I've used that before, and it is very convenient.
[20:59] <abentley> mars, cool.  It's basically the same code.
[21:14] <rockstar> abentley, had I known it was that small, I would have done that before lunch!  :)
[21:14] <abentley> rockstar, :-)
[21:15] <abentley> I prefer my rockstars happy and well-fed.
[21:16] <abentley> rockstar, chat soon?
[21:16] <rockstar> abentley, well-fed == sleepy  :)
[21:16] <rockstar> abentley, sure, lemme send this email or thumper will lynch me.
[21:16] <abentley> rockstar, okie.
[22:11] <jtv> barry: see the update for the lazr.batchnavigator review?  https://code.launchpad.net/~jtv/lazr.batchnavigator/bug-574159/+merge/24577