=== barry` is now known as barry_
=== danilos changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [danilo] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== leonardr changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [danilo, leonardr] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== leonardr changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [danilo, leonardr, leonardr] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: - || queue: [leonardr, leonardr] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: leonardr || queue: [leonardr] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: leonardr || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:25] <bigjools> intellectronica: ping
[14:26] <intellectronica> bigjools: yo
=== intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: stevenk || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:27] <bigjools> intellectronica: just wondering if you were still reviewing Steve's branch?  I am going to approve it since I am familiar with what's going on, might save you some time :)
[14:28] <intellectronica> bigjools: great! was just starting on it, and it will be great not to have to go on :)
=== intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:28] <bigjools> intellectronica: yeah  it's a typical Soyuz branch, you don't need that pain
[14:28] <intellectronica> bigjools: thanks!
=== sinzui changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:29] <sinzui> intellectronica, I have a simple branch that I hope you have time to review
[14:29] <intellectronica> sinzui: just started on a branchlet from deryck but will look at yours as soon as i finish that
[14:29] <sinzui> thanks
[14:35] <leonardr> intellectronica, thanks for thos reviews
[14:38] <intellectronica> leonardr: yer welcome
[14:40] <intellectronica> sinzui: is it the oopsless-repr branch?
=== intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:40] <sinzui> intellectronica, it is
[14:40] <intellectronica> cool, on it
[14:43] <intellectronica> sinzui: is it not the case that encode('ASCII'... will raise an exception if you feed it stuff it can't encode?
[14:43] <intellectronica> sinzui: or is that taken care of completely by 'backslashreplace'?
[14:43] <sinzui> intellectronica, yes.
[14:44] <intellectronica> sinzui: yes, the latter? :)
[14:44] <sinzui> intellectronica,  'backslashreplace' replaces all the unicode possitions
[14:44] <intellectronica> cool
[14:45] <sinzui> We know the field is unicode, so if 'backslashreplace' fails, we have a deeper problem in the app
[14:46] <intellectronica> sinzui: r=me
[14:46] <sinzui> thanks
=== jelmer_ is now known as jelmer
=== gary_poster_ is now known as gary_poster
[15:50] <mars> intellectronica, room for a trivial cleanup branch?  https://code.edge.launchpad.net/~mars/launchpad/trivial-add-ec2-xxx/+merge/24927
[15:50] <intellectronica> mars: sure
[15:50] <mars> thanks
[15:51] <mars> intellectronica, FYI, then branch was reviewed earlier by Gary, but I made some post-review cleanups that need to be checked over.  The branch is still tiny though.
[15:51] <intellectronica> mars: cool, on it
=== intellectronica changed the topic of #launchpad-reviews to: On call: intellectronica || reviewing: mars || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:52] <intellectronica> mars: r=me
[15:52] <mars> great, thanks Tom :)
=== matsubara is now known as matsubara-lunch
=== gary_poster is now known as gary-lunch
=== matsubara-lunch is now known as matsubara
=== intellectronica changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== gary-lunch is now known as gary_poster
=== matsubara is now known as matsubara-afk
=== barry` is now known as barry_