[00:13] <jelmer> thumper: done
[00:13]  * jelmer -> sleep
[00:13] <thumper> ta
[07:45] <jtv> morning henninge!
[08:26] <jtv> morning danilos
[08:27] <danilos> jtv, good morning
[11:41] <wgrant> noodles785: Hi. Can you be convinced to at some point formally UI review https://code.edge.launchpad.net/~wgrant/launchpad/diffs-in-queue/+merge/25135? It's the change we discussed yesterday.
[11:54] <noodles785> wgrant: sure... since we've already sat and chatted about it :)
=== noodles785 changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [bigjools, noodles] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[11:59] <noodles785> wgrant: why not include the "diff from .." in your PackageDiffFormatterAPI so that it's included inside the link?
[12:00] <wgrant> noodles785: Right, I sort of pointed that out yesterday. If you look at https://edge.launchpad.net/ubuntu/+archive/primary/+sourcepub/1107215/+listing-archive-extra, you'll see the other place it is used.
[12:01] <wgrant> I'm not sure that the 'diff from' is appropriate there, though I don't really care.
[12:01]  * noodles785 checks.
=== jelmer changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [bigjools, noodles, jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara-afk is now known as matsubara
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: EdwinGrubbs || reviewing: - || queue: [bigjools, noodles, jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:15] <EdwinGrubbs> sinzui, can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-562486-pending-gpg-keys/+merge/25154
[15:16] <sinzui> yes
=== Ursinha is now known as Ursinha-afk
=== sinzui changed the topic of #launchpad-reviews to: On call: EdwinGrubbs || reviewing: - || queue: [bigjools, noodles, jelmer, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== sinzui changed the topic of #launchpad-reviews to: On call: EdwinGrubbs || reviewing: - || queue: [bigjools, noodles, jelmer, sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[16:36] <gary_poster> rockstar: would you be willing to do a rubber stamp review of a change you already approved for bac?  You approved for production-devel before; now we need it for devel.  https://code.edge.launchpad.net/~gary/launchpad/loggerheadlogout/+merge/25108
[16:36] <rockstar> gary_poster, rs=me
[16:36] <gary_poster> thanks rockstar
[16:37] <rockstar> gary_poster, no problem.
[16:45] <EdwinGrubbs> bigjools, which branch did you want to have reviewed?
[16:46] <bigjools> EdwinGrubbs: I should not be in the queue, danilos forgot to remove me when he removed my branch yesterday :)
=== bigjools changed the topic of #launchpad-reviews to: On call: EdwinGrubbs || reviewing: - || queue: [noodles, jelmer, sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[16:46] <bigjools> s/removed/reviewed/
[16:46] <bigjools> meh
[16:46] <danilos> bigjools, yeah, push the blame onto me for helping you :P
[16:47] <bigjools> lol
[16:47] <bigjools> danilos: you're an awesome guy
[16:52] <noodles785> Hi EdwinGrubbs, will you get a chance to review my branch? https://code.edge.launchpad.net/~michael.nelson/launchpad/567922-binarypackagebuild-new-table-4/+merge/25138
[16:53] <noodles785> I won't be around much longer though, so if email is an option?
[17:02] <EdwinGrubbs> noodles785, I'll start on it now
[17:06] <danilos> jtv, r=me, but I don't think you really need another approval from Bjorn for a single-line change
[17:06] <jtv> danilos: come to think of it, it's a single-line test change innit
[17:06] <jtv> danilos: should I land the same on devel btw?
[17:06] <danilos> jtv, sure
[17:08] <EdwinGrubbs> noodles785, I get some conflicts when I merge your branch into the latest db-devel.
=== matsubara is now known as matsubara-lunch
[17:21] <noodles785> EdwinGrubbs: please see the note on the MP regarding the conflicts. If you want to run the tests, you can branch it directly... is that OK?
[17:23] <noodles785> If not it's no problem, it can wait a few days until I can pump through an up-to-date db-devel and resolve the conflicts.
[17:26] <EdwinGrubbs> noodles785, that's fine, I was just letting you know.
[17:34] <EdwinGrubbs> noodles785, r=me
[17:34] <EdwinGrubbs> sinzui, which branch would you like me to review first?
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: EdwinGrubbs || reviewing: sinzui || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[17:34] <sinzui> EdwinGrubbs, the css fix will make jtv and mars happy
[17:36] <EdwinGrubbs> sinzui, r=me
[17:36] <sinzui> thanks
=== Ursinha-afk is now known as Ursinha
=== matsubara-lunch is now known as matsubara
[18:17] <EdwinGrubbs> sinzui, registry/browser/tests/project-add-views.txt has an error.
[18:17] <sinzui> oh?
[18:18]  * sinzui is running test
[18:19] <sinzui> yes, it has an error
[18:20]  * sinzui rewrites test for happy from/to addressees and see if that is the real issue
[18:21] <sinzui> ah...two emails
[18:23] <sinzui> EdwinGrubbs, I can update the test to show the two emails, but I think it is duplicating the unittest. The doc test says it is verifying the license info rule, and that was verified a few lines above
[18:28] <sinzui> EdwinGrubbs, This is the diff to include the email to the user and fix the addressee in the email to me: http://pastebin.ubuntu.com/432348/
[18:32] <rockstar> EdwinGrubbs, can I jump on your queue?
[18:36] <rockstar> EdwinGrubbs, I need to go run some lunch errands, but when you have the bandwidth, here's my proposal: https://code.edge.launchpad.net/~rockstar/launchpad/enable-edge-recipe-builds/+merge/25175
[18:36] <rockstar> (I'm figuring you're at lunch)
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: EdwinGrubbs || reviewing: sinzui || queue: [sinzui, rockstar] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[18:59] <EdwinGrubbs> sinzui, yep, that fixes it for me
[18:59] <EdwinGrubbs> rockstar, I'll get to your review later
[19:00] <rockstar> EdwinGrubbs, okay.  I have it playing in ec2 now so that I know the tests pass.  I need to get this on edge tonight though.
[19:00] <rockstar> (They're demoing it at UDS tomorrow)
[19:01] <EdwinGrubbs> ah
[19:07] <EdwinGrubbs> rockstar, r=me
[19:26] <jtv> danilos: ec2 tests are still running.  Shouldn't be long now, but I don't think I can hold out.
[19:27] <danilos> jtv, sure, just get it CPed in the morning and it's fine (Bjorn has approved it, so do indicate that to spm)
[19:27] <jtv> cool, thanks
[19:27] <jtv> did the loganberry patch fix our generation jobs?
[19:28] <danilos> jtv, I think it did (I've seen it in the log, but then twistd rotated logs and I can't find it anymore)
[19:29] <jtv> Would be really, really nice to know that it did :)
[19:31] <danilos> jtv, it seems the log file for the period is missing
[19:32] <jtv> The computer hates us.
[19:33] <danilos> jtv, 2010-05-12 19:27:34+0100 [-] Starting templates build proba-3443818 for lp:php-gettext/proba.
[19:33] <danilos>  (another try)
[19:34] <danilos> jtv, now if I only knew how to watch the build
[19:34] <jtv> danilos: launchpad.net/builders
[19:34] <danilos> jtv, woohoo, it's working on samarium
[19:35]  * jtv hugs danilos
[19:35] <danilos> jtv, https://edge.launchpad.net/builders/samarium
[19:35] <jtv> Of course my mis-typing it as smarmium doesn't exactly enhance the dignity of this special moment
[19:36]  * danilos hugs jtv back, now if it also gets a branch and produces a POT file it'll be a very special moment for mankind
[19:36] <jtv> danilos: what's the project?
[19:36] <danilos> jtv, php-gettext, I've did it on my project so I can remove the series later :)
[19:36] <danilos> jtv, branch is from libgnomeui
[19:36] <danilos> jtv, build is finished
[19:37] <jtv> danilos: no pots on its queue :(
[19:37] <danilos> jtv, I think it first needs to get to process-upload step
[19:38] <jtv> danilos: no idea how long that takes...
[19:38] <danilos> jtv, something is still not working there
[19:38] <jtv> The buildd-master logs should have more.  However it's bedtime for me!
[19:39]  * jtv sneaks off
[19:41] <danilos> jtv, good night
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: EdwinGrubbs || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[19:45] <EdwinGrubbs> sinzui, review sent
=== EdwinGrubbs is now known as Edwin-lunch
[19:47] <sinzui> thanks
=== matsubara is now known as matsubara-afk
[22:35] <thumper> rockstar: https://code.edge.launchpad.net/~thumper/launchpad/fix-factory-ids-in-tests/+merge/25037