| === Ursinha is now known as Ursinha-afk | ||
| === barry` is now known as barry_ | ||
| === barry` is now known as barry_ | ||
| === matsubara-afk is now known as matsubara | ||
| === gmb changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [gmb(http://bit.ly/dAaTnb), gmb(http://bit.ly/cUeBk0)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === NCommander is now known as Guest79402 | ||
| === gmb changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [gmb(http://bit.ly/dAaTnb), gmb(http://bit.ly/cUeBk0), gmb(http://bit.ly/cTVRv6)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | jtv: why are you doing slave_status.get('filemap'), rather than get('filemap', None)? | 14:24 |
|---|---|---|
| jtv | noodles775: what would that do for me? | 14:25 |
| noodles775 | That's where I'm confused - I can see from your test that it works when filemap is not present as a key... | 14:25 |
| noodles775 | jtv: nm... | 14:26 |
| jtv | noodles775: to make sure I understand you correctly... you're just talking about passing a second parameter to dict.get, right? | 14:26 |
| === bac` is now known as bac | ||
| noodles775 | None is the default... | 14:26 |
| noodles775 | r=me | 14:26 |
| jtv | noodles775: thanks | 14:28 |
| * noodles775 goes back to hacking at UDS. | 14:28 | |
| === wgrant changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [gmb(http://bit.ly/dAaTnb), gmb(http://bit.ly/cUeBk0), gmb(http://bit.ly/cTVRv6), wgrant)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jtv is now known as jtv-zzz | ||
| === matsubara is now known as matsubara-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| === noodles775 changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [gmb(http://bit.ly/dAaTnb), gmb(http://bit.ly/cUeBk0), gmb(http://bit.ly/cTVRv6), wgrant, noodles775)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === noodles775 changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [gmb(http://bit.ly/cUeBk0), gmb(http://bit.ly/cTVRv6), wgrant, noodles775)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === noodles775 changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [gmb(http://bit.ly/cUeBk0), wgrant, noodles775)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === rockstar changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [gmb(http://bit.ly/cUeBk0)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === rockstar changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: - || queue: [gmb(http://bit.ly/cUeBk0)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === gary_poster is now known as gary-lunch | ||
| === gary-lunch is now known as gary_poster | ||
| rockstar | sinzui, can I get you to review the Branches->Code change? | 20:01 |
| rockstar | https://code.edge.launchpad.net/~rockstar/launchpad/branches-code/+merge/25249 | 20:01 |
| sinzui | yes | 20:02 |
| rockstar | sinzui, fank you. | 20:03 |
| sinzui | rockstar, I pondered the tooltips in the app menu several times | 20:04 |
| sinzui | rockstar, summary = 'The Code Bazaar' vs 'View related code'. look to be different messages for the samething | 20:05 |
| sinzui | I doubt there are any tests for the summary because our toolstips are often missing or contradictory | 20:06 |
| rockstar | sinzui, "The Code Bazaar" was for code.launchpad.net itself I thought. | 20:06 |
| rockstar | So "View related code" for no context doesn't make sense. | 20:07 |
| sinzui | rockstar, can project have recipes? | 20:10 |
| rockstar | sinzui, project can't, but product can (and does) | 20:10 |
| rockstar | sinzui, project may, in the future, but I can't see a sane use case for it. | 20:10 |
| sinzui | lib/lp/registry/browser/product.py's summary says branches | 20:10 |
| sinzui | Do you want to revise it to 'code', add 'recipes', or ignore it | 20:11 |
| rockstar | sinzui, probably ignore it for now. | 20:11 |
| rockstar | sinzui, frankly, I didn't even know there WERE summaries until I saw the code. | 20:12 |
| rockstar | I think the purpose of the tabs is that they shouldn't need explanation... | 20:12 |
| sinzui | rockstar, bug 211117 | 20:12 |
| mup | Bug #211117: Tooltips on sections don't always show <ui> <launchpad-web:Triaged> <https://launchpad.net/bugs/211117> | 20:12 |
| sinzui | We should have summaries for every case, and they should help the user, not confuse him | 20:13 |
| sinzui | rockstar, This bug keeps appear when I listen to user complaints. I have not been able to scope it. I do not know all the places that summaries are missing or wrong | 20:14 |
| rockstar | sinzui, yeah, working on the tab stuff, I see why that could be. | 20:15 |
| sinzui | You have an opportunity to fix a few. As I said, you could say "Get Nutella crepes at the bazaar" in everyone and no test will break, but at least they will all be consistent. | 20:15 |
| rockstar | sinzui, truthfully, I think there was a lot of duplication of code for cases where we only wanted to change a summary for a tab or link to another subdomain. | 20:15 |
| rockstar | sinzui, okay, I'm happy to fix those. | 20:15 |
| sinzui | r=me. what you have is fine to land. if you see a summary you want to fix, go ahead | 20:16 |
| rockstar | sinzui, okay, I'll see if I can fix it. | 20:22 |
| === rockstar changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| thumper | rockstar: I don't like "The Code Bazaar" | 21:26 |
| thumper | too esoteric | 21:26 |
| rockstar | thumper, I don't either. | 21:26 |
| thumper | rockstar: aye | 22:21 |
| === Edwin-lunch is now known as EdwinGrubbs | ||
| === matsubara is now known as matsubara-afk | ||
| wgrant | rockstar: Hm, why was I dropped from the queue? | 22:55 |
| rockstar | wgrant, because the queue is something managed by the OCR, not by people needing reviews. | 23:15 |
| rockstar | wgrant, I've been a stickler about it, and reminded everyone a few weeks back in the reviewer meeting that OCR does not mean "review lackey" It is the reviewee's job to get a review, not the reviewer's job to just take an existing queue and do it. | 23:16 |
| wgrant | rockstar: Perhaps the documentation is lacking. | 23:25 |
| wgrant | I cannot find a definition of how OCR works. | 23:25 |
| rockstar | wgrant, well, it's mostly a social definition, but one that we've been lacking in letting other people know about. | 23:40 |
| rockstar | wgrant, basically, it's just polite to say things like "Can I get into your queue?" | 23:41 |
| rockstar | wgrant, basically, it's not the job of the reviewer to go find reviews. It's the job of the reviewee to find someone to do the review, regardless of whether they use the on call reviewer or not. | 23:41 |
| wgrant | rockstar: Yeah, I normally try to do that, except it often fails because there are no reviewers near my timezone (or in this case there was no EU reviewer, and I was at dinner when you appeared) | 23:42 |
| rockstar | wgrant, yeah, I understand that. I'm kinda being a pedant specifically to make the point that reviewees don't just say "Review my patch, bitch!" and it's gets reviewed. :) | 23:44 |
| === Ursinha is now known as Ursinha-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!