| lifeless | elmo: ok | 00:00 |
|---|---|---|
| lifeless | so we need to discuss with apache a bit more | 00:00 |
| elmo | leonardr/lifeless: unless we can guarantee the patch will go into upstream or at least ubuntu, I'd need to be convinced the maintenance cost would be justified | 00:00 |
| leonardr | lifeless: in the meantime, would you mind if i applied my lazr.restful-based workaround? | 00:01 |
| lifeless | leonardr: of course; I think I wouldn't have asked these questions though, if you'd had a reference to the upstream state of discussion in the patch. | 00:02 |
| lifeless | e.g. bug <url> is tracking the issue and apache are currently undecided about whether to fix this or not | 00:02 |
| leonardr | lifeless: fair enough. i did link to the apache bug in my lazr.restful branch, but i didn't discuss it in any detail, and also there are two branches | 00:03 |
| lifeless | elmo: I'd like to see it go into Ubuntu regardless; its nuts to do a half-job the way it does. | 00:04 |
| thumper | lifeless: hey | 00:05 |
| thumper | lifeless: voice would probably be easier if you have skype | 00:05 |
| lifeless | I do | 00:29 |
| lifeless | popping out to the doctors to register here etc, back soon | 00:30 |
| lifeless | ok | 00:50 |
| lifeless | thumper: so, skype? | 00:55 |
| thumper | lifeless: in a kiwipycon committee meeting right now | 00:55 |
| lifeless | ok | 00:55 |
| lifeless | this arvo perhaps, then. | 00:55 |
| lifeless | its really just curiosity about what worked/didn't work with the unique stuff for you. | 00:55 |
| thumper | yep | 00:56 |
| === matsubara-afk is now known as matsubara | ||
| thumper | mwhudson: where do we update the rev numbers of the sourcecode dirs? | 01:43 |
| mwhudson | thumper: utilities/sourcedeps.conf | 01:43 |
| thumper | ta | 01:43 |
| thumper | bzr uncommit; bzr shelve; bzr pull ../db-devel -r ancestor:../production-devel/ --overwrite | 01:52 |
| lifeless | sounds like you wanted rebase? | 01:53 |
| thumper | probably | 01:53 |
| thumper | it didn't work anyway | 01:53 |
| thumper | lifeless: what should I use? | 01:53 |
| lifeless | what are you trying to do ? | 01:55 |
| thumper | I created the branch from devel -r ancestor:production-devel | 01:56 |
| thumper | but what I wanted was db-devel -r ancestor:production-devel | 01:56 |
| thumper | so now I have a branch which I want to replace the history of | 01:56 |
| lifeless | IIRC | 01:57 |
| lifeless | make the new branch | 01:57 |
| lifeless | use replay with a -r selector to replay your revisions from the branch you want to redo | 01:57 |
| thumper | it is one revision which I could trivially recreate | 01:57 |
| thumper | I was just thinking there'd be a way | 01:58 |
| wgrant | Yeah, it's easy with rewrite as lifeless says. 'bzr rebase -r-1.. ../production-devel' should do it. | 02:00 |
| wgrant | replay sort of goes the other way. | 02:01 |
| thumper | wgrant: from the bzr-rebase plugin I take it | 02:02 |
| lifeless | bzr-rewrite | 02:03 |
| wgrant | But the package is bzr-rebase. | 02:06 |
| thumper | gee that isn't confusing is it | 02:06 |
| lifeless | blame jelmer | 02:07 |
| thumper | lifeless: call now? | 02:16 |
| lifeless | sure | 02:17 |
| thumper | mwhudson: going to land https://code.edge.launchpad.net/~mwhudson/launchpad/unregister-bzr-git/+merge/24279 ? | 03:27 |
| mwhudson | thumper: it failed tests | 03:37 |
| mwhudson | so um, maybe? | 03:37 |
| thumper | ah | 03:57 |
| === Ursinha is now known as Ursinha-afk | ||
| lifeless | mwhudson: what fails ? | 04:51 |
| * thumper back later tonight to talk to europeans | 05:57 | |
| adeuring | god morning | 08:17 |
| thekorn | hi adeuring, bryceh: is it possible to get a typo fixed before https://code.edge.launchpad.net/~bryceharrington/launchpad/api-doc-fixes/+merge/24786 gets merged? | 08:38 |
| thekorn | line 10 of the diff has 'whcih' | 08:38 |
| bryceh | hrm | 08:38 |
| bryceh | thekorn, the ec2 instance to land the change just now completed | 08:39 |
| bryceh | (not sure what that means in terms of being able to make changes) | 08:39 |
| adeuring | bryceh: did you run "ec2 land" or "ec2 test -s"? in that case, your branch should soon appear in PQM | 08:40 |
| thekorn | ah ok | 08:40 |
| bryceh | adeuring, I ran ec2 test earlier today (with no -s), and then did ec2 land | 08:41 |
| adeuring | bryceh: ok; in this case, the branch should be in PQM. Or have passed PQM | 08:42 |
| bryceh | if it's too late to include the spelling fix this time through, I do plan on doing another docs fix and can include that fix with it | 08:42 |
| noodles775 | q bryceh | 08:43 |
| noodles775 | :) | 08:43 |
| wgrant | Can someone please ec2 land https://code.edge.launchpad.net/~wgrant/launchpad/diffs-in-queue/+merge/25135 and https://code.edge.launchpad.net/~wgrant/launchpad/bug-558905-get-archive/+merge/25300? They both disappeared overnight. | 08:49 |
| wgrant | Although I see that WindmillLayer has been killed off now, so these runs should work! | 08:50 |
| noodles775 | wgrant: sure. | 08:51 |
| wgrant | noodles775: Thanks. | 08:52 |
| mrevell | Morning | 08:58 |
| noodles775 | wgrant: did you have a third one? The first one wasn't approved yet so I'm guessing it didn't disappear overnight? | 08:58 |
| * noodles775 switches it to approved and sends off. | 08:58 | |
| noodles775 | And 'morning mrevell. | 09:00 |
| jml | good morning Launchpadders | 09:06 |
| wgrant | noodles775: Interesting. It was apparently sent off, so maybe neither of them were. | 09:07 |
| noodles775 | wgrant: ok, both sent now. | 09:09 |
| wgrant | noodles775: Thanks. | 09:09 |
| === wgrant_ is now known as wgrant | ||
| === henninge_ is now known as henninge | ||
| === jtv1 is now known as jtv | ||
| deryck | Morning, all. | 10:56 |
| zyga | hello | 11:20 |
| zyga | how hard would it be to deploy something like librarian outside of launchpad> | 11:20 |
| mrevell | A bloke's here to change my electricity meter, so I'll be offline for 40 mins or so but working on laptop battery. | 11:27 |
| deryck | gmb, hi. So I think we need to do something this cycle about calculate-bug-heat runs causing us problems. | 11:36 |
| gmb | deryck, Agreed. | 11:36 |
| deryck | gmb, do we know why it hung yesterday? | 11:37 |
| gmb | deryck, This particular problem is because it didn't run for a while during the rollout | 11:37 |
| gmb | And whilst we fixed that last week all we ended up doing was deferr the problem for a week. | 11:37 |
| gmb | So once again it's got too many jobs to deal with. | 11:37 |
| gmb | deryck, The quick solution is to cancel all the existing jobs and randomize the heat_last_updated dates of all the bugs over, say, a 48 hour period, so that they don't get all bunched up., | 11:38 |
| deryck | gmb, ah, right. So it's the offline run where we try to decrease heat on bugs that haven't been touched for awhile? We end up with too many bugs needing to be touched, so too many jobs? | 11:38 |
| gmb | But what we actually need to do is make calculation much more efficient, say with a stored procedure. | 11:38 |
| gmb | deryck, Yes, exactly. | 11:38 |
| deryck | gmb, I think we should focus on efficiency, not stop-gaps. Though a band-aid today to get us running again is fine. | 11:39 |
| * deryck looks for a bug.... | 11:39 | |
| gmb | deryck, Agreed. I think we're going to have to do the calculation as a stored procedure. | 11:39 |
| gmb | The Jobs system can't cope with the volume if we stop doing the work for 24 hours. | 11:40 |
| deryck | gmb, is this bug 521447? Or really we need a new bug about number of jobs created? | 11:41 |
| mup | Bug #521447: Uninformative error message <error-handling> <errors> <javascript> <ui> <LAZR Javascript Library:Triaged> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/521447> | 11:41 |
| deryck | oops :-) | 11:41 |
| deryck | gmb, meant bug 557252 | 11:41 |
| mup | Bug #557252: Creating CalculateBugHeatJob is very slow <story-bug-heat> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/557252> | 11:41 |
| gmb | deryck, I think it's a new bug altogether. I'll file one, and once that bug's fixed it will invalidate 557252. | 11:41 |
| gmb | deryck, Basically, whilst it's nice that we try to do heat calculation in python, it's just not feasible for large numbers of bugs. | 11:42 |
| gmb | (Because we do it iteratively). | 11:42 |
| gmb | If come up with a stored proceedure which does the same job then we can use that for both decay and on-change re-calculations. | 11:43 |
| deryck | gmb, and this is a trade, right? So we move the calculation out of python and into the db? We won't have to do this in two places, will we? | 11:43 |
| gmb | deryck, Right. If we're going to do this we need to do it such a way that it completely supersedes the Jobs system work, though there could be a transitional period where we use both for the sake of developer sanity :) | 11:44 |
| gmb | (Or we could have the Jobs system call the stored procedure rather than use BugHeatCalculator) | 11:44 |
| deryck | maybe so. But I think just doing it all on trigger is better. | 11:45 |
| deryck | gmb, if we do this, this would also make bug 571730 invalid, too, right? | 11:46 |
| mup | Bug #571730: garbo-daily should prune CalculateBugHeatJobs <story-bug-heat> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/571730> | 11:46 |
| gmb | deryck, Yes. | 11:46 |
| deryck | gmb, ok, so let's do this then... | 11:46 |
| deryck | gmb, please file a bug about the new work to be done, then mark 571730 and 557252 invalid, citing the new bug. Then add the new bug to the bugs backlog on the board where the card for 571730 currently is. Sound cool? | 11:47 |
| gmb | deryck, Yep, WFM. | 11:47 |
| deryck | gmb, thanks! | 11:48 |
| gmb | np | 11:48 |
| === magcius_ is now known as magcius | ||
| gmb | deryck, bug 582195 | 11:58 |
| deryck | gmb, great, thanks. | 12:00 |
| gmb | Thanks for nothing, mup. | 12:02 |
| wgrant | noodles775: Any idea what happened to the second branch? The errors look... unrelated. | 12:21 |
| wgrant | Not a set that I've seen before, either. | 12:25 |
| === thekorn_ is now known as thekorn | ||
| * jml off to lunch | 12:46 | |
| jml | wuu, cafe internet works. | 13:06 |
| noodles775 | wgrant: yeah, the failures in the second branch look unrelated. Let me know when you've pushed the fix for the first branch and I'll resend it. | 13:07 |
| noodles775 | jml: so enjoy it and read some stuff you've wanted to read ;) (btw: are you using an android irc app? or a computer) | 13:07 |
| jml | noodles775, I'm using my computer. | 13:08 |
| jml | noodles775, and compiling notes from UDS, which I don't really need to be online for | 13:08 |
| BjornT | jml: how do i use subunit to list all failed tests in a test run (i have a log file from ec2) | 13:09 |
| jml | BjornT, pipe them through subunit-filter | 13:09 |
| jml | BjornT, there's a bug in subunit-filter where it lets timestamps through | 13:10 |
| BjornT | jml: i've figured so much out, but i can't get it to work. oh, that would explain it.... | 13:10 |
| BjornT | jml: any way to work around it? | 13:10 |
| jml | BjornT, grep, I think | 13:10 |
| jml | BjornT, as in, grep -v "time: ", or something similar. | 13:10 |
| jml | BjornT, https://bugs.edge.launchpad.net/subunit/+bug/567150 | 13:11 |
| mup | Bug #567150: subunit-filter doesn't understand time <subunit:Triaged> <https://launchpad.net/bugs/567150> | 13:11 |
| BjornT | jml: right. any way to list only the names of the test, not including the tracebacks? | 13:12 |
| jml | BjornT, | subunit-ls | 13:12 |
| BjornT | cool, thanks | 13:16 |
| jml | crap. I didn't meet adiroiban while I was at UDS :( | 13:50 |
| noodles775 | Hi abentley, I'm just at the point where I'm ready to refactor IBuildFarmJob to refer (and delegate) to IJob, but wanted to run a few things past you... | 14:04 |
| abentley | noodles775, sure. | 14:04 |
| noodles775 | Initially, it will really be only date_create, date_started and date_finished that benefit (and I'll need to add indexes on IJob for these)... | 14:04 |
| noodles775 | IJob.log vs. IBuildFarmJob.log is a bit of an issue - the former being Text, the latter a LibraryFileAlias reference | 14:04 |
| noodles775 | (we could rename IBuildFarmJob.log to log_file I guess, but we'd probably want to do IBFJ.upload_log -> upload_log_file too then). | 14:05 |
| abentley | noodles775, we haven't really used the log field yet, AFAIK. | 14:05 |
| noodles775 | oh. | 14:06 |
| noodles775 | In which case, we *could* rename IJob.log -> log_tail? | 14:06 |
| abentley | noodles775, I think so. | 14:07 |
| noodles775 | abentley: OK, thanks. | 14:08 |
| abentley | noodles775, any thoughts on status? | 14:10 |
| abentley | noodles775, I've been thinking that IJob.status maps pretty well to Build.buildstate, except that Build.buildstate describes failures much better. | 14:12 |
| noodles775 | abentley: I had planned for the moment to simply override it on IBuildFarmJob.status (as we have a lot of filtering on this field), but if you think it would be better to move them completely to IJob now, I can do that? | 14:14 |
| bigjools | that scares me | 14:14 |
| wgrant | This was the main point that my initial diagrams did not solve. | 14:14 |
| wgrant | I am leaning towards letting each job type have its own failure states. | 14:14 |
| wgrant | But using IJob.status for everything else. | 14:15 |
| abentley | wgrant, me too. | 14:15 |
| wgrant | Since it covers most of it. | 14:15 |
| wgrant | But, well, it's slightly awkwarded, which is why I didn't propose it initially. | 14:15 |
| wgrant | Woah. Awkward. | 14:15 |
| abentley | noodles775, were you planning on implementing IJob.status in terms of BuildFarmJob.status ? | 14:16 |
| noodles775 | wgrant: how would we filter for all builds where the set of statuses for the filter are on different tables? | 14:16 |
| adiroiban | jml: eh. there will be other UDS-es :) I also missed the LP meeting | 14:16 |
| noodles775 | (well, ok, it'd be possible, but seems overly complex) | 14:16 |
| wgrant | noodles775: Therein lies the awkwardness. | 14:16 |
| noodles775 | Which is why for the moment I wasn't goin to try to merge the statuses, but continue with IBuildFarmJob.status defining all the statuses we need. | 14:17 |
| bigjools | I think job status and build state are somewhat orthogonal | 14:17 |
| wgrant | Everything else is easy. | 14:17 |
| wgrant | bigjools: They only appear to diverage once the build is complete. | 14:17 |
| wgrant | And then only upon failure (at the moment, at least) | 14:18 |
| bigjools | for all of our build types? | 14:18 |
| wgrant | Yes. | 14:18 |
| bigjools | and future types? :) | 14:18 |
| wgrant | I can't think why not, but it is something to think about. | 14:18 |
| abentley | bigjools, I don't see how they can be orthagonal. They can't disagree about whether the build failed, succeeded, or hasn't been attempted. | 14:18 |
| wgrant | Exactly. | 14:18 |
| bigjools | you're making the mistake that they represent the same thing | 14:19 |
| wgrant | At the moment they do. | 14:19 |
| bigjools | I am playing devil's advocate to some extent, but I'm kinda wary of having a one-size-fits-all status | 14:20 |
| wgrant | There are, I guess, statuses like ABORTING and ABORTED that we probably need. | 14:21 |
| wgrant | I wonder how that would be implemented or map onto this. | 14:21 |
| abentley | bigjools, Jobs are intended to be general. If there is a state that they can't represent in general terms, we should add it. | 14:21 |
| bigjools | yeah, I want a new build status that represents an admin terminating it | 14:22 |
| noodles775 | wgrant: ABORTING and ABORTED would be such new JobStatus items. | 14:22 |
| wgrant | noodles775: I guess they could be. | 14:23 |
| wgrant | Since they are general. | 14:23 |
| bigjools | abentley: should we have a massive list of states, and change the state transitions depending on the job type? | 14:23 |
| * jml hates human computer interfaces | 14:23 | |
| * bigjools hates humans and computer interfaces | 14:24 | |
| abentley | bigjools, I don't think we should. The idea with Jobs was that the general states would be represented by Job.status, and failure modes would be specified in Job.reason | 14:24 |
| noodles775 | OK, but that would be a bigger change than I can afford right now for package builds. | 14:25 |
| wgrant | abentley: Is that a string? | 14:25 |
| abentley | noodles775, sure. | 14:25 |
| abentley | wgrant, yes, and actually, I may be wrong about that. | 14:25 |
| wgrant | Hmmm. | 14:25 |
| wgrant | Is that another thing that isn't used anywhere yet? | 14:25 |
| abentley | The comment on reason suggests it's the reason the job was created, not the reason it failed. | 14:26 |
| wgrant | Ah. | 14:26 |
| abentley | bigjools, I also notice that the comment on Job.status mentions "cancelling" and "cancelled" as possible statuses. | 14:27 |
| noodles775 | So, fwiw, the only way forward I can see for the moment is to have all status represented by JobStatus. | 14:27 |
| noodles775 | (or leave the IBuildFarmJob is an IJob for later). | 14:28 |
| wgrant | I'd really just shadow IJob.status for now. | 14:28 |
| wgrant | Ah. | 14:28 |
| noodles775 | wgrant: yes. | 14:28 |
| wgrant | This change is already massive enough... | 14:28 |
| noodles775 | +1, over 7k lines at the moment, that I want to land as soon as we've tested on dogfood. | 14:29 |
| wgrant | Oouch. | 14:29 |
| abentley | noodles775, yes, I just asked your thoughts on status. Doesn't have to be now. | 14:30 |
| BjornT | danilos, henninge: can anyone help me with understanding a test failure in test_getPOTMsgSetBySequence (lp.translations.tests.test_shared_potemplate.TestTranslationSharingPOTemplate)? | 14:39 |
| === joey` is now known as joey | ||
| henninge | BjornT: Show me. ;) | 14:40 |
| danilos | BjornT, are you, by any chance, changing sampledata? | 14:41 |
| BjornT | henninge, danilos: http://paste.ubuntu.com/435535/ | 14:42 |
| BjornT | danilos: no. i am however changing the sequence number | 14:42 |
| danilos | BjornT, how are you changing it? | 14:43 |
| BjornT | danilos, henninge: it seems that i get this when if factory.getUniqueInteger() returns 1, but the test doesn't contain any guards against it, so i'm not sure what the right thing to do is | 14:43 |
| danilos | BjornT, setSequence call doesn't do any checking because it assumes you know what you are doing (for performance reasons) | 14:43 |
| BjornT | danilos: i changed factory.getUniqueString() not use factory.getUniqueInteger() | 14:44 |
| danilos | BjornT, let me take a look at the test then | 14:45 |
| danilos | BjornT, I'd have to see the branch to see where the problem is, because test seems sane otherwise | 14:49 |
| danilos | BjornT, i.e. it depends on what's going on: what the names for self.devel_template and self.stable_template are etc. | 14:50 |
| danilos | BjornT, the test shouldn't depend on getUniqueString at all | 14:50 |
| danilos | BjornT, except maybe person creation and such | 14:51 |
| BjornT | danilos: you could apply this patch: http://paste.ubuntu.com/435540/ | 14:51 |
| BjornT | danilos: it doesn't depend on getUniqueString directly, it just depends on getUniqueString() calling getUniqueInteger(), so that getUniqueInteger() won't return 1 | 14:52 |
| BjornT | at least as far as i can see | 14:52 |
| bigjools | jml: is there a standard way of doing diagrams to show chains of Deferreds? | 14:54 |
| jml | bigjools: not really. See http://twistedmatrix.com/documents/current/core/howto/defer.html http://twistedmatrix.com/documents/current/core/howto/gendefer.html http://twistedmatrix.com/documents/current/core/howto/deferredindepth.html | 14:56 |
| danilos | BjornT, yeah, that does sound likely, you can simply fix it by setting the sequence to 2 instead, or, what's probably better, use getUniqueInteger in setUp instead (though, that will needlessly get different sequence ids for each of the tests, but not a big deal) | 14:56 |
| jml | bigjools: in general, it's an implementation thing, not an interface thing, so there's rarely a reason to draw such a diagram | 14:56 |
| bigjools | jml: ok, I want to draw the decision tree for the buildd-manager | 14:57 |
| mars | rockstar, BjornT, I landed the branch that disables the windmill suite on ec2. ec2test should work again. | 14:57 |
| jml | bigjools: then just draw a flowchart | 14:57 |
| * jml in a call | 14:57 | |
| bigjools | jml: that's what I was doing until I stopped and wondered if there was a Twisted Way :) | 14:57 |
| bigjools | thx | 14:57 |
| jml | bigjools: np | 14:57 |
| BjornT | danilos: ok. i think i will hard code it, because it's hard coded in other tests, so using getUniqueInteger() in setUp() might make other tests fail. | 14:57 |
| danilos | BjornT, sure, makes sense | 14:58 |
| jml | bigjools: btw, I looked up the deferred implementation. There's already some code that does "if isinstance(result, failure.Failure)" | 14:59 |
| bigjools | jml: ah precedence is wonderful | 15:00 |
| jml | bigjools: no, as in, the check has already been performed by the time it gets to your custom check :) | 15:00 |
| jml | bigjools: another diagrammatic tool that people use sometimes is state machines | 15:00 |
| bigjools | yes | 15:01 |
| bigjools | jml: it would be nice to have a state machine internally instead of this mishmash of code | 15:02 |
| bigjools | but I want to re-work it anyway | 15:03 |
| wgrant | bigjools: Are you also planning to rework the internal bits of code that think they are synchronous, but really aren't? | 15:04 |
| wgrant | Or is that out of scope? | 15:04 |
| bigjools | wgrant: which bits do you mean? | 15:05 |
| wgrant | bigjools: dispatchBuildToSlave and other bits and pieces around that where make synchronous calls to RecordingSlave. | 15:05 |
| wgrant | RecordingSlave then forges successful XML-RPC responses, so it can execute the real calls later. | 15:05 |
| bigjools | I think that's just an artefact of RecordingSlave | 15:06 |
| wgrant | So people tend to assume that they will get real results in those methods... when in fact methods will fail without anybody noticing. | 15:06 |
| wgrant | Right. | 15:06 |
| bigjools | that's how it's designed to work | 15:06 |
| bigjools | which is fine for now | 15:06 |
| wgrant | I imagine it was only built that way so slavescanner would continue to function. | 15:06 |
| bigjools | I aim to attack 2 things: | 15:06 |
| wgrant | But slavescanner is dead now. | 15:06 |
| bigjools | 1. make build uploads asychronous by throwing them in a queue and forgetting about them | 15:07 |
| wgrant | \o/ | 15:07 |
| bigjools | 2. throw away the global scan, and have a scan interval on each builder instead | 15:07 |
| wgrant | Right. A separate state machine for each builder. Yay. | 15:07 |
| wgrant | That will fix just about everything. | 15:08 |
| bigjools | at that point we'll have solved most of the scalability issues | 15:08 |
| bigjools | then we can start making the rest of the code nicer | 15:08 |
| wgrant | Yep. | 15:08 |
| bigjools | the design of the b-m was influenced too much by the slave scanner really | 15:09 |
| wgrant | Well, it had to not break slavescanner. | 15:09 |
| bigjools | that's separate | 15:09 |
| bigjools | I mean the global scan | 15:09 |
| wgrant | Ah. | 15:09 |
| bigjools | we could have done separate scans on each builder right from the start | 15:09 |
| wgrant | Mm, yes, I guess so. | 15:10 |
| === leonardr is now known as leonardr-afk | ||
| BjornT | mars: about your branch to disable windmill tests on ec2. did you land that one through ec2tests? :) | 15:46 |
| mars | BjornT, nope, ironically | 15:47 |
| BjornT | mars: maybe you should have :) looking at your patch, it looks like you've now enabled the mailman tests, haven't you? | 15:48 |
| mars | BjornT, ? I did not touch that code. | 15:49 |
| BjornT | mars: but you changed which layers are run | 15:49 |
| BjornT | mars: it used to be !MailmanLayer. now it's !WindmillLayer. no? | 15:50 |
| mars | BjornT, yes. I added another --layer switch to disable the windmill tests. bin/test adds yet another layer switch on its own to disable mailman. | 15:50 |
| BjornT | mars: i don't think so. the defaults are there, in case no --layer is specified only | 15:50 |
| mars | BjornT, ah, so I misread the code in bin/test then. Either way, I doubt I would have noticed the mailman tests running on ec2. | 15:52 |
| wgrant | Well... the mailman tests normally mostly fail. | 15:52 |
| wgrant | So you probably would have. | 15:52 |
| BjornT | mars: well, what wgrant said :) | 15:52 |
| mars | :) | 15:53 |
| wgrant | OK, so, yes, it looks like MailmanLayer is running :( | 15:54 |
| wgrant | That explains the odd failures that one of my branches had. | 15:54 |
| mars | BjornT, so is there anything that needs to be fixed outside of adding the explicit --layer=!Mailman ? | 15:54 |
| BjornT | mars: nope, adding the explict !Mailman is the right thing to do, i think. i would use --layer=!(MailmanLayer|WindmillLayer) just to be sure, though. i don't think using --layer=!MailmanLayer --layer=!WindmillLayer will work | 15:57 |
| mars | BjornT, ok, will do so as soon as rf-get completes | 15:58 |
| === leonardr-afk is now known as leonardr | ||
| abentley | noodles775, what is the relationship between BinaryPackageBuild.is_virtualized and BuildQueue.virtualized ? | 16:09 |
| abentley | noodles775, err, not BuildQueue. SomethingJob.virtualized | 16:09 |
| noodles775 | abentley: so currently BinaryPackageBuild.is_virtualized just returns whether the associated archive is virtualised, which isn't great, which is why the new schema adds a virtualized attribute to BuildFarmJob. | 16:15 |
| noodles775 | abentley: which I'm guessing you saw yourself... do you have a suggestion? | 16:15 |
| mars | wgrant, look at the bright side: at least the ec2 server didn't hang | 16:16 |
| wgrant | mars: True! | 16:16 |
| abentley | noodles775, I'm just trying to understand the various attributes. Seems like virtualized returns is_virtualized, which returns archive.virtualized. | 16:16 |
| abentley | noodles775, if we have all these attributes, I would expect them to vary. | 16:17 |
| noodles775 | abentley: IBuildFarmJob.virtualized is a Bool db attribute... (and I've not yet removed IBinaryPackageBuild.is_virtualized, but intend to)... or did I miss something? | 16:18 |
| abentley | noodles775, No, that sounds like a sane plan. | 16:20 |
| noodles775 | abentley: great. Let me know if you spot anything else. | 16:33 |
| === Ursinha_ is now known as Ursinha | ||
| === salgado is now known as salgado-lunch | ||
| === beuno is now known as beuno-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| === Ursinha is now known as Ursinha-lunch | ||
| === kfogel is now known as kfogel-lunchpad | ||
| obergix[work] | flacoste: Hi. Just sent you some request again about presentation @OWF... in case you missed previous emails and could ACK me | 17:39 |
| obergix[work] | jml: as I didn't get any response from you about presenting @OWF, I just resent a query to Francis, but of course, I'd appreciate if you responded too ;) | 17:40 |
| adiroiban | what is the prefered way for naming the Y.namespace variable ? In the current code we have the folowing http://paste.ubuntu.com/435636/ | 17:54 |
| zyga | does launchpad use storm as the ORM layer or is there some other piece of tech involved? | 17:58 |
| === gary_poster is now known as gary-lunch | ||
| rockstar | We're in testfix? | 18:06 |
| rockstar | zyga, yes, storm is our preferred ORM. | 18:06 |
| zyga | rockstar, are you aware of any django-on-storm projects? | 18:06 |
| rockstar | zyga, yes, Ubuntu One uses storm and django. | 18:07 |
| zyga | rockstar, can I (canonical) get a peek at the code to see how to piece django and storm in a sensible way? | 18:07 |
| zyga | anything that you might share would be beneficial to me | 18:07 |
| rockstar | zyga, you're asking the wrong person. You should probably ask someone on the U1 team. | 18:08 |
| zyga | rockstar, #? #ubuntu-one? | 18:08 |
| rockstar | zyga, no idea, actually. | 18:08 |
| zyga | ok, I'll check, thanks | 18:08 |
| rockstar | zyga, I believe jamesh made a storm mailing list post about using storm and django as well. | 18:09 |
| rockstar | adiroiban, var namespace = Y.namespace('lp.<app>.<app-specific-namespace>'); is correct. | 18:09 |
| === beuno-lunch is now known as beuno | ||
| adiroiban | rockstar: thanks! | 18:10 |
| === matsubara-lunch is now known as matsubara | ||
| jml | good night Launchpadders | 18:26 |
| jml | rockstar, grats on your dementating! | 18:26 |
| rockstar | jml, I had to stop and think about that. | 18:27 |
| rockstar | jml, I thought you knew more about my mental health than I did... :) | 18:27 |
| rockstar | (although that wouldn't surprise me) | 18:27 |
| jml | I have orbs. | 18:27 |
| === salgado-lunch is now known as salgado | ||
| adiroiban | rockstar: is this wikipage still valid https://dev.launchpad.net/JavaScriptBuildSystem ? | 19:01 |
| === mup_ is now known as mup | ||
| mars | adiroiban, the part about new script files is correct. Plenty of examples in base-layout-macros.pt | 19:08 |
| mars | adiroiban, the CSS story is different. | 19:08 |
| mars | adiroiban, look at buildout-templates/bin/combine-css.in to see how the different CSS files are pulled together. | 19:09 |
| === Ursinha-lunch is now known as Ursinha | ||
| adiroiban | mars: there is also utilities/lp-deps.py | 19:10 |
| adiroiban | and it looks like in base-layout-macros.pt, the JS files must be manualy added for devmode | 19:12 |
| adiroiban | or I am missing something ? | 19:12 |
| mars | adiroiban, when you add a file to the devmode block, lp-deps will pick it up as a new dependency. It will be automatically rolled into launchpad.js. | 19:13 |
| adiroiban | mars: ok. but what is the recommended way for incliding JS files: in base-layout-macros.pt or in each templates? | 19:14 |
| mars | adiroiban, that depends where the JS is used. What did you add? | 19:14 |
| adiroiban | mars: I'm moving the translation js files from canonical/launchpad/javascript to lib/lp/translations/javascript | 19:15 |
| mars | adiroiban, then they are probably listed in base-layout-macros.pt | 19:16 |
| adiroiban | one file is in base-layout-macros.pt while others are in other templates | 19:17 |
| adiroiban | but the file included in base-layout-macros.pt is only used in 2 other templates | 19:17 |
| mars | adiroiban, how heavy are the other files? Are they all used on only one page? | 19:18 |
| adiroiban | mars: yes. they are used on only one page | 19:19 |
| adiroiban | but in production, all js files are merged into launchpad.js. right? | 19:19 |
| === kfogel-lunchpad is now known as kfogel | ||
| mars | I believe that is the case if and only if they are listed in base-layout-macros | 19:20 |
| mars | lp-deps.py does not scan every template file in launchpad | 19:20 |
| mars | adiroiban, to my knowledge the other applications combine everything together into one JS file, then have it all in launchpad.js | 19:21 |
| mars | regardless of whether it is used on one page, or on many | 19:22 |
| mars | it works because the vast majority of the JavaScript for LP is in the YUI Core. Our apps are very thin on top of that. | 19:22 |
| adiroiban | mars: that is correct. and if in production, all js code is merged in launchpad.js, then why not put all js file include statements in base-layout-macros ? | 19:23 |
| mars | adiroiban, I do not know why translations chose to do it otherwise. | 19:23 |
| mars | also, I can not guarantee that those files are minified | 19:24 |
| mars | if they aren't in the JS rollup | 19:24 |
| adiroiban | mars: how do I know if a file is minified? | 19:24 |
| mars | adiroiban, simplest way is to visit that page on staging.launchpad.net, View Source | 19:25 |
| mars | see if it looks like jibberish :) | 19:25 |
| mars | adiroiban, if you tell me a URL to check, I can do so for you | 19:25 |
| adiroiban | https://translations.edge.launchpad.net/ubuntu/lucid/ | 19:25 |
| adiroiban | mars: sorry. https://translations.edge.launchpad.net/ubuntu/lucid/+imports | 19:26 |
| adiroiban | lib/lp/translations/templates/translation-import-queue-macros.pt has an javascript include tal condition for devmode | 19:27 |
| adiroiban | mars: it should be build/translations/translations.js | 19:28 |
| mars | adiroiban, it looks like everything on production has been properly rolled into launchpad.js | 19:28 |
| adiroiban | mars: then it would make sense to put the include statements in base-layout-macros. or not? | 19:29 |
| mars | It sounds like it, yes. | 19:29 |
| adiroiban | mars: and then maybe we can add a note on the wikipage that js includes can be put in base-layout-macros, rather than in templates using tal conditions for devmode | 19:30 |
| mars | yes, that would help | 19:30 |
| adiroiban | ok. righ now we have „To add a new YUI3 dependency, just add a new <script> line to the main site template.” | 19:31 |
| adiroiban | but for me „YUI3 dependency” does not mean „a new js file used for Launchpad” | 19:31 |
| mars | s#main site template#lib/lp/app/templates/base-layout-macros.pt# | 19:32 |
| adiroiban | mars: yep | 19:32 |
| mars | good point | 19:32 |
| mars | that is not clear | 19:32 |
| adiroiban | mars: can you please change the wikipage. I don't think I was accepted yet into the LP-documentation team | 19:33 |
| mars | ok | 19:33 |
| adiroiban | thanks! | 19:36 |
| mars | adiroiban, better? https://dev.launchpad.net/JavaScriptBuildSystem | 19:43 |
| mars | I dislike the asymmetry between the CSS and JS build chain. | 19:44 |
| mars | Would be nice if you could just type "make clean_static && make static" | 19:44 |
| mars | or something :/ | 19:44 |
| mars | web_resources? | 19:44 |
| mars | assets? | 19:44 |
| adiroiban | mars: much better :) | 19:45 |
| mars | "make assets"? | 19:45 |
| adiroiban | after changing utilities/lp-deps.py, i had to do „make clean” | 19:45 |
| mars | adiroiban, good! | 19:45 |
| adiroiban | and make js_clean & make jsbuild | 19:45 |
| adiroiban | had not created the symlinks | 19:45 |
| adiroiban | but utilities/lp-deps.py should only be changed once per each lp application | 19:46 |
| === gary-lunch is now known as gary_poster | ||
| === mwhudson_ is now known as mwhudson | ||
| === gary_poster_ is now known as gary_poster | ||
| mtaylor | the "Find" link on the Assign to: field on +filebug doesn't open up a popup, it takes you to a whole new page - this can be troubling... | 22:06 |
| wgrant | mtaylor: Bug #513591 | 22:09 |
| mup | Bug #513591: Assignee selector on +filebug has lost its JavaScript <story-ajaxify-dupe-finder> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/513591> | 22:09 |
| mtaylor | wgrant: awesome. | 22:12 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| === mup_ is now known as mup | ||
| lifeless | gary_poster: I realise you're probably gone; just letting you know that I'm chatting to apache, I hope: https://issues.apache.org/bugzilla/show_bug.cgi?id=39727#c34 | 23:53 |
| bdmurray | could somebody help me out with the following error message when running a test? | 23:56 |
| bdmurray | http://pastebin.osuosl.org/32810 | 23:56 |
| * thumper looks for jelmer | 23:57 | |
| thumper | bdmurray: you are missing a login | 23:57 |
| thumper | bdmurray: I take it this is in a page test? | 23:58 |
| bdmurray | thumper: yes, thanks | 23:58 |
| thumper | bdmurray: in the story page tests you need an interation, which you get from login() | 23:58 |
| thumper | or login_person | 23:58 |
| thumper | bdmurray: often login(ANONYMOUS) is enough | 23:58 |
| thumper | also, to get the ubuntu distro, probably easier to use getUtility(ILaunchpadCelebrities).ubuntu | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!