| === matsubara-afk is now known as matsubara | ||
| thumper | mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/git-update/+merge/25485 ? | 01:49 |
|---|---|---|
| thumper | mwhudson: super trivial | 01:49 |
| mwhudson | thumper: i guess you're fixing the conflicts? | 01:50 |
| thumper | :( | 01:50 |
| thumper | yeah | 01:50 |
| thumper | I should have branched from db-devel not devel with the production ancestor | 01:51 |
| thumper | will fix | 01:51 |
| thumper | mwhudson: updated | 02:21 |
| mwhudson | thumper: approved | 02:22 |
| thumper | ta | 02:22 |
| thumper | mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/package-branch-edit-owner/+merge/25291 if you are looking for something to do | 03:28 |
| === Ursinha is now known as Ursinha-afk | ||
| === wgrant_ is now known as wgrant | ||
| === noodles775 changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === henninge_ is now known as henninge | ||
| adiroiban | jtv1: hi. Should I add you as a reviewer for the POTemplates API MP, or it is on your todo list and you will review it when you have time ? https://code.edge.launchpad.net/~adiroiban/launchpad/bug-525371/+merge/25423 | 10:32 |
| jtv1 | adiroiban: I'm terribly sorry, I'm just too distracted by what's going on here. I'll continue trying to give you feedback, but reviews are pretty difficult under the circumstances. | 10:34 |
| adiroiban | jtv1: ok. just let me know if the branch is to hard to review and I will need to rewrite or break it in multiple MPs | 10:40 |
| jtv1 | adiroiban: don't worry too much about the lint warnings... sometimes it's just being annoying. | 10:46 |
| jtv1 | adiroiban: thanks for doing this btw... it'll be a great thing to have. | 10:48 |
| === jtv1 is now known as jtv | ||
| jtv | adiroiban: it's looking good to me so far. | 10:51 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: noodles775 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | noodles775, Is it your 567922-binarypackagebuild-new-table-7 that you need reviewed? | 11:27 |
| noodles775 | gmb: yes, that's the one. Thanks! | 11:28 |
| gmb | noodles775, ... Cos' it's got a bunch of conflicts :) | 11:28 |
| gmb | Aaah | 11:28 |
| gmb | That's because it's a pipeline branch, isn't it. | 11:28 |
| gmb | Right, okay. Good. | 11:29 |
| noodles775 | gmb: yeah, I've mentioned it in the MP. Great. | 11:32 |
| gmb | noodles775, Yeah, I only had the topmost portion of the MP on my screen at the time. That'll teach me to not scroll down :) | 11:32 |
| gmb | noodles775, r=me | 11:40 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | Thanks gmb. | 11:41 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| intellectronica | BjornT: just sent a db review your way | 14:58 |
| === noodles775 changed the topic of #launchpad-reviews to: On call: gmb || reviewing: lunch || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | Hi gmb, just another branch ensuring tests pass after previous refactoring work: https://code.edge.launchpad.net/~michael.nelson/launchpad/567922-binarypackagebuild-new-table-8/+merge/25515 | 15:06 |
| adiroiban | intellectronica: do you have time to review this branch that we have discussed yesterday, or should I find another reviewer ? https://code.edge.launchpad.net/~adiroiban/launchpad/bug-570899/+merge/25443 | 15:07 |
| gmb | noodles775, Righto, I'll take a look. | 15:07 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: noodles775 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| intellectronica | adiroiban: no, i'll be happy to finish the review. thanks for making the changes! | 15:07 |
| noodles775 | gmb: thanks! | 15:07 |
| intellectronica | adiroiban: that looks great. i really like the solution you've come up with. | 15:10 |
| === leonardr is now known as leonardr-afk | ||
| BjornT | intellectronica: ok. you could start with committing and pushing your changes to comments.sql, which you seem to have forget to do ;) | 15:11 |
| intellectronica | BjornT: heh, of course :) | 15:12 |
| gmb | noodles775, At the start of the diff you have a commented out `ALTER TABLE Build SET SCHEMA todrop;` and then an uncommented version immediately after it. Is the commented version unnecessary or is it an artifact of the pipeline process? | 15:15 |
| noodles775 | gmb: it's actually removing lines 8-11 (the diff makes this hard to see). ie. removing the comment and replacing it with the real deal. But I actually didn't intend that to be in the diff (the db-schema change will obviously need a separate review). | 15:17 |
| gmb | noodles775, Ah right. Makes sense. | 15:17 |
| gmb | noodles775, r=me | 15:20 |
| noodles775 | Thanks gmb. | 15:20 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | intellectronica: did you have trouble updating the sampledata? When I tried with a db-patch I'm preparing, I ended up with over 6k of sample data diff :/ | 15:21 |
| noodles775 | (actually, that was on a pristine db-devel, not my branch). | 15:22 |
| intellectronica | noodles775: ehrm .... haven't tried that yes, i'm afraid. is it even necessary? we're definitely not adding any new sample data, after all, and i don't remember creating new versions of the sample data for ages (and evidently other devs haven't either) | 15:23 |
| intellectronica | of course for some changes that's unavoidable | 15:24 |
| BjornT | gmb: want to review a really small branch? https://code.launchpad.net/~bjornt/launchpad/dont-hardcode-auto-generated-names/+merge/25518 | 15:24 |
| noodles775 | intellectronica: ok. | 15:24 |
| gmb | BjornT, Of course. | 15:24 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: BjornT || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | BjornT, r=me. | 15:25 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| intellectronica | BjornT: updated by db branch with comments | 15:25 |
| BjornT | gmb: thanks. here's a related one, slightly longer: https://code.edge.launchpad.net/~bjornt/launchpad/compare-email-headers/+merge/25520 | 15:29 |
| gmb | BjornT, I'll take a look | 15:29 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: BjornT || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| BjornT | thanks | 15:30 |
| gmb | BjornT, r=me | 15:35 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| BjornT | gmb: thanks. i guess you could take a look with this one as well :) https://code.edge.launchpad.net/~bjornt/launchpad/more-unique-factory-strings/+merge/25438 | 15:39 |
| BjornT | gmb: the previous two branches fixed all the test failures in the third one | 15:39 |
| gmb | BjornT, Sure :) | 15:39 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: BjornT || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | BjornT, And that's r=me too :) | 15:44 |
| gmb | Would've been quicker but for my connection going away for a couple of minutes... | 15:44 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| BjornT | gmb: thanks! | 15:46 |
| === leonardr-afk is now known as leonardr | ||
| BjornT | EdwinGrubbs: i've added some questions/comments to your db patch review | 16:24 |
| === sinzui changed the topic of #launchpad-reviews to: On call: gmb || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| sinzui | gmb, do you have time to read a short branch about memcached. I do not consider it to be mechanical, though it looks like it is | 16:29 |
| gmb | sinzui, Sure. | 16:31 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === Ursinha_ is now known as Ursinha | ||
| EdwinGrubbs | bigjools, BjornT made an interesting point about renaming the columns in DistributionSourcePackage to make it clear that they are cached values. That could be annoying if DistributionSourcePackageCache and DistributionSourcePackage are ever merged. The only non-cached value in either table that I'm aware of is the bug_reporting_guidelines. I'm wondering if it makes more sense to add the new columns to the DistributionSourc | 16:41 |
| EdwinGrubbs | ePackageCache table instead. | 16:41 |
| bigjools | EdwinGrubbs: OTP, gimme 20m | 16:44 |
| BjornT_ | EdwinGrubbs: btw, i was only talking about the ones that might be out-of-date. section is fine, since it should always be up-to-date. | 16:45 |
| EdwinGrubbs | BjornT_, well, there is some hope that DistributionSourcePackageCache and DistributionSourcePackage would eventually be merged. That would mean there could be a bunch more columns with "cached" in the name. However, if we don't merge them, just moving cached values to DistributionSourcePackageCache makes it clear that they are cached without renaming the columns. | 16:47 |
| === salgado is now known as salgado-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| === Ursinha is now known as Ursinha-lunch | ||
| gmb | sinzui, Sorry for taking so long - OTP and other things - is this your milestone-performance-0 branch that needs reviewing? | 17:20 |
| sinzui | gmb: yes | 17:21 |
| sinzui | I should have made that clear when I asked | 17:21 |
| gmb | sinzui, r=me | 17:30 |
| === gmb changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| sinzui | gmb, thanks | 17:31 |
| === kfogel is now known as kfogel-lunchpad | ||
| === gary_poster is now known as gary-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| === salgado-lunch is now known as salgado | ||
| === mup_ is now known as mup | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === kfogel-lunchpad is now known as kfogel | ||
| abentley | rockstar, would you be able to review https://code.edge.launchpad.net/~abentley/launchpad/fix-recipebuilder/+merge/25528 ? | 19:46 |
| rockstar | abentley, sure | 19:46 |
| abentley | rockstar, thanks. | 19:47 |
| === gary-lunch is now known as gary_poster | ||
| mars | gary_poster, ping, do you have a moment to review this on-line change? https://code.edge.launchpad.net/~mars/launchpad/fix-ec2-mailmanlayer/+merge/25527 | 20:14 |
| gary_poster | what, you did it on=line? :-) | 20:14 |
| gary_poster | yes | 20:14 |
| mars | on=line ? | 20:14 |
| mars | oh, typo of the typo | 20:15 |
| gary_poster | yes :-) | 20:15 |
| gary_poster | approved mars | 20:15 |
| mars | gary_poster, thanks. Passes "ec2 test", will be landing now with "bzr lp-land" | 20:16 |
| gary_poster | mars, ack, cool | 20:16 |
| abentley | rockstar, could you also review https://code.edge.launchpad.net/~abentley/launchpad/estimate-duration/+merge/25553 ? | 20:29 |
| rockstar | abentley, sure. | 20:29 |
| abentley | rockstar, thanks again. | 20:29 |
| === mwhudson_ is now known as mwhudson | ||
| === gary_poster_ is now known as gary_poster | ||
| abentley | rockstar, could you please review https://code.launchpad.net/~abentley/launchpad/remember-archive/+merge/25564 ? | 22:27 |
| rockstar | abentley, on it. | 22:27 |
| abentley | rockstar, ta | 22:27 |
| rockstar | abentley, are you EODing soon? Do you need this before you EOD? | 22:30 |
| abentley | rockstar, I have EOD'd. No rush. | 22:31 |
| rockstar | abentley, okay. I'll make sure it's done before I EOD. | 22:31 |
| abentley | rockstar, cool. | 22:31 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| === adiroiban changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [adiroiban(bug-561586)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === mup_ is now known as mup | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!